Re: Review Request 129283: kwidgetaddons - add overrides

[Christoph Feck]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129283/#review100658
---


Ship it!




Merci :)

- Christoph Feck


On Nov. 6, 2016, 7:26 p.m., Allen Winter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129283/
> ---
> 
> (Updated Nov. 6, 2016, 7:26 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> Add Q_DECL_OVERRIDES as suggested by -Wsuggest-override
> 
> 
> Diffs
> -
> 
>   src/kacceleratormanager_p.h 55ab1c1 
>   src/kcharselect_p.h e4efdab 
>   src/kcursor_p.h fcac8d9 
>   src/kfontaction.h ae84944 
>   src/kmultitabbar.h 79e62ed 
>   src/kmultitabbar_p.h 6311413 
>   src/kurllabel.h eeba9e0 
> 
> Diff: https://git.reviewboard.kde.org/r/129283/diff/
> 
> 
> Testing
> ---
> 
> all warnings for -Wsuggest-override are gone
> make test still passes
> 
> 
> Thanks,
> 
> Allen Winter
> 
>

Re: Review Request 129283: kwidgetaddons - add overrides

[Allen Winter]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129283/
---

(Updated Nov. 6, 2016, 6:26 p.m.)


Review request for KDE Frameworks.


Changes
---

restore the 'int' I removed accidentally


Repository: kwidgetsaddons


Description
---

Add Q_DECL_OVERRIDES as suggested by -Wsuggest-override


Diffs (updated)
-

  src/kacceleratormanager_p.h 55ab1c1 
  src/kcharselect_p.h e4efdab 
  src/kcursor_p.h fcac8d9 
  src/kfontaction.h ae84944 
  src/kmultitabbar.h 79e62ed 
  src/kmultitabbar_p.h 6311413 
  src/kurllabel.h eeba9e0 

Diff: https://git.reviewboard.kde.org/r/129283/diff/


Testing
---

all warnings for -Wsuggest-override are gone
make test still passes


Thanks,

Allen Winter

Re: Review Request 129283: kwidgetaddons - add overrides

[Allen Winter]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129283/
---

(Updated Nov. 6, 2016, 6:18 p.m.)


Review request for KDE Frameworks.


Changes
---

remove "virtual" as requested.


Repository: kwidgetsaddons


Description
---

Add Q_DECL_OVERRIDES as suggested by -Wsuggest-override


Diffs (updated)
-

  src/kacceleratormanager_p.h 55ab1c1 
  src/kcharselect_p.h e4efdab 
  src/kcursor_p.h fcac8d9 
  src/kfontaction.h ae84944 
  src/kmultitabbar.h 79e62ed 
  src/kmultitabbar_p.h 6311413 
  src/kurllabel.h eeba9e0 

Diff: https://git.reviewboard.kde.org/r/129283/diff/


Testing
---

all warnings for -Wsuggest-override are gone
make test still passes


Thanks,

Allen Winter

Re: Review Request 129283: kwidgetaddons - add overrides

[Albert Astals Cid]

> On Oct. 30, 2016, 2:22 p.m., Christoph Feck wrote:
> > src/kcursor_p.h, line 46
> > 
> >
> > Do we remove the "virtual" keyword? Or would that mean that subclasses 
> > can no longer override?
> 
> Dominik Haumann wrote:
> Personally, I would remove it, since it's redundant, and only adds noise 
> I have to read. And no, once a function is virtual it'll stay virtual.

> once a function is virtual it'll stay virtual.

(For completion) Until you mark it as final


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129283/#review100403
---


On Oct. 30, 2016, 1:33 p.m., Allen Winter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129283/
> ---
> 
> (Updated Oct. 30, 2016, 1:33 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> Add Q_DECL_OVERRIDES as suggested by -Wsuggest-override
> 
> 
> Diffs
> -
> 
>   src/kacceleratormanager_p.h 55ab1c1 
>   src/kcharselect_p.h e4efdab 
>   src/kcharselectdata.cpp 92c1c79 
>   src/kcursor_p.h fcac8d9 
>   src/kfontaction.h ae84944 
>   src/kmultitabbar.h 79e62ed 
>   src/kmultitabbar_p.h 6311413 
>   src/kurllabel.h eeba9e0 
> 
> Diff: https://git.reviewboard.kde.org/r/129283/diff/
> 
> 
> Testing
> ---
> 
> all warnings for -Wsuggest-override are gone
> make test still passes
> 
> 
> Thanks,
> 
> Allen Winter
> 
>

Re: Review Request 129283: kwidgetaddons - add overrides

[Dominik Haumann]

> On Oct. 30, 2016, 2:22 p.m., Christoph Feck wrote:
> > src/kcursor_p.h, line 46
> > 
> >
> > Do we remove the "virtual" keyword? Or would that mean that subclasses 
> > can no longer override?

Personally, I would remove it, since it's redundant, and only adds noise I have 
to read. And no, once a function is virtual it'll stay virtual.


- Dominik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129283/#review100403
---


On Oct. 30, 2016, 1:33 p.m., Allen Winter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129283/
> ---
> 
> (Updated Oct. 30, 2016, 1:33 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> Add Q_DECL_OVERRIDES as suggested by -Wsuggest-override
> 
> 
> Diffs
> -
> 
>   src/kacceleratormanager_p.h 55ab1c1 
>   src/kcharselect_p.h e4efdab 
>   src/kcharselectdata.cpp 92c1c79 
>   src/kcursor_p.h fcac8d9 
>   src/kfontaction.h ae84944 
>   src/kmultitabbar.h 79e62ed 
>   src/kmultitabbar_p.h 6311413 
>   src/kurllabel.h eeba9e0 
> 
> Diff: https://git.reviewboard.kde.org/r/129283/diff/
> 
> 
> Testing
> ---
> 
> all warnings for -Wsuggest-override are gone
> make test still passes
> 
> 
> Thanks,
> 
> Allen Winter
> 
>

Re: Review Request 129283: kwidgetaddons - add overrides

[Christoph Feck]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129283/#review100403
---


Ship it!




Ship It!


src/kcursor_p.h (line 46)


Do we remove the "virtual" keyword? Or would that mean that subclasses can 
no longer override?


- Christoph Feck


On Oct. 30, 2016, 2:33 p.m., Allen Winter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129283/
> ---
> 
> (Updated Oct. 30, 2016, 2:33 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> Add Q_DECL_OVERRIDES as suggested by -Wsuggest-override
> 
> 
> Diffs
> -
> 
>   src/kacceleratormanager_p.h 55ab1c1 
>   src/kcharselect_p.h e4efdab 
>   src/kcharselectdata.cpp 92c1c79 
>   src/kcursor_p.h fcac8d9 
>   src/kfontaction.h ae84944 
>   src/kmultitabbar.h 79e62ed 
>   src/kmultitabbar_p.h 6311413 
>   src/kurllabel.h eeba9e0 
> 
> Diff: https://git.reviewboard.kde.org/r/129283/diff/
> 
> 
> Testing
> ---
> 
> all warnings for -Wsuggest-override are gone
> make test still passes
> 
> 
> Thanks,
> 
> Allen Winter
> 
>

Review Request 129283: kwidgetaddons - add overrides

[Allen Winter]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129283/
---

Review request for KDE Frameworks.


Repository: kwidgetsaddons


Description
---

Add Q_DECL_OVERRIDES as suggested by -Wsuggest-override


Diffs
-

  src/kacceleratormanager_p.h 55ab1c1 
  src/kcharselect_p.h e4efdab 
  src/kcharselectdata.cpp 92c1c79 
  src/kcursor_p.h fcac8d9 
  src/kfontaction.h ae84944 
  src/kmultitabbar.h 79e62ed 
  src/kmultitabbar_p.h 6311413 
  src/kurllabel.h eeba9e0 

Diff: https://git.reviewboard.kde.org/r/129283/diff/


Testing
---

all warnings for -Wsuggest-override are gone
make test still passes


Thanks,

Allen Winter