Re: Review Request 129314: Fix 'checkXML5 generates html files in workdir for valid docbooks'
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129314/ --- (Updated Nov. 4, 2016, 1:25 p.m.) Status -- This change has been marked as submitted. Review request for Documentation, KDE Frameworks and Luigi Toscano. Changes --- Submitted with commit 29c0ecf99c50bb4bed62a4d90f45e5c9e3899d1c by Ralf Habacker to branch master. Bugs: 371987 https://bugs.kde.org/show_bug.cgi?id=371987 Repository: kdoctools Description --- Fix 'checkXML5 generates html files in workdir for valid docbooks'. BUG:371987 Diffs - src/checkXML5.cpp 437296a0b582c5b3e11c72712c62188dbcef5aa7 Diff: https://git.reviewboard.kde.org/r/129314/diff/ Testing --- tested on opensuse 13.2 Thanks, Ralf Habacker
Re: Review Request 129314: Fix 'checkXML5 generates html files in workdir for valid docbooks'
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129314/#review100567 --- Ship it! I can't compile it, but the code looks fine, apol's comments have been addressed, I trust Burkhard's testing (maybe we should add an automated test for this) and we have a tag tomorrow. So let's go for it. - Luigi Toscano On Nov. 4, 2016, 9:18 a.m., Ralf Habacker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129314/ > --- > > (Updated Nov. 4, 2016, 9:18 a.m.) > > > Review request for Documentation, KDE Frameworks and Luigi Toscano. > > > Bugs: 371987 > https://bugs.kde.org/show_bug.cgi?id=371987 > > > Repository: kdoctools > > > Description > --- > > Fix 'checkXML5 generates html files in workdir for valid docbooks'. > > BUG:371987 > > > Diffs > - > > src/checkXML5.cpp 437296a0b582c5b3e11c72712c62188dbcef5aa7 > > Diff: https://git.reviewboard.kde.org/r/129314/diff/ > > > Testing > --- > > tested on opensuse 13.2 > > > Thanks, > > Ralf Habacker > >
Re: Review Request 129314: Fix 'checkXML5 generates html files in workdir for valid docbooks'
> On Nov. 4, 2016, 9:58 vorm., Burkhard Lück wrote: > > Using checkXML5+meinproc5 with patch on a valid docbook: > > > > $ ls *html > > ls: cannot access '*html': No such file or directory > > $ checkXML5 kdegraphics/okular/doc/index.docbook > > $ ls *html > > ls: cannot access '*html': No such file or directory > > $ meinproc5 --check kdegraphics/okular/doc/index.docbook > > $ ls *html > > advanced.html command-line-options.html configeditor.html > > configperformance.html configure.html forms.html > > inverse_search.html menugo.html menuview.html > > primary-menu-items.html > > annotations.html configaccessibility.html configgeneral.html > > configpresentation.html credits.html index.html > > menubookmarks.html menuhelp.html navigating.html > > settings-menu.html > > bookmark-management.html configannotations.html config-pdf.html > > configure-backends.html fit-window-to-page.html introduction.html > > menuedit.htmlmenutools.html presentationMode.html use.html > > > > -> meinproc5 --check should not generate html files used with "--check" > > > > Using checkXML5+meinproc5 with patch on an invalid docbook: > > > > $ rm *html > > $ checkXML5 kdegraphics/okular/doc/index.docbook > > > > -> no output of errors! > > > > $ ls *html > > ls: cannot access '*html': No such file or directory > > $ meinproc5 --check kdegraphics/okular/doc/index.docbook > > index.docbook:912: parser error : expected '>' > > > > ^ > > meinproc(16611)/default main: Error: `xmllint --noout` outputted text > > > > checkXML5+meinproc5 with patch are still broken > > Ralf Habacker wrote: > You probably uses revision 1 of this patch. This is fixed with patch > revision 2, where checkXML5 redirects meinproc5 stderr output to stderr. > > Burkhard Lück wrote: > You are right, sorry for the noise. > checkXML5+meinproc5 work now as before So I have a go ? - Ralf --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129314/#review100556 --- On Nov. 4, 2016, 9:18 vorm., Ralf Habacker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129314/ > --- > > (Updated Nov. 4, 2016, 9:18 vorm.) > > > Review request for Documentation, KDE Frameworks and Luigi Toscano. > > > Bugs: 371987 > https://bugs.kde.org/show_bug.cgi?id=371987 > > > Repository: kdoctools > > > Description > --- > > Fix 'checkXML5 generates html files in workdir for valid docbooks'. > > BUG:371987 > > > Diffs > - > > src/checkXML5.cpp 437296a0b582c5b3e11c72712c62188dbcef5aa7 > > Diff: https://git.reviewboard.kde.org/r/129314/diff/ > > > Testing > --- > > tested on opensuse 13.2 > > > Thanks, > > Ralf Habacker > >
Re: Review Request 129314: Fix 'checkXML5 generates html files in workdir for valid docbooks'
> On Nov. 4, 2016, 8:58 vorm., Burkhard Lück wrote: > > Using checkXML5+meinproc5 with patch on a valid docbook: > > > > $ ls *html > > ls: cannot access '*html': No such file or directory > > $ checkXML5 kdegraphics/okular/doc/index.docbook > > $ ls *html > > ls: cannot access '*html': No such file or directory > > $ meinproc5 --check kdegraphics/okular/doc/index.docbook > > $ ls *html > > advanced.html command-line-options.html configeditor.html > > configperformance.html configure.html forms.html > > inverse_search.html menugo.html menuview.html > > primary-menu-items.html > > annotations.html configaccessibility.html configgeneral.html > > configpresentation.html credits.html index.html > > menubookmarks.html menuhelp.html navigating.html > > settings-menu.html > > bookmark-management.html configannotations.html config-pdf.html > > configure-backends.html fit-window-to-page.html introduction.html > > menuedit.htmlmenutools.html presentationMode.html use.html > > > > -> meinproc5 --check should not generate html files used with "--check" > > > > Using checkXML5+meinproc5 with patch on an invalid docbook: > > > > $ rm *html > > $ checkXML5 kdegraphics/okular/doc/index.docbook > > > > -> no output of errors! > > > > $ ls *html > > ls: cannot access '*html': No such file or directory > > $ meinproc5 --check kdegraphics/okular/doc/index.docbook > > index.docbook:912: parser error : expected '>' > > > > ^ > > meinproc(16611)/default main: Error: `xmllint --noout` outputted text > > > > checkXML5+meinproc5 with patch are still broken > > Ralf Habacker wrote: > You probably uses revision 1 of this patch. This is fixed with patch > revision 2, where checkXML5 redirects meinproc5 stderr output to stderr. You are right, sorry for the noise. checkXML5+meinproc5 work now as before - Burkhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129314/#review100556 --- On Nov. 4, 2016, 8:18 vorm., Ralf Habacker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129314/ > --- > > (Updated Nov. 4, 2016, 8:18 vorm.) > > > Review request for Documentation, KDE Frameworks and Luigi Toscano. > > > Bugs: 371987 > https://bugs.kde.org/show_bug.cgi?id=371987 > > > Repository: kdoctools > > > Description > --- > > Fix 'checkXML5 generates html files in workdir for valid docbooks'. > > BUG:371987 > > > Diffs > - > > src/checkXML5.cpp 437296a0b582c5b3e11c72712c62188dbcef5aa7 > > Diff: https://git.reviewboard.kde.org/r/129314/diff/ > > > Testing > --- > > tested on opensuse 13.2 > > > Thanks, > > Ralf Habacker > >
Re: Review Request 129314: Fix 'checkXML5 generates html files in workdir for valid docbooks'
> On Nov. 4, 2016, 9:58 vorm., Burkhard Lück wrote: > > Using checkXML5+meinproc5 with patch on a valid docbook: > > > > $ ls *html > > ls: cannot access '*html': No such file or directory > > $ checkXML5 kdegraphics/okular/doc/index.docbook > > $ ls *html > > ls: cannot access '*html': No such file or directory > > $ meinproc5 --check kdegraphics/okular/doc/index.docbook > > $ ls *html > > advanced.html command-line-options.html configeditor.html > > configperformance.html configure.html forms.html > > inverse_search.html menugo.html menuview.html > > primary-menu-items.html > > annotations.html configaccessibility.html configgeneral.html > > configpresentation.html credits.html index.html > > menubookmarks.html menuhelp.html navigating.html > > settings-menu.html > > bookmark-management.html configannotations.html config-pdf.html > > configure-backends.html fit-window-to-page.html introduction.html > > menuedit.htmlmenutools.html presentationMode.html use.html > > > > -> meinproc5 --check should not generate html files used with "--check" > > > > Using checkXML5+meinproc5 with patch on an invalid docbook: > > > > $ rm *html > > $ checkXML5 kdegraphics/okular/doc/index.docbook > > > > -> no output of errors! > > > > $ ls *html > > ls: cannot access '*html': No such file or directory > > $ meinproc5 --check kdegraphics/okular/doc/index.docbook > > index.docbook:912: parser error : expected '>' > > > > ^ > > meinproc(16611)/default main: Error: `xmllint --noout` outputted text > > > > checkXML5+meinproc5 with patch are still broken You probably uses revision 1 of this patch. This is fixed with patch revision 2, where checkXML5 redirects meinproc5 stderr output to stderr. - Ralf --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129314/#review100556 --- On Nov. 4, 2016, 9:18 vorm., Ralf Habacker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129314/ > --- > > (Updated Nov. 4, 2016, 9:18 vorm.) > > > Review request for Documentation, KDE Frameworks and Luigi Toscano. > > > Bugs: 371987 > https://bugs.kde.org/show_bug.cgi?id=371987 > > > Repository: kdoctools > > > Description > --- > > Fix 'checkXML5 generates html files in workdir for valid docbooks'. > > BUG:371987 > > > Diffs > - > > src/checkXML5.cpp 437296a0b582c5b3e11c72712c62188dbcef5aa7 > > Diff: https://git.reviewboard.kde.org/r/129314/diff/ > > > Testing > --- > > tested on opensuse 13.2 > > > Thanks, > > Ralf Habacker > >
Re: Review Request 129314: Fix 'checkXML5 generates html files in workdir for valid docbooks'
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129314/#review100556 --- Using checkXML5+meinproc5 with patch on a valid docbook: $ ls *html ls: cannot access '*html': No such file or directory $ checkXML5 kdegraphics/okular/doc/index.docbook $ ls *html ls: cannot access '*html': No such file or directory $ meinproc5 --check kdegraphics/okular/doc/index.docbook $ ls *html advanced.html command-line-options.html configeditor.html configperformance.html configure.html forms.html inverse_search.html menugo.html menuview.html primary-menu-items.html annotations.html configaccessibility.html configgeneral.html configpresentation.html credits.html index.html menubookmarks.html menuhelp.html navigating.htmlsettings-menu.html bookmark-management.html configannotations.html config-pdf.html configure-backends.html fit-window-to-page.html introduction.html menuedit.htmlmenutools.html presentationMode.html use.html -> meinproc5 --check should not generate html files used with "--check" Using checkXML5+meinproc5 with patch on an invalid docbook: $ rm *html $ checkXML5 kdegraphics/okular/doc/index.docbook -> no output of errors! $ ls *html ls: cannot access '*html': No such file or directory $ meinproc5 --check kdegraphics/okular/doc/index.docbook index.docbook:912: parser error : expected '>' ^ meinproc(16611)/default main: Error: `xmllint --noout` outputted text checkXML5+meinproc5 with patch are still broken - Burkhard Lück On Nov. 4, 2016, 8:18 vorm., Ralf Habacker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129314/ > --- > > (Updated Nov. 4, 2016, 8:18 vorm.) > > > Review request for Documentation, KDE Frameworks and Luigi Toscano. > > > Bugs: 371987 > https://bugs.kde.org/show_bug.cgi?id=371987 > > > Repository: kdoctools > > > Description > --- > > Fix 'checkXML5 generates html files in workdir for valid docbooks'. > > BUG:371987 > > > Diffs > - > > src/checkXML5.cpp 437296a0b582c5b3e11c72712c62188dbcef5aa7 > > Diff: https://git.reviewboard.kde.org/r/129314/diff/ > > > Testing > --- > > tested on opensuse 13.2 > > > Thanks, > > Ralf Habacker > >
Re: Review Request 129314: Fix 'checkXML5 generates html files in workdir for valid docbooks'
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129314/ --- (Updated Nov. 4, 2016, 9:18 vorm.) Review request for Documentation, KDE Frameworks and Luigi Toscano. Summary (updated) - Fix 'checkXML5 generates html files in workdir for valid docbooks' Bugs: 371987 https://bugs.kde.org/show_bug.cgi?id=371987 Repository: kdoctools Description --- Fix 'checkXML5 generates html files in workdir for valid docbooks'. BUG:371987 Diffs - src/checkXML5.cpp 437296a0b582c5b3e11c72712c62188dbcef5aa7 Diff: https://git.reviewboard.kde.org/r/129314/diff/ Testing --- tested on opensuse 13.2 Thanks, Ralf Habacker
Re: Review Request 129314: Fix 'checkXML5 generates html files in workdir for valid docbooks'.Setup targets for cross compiling.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129314/ --- (Updated Nov. 4, 2016, 9:16 vorm.) Review request for Documentation, KDE Frameworks and Luigi Toscano. Summary (updated) - Fix 'checkXML5 generates html files in workdir for valid docbooks'.Setup targets for cross compiling. Bugs: 371987 https://bugs.kde.org/show_bug.cgi?id=371987 Repository: kdoctools Description --- Fix 'checkXML5 generates html files in workdir for valid docbooks'. BUG:371987 Diffs (updated) - src/checkXML5.cpp 437296a0b582c5b3e11c72712c62188dbcef5aa7 Diff: https://git.reviewboard.kde.org/r/129314/diff/ Testing --- tested on opensuse 13.2 Thanks, Ralf Habacker
