Review Request 129314: Setup targets for cross compiling.

2016-11-02 Thread Ralf Habacker 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129314/
---

Review request for Documentation, KDE Frameworks and Luigi Toscano.


Bugs: 371987
https://bugs.kde.org/show_bug.cgi?id=371987


Repository: kdoctools


Description
---

Fix 'checkXML5 generates html files in workdir for valid docbooks'.

BUG:371987


Diffs
-

  KF5DocToolsMacros.cmake d73201dbecaf370898f66f807e6d8856d6f88a8d 
  src/checkXML5.cpp 437296a0b582c5b3e11c72712c62188dbcef5aa7 

Diff: https://git.reviewboard.kde.org/r/129314/diff/


Testing
---

tested on opensuse 13.2


Thanks,

Ralf Habacker

Re: Review Request 129314: Setup targets for cross compiling.

2016-11-02 Thread Burkhard Lück 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129314/#review100517
---



works for me, but let's wait for Luigi's OK

- Burkhard Lück


On Nov. 2, 2016, 7:55 nachm., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129314/
> ---
> 
> (Updated Nov. 2, 2016, 7:55 nachm.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Bugs: 371987
> https://bugs.kde.org/show_bug.cgi?id=371987
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Fix 'checkXML5 generates html files in workdir for valid docbooks'.
> 
> BUG:371987
> 
> 
> Diffs
> -
> 
>   KF5DocToolsMacros.cmake d73201dbecaf370898f66f807e6d8856d6f88a8d 
>   src/checkXML5.cpp 437296a0b582c5b3e11c72712c62188dbcef5aa7 
> 
> Diff: https://git.reviewboard.kde.org/r/129314/diff/
> 
> 
> Testing
> ---
> 
> tested on opensuse 13.2
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Re: Review Request 129314: Setup targets for cross compiling.

2016-11-02 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129314/#review100526
---




KF5DocToolsMacros.cmake (line 150)


Doesn't cmake already do this expansion itself? What error are you trying 
to fix?



src/checkXML5.cpp (line 35)


Reading the documentation these two versions do the exact same thing.


- Aleix Pol Gonzalez


On Nov. 2, 2016, 8:55 p.m., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129314/
> ---
> 
> (Updated Nov. 2, 2016, 8:55 p.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Bugs: 371987
> https://bugs.kde.org/show_bug.cgi?id=371987
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Fix 'checkXML5 generates html files in workdir for valid docbooks'.
> 
> BUG:371987
> 
> 
> Diffs
> -
> 
>   KF5DocToolsMacros.cmake d73201dbecaf370898f66f807e6d8856d6f88a8d 
>   src/checkXML5.cpp 437296a0b582c5b3e11c72712c62188dbcef5aa7 
> 
> Diff: https://git.reviewboard.kde.org/r/129314/diff/
> 
> 
> Testing
> ---
> 
> tested on opensuse 13.2
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Re: Review Request 129314: Setup targets for cross compiling.

2016-11-04 Thread Burkhard Lück 


> On Nov. 2, 2016, 8:22 nachm., Burkhard Lück wrote:
> > works for me, but let's wait for Luigi's OK

-100
I just noticed checkXML5 does not output any error on invalid xml, makes 
checkXML5 useless


- Burkhard


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129314/#review100517
---


On Nov. 2, 2016, 7:55 nachm., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129314/
> ---
> 
> (Updated Nov. 2, 2016, 7:55 nachm.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Bugs: 371987
> https://bugs.kde.org/show_bug.cgi?id=371987
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Fix 'checkXML5 generates html files in workdir for valid docbooks'.
> 
> BUG:371987
> 
> 
> Diffs
> -
> 
>   KF5DocToolsMacros.cmake d73201dbecaf370898f66f807e6d8856d6f88a8d 
>   src/checkXML5.cpp 437296a0b582c5b3e11c72712c62188dbcef5aa7 
> 
> Diff: https://git.reviewboard.kde.org/r/129314/diff/
> 
> 
> Testing
> ---
> 
> tested on opensuse 13.2
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>