Re: Review Request 129327: Expose desktopFileName in KWindowInfo
> On Nov. 8, 2016, 6:08 p.m., Aleix Pol Gonzalez wrote: > > It's weird that it's called `desktopFileName` but it doesn't offer a file > > name? I think it should be renamed or fixed to provide the path. In the end > > it's an API that then requires the user to do a rather big look-up. The naming follows the naming in: NETWinInfo, KAboutData and QGuiApplication. Naming it differently would be wrong IMHO. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129327/#review100732 --- On Nov. 7, 2016, 7:29 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129327/ > --- > > (Updated Nov. 7, 2016, 7:29 a.m.) > > > Review request for KDE Frameworks and Eike Hein. > > > Repository: kwindowsystem > > > Description > --- > > This change introduced a new method in KWindowInfo: > QByteArray KWindowInfo::desktopFileName() const > > It returns the desktop file name of the application if known on the > given platform. So far only provided on X11 through > NETWinInfo::desktopFileName. > > > Diffs > - > > autotests/kwindowinfox11test.cpp 5dfbcfa67d74244122c86433a40a7ed6923fb1ab > src/kwindowinfo.h 5d9799b20d640caa1b1cf9ab4d9dc69b8cceefe3 > src/kwindowinfo.cpp 658a0b645797676d4e48585ede3d832333688081 > src/kwindowinfo_p.h 45390c06e7b5ad064ea9368ca102b2462a029c06 > src/platforms/xcb/kwindowinfo.cpp eca607e18a979439593e05e1da232548d0e7d139 > src/platforms/xcb/kwindowinfo_p_x11.h > 68805765fd630c2bc7cf0d77be688333b4a363f7 > > Diff: https://git.reviewboard.kde.org/r/129327/diff/ > > > Testing > --- > > > Thanks, > > Martin Gräßlin > >
Re: Review Request 129327: Expose desktopFileName in KWindowInfo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129327/#review100732 --- It's weird that it's called `desktopFileName` but it doesn't offer a file name? I think it should be renamed or fixed to provide the path. In the end it's an API that then requires the user to do a rather big look-up. - Aleix Pol Gonzalez On Nov. 7, 2016, 7:29 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129327/ > --- > > (Updated Nov. 7, 2016, 7:29 a.m.) > > > Review request for KDE Frameworks and Eike Hein. > > > Repository: kwindowsystem > > > Description > --- > > This change introduced a new method in KWindowInfo: > QByteArray KWindowInfo::desktopFileName() const > > It returns the desktop file name of the application if known on the > given platform. So far only provided on X11 through > NETWinInfo::desktopFileName. > > > Diffs > - > > autotests/kwindowinfox11test.cpp 5dfbcfa67d74244122c86433a40a7ed6923fb1ab > src/kwindowinfo.h 5d9799b20d640caa1b1cf9ab4d9dc69b8cceefe3 > src/kwindowinfo.cpp 658a0b645797676d4e48585ede3d832333688081 > src/kwindowinfo_p.h 45390c06e7b5ad064ea9368ca102b2462a029c06 > src/platforms/xcb/kwindowinfo.cpp eca607e18a979439593e05e1da232548d0e7d139 > src/platforms/xcb/kwindowinfo_p_x11.h > 68805765fd630c2bc7cf0d77be688333b4a363f7 > > Diff: https://git.reviewboard.kde.org/r/129327/diff/ > > > Testing > --- > > > Thanks, > > Martin Gräßlin > >
Re: Review Request 129327: Expose desktopFileName in KWindowInfo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129327/ --- (Updated Nov. 7, 2016, 7:29 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Eike Hein. Repository: kwindowsystem Description --- This change introduced a new method in KWindowInfo: QByteArray KWindowInfo::desktopFileName() const It returns the desktop file name of the application if known on the given platform. So far only provided on X11 through NETWinInfo::desktopFileName. Diffs - autotests/kwindowinfox11test.cpp 5dfbcfa67d74244122c86433a40a7ed6923fb1ab src/kwindowinfo.h 5d9799b20d640caa1b1cf9ab4d9dc69b8cceefe3 src/kwindowinfo.cpp 658a0b645797676d4e48585ede3d832333688081 src/kwindowinfo_p.h 45390c06e7b5ad064ea9368ca102b2462a029c06 src/platforms/xcb/kwindowinfo.cpp eca607e18a979439593e05e1da232548d0e7d139 src/platforms/xcb/kwindowinfo_p_x11.h 68805765fd630c2bc7cf0d77be688333b4a363f7 Diff: https://git.reviewboard.kde.org/r/129327/diff/ Testing --- Thanks, Martin Gräßlin
Re: Review Request 129327: Expose desktopFileName in KWindowInfo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129327/#review100558 --- Ship it! Ship It! - Eike Hein On Nov. 4, 2016, 9:53 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129327/ > --- > > (Updated Nov. 4, 2016, 9:53 a.m.) > > > Review request for KDE Frameworks and Eike Hein. > > > Repository: kwindowsystem > > > Description > --- > > This change introduced a new method in KWindowInfo: > QByteArray KWindowInfo::desktopFileName() const > > It returns the desktop file name of the application if known on the > given platform. So far only provided on X11 through > NETWinInfo::desktopFileName. > > > Diffs > - > > autotests/kwindowinfox11test.cpp 5dfbcfa67d74244122c86433a40a7ed6923fb1ab > src/kwindowinfo.h 5d9799b20d640caa1b1cf9ab4d9dc69b8cceefe3 > src/kwindowinfo.cpp 658a0b645797676d4e48585ede3d832333688081 > src/kwindowinfo_p.h 45390c06e7b5ad064ea9368ca102b2462a029c06 > src/platforms/xcb/kwindowinfo.cpp eca607e18a979439593e05e1da232548d0e7d139 > src/platforms/xcb/kwindowinfo_p_x11.h > 68805765fd630c2bc7cf0d77be688333b4a363f7 > > Diff: https://git.reviewboard.kde.org/r/129327/diff/ > > > Testing > --- > > > Thanks, > > Martin Gräßlin > >
Review Request 129327: Expose desktopFileName in KWindowInfo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129327/ --- Review request for KDE Frameworks and Eike Hein. Repository: kwindowsystem Description --- This change introduced a new method in KWindowInfo: QByteArray KWindowInfo::desktopFileName() const It returns the desktop file name of the application if known on the given platform. So far only provided on X11 through NETWinInfo::desktopFileName. Diffs - autotests/kwindowinfox11test.cpp 5dfbcfa67d74244122c86433a40a7ed6923fb1ab src/kwindowinfo.h 5d9799b20d640caa1b1cf9ab4d9dc69b8cceefe3 src/kwindowinfo.cpp 658a0b645797676d4e48585ede3d832333688081 src/kwindowinfo_p.h 45390c06e7b5ad064ea9368ca102b2462a029c06 src/platforms/xcb/kwindowinfo.cpp eca607e18a979439593e05e1da232548d0e7d139 src/platforms/xcb/kwindowinfo_p_x11.h 68805765fd630c2bc7cf0d77be688333b4a363f7 Diff: https://git.reviewboard.kde.org/r/129327/diff/ Testing --- Thanks, Martin Gräßlin
