Re: Review Request 129355: kparts add overrides
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129355/ --- (Updated Nov. 6, 2016, 11:35 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit fd8693fba950010b64b4d7ae2e6ca84e68562e61 by Allen Winter to branch master. Repository: kparts Description --- Add Q_DECL_OVERRIDES as suggested by -Wsuggest-override Diffs - src/scriptableextension_p.h c8e58be Diff: https://git.reviewboard.kde.org/r/129355/diff/ Testing --- all warnings for -Wsuggest-override are gone make test still passes Thanks, Allen Winter
Re: Review Request 129355: kparts add overrides
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129355/#review100671 --- Ship it! Ship It! - David Faure On Nov. 6, 2016, 9:06 p.m., Allen Winter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129355/ > --- > > (Updated Nov. 6, 2016, 9:06 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kparts > > > Description > --- > > Add Q_DECL_OVERRIDES as suggested by -Wsuggest-override > > > Diffs > - > > src/scriptableextension_p.h c8e58be > > Diff: https://git.reviewboard.kde.org/r/129355/diff/ > > > Testing > --- > > all warnings for -Wsuggest-override are gone > make test still passes > > > Thanks, > > Allen Winter > >
Review Request 129355: kparts add overrides
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129355/ --- Review request for KDE Frameworks. Repository: kparts Description --- Add Q_DECL_OVERRIDES as suggested by -Wsuggest-override Diffs - src/scriptableextension_p.h c8e58be Diff: https://git.reviewboard.kde.org/r/129355/diff/ Testing --- all warnings for -Wsuggest-override are gone make test still passes Thanks, Allen Winter
