Re: Review Request 129356: kdesignerplugin - add overrides to the generated source
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129356/ --- (Updated Nov. 7, 2016, 1:48 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 606352070ae07bd5c7fe6e2702628632b8245c9b by Allen Winter to branch master. Repository: kdesignerplugin Description --- add Q_DECL_OVERRIDE to the kgendesignerplugin.cpp generated code so -Wsuggest-overrides doesn't complain Diffs - src/kgendesignerplugin.cpp 33326d0 Diff: https://git.reviewboard.kde.org/r/129356/diff/ Testing --- The generated code can be compiled with -Wsuggest-overrides without complaining. make test passes also removed tabs from the generated source code Thanks, Allen Winter
Re: Review Request 129356: kdesignerplugin - add overrides to the generated source
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129356/#review100672 --- Ship it! Ship It! - David Faure On Nov. 6, 2016, 10:30 p.m., Allen Winter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129356/ > --- > > (Updated Nov. 6, 2016, 10:30 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdesignerplugin > > > Description > --- > > add Q_DECL_OVERRIDE to the kgendesignerplugin.cpp generated code so > -Wsuggest-overrides doesn't complain > > > Diffs > - > > src/kgendesignerplugin.cpp 33326d0 > > Diff: https://git.reviewboard.kde.org/r/129356/diff/ > > > Testing > --- > > The generated code can be compiled with -Wsuggest-overrides without > complaining. > make test passes > > also removed tabs from the generated source code > > > Thanks, > > Allen Winter > >
Review Request 129356: kdesignerplugin - add overrides to the generated source
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129356/ --- Review request for KDE Frameworks. Repository: kdesignerplugin Description --- add Q_DECL_OVERRIDE to the kgendesignerplugin.cpp generated code so -Wsuggest-overrides doesn't complain Diffs - src/kgendesignerplugin.cpp 33326d0 Diff: https://git.reviewboard.kde.org/r/129356/diff/ Testing --- The generated code can be compiled with -Wsuggest-overrides without complaining. make test passes also removed tabs from the generated source code Thanks, Allen Winter
