Re: Review Request 129710: KConfigDialogManager: drop kdelibs3 classes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129710/ --- (Updated Dec. 28, 2016, 11:54 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Albert Astals Cid and Aleix Pol Gonzalez. Changes --- Submitted with commit 6854fc2e197c7defbd9b1e59dfa3155d0c62830c by Elvis Angelaccio to branch master. Repository: kconfigwidgets Description --- Simpler version of https://git.reviewboard.kde.org/r/129658/ This patch just drops a couple of kdelibs3 classes no one is using anymore (according to lxr). Diffs - src/kconfigdialogmanager.cpp 118d502f2290aa25bf07c1c9dad359fc2b163eaa Diff: https://git.reviewboard.kde.org/r/129710/diff/ Testing --- Builds, tests pass. Thanks, Elvis Angelaccio
Re: Review Request 129710: KConfigDialogManager: drop kdelibs3 classes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129710/#review101628 --- Ship it! Ship It! - Albert Astals Cid On Dec. 28, 2016, 11:11 a.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129710/ > --- > > (Updated Dec. 28, 2016, 11:11 a.m.) > > > Review request for KDE Frameworks, Albert Astals Cid and Aleix Pol Gonzalez. > > > Repository: kconfigwidgets > > > Description > --- > > Simpler version of https://git.reviewboard.kde.org/r/129658/ > > This patch just drops a couple of kdelibs3 classes no one is using anymore > (according to lxr). > > > Diffs > - > > src/kconfigdialogmanager.cpp 118d502f2290aa25bf07c1c9dad359fc2b163eaa > > Diff: https://git.reviewboard.kde.org/r/129710/diff/ > > > Testing > --- > > Builds, tests pass. > > > Thanks, > > Elvis Angelaccio > >
Review Request 129710: KConfigDialogManager: drop kdelibs3 classes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129710/ --- Review request for KDE Frameworks, Albert Astals Cid and Aleix Pol Gonzalez. Repository: kconfigwidgets Description --- Simpler version of https://git.reviewboard.kde.org/r/129658/ This patch just drops a couple of kdelibs3 classes no one is using anymore (according to lxr). Diffs - src/kconfigdialogmanager.cpp 118d502f2290aa25bf07c1c9dad359fc2b163eaa Diff: https://git.reviewboard.kde.org/r/129710/diff/ Testing --- Builds, tests pass. Thanks, Elvis Angelaccio