Review Request 130209: Fix 'klauncher uses absolute compile time install path for finding kioslave.exe'

2017-09-06 Thread Ralf Habacker

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130209/
---

Review request for KDE Frameworks.


Bugs: 382920
https://bugs.kde.org/show_bug.cgi?id=382920


Repository: kinit


Description
---

This patch fixes an issue that kinit uses an absolute path on starting a 
kioslave process on Windows


Diffs
-

  src/klauncher/klauncher.cpp c02bd90c4bb65ceb451c9349b637ae9161a3b76a 

Diff: https://git.reviewboard.kde.org/r/130209/diff/


Testing
---


Thanks,

Ralf Habacker



Re: Review Request 130209: Fix 'klauncher uses absolute compile time install path for finding kioslave.exe'

2017-09-06 Thread Christoph Feck

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130209/#review103691
---



Please use https://phabricator.kde.org/differential/diff/create/ for review 
requests.

- Christoph Feck


On Sept. 6, 2017, 2:07 p.m., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130209/
> ---
> 
> (Updated Sept. 6, 2017, 2:07 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 382920
> https://bugs.kde.org/show_bug.cgi?id=382920
> 
> 
> Repository: kinit
> 
> 
> Description
> ---
> 
> This patch fixes an issue that kinit uses an absolute path on starting a 
> kioslave process on Windows
> 
> 
> Diffs
> -
> 
>   src/klauncher/klauncher.cpp c02bd90c4bb65ceb451c9349b637ae9161a3b76a 
> 
> Diff: https://git.reviewboard.kde.org/r/130209/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>



Re: Review Request 130209: Fix 'klauncher uses absolute compile time install path for finding kioslave.exe'

2017-12-14 Thread Ralf Habacker


> On Sept. 6, 2017, 2:21 nachm., Christoph Feck wrote:
> > Please use https://phabricator.kde.org/differential/diff/create/ for review 
> > requests.

Moved to https://phabricator.kde.org/D7707


- Ralf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130209/#review103691
---


On Sept. 6, 2017, 2:07 nachm., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130209/
> ---
> 
> (Updated Sept. 6, 2017, 2:07 nachm.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 382920
> https://bugs.kde.org/show_bug.cgi?id=382920
> 
> 
> Repository: kinit
> 
> 
> Description
> ---
> 
> This patch fixes an issue that kinit uses an absolute path on starting a 
> kioslave process on Windows
> 
> 
> Diffs
> -
> 
>   src/klauncher/klauncher.cpp c02bd90c4bb65ceb451c9349b637ae9161a3b76a 
> 
> 
> Diff: https://git.reviewboard.kde.org/r/130209/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>



Re: Review Request 130209: Fix 'klauncher uses absolute compile time install path for finding kioslave.exe'

2017-12-14 Thread Ralf Habacker

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130209/
---

(Updated Dez. 14, 2017, 12:33 nachm.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Bugs: 382920
https://bugs.kde.org/show_bug.cgi?id=382920


Repository: kinit


Description
---

This patch fixes an issue that kinit uses an absolute path on starting a 
kioslave process on Windows


Diffs
-

  src/klauncher/klauncher.cpp c02bd90c4bb65ceb451c9349b637ae9161a3b76a 


Diff: https://git.reviewboard.kde.org/r/130209/diff/1/


Testing
---


Thanks,

Ralf Habacker