Some more projects in need of respecting KF5_INSTALL_TARGETS_DEFAULT_ARGS
Hi Christoph, I’ve found that these projects do not make use of KF5_INSTALL_TARGETS_DEFAULT_ARGS at the moment: - systemsettings - muon - rocs - libkdegames - kiten - cantor - kolourpaint - libkmahjongg See for details below in order of appearance. I figure this is only the beginning of it and more projects might turn up in the future. Thanks for taking care of these. Regards, Marko P.S.: I’ve tested locally to prepend "KF5_” to INSTALL_TARGETS_DEFAULT_ARGS for project systemsettings only, which worked fine and made the project install successfully again here on my OSX/CI system. P.P.S.: I realised by now that there are no changes on the production branch, which probably means that there was some change in ECM or wherever provoking these issues... --- systemsettings: CMake Error at core/CMakeLists.txt:37 (install): install TARGETS given no LIBRARY DESTINATION for shared library target "systemsettingsview”. --- muon: CMake Error at libmuon/notifiers/CMakeLists.txt:7 (install): install TARGETS given no LIBRARY DESTINATION for shared library target "MuonNotifiers". CMake Error at libmuon/CMakeLists.txt:63 (install): install TARGETS given no LIBRARY DESTINATION for shared library target "muonprivate”. --- rocs: CMake Error at libgraphtheory/CMakeLists.txt:106 (install): install TARGETS given no LIBRARY DESTINATION for shared library target "rocsgraphtheory”. --- libkdegames: CMake Error at CMakeLists.txt:163 (install): install TARGETS given no LIBRARY DESTINATION for shared library target "KF5KDEGames". CMake Error at CMakeLists.txt:222 (install): install TARGETS given no LIBRARY DESTINATION for shared library target "KF5KDEGamesPrivate”. --- kiten: CMake Error at lib/CMakeLists.txt:37 (install): install TARGETS given no LIBRARY DESTINATION for shared library target "kiten". --- cantor: CMake Error at src/lib/CMakeLists.txt:75 (install): install TARGETS given no LIBRARY DESTINATION for shared library target "cantorlibs”. CMake Error at src/CMakeLists.txt:25 (install): install TARGETS given no LIBRARY DESTINATION for shared library target "cantor_config". --- kolourpaint: CMake Error at CMakeLists.txt:579 (install): install TARGETS given no LIBRARY DESTINATION for shared library target "kolourpaint_lgpl". --- libkmahjongg: CMake Error at CMakeLists.txt:64 (install): install TARGETS given no LIBRARY DESTINATION for shared library target "KF5KMahjongglib". CMake Error at CMakeLists.txt:67 (install): install TARGETS given no LIBRARY DESTINATION for shared library target "KF5KMahjongglib". --- ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Some more projects in need of respecting KF5_INSTALL_TARGETS_DEFAULT_ARGS
Yes, ecm changed recently. On Tue, Jan 6, 2015 at 3:55 PM, Marko Käning wrote: > Hi Christoph, > > I’ve found that these projects do not make use of > KF5_INSTALL_TARGETS_DEFAULT_ARGS > at the moment: > > - systemsettings > - muon > - rocs > - libkdegames > - kiten > - cantor > - kolourpaint > - libkmahjongg > > See for details below in order of appearance. > > I figure this is only the beginning of it and more projects might turn up > in the future. > > Thanks for taking care of these. > > Regards, > Marko > > > > > P.S.: I’ve tested locally to prepend "KF5_” to INSTALL_TARGETS_DEFAULT_ARGS > for project systemsettings only, which worked fine and made the > project > install successfully again here on my OSX/CI system. > > > > > P.P.S.: I realised by now that there are no changes on the production > branch, > which probably means that there was some change in ECM or wherever > provoking these issues... > > > > > --- > > systemsettings: > > CMake Error at core/CMakeLists.txt:37 (install): > install TARGETS given no LIBRARY DESTINATION for shared library target > "systemsettingsview”. > --- > > muon: > > CMake Error at libmuon/notifiers/CMakeLists.txt:7 (install): > install TARGETS given no LIBRARY DESTINATION for shared library target > "MuonNotifiers". > > CMake Error at libmuon/CMakeLists.txt:63 (install): > install TARGETS given no LIBRARY DESTINATION for shared library target > "muonprivate”. > --- > > rocs: > > CMake Error at libgraphtheory/CMakeLists.txt:106 (install): > install TARGETS given no LIBRARY DESTINATION for shared library target > "rocsgraphtheory”. > --- > > libkdegames: > > CMake Error at CMakeLists.txt:163 (install): > install TARGETS given no LIBRARY DESTINATION for shared library target > "KF5KDEGames". > > CMake Error at CMakeLists.txt:222 (install): > install TARGETS given no LIBRARY DESTINATION for shared library target > "KF5KDEGamesPrivate”. > --- > > kiten: > > CMake Error at lib/CMakeLists.txt:37 (install): > install TARGETS given no LIBRARY DESTINATION for shared library target > "kiten". > --- > > cantor: > > CMake Error at src/lib/CMakeLists.txt:75 (install): > install TARGETS given no LIBRARY DESTINATION for shared library target > "cantorlibs”. > > CMake Error at src/CMakeLists.txt:25 (install): > install TARGETS given no LIBRARY DESTINATION for shared library target > "cantor_config". > --- > > kolourpaint: > > CMake Error at CMakeLists.txt:579 (install): > install TARGETS given no LIBRARY DESTINATION for shared library target > "kolourpaint_lgpl". > --- > > libkmahjongg: > > CMake Error at CMakeLists.txt:64 (install): > install TARGETS given no LIBRARY DESTINATION for shared library target > "KF5KMahjongglib". > > CMake Error at CMakeLists.txt:67 (install): > install TARGETS given no LIBRARY DESTINATION for shared library target > "KF5KMahjongglib". > --- > > ___ > Kde-frameworks-devel mailing list > Kde-frameworks-devel@kde.org > https://mail.kde.org/mailman/listinfo/kde-frameworks-devel > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Some more projects in need of respecting KF5_INSTALL_TARGETS_DEFAULT_ARGS
On Tuesday 06 January 2015 23:55:48 Marko Käning wrote: > Hi Christoph, > > I’ve found that these projects do not make use of > KF5_INSTALL_TARGETS_DEFAULT_ARGS at the moment: > > - systemsettings > - muon > - rocs > - libkdegames > - kiten > - cantor > - kolourpaint > - libkmahjongg > > See for details below in order of appearance. > > I figure this is only the beginning of it and more projects might turn up in > the future. Is KF5_INSTALL_TARGETS_DEFAULT_ARGS even correct for non-frameworks projects? KF5_INSTALL_TARGETS_DEFAULT_ARGS's INCLUDES location points to $SOMETHING/KF5. KDEInstallDirs.cmake also has a KDE_INSTALL_TARGETS_DEFAULT_ARGS, which seems more appropriate. @Alex, please elaborate. > > Thanks for taking care of these. > > Regards, > Marko > > > > > P.S.: I’ve tested locally to prepend "KF5_” to INSTALL_TARGETS_DEFAULT_ARGS > for project systemsettings only, which worked fine and made the > project install successfully again here on my OSX/CI system. > > > > > P.P.S.: I realised by now that there are no changes on the production > branch, which probably means that there was some change in ECM or wherever > provoking these issues... > > > > > --- > > systemsettings: > > CMake Error at core/CMakeLists.txt:37 (install): > install TARGETS given no LIBRARY DESTINATION for shared library target > "systemsettingsview”. > --- > > muon: > > CMake Error at libmuon/notifiers/CMakeLists.txt:7 (install): > install TARGETS given no LIBRARY DESTINATION for shared library target > "MuonNotifiers". > > CMake Error at libmuon/CMakeLists.txt:63 (install): > install TARGETS given no LIBRARY DESTINATION for shared library target > "muonprivate”. > --- > > rocs: > > CMake Error at libgraphtheory/CMakeLists.txt:106 (install): > install TARGETS given no LIBRARY DESTINATION for shared library target > "rocsgraphtheory”. > --- > > libkdegames: > > CMake Error at CMakeLists.txt:163 (install): > install TARGETS given no LIBRARY DESTINATION for shared library target > "KF5KDEGames". > > CMake Error at CMakeLists.txt:222 (install): > install TARGETS given no LIBRARY DESTINATION for shared library target > "KF5KDEGamesPrivate”. > --- > > kiten: > > CMake Error at lib/CMakeLists.txt:37 (install): > install TARGETS given no LIBRARY DESTINATION for shared library target > "kiten". > --- > > cantor: > > CMake Error at src/lib/CMakeLists.txt:75 (install): > install TARGETS given no LIBRARY DESTINATION for shared library target > "cantorlibs”. > > CMake Error at src/CMakeLists.txt:25 (install): > install TARGETS given no LIBRARY DESTINATION for shared library target > "cantor_config". > --- > > kolourpaint: > > CMake Error at CMakeLists.txt:579 (install): > install TARGETS given no LIBRARY DESTINATION for shared library target > "kolourpaint_lgpl". > --- > > libkmahjongg: > > CMake Error at CMakeLists.txt:64 (install): > install TARGETS given no LIBRARY DESTINATION for shared library target > "KF5KMahjongglib". > > CMake Error at CMakeLists.txt:67 (install): > install TARGETS given no LIBRARY DESTINATION for shared library target > "KF5KMahjongglib". > --- > > ___ > Kde-frameworks-devel mailing list > Kde-frameworks-devel@kde.org > https://mail.kde.org/mailman/listinfo/kde-frameworks-devel -- Kevin Funk | kf...@kde.org | http://kfunk.org ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Some more projects in need of respecting KF5_INSTALL_TARGETS_DEFAULT_ARGS
> On Tuesday 06 January 2015 23:55:48 Marko Käning wrote: > > Hi Christoph, > > > > I’ve found that these projects do not make use of > > KF5_INSTALL_TARGETS_DEFAULT_ARGS at the moment: > > > > - systemsettings > > - muon > > - rocs > > - libkdegames > > - kiten > > - cantor > > - kolourpaint > > - libkmahjongg > > > > See for details below in order of appearance. > > > > I figure this is only the beginning of it and more projects might turn up > > in > > the future. > > Is KF5_INSTALL_TARGETS_DEFAULT_ARGS even correct for non-frameworks projects? > KF5_INSTALL_TARGETS_DEFAULT_ARGS's INCLUDES location points to > $SOMETHING/KF5. > > KDEInstallDirs.cmake also has a KDE_INSTALL_TARGETS_DEFAULT_ARGS, which seems > more appropriate. > > @Alex, please elaborate. Yeah, for non-framework repos, I am not sure of that, true. Greetings Christoph > > > > > Thanks for taking care of these. > > > > Regards, > > Marko > > > > > > > > > > P.S.: I’ve tested locally to prepend "KF5_” to INSTALL_TARGETS_DEFAULT_ARGS > > for project systemsettings only, which worked fine and made the > > project install successfully again here on my OSX/CI system. > > > > > > > > > > P.P.S.: I realised by now that there are no changes on the production > > branch, which probably means that there was some change in ECM or wherever > > provoking these issues... > > > > > > > > > > --- > > > > systemsettings: > > > > CMake Error at core/CMakeLists.txt:37 (install): > > install TARGETS given no LIBRARY DESTINATION for shared library target > > "systemsettingsview”. > > --- > > > > muon: > > > > CMake Error at libmuon/notifiers/CMakeLists.txt:7 (install): > > install TARGETS given no LIBRARY DESTINATION for shared library target > > "MuonNotifiers". > > > > CMake Error at libmuon/CMakeLists.txt:63 (install): > > install TARGETS given no LIBRARY DESTINATION for shared library target > > "muonprivate”. > > --- > > > > rocs: > > > > CMake Error at libgraphtheory/CMakeLists.txt:106 (install): > > install TARGETS given no LIBRARY DESTINATION for shared library target > > "rocsgraphtheory”. > > --- > > > > libkdegames: > > > > CMake Error at CMakeLists.txt:163 (install): > > install TARGETS given no LIBRARY DESTINATION for shared library target > > "KF5KDEGames". > > > > CMake Error at CMakeLists.txt:222 (install): > > install TARGETS given no LIBRARY DESTINATION for shared library target > > "KF5KDEGamesPrivate”. > > --- > > > > kiten: > > > > CMake Error at lib/CMakeLists.txt:37 (install): > > install TARGETS given no LIBRARY DESTINATION for shared library target > > "kiten". > > --- > > > > cantor: > > > > CMake Error at src/lib/CMakeLists.txt:75 (install): > > install TARGETS given no LIBRARY DESTINATION for shared library target > > "cantorlibs”. > > > > CMake Error at src/CMakeLists.txt:25 (install): > > install TARGETS given no LIBRARY DESTINATION for shared library target > > "cantor_config". > > --- > > > > kolourpaint: > > > > CMake Error at CMakeLists.txt:579 (install): > > install TARGETS given no LIBRARY DESTINATION for shared library target > > "kolourpaint_lgpl". > > --- > > > > libkmahjongg: > > > > CMake Error at CMakeLists.txt:64 (install): > > install TARGETS given no LIBRARY DESTINATION for shared library target > > "KF5KMahjongglib". > > > > CMake Error at CMakeLists.txt:67 (install): > > install TARGETS given no LIBRARY DESTINATION for shared library target > > "KF5KMahjongglib". > > --- > > > > ___ > > Kde-frameworks-devel mailing list > > Kde-frameworks-devel@kde.org > > https://mail.kde.org/mailman/listinfo/kde-frameworks-devel > > -- > Kevin Funk | kf...@kde.org | http://kfunk.org > -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken Fax: +49-681-38360-20 GERMANYWWW: http://www.AbsInt.com Geschäftsführung: Dr.-Ing. Christian Ferdinand Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Some more projects in need of respecting KF5_INSTALL_TARGETS_DEFAULT_ARGS
On Wednesday 07 January 2015 08:38:27 Kevin Funk wrote: > On Tuesday 06 January 2015 23:55:48 Marko Käning wrote: > > Hi Christoph, > > > > I’ve found that these projects do not make use of > > > > KF5_INSTALL_TARGETS_DEFAULT_ARGS at the moment: > > - systemsettings > > - muon > > - rocs > > - libkdegames > > - kiten > > - cantor > > - kolourpaint > > - libkmahjongg > > > > See for details below in order of appearance. > > > > I figure this is only the beginning of it and more projects might turn up > > in the future. > > Is KF5_INSTALL_TARGETS_DEFAULT_ARGS even correct for non-frameworks > projects? KF5_INSTALL_TARGETS_DEFAULT_ARGS's INCLUDES location points to > $SOMETHING/KF5. > > KDEInstallDirs.cmake also has a KDE_INSTALL_TARGETS_DEFAULT_ARGS, which > seems more appropriate. I think you're fully correct. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Some more projects in need of respecting KF5_INSTALL_TARGETS_DEFAULT_ARGS
On Wednesday 07 January 2015 08:38:27 Kevin Funk wrote: > On Tuesday 06 January 2015 23:55:48 Marko Käning wrote: > > Hi Christoph, > > > > I’ve found that these projects do not make use of > > > > KF5_INSTALL_TARGETS_DEFAULT_ARGS at the moment: > > - systemsettings > > - muon > > - rocs > > - libkdegames > > - kiten > > - cantor > > - kolourpaint > > - libkmahjongg > > > > See for details below in order of appearance. > > > > I figure this is only the beginning of it and more projects might turn up > > in the future. > > Is KF5_INSTALL_TARGETS_DEFAULT_ARGS even correct for non-frameworks > projects? KF5_INSTALL_TARGETS_DEFAULT_ARGS's INCLUDES location points to > $SOMETHING/KF5. > > KDEInstallDirs.cmake also has a KDE_INSTALL_TARGETS_DEFAULT_ARGS, which > seems more appropriate. > > @Alex, please elaborate. Nope, any variable from KDEInstallDirs.cmake with KF5 in the name is only for the use of Frameworks. They all have a non-KF5 equivalent - in this case, KDE_INSTALL_TARGETS_DEFAULT_ARGS, as you noticed. I think KF5_INSTALL_TARGETS_DEFAULT_ARGS should actually be KDE_INSTALL_TARGETS_DEFAULT_ARGS_KF5 for consistency with other variables, now I look again. Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Some more projects in need of respecting KF5_INSTALL_TARGETS_DEFAULT_ARGS
On Tuesday 06 January 2015 23:55:48 Marko Käning wrote: > P.P.S.: I realised by now that there are no changes on the production > branch, which probably means that there was some change in ECM or wherever > provoking these issues... I'm somewhat puzzled, as INSTALL_TARGET_DEFAULT_ARGS should still be set (to the same value as KDE_INSTALL_TARGET_DEFAULT_ARGS) unless you have set KDE_INSTALL_DIRS_NO_DEPRECATED to some TRUE-ish value. If not, that's a bug. Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Some more projects in need of respecting KF5_INSTALL_TARGETS_DEFAULT_ARGS
I hit the same issues reported by Marko here on OS X also, and have no KDE_INSTALL_DIRS_NO_DEPRECATED set either. Maybe the logic in ecm is broken somehow? On Wed, Jan 7, 2015 at 11:48 AM, Alex Merry wrote: > On Tuesday 06 January 2015 23:55:48 Marko Käning wrote: > > P.P.S.: I realised by now that there are no changes on the production > > branch, which probably means that there was some change in ECM or > wherever > > provoking these issues... > > I'm somewhat puzzled, as INSTALL_TARGET_DEFAULT_ARGS should still be set > (to > the same value as KDE_INSTALL_TARGET_DEFAULT_ARGS) unless you have set > KDE_INSTALL_DIRS_NO_DEPRECATED to some TRUE-ish value. If not, that's a > bug. > > Alex > ___ > Kde-frameworks-devel mailing list > Kde-frameworks-devel@kde.org > https://mail.kde.org/mailman/listinfo/kde-frameworks-devel > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Some more projects in need of respecting KF5_INSTALL_TARGETS_DEFAULT_ARGS
Hi Alex, Hi Ben, Happy New Year, for a start! :) On 07 Jan 2015, at 19:48 , Alex Merry wrote: > On Tuesday 06 January 2015 23:55:48 Marko Käning wrote: >> P.P.S.: I realised by now that there are no changes on the production >> branch, which probably means that there was some change in ECM or wherever >> provoking these issues... > > I'm somewhat puzzled, as INSTALL_TARGET_DEFAULT_ARGS should still be set (to > the same value as KDE_INSTALL_TARGET_DEFAULT_ARGS) unless you have set > KDE_INSTALL_DIRS_NO_DEPRECATED to some TRUE-ish value. If not, that's a bug. Hmmm... Well, off-list I already had contacted Ben because of this issue. See this: Begin forwarded message: > On 07 Jan 2015, at 09:12 , David Faure wrote: >>> KDEInstallDirs.cmake also has a KDE_INSTALL_TARGETS_DEFAULT_ARGS, which >>> seems more appropriate. >> >> I think you're fully correct. > > Thus I tried KDE_INSTALL_TARGETS_DEFAULT_ARGS for the non-KF5 “systemsettings” > project but it lead to the same error as the original > INSTALL_TARGETS_DEFAULT_ARGS > variable in my initial post. > > Is this perhaps specific to the CI system? So, I really wonder what’s going on here, as it doesn’t hit all projects! kstars fails, but marble - for instance - still builds fine without the need to mess with these vars! I can't find KDE_INSTALL_DIRS_NO_DEPRECATED in CMakeCache.txt of kstars at all, so I assume that it is not set. Does this mean it IS a bug for kstars and all the other projects after all? Marko ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Some more projects in need of respecting KF5_INSTALL_TARGETS_DEFAULT_ARGS
Hi,
I see why KDE_INSTALL_TARGETS_DEFAULT_ARGS and INSTALL_TARGETS_DEFAULT_ARGS
fail on Mac,
typo:
# on the Mac support an extra install directory for application bundles
if(APPLE)
set(KDE_INSTALL_TARGETS_DEFAULT_ARGS ${INSTALL_TARGETS_DEFAULT_ARGS}
BUNDLE DESTINATION
"${BUNDLE_INSTALL_DIR}" )
set(KF5_INSTALL_TARGETS_DEFAULT_ARGS ${KF5_INSTALL_TARGETS_DEFAULT_ARGS}
BUNDLE DESTINATION
"${BUNDLE_INSTALL_DIR}" )
endif(APPLE)
should be
# on the Mac support an extra install directory for application bundles
if(APPLE)
set(KDE_INSTALL_TARGETS_DEFAULT_ARGS ${KDE_INSTALL_TARGETS_DEFAULT_ARGS}
BUNDLE DESTINATION
"${BUNDLE_INSTALL_DIR}" )
set(KF5_INSTALL_TARGETS_DEFAULT_ARGS ${KF5_INSTALL_TARGETS_DEFAULT_ARGS}
BUNDLE DESTINATION
"${BUNDLE_INSTALL_DIR}" )
endif(APPLE)
will patch that ;=)
- Ursprüngliche Mail -
> Hi Alex,
> Hi Ben,
>
> Happy New Year, for a start! :)
>
> On 07 Jan 2015, at 19:48 , Alex Merry wrote:
>
> > On Tuesday 06 January 2015 23:55:48 Marko Käning wrote:
> >> P.P.S.: I realised by now that there are no changes on the production
> >> branch, which probably means that there was some change in ECM or wherever
> >> provoking these issues...
> >
> > I'm somewhat puzzled, as INSTALL_TARGET_DEFAULT_ARGS should still be set
> > (to
> > the same value as KDE_INSTALL_TARGET_DEFAULT_ARGS) unless you have set
> > KDE_INSTALL_DIRS_NO_DEPRECATED to some TRUE-ish value. If not, that's a
> > bug.
>
>
> Hmmm...
>
> Well, off-list I already had contacted Ben because of this issue. See this:
>
>
> Begin forwarded message:
> > On 07 Jan 2015, at 09:12 , David Faure wrote:
> >>> KDEInstallDirs.cmake also has a KDE_INSTALL_TARGETS_DEFAULT_ARGS, which
> >>> seems more appropriate.
> >>
> >> I think you're fully correct.
> >
> > Thus I tried KDE_INSTALL_TARGETS_DEFAULT_ARGS for the non-KF5
> > “systemsettings”
> > project but it lead to the same error as the original
> > INSTALL_TARGETS_DEFAULT_ARGS
> > variable in my initial post.
> >
> > Is this perhaps specific to the CI system?
>
>
>
> So, I really wonder what’s going on here, as it doesn’t hit all projects!
> kstars fails,
> but marble - for instance - still builds fine without the need to mess with
> these vars!
>
> I can't find KDE_INSTALL_DIRS_NO_DEPRECATED in CMakeCache.txt of kstars at
> all, so I assume
> that it is not set.
>
> Does this mean it IS a bug for kstars and all the other projects after
> all?
>
> Marko
> ___
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
>
--
- Dr.-Ing. Christoph Cullmann -
AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com
Science Park 1 Tel: +49-681-38360-22
66123 Saarbrücken Fax: +49-681-38360-20
GERMANYWWW: http://www.AbsInt.com
Geschäftsführung: Dr.-Ing. Christian Ferdinand
Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Some more projects in need of respecting KF5_INSTALL_TARGETS_DEFAULT_ARGS
On 07 Jan 2015, at 20:15 , Christoph Cullmann wrote: > will patch that ;=) Thanks for patching this so promptly! :-) ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Some more projects in need of respecting KF5_INSTALL_TARGETS_DEFAULT_ARGS
On Wednesday 07 January 2015 20:15:54 Christoph Cullmann wrote:
> Hi,
>
> I see why KDE_INSTALL_TARGETS_DEFAULT_ARGS and INSTALL_TARGETS_DEFAULT_ARGS
> fail on Mac, typo:
>
> # on the Mac support an extra install directory for application bundles
> if(APPLE)
> set(KDE_INSTALL_TARGETS_DEFAULT_ARGS ${INSTALL_TARGETS_DEFAULT_ARGS}
> BUNDLE DESTINATION
> "${BUNDLE_INSTALL_DIR}" ) set(KF5_INSTALL_TARGETS_DEFAULT_ARGS
> ${KF5_INSTALL_TARGETS_DEFAULT_ARGS} BUNDLE DESTINATION
> "${BUNDLE_INSTALL_DIR}" ) endif(APPLE)
>
> should be
>
> # on the Mac support an extra install directory for application bundles
> if(APPLE)
> set(KDE_INSTALL_TARGETS_DEFAULT_ARGS
> ${KDE_INSTALL_TARGETS_DEFAULT_ARGS} BUNDLE DESTINATION
> "${BUNDLE_INSTALL_DIR}" ) set(KF5_INSTALL_TARGETS_DEFAULT_ARGS
> ${KF5_INSTALL_TARGETS_DEFAULT_ARGS} BUNDLE DESTINATION
> "${BUNDLE_INSTALL_DIR}" ) endif(APPLE)
Oops. Well spotted! That wouldn't be caught by the unit tests, either, which
just check the variable is set.
Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
