Re: libkomparediff2

2014-04-27 Thread Aleix Pol
On Sat, Apr 26, 2014 at 6:07 AM, Jeremy Whiting jpwhit...@kde.org wrote:

 Hello,

 I've prepared a port of libkomparediff2 to KDE Frameworks and Qt 5.2
 on the frameworks branch of it's git repo. If someone would take a
 look and check if I did anything wrong that would be great.  It builds
 here and the tests all pass, but a second (or more) set of eyes is
 always welcome.

 I guess another step to take with it would be to port it away from
 KDELibs4Support and KIO::NetAccess ?

 Any comments welcome, thanks,
 Jeremy
 ___
 Kde-frameworks-devel mailing list
 Kde-frameworks-devel@kde.org
 https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Hi Jeremy!
I just built it, it's indeed looking good.

I just committed a couple of changes because it was not setting the
library's name properly, but it's a small detail.

Cheers!
Aleix
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


libkomparediff2

2014-04-25 Thread Jeremy Whiting
Hello,

I've prepared a port of libkomparediff2 to KDE Frameworks and Qt 5.2
on the frameworks branch of it's git repo. If someone would take a
look and check if I did anything wrong that would be great.  It builds
here and the tests all pass, but a second (or more) set of eyes is
always welcome.

I guess another step to take with it would be to port it away from
KDELibs4Support and KIO::NetAccess ?

Any comments welcome, thanks,
Jeremy
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel