[Bug 235921] Mk/Uses/qt-dist.mk: fix build with GCC-based architectures
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235921
--- Comment #9 from commit-h...@freebsd.org ---
A commit references this bug:
Author: tcberner
Date: Sat May 25 20:53:13 UTC 2019
New revision: 502634
URL: https://svnweb.freebsd.org/changeset/ports/502634
Log:
MFH: r499101 r499116 r502628
Fix build when using GCC. Needed by GCC architectures.
Tested for no breakage on amd64 with Clang.
PR: 235921
Reviewed by: tcberner
Approved by: tcberner (mentor)
devel/qt5: Follow-up to r499101
- Move the GCC related path fix into freebsd-g++/qmake.conf
Otherwise the inclusion of the GCC path would break clang
based systems when gcc-${GCC_DEFAULT} was installed.
- This might break GCC architectures again, and if so, that
will be fixed in a follow up commit.
PR: 235921
qt5: fix build on gcc architectures
- the sed call was only replacing one of the %%LOCALBASE%% by ${LOCALBASE},
due to the missing 'g' flag to the sed call.
- with this change the gcc architectures should be able to build Qt5 again.
PR: 237745
Submitted by: Mark Millard , jwb
Reported by: pkubaj
Approved by: ports-secteam (joneum via irc)
Changes:
_U branches/2019Q2/
branches/2019Q2/Mk/Uses/qt-dist.mk
branches/2019Q2/devel/qt5/files/extrapatch-mkspecs_freebsd-g++_qmake.conf
branches/2019Q2/devel/qt5-qmake/Makefile
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 235921] Mk/Uses/qt-dist.mk: fix build with GCC-based architectures
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235921
--- Comment #8 from commit-h...@freebsd.org ---
A commit references this bug:
Author: tcberner
Date: Tue Apr 16 19:37:12 UTC 2019
New revision: 499116
URL: https://svnweb.freebsd.org/changeset/ports/499116
Log:
devel/qt5: Follow-up to r499101
- Move the GCC related path fix into freebsd-g++/qmake.conf
Otherwise the inclusion of the GCC path would break clang
based systems when gcc-${GCC_DEFAULT} was installed.
- This might break GCC architectures again, and if so, that
will be fixed in a follow up commit.
PR: 235921
Changes:
head/Mk/Uses/qt-dist.mk
head/devel/qt5/files/extrapatch-mkspecs_common_bsd_bsd.conf
head/devel/qt5/files/extrapatch-mkspecs_freebsd-g++_qmake.conf
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 235921] Mk/Uses/qt-dist.mk: fix build with GCC-based architectures
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235921 Piotr Kubaj changed: What|Removed |Added Resolution|--- |FIXED Status|In Progress |Closed --- Comment #7 from Piotr Kubaj --- Fixed. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 235921] Mk/Uses/qt-dist.mk: fix build with GCC-based architectures
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235921 --- Comment #6 from commit-h...@freebsd.org --- A commit references this bug: Author: pkubaj Date: Tue Apr 16 17:31:19 UTC 2019 New revision: 499101 URL: https://svnweb.freebsd.org/changeset/ports/499101 Log: Fix build when using GCC. Needed by GCC architectures. Tested for no breakage on amd64 with Clang. PR: 235921 Reviewed by: tcberner Approved by: tcberner (mentor) Changes: head/Mk/Uses/qt-dist.mk head/devel/qt5/files/extrapatch-mkspecs_common_bsd_bsd.conf -- You are receiving this mail because: You are the assignee for the bug.
[Bug 235921] Mk/Uses/qt-dist.mk: fix build with GCC-based architectures
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235921 Piotr Kubaj changed: What|Removed |Added CC||pku...@freebsd.org --- Comment #5 from Piotr Kubaj --- (In reply to Raphael Kubo da Costa from comment #4) "Can you explain why this is necessary? /usr/lib, /lib and /usr/include should all be part of the standard search paths." Apparently that is true when you build using Clang, but not when using GCC. "Wouldn't that cause those lines to be included even one's not using GCC? Plus, aren't those added automatically by GCC itself?" I tried building QT with this patch on amd64 with Clang, it works. GCC from ports doesn't add those arguments automatically. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 235921] Mk/Uses/qt-dist.mk: fix build with GCC-based architectures
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235921 Piotr Kubaj changed: What|Removed |Added Flags||merge-quarterly? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 235921] Mk/Uses/qt-dist.mk: fix build with GCC-based architectures
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235921 Tobias C. Berner changed: What|Removed |Added Flags|maintainer-feedback?(kde@Fr |maintainer-feedback+ |eeBSD.org) | -- You are receiving this mail because: You are the assignee for the bug.
[Bug 235921] Mk/Uses/qt-dist.mk: fix build with GCC-based architectures
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235921
--- Comment #4 from Raphael Kubo da Costa ---
> - ${ECHO_CMD} 'QMAKE_DEFAULT_LIBDIRS = ${LOCALBASE}/lib' >>
> ${CONFIGURE_WRKSRC}/.qmake.cache
> - ${ECHO_CMD} 'QMAKE_DEFAULT_INCDIRS = ${LOCALBASE}/include' >>
> ${CONFIGURE_WRKSRC}/.qmake.cache
> + ${ECHO_CMD} 'QMAKE_DEFAULT_LIBDIRS += ${LOCALBASE}/lib /usr/lib /lib'
> >> ${CONFIGURE_WRKSRC}/.qmake.cache
> + ${ECHO_CMD} 'QMAKE_DEFAULT_INCDIRS += ${LOCALBASE}/include
> /usr/include' >> ${CONFIGURE_WRKSRC}/.qmake.cache
Can you explain why this is necessary? /usr/lib, /lib and /usr/include should
all be part of the standard search paths.
> ++EXTRA_INCLUDEPATH += %%LOCALBASE%%/lib/gcc%%GCC_DEFAULT%%/include
> %%LOCALBASE%%/lib/gcc%%GCC_DEFAULT%%/include/c++
Wouldn't that cause those lines to be included even one's not using GCC? Plus,
aren't those added automatically by GCC itself?
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 235921] Mk/Uses/qt-dist.mk: fix build with GCC-based architectures
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235921 Tobias C. Berner changed: What|Removed |Added CC||tcber...@freebsd.org Status|New |In Progress --- Comment #3 from Tobias C. Berner --- Sorry forcthe timeout. I'll look at it this weekend. Mfg Tobias -- You are receiving this mail because: You are the assignee for the bug.
[Bug 235921] Mk/Uses/qt-dist.mk: fix build with GCC-based architectures
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235921 Piotr Kubaj changed: What|Removed |Added Attachment #202578|0 |1 is obsolete|| --- Comment #2 from Piotr Kubaj --- Created attachment 202806 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=202806=edit v3 Add the part with devel/qt5/files/extrapatch-mkspecs_common_bsd_bsd.conf, removed earlier by mistake. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 235921] Mk/Uses/qt-dist.mk: fix build with GCC-based architectures
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235921 Piotr Kubaj changed: What|Removed |Added Attachment #202236|0 |1 is obsolete|| --- Comment #1 from Piotr Kubaj --- Created attachment 202578 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=202578=edit v2 Remove the commented out lines used for debugging. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 235921] Mk/Uses/qt-dist.mk: fix build with GCC-based architectures
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235921 Mark Linimon changed: What|Removed |Added See Also||https://bugs.freebsd.org/bu ||gzilla/show_bug.cgi?id=2362 ||41 -- You are receiving this mail because: You are the assignee for the bug.
maintainer-feedback requested: [Bug 235921] Mk/Uses/qt-dist.mk: fix build with GCC-based architectures
Bugzilla Automation has asked k...@freebsd.org for maintainer-feedback: Bug 235921: Mk/Uses/qt-dist.mk: fix build with GCC-based architectures https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235921 --- Description --- Qt 5.12.1 made building with GCC on FreeBSD fail. Fix this by adding relevant system directories to QMAKE_DEFAULT_INCDIRS and QMAKE_DEFAULT_LIBDIRS since they are not added automatically when building with GCC (only with Clang). Also add %%LOCALBASE%%/lib/gcc%%GCC_DEFAULT%%/include and %%LOCALBASE%%/lib/gcc%%GCC_DEFAULT%%/include/c++ to EXTRA_INCLUDEPATH so that headers in those directories are detected during configuring. Tested by Poudriere build of devel/qt5 on powerpc64 and amd64. Hardware sponsored by IntegriCloud.
[Bug 235921] Mk/Uses/qt-dist.mk: fix build with GCC-based architectures
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235921 Piotr Kubaj changed: What|Removed |Added Component|Individual Port(s) |Package Infrastructure -- You are receiving this mail because: You are the assignee for the bug.
[Bug 235921] Mk/Uses/qt-dist.mk: fix build with GCC-based architectures
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235921 Piotr Kubaj changed: What|Removed |Added Component|Package Infrastructure |Ports Framework CC||ports-b...@freebsd.org -- You are receiving this mail because: You are the assignee for the bug.
[Bug 235921] Mk/Uses/qt-dist.mk: fix build with GCC-based architectures
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235921 Bug ID: 235921 Summary: Mk/Uses/qt-dist.mk: fix build with GCC-based architectures Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: k...@freebsd.org Reporter: pku...@anongoth.pl Flags: maintainer-feedback?(k...@freebsd.org) Assignee: k...@freebsd.org Created attachment 202236 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=202236=edit patch Qt 5.12.1 made building with GCC on FreeBSD fail. Fix this by adding relevant system directories to QMAKE_DEFAULT_INCDIRS and QMAKE_DEFAULT_LIBDIRS since they are not added automatically when building with GCC (only with Clang). Also add %%LOCALBASE%%/lib/gcc%%GCC_DEFAULT%%/include and %%LOCALBASE%%/lib/gcc%%GCC_DEFAULT%%/include/c++ to EXTRA_INCLUDEPATH so that headers in those directories are detected during configuring. Tested by Poudriere build of devel/qt5 on powerpc64 and amd64. Hardware sponsored by IntegriCloud. -- You are receiving this mail because: You are the assignee for the bug.
