[Bug 279139] security/kleopatra: Fix build against libc++ 18
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279139 Olivier Certner changed: What|Removed |Added Resolution|--- |FIXED Status|New |Closed Assignee|k...@freebsd.org |o...@freebsd.org --- Comment #3 from Olivier Certner --- (In reply to Max Brazhnikov from comment #1) Just done. Thanks. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 279139] security/kleopatra: Fix build against libc++ 18
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279139 --- Comment #2 from commit-h...@freebsd.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=97eecf838ae8e88c56c7f97080adce0dc593a491 commit 97eecf838ae8e88c56c7f97080adce0dc593a491 Author: Olivier Certner AuthorDate: 2024-05-22 19:08:41 + Commit: Olivier Certner CommitDate: 2024-05-22 19:51:01 + security/kleopatra: Fix build against libc++18 libc++ 18 by default removes unique() in 'std::shared_ptr' (in ), as a follow-up to this resolution: https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2016/p0521r0.html An alternative would be to get it back by defining _LIBCPP_ENABLE_CXX20_REMOVED_SHARED_PTR_UNIQUE before including the libc++ headers, but trying to fight the standard may not be a wise move going forward, especially if/as other C++ libraries follow suit. Upstream MR (approved) is at https://invent.kde.org/pim/kleopatra/-/merge_requests/205. PR: 279139 Approved by:kde (maintainer) Approved by:jrm (ports) Approved by:markj (mentor) .../kleopatra/files/patch-src_crypto_recipient.cpp (new) | 14 ++ security/kleopatra/files/patch-src_crypto_sender.cpp (new) | 14 ++ 2 files changed, 28 insertions(+) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 279139] security/kleopatra: Fix build against libc++ 18
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279139 Max Brazhnikov changed: What|Removed |Added CC||m...@freebsd.org Flags|maintainer-feedback?(kde@Fr |maintainer-feedback+ |eeBSD.org) | --- Comment #1 from Max Brazhnikov --- Olivier, could you please add and commit a patch submitted upstream instead of amending the port Makefile? Thanks! -- You are receiving this mail because: You are the assignee for the bug.
[Bug 279139] security/kleopatra: Fix build against libc++ 18
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279139 Olivier Certner changed: What|Removed |Added Keywords||patch -- You are receiving this mail because: You are the assignee for the bug.
maintainer-feedback requested: [Bug 279139] security/kleopatra: Fix build against libc++ 18
Bugzilla Automation has asked freebsd-kde (group) for maintainer-feedback: Bug 279139: security/kleopatra: Fix build against libc++ 18 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279139 --- Description --- Kleopatra uses unique() on std::shared_ptr, which is deprecated and is by default not exposed by libc++ 18. Fortunately, the latter defines a new macro, _LIBCPP_ENABLE_CXX20_REMOVED_SHARED_PTR_UNIQUE, allowing to recover that member function. Source code modification submitted upstream at: https://invent.kde.org/pim/kleopatra/-/merge_requests/205 Thanks and regards.
[Bug 279139] security/kleopatra: Fix build against libc++ 18
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279139 Bug ID: 279139 Summary: security/kleopatra: Fix build against libc++ 18 Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: k...@freebsd.org Reporter: o...@freebsd.org Assignee: k...@freebsd.org Flags: maintainer-feedback?(k...@freebsd.org) Created attachment 250798 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=250798&action=edit Patch fixing the build against libc++ 18 Kleopatra uses unique() on std::shared_ptr, which is deprecated and is by default not exposed by libc++ 18. Fortunately, the latter defines a new macro, _LIBCPP_ENABLE_CXX20_REMOVED_SHARED_PTR_UNIQUE, allowing to recover that member function. Source code modification submitted upstream at: https://invent.kde.org/pim/kleopatra/-/merge_requests/205 Thanks and regards. -- You are receiving this mail because: You are the assignee for the bug.
