[kde-freebsd] [Bug 207906] [exp-run] Change header installation location for kdelibs4-based ports

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207906

Bug ID: 207906
   Summary: [exp-run] Change header installation location for
kdelibs4-based ports
   Product: Ports & Packages
   Version: Latest
  Hardware: Any
OS: Any
Status: New
  Severity: Affects Only Me
  Priority: ---
 Component: Individual Port(s)
  Assignee: port...@freebsd.org
  Reporter: rak...@freebsd.org
CC: k...@freebsd.org
 Flags: exp-run?

Created attachment 168013
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=168013&action=edit
Patch v1

kde@ would like to request an exp-run for

(also attached).

We want to install x11/kdelibs4's headers into include/kde4 instead of include,
and that consequently causes several other ports to have their installation
paths changed too. The idea behind this is to reduce path conflicts between
KDE4 ports and the upcoming KDE Frameworks 5 ports that will be installed into
include/KF5 (if we continue installing the KDE4 headers into include,
-I/usr/local/include can cause the wrong headers to be picked up).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
kde-freebsd mailing list
kde-freebsd@kde.org
https://mail.kde.org/mailman/listinfo/kde-freebsd
See also http://freebsd.kde.org/ for latest information

[kde-freebsd] [Bug 207906] [exp-run] Change header installation location for kdelibs4-based ports

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207906

Raphael Kubo da Costa  changed:

   What|Removed |Added

 Attachment #168013|0   |1
is obsolete||

--- Comment #1 from Raphael Kubo da Costa  ---
Created attachment 168039
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=168039&action=edit
Patch v2

Patch v2 is up:


-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
kde-freebsd mailing list
kde-freebsd@kde.org
https://mail.kde.org/mailman/listinfo/kde-freebsd
See also http://freebsd.kde.org/ for latest information

[kde-freebsd] [Bug 207906] [exp-run] Change header installation location for kdelibs4-based ports

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207906

Antoine Brodin  changed:

   What|Removed |Added

 CC||port...@freebsd.org
 Status|New |Open
   Assignee|port...@freebsd.org |anto...@freebsd.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
kde-freebsd mailing list
kde-freebsd@kde.org
https://mail.kde.org/mailman/listinfo/kde-freebsd
See also http://freebsd.kde.org/ for latest information

[kde-freebsd] [Bug 207906] [exp-run] Change header installation location for kdelibs4-based ports

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207906

--- Comment #2 from Antoine Brodin  ---
On 10.3 i386 there is 1 new failure:

http://package18.nyi.freebsd.org/data/103i386-default-PR207906/2016-03-13_07h09m13s/logs/errors/subversion-kwallet-1.9.3.log

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
kde-freebsd mailing list
kde-freebsd@kde.org
https://mail.kde.org/mailman/listinfo/kde-freebsd
See also http://freebsd.kde.org/ for latest information

[kde-freebsd] [Bug 207906] [exp-run] Change header installation location for kdelibs4-based ports

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207906

Raphael Kubo da Costa  changed:

   What|Removed |Added

 Attachment #168039|0   |1
is obsolete||

--- Comment #3 from Raphael Kubo da Costa  ---
Created attachment 168146
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=168146&action=edit
Patch v3

Thanks, it looks like subversion was being stupid with the way it uses
kde4-config to determine where kdelibs's headers are.

I've sent a patch upstream that hasn't made it to svn's development mailing
list yet that does the right thing and am attaching a patch v3 (also available
at )
for completeness, there's no need to run another exp-run.

I'll wait for the current 9.3 exp-run to finish before landing, but I don't
expect any surprises.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
kde-freebsd mailing list
kde-freebsd@kde.org
https://mail.kde.org/mailman/listinfo/kde-freebsd
See also http://freebsd.kde.org/ for latest information

[kde-freebsd] [Bug 207906] [exp-run] Change header installation location for kdelibs4-based ports

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207906

--- Comment #4 from Antoine Brodin  ---
On 9.3 amd64 there is this failure too:

http://package18.nyi.freebsd.org/data/93amd64-default-PR207906/2016-03-14_08h30m26s/logs/errors/skrooge-1.12.5.log

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
kde-freebsd mailing list
kde-freebsd@kde.org
https://mail.kde.org/mailman/listinfo/kde-freebsd
See also http://freebsd.kde.org/ for latest information

[kde-freebsd] [Bug 207906] [exp-run] Change header installation location for kdelibs4-based ports

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207906

Antoine Brodin  changed:

   What|Removed |Added

   Assignee|anto...@freebsd.org |rak...@freebsd.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
kde-freebsd mailing list
kde-freebsd@kde.org
https://mail.kde.org/mailman/listinfo/kde-freebsd
See also http://freebsd.kde.org/ for latest information

[kde-freebsd] [Bug 207906] [exp-run] Change header installation location for kdelibs4-based ports

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207906

Raphael Kubo da Costa  changed:

   What|Removed |Added

  Flags|exp-run?|

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
kde-freebsd mailing list
kde-freebsd@kde.org
https://mail.kde.org/mailman/listinfo/kde-freebsd
See also http://freebsd.kde.org/ for latest information

[kde-freebsd] [Bug 207906] [exp-run] Change header installation location for kdelibs4-based ports

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207906

Raphael Kubo da Costa  changed:

   What|Removed |Added

 Attachment #168146|0   |1
is obsolete||

--- Comment #5 from Raphael Kubo da Costa  ---
Created attachment 168234
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=168234&action=edit
Patch v4

For completeness, here's patch v4 (also available here:
)
that fixes finance/skrooge on 9.3.

I'll finally commit this to the tree. Fasten your seatbelts!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
kde-freebsd mailing list
kde-freebsd@kde.org
https://mail.kde.org/mailman/listinfo/kde-freebsd
See also http://freebsd.kde.org/ for latest information

[kde-freebsd] [Bug 207906] [exp-run] Change header installation location for kdelibs4-based ports

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207906

--- Comment #7 from commit-h...@freebsd.org ---
A commit references this bug:

Author: rakuco
Date: Tue Mar 15 12:35:58 UTC 2016
New revision: 411156
URL: https://svnweb.freebsd.org/changeset/ports/411156

Log:
  Change header installation location for kdelibs4-based ports.

  Install x11/kdelibs4's headers into include/kde4 instead of include (which
  consequently causes several other ports to have their installation paths
  changed too).

  The idea behind this is to reduce path conflicts between KDE4 ports and the
  upcoming KDE Frameworks 5 ports that will be installed into include/KF5. If
  we continue installing the KDE4 headers into include/, we can end up in a
  situation like this:

  c++ [...] -I/usr/local/include -I/usr/local/include/KF5 file.cpp

  If the KDE4 and KF5 versions of a port have the same headers, the KDE4 port
  will unintentionally be picked up first and the build will fail.

  Most of this huge patch is just PORTREVISION bumps, pkg-plist changes and a
  few patches to FooConfig.cmake files to make them look into the kde4/
  subdirectory in include/.

  Changes which don't fit into the above are:
  - deskutils/kdepimlibs4: Import an upstream patch to remove some double
semicolons that cause base GCC to fail. They have always been present, but
since the faulty header was referenced via -isystem /usr/local/include
this never caused any problems.
  - devel/subversion, devel/subversion18: Update patch-configure. The current
kwallet changes there date back to 2011 (r272490), at a time when the
build could fail when both KDE3 and KDE4 were installed. Replace those
bits with a change I've submitted upstream to use the kde4-config program
to determine where KDE4's headers and libraries are installed instead of
assuming the headers are always in include/.

  Once again, huge thanks to Tobias Berner  for being the
  first one to notice this problem when working on the KDE Frameworks 5 ports,
  coming up with the solution and bugging me until I had time to work on this
  and ask for the exp-run :-)

  PR:   207906 (exp-run)

Changes:
  head/astro/libkgeomap/Makefile
  head/astro/libkgeomap/pkg-plist
  head/audio/kio-audiocd/Makefile
  head/audio/kio-audiocd/pkg-plist
  head/audio/libkcddb/Makefile
  head/audio/libkcddb/pkg-plist
  head/audio/libkcompactdisc/Makefile
  head/audio/libkcompactdisc/pkg-plist
  head/databases/kbibtex/Makefile
  head/databases/kbibtex/pkg-plist
  head/deskutils/kdeconnect/Makefile
  head/deskutils/kdeconnect/pkg-plist
  head/deskutils/kdepim4/Makefile
  head/deskutils/kdepim4/pkg-plist
  head/deskutils/kdepimlibs4/Makefile
  head/deskutils/kdepimlibs4/files/patch-git_8d49c611
  head/deskutils/kdepimlibs4/pkg-plist
  head/deskutils/kdeplasma-addons/Makefile
  head/deskutils/kdeplasma-addons/pkg-plist
  head/devel/kde-dev-utils/Makefile
  head/devel/kde-dev-utils/pkg-plist
  head/devel/kdevelop-kde4/Makefile
  head/devel/kdevelop-kde4/pkg-plist
  head/devel/kdevplatform/Makefile
  head/devel/kdevplatform/pkg-plist
  head/devel/libkgapi/Makefile
  head/devel/libkgapi/pkg-plist
  head/devel/okteta/Makefile
  head/devel/okteta/pkg-plist
  head/devel/subversion/files/patch-configure
  head/devel/subversion18/files/patch-configure
  head/editors/calligra/Makefile
  head/editors/calligra/pkg-plist
  head/editors/kate/Makefile
  head/editors/kate/pkg-plist
  head/finance/kmymoney-kde4/Makefile
  head/finance/kmymoney-kde4/pkg-plist
  head/finance/libalkimia/Makefile
  head/finance/libalkimia/pkg-plist
  head/games/libkdegames/Makefile
  head/games/libkdegames/pkg-plist
  head/games/libkmahjongg/Makefile
  head/games/libkmahjongg/pkg-plist
  head/games/palapeli/Makefile
  head/games/palapeli/pkg-plist
  head/graphics/kdegraphics4-mobipocket/Makefile
  head/graphics/kdegraphics4-mobipocket/files/
  head/graphics/kdegraphics4-mobipocket/files/patch-QMobipocketConfig.cmake
  head/graphics/kdegraphics4-mobipocket/pkg-plist
  head/graphics/libkdcraw-kde4/Makefile
  head/graphics/libkdcraw-kde4/pkg-plist
  head/graphics/libkexiv2-kde4/Makefile
  head/graphics/libkexiv2-kde4/pkg-plist
  head/graphics/libkface/Makefile
  head/graphics/libkface/pkg-plist
  head/graphics/libkipi-kde4/Makefile
  head/graphics/libkipi-kde4/pkg-plist
  head/graphics/libksane/Makefile
  head/graphics/libksane/files/
  head/graphics/libksane/files/patch-KSaneConfig.cmake.in
  head/graphics/libksane/pkg-plist
  head/graphics/libkscreen/Makefile
  head/graphics/libkscreen/pkg-plist
  head/graphics/okular/Makefile
  head/graphics/okular/files/patch-OkularConfig.cmake
  head/graphics/okular/pkg-plist
  head/japanese/kiten/Makefile
  head/japanese/kiten/pkg-plist
  head/math/analitza/Makefile
  head/math/analitza/pkg-plist
  head/math/cantor/Makefile
  head/math/cantor/pkg-plist
  head/math/rocs/Makefile
  head/math/rocs/pkg-plist
  head/misc/libkdeedu/Makefile
  head/misc/libkdeedu/pkg-plist
  head/net/kio-up

[kde-freebsd] [Bug 207906] [exp-run] Change header installation location for kdelibs4-based ports

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207906

Raphael Kubo da Costa  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Open|Closed

--- Comment #6 from Raphael Kubo da Costa  ---
For some reason the commit did not add a comment here.

This was landed in ports r411156.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
kde-freebsd mailing list
kde-freebsd@kde.org
https://mail.kde.org/mailman/listinfo/kde-freebsd
See also http://freebsd.kde.org/ for latest information