[kde-freebsd] Re: icon for optical disk
On Thursday 10 March 2011 14:58:36 Alberto Villa wrote: i think we should keep the patch running for some days before submitting it to gnome@ i decided to fix the real bug in solid (which also applied to devices descriptions) rather than adding a workaround to hal: committed to area51 -- Alberto Villa, FreeBSD committer avi...@freebsd.org http://people.FreeBSD.org/~avilla She missed an invaluable opportunity to give him a look that you could have poured on a waffle. signature.asc Description: This is a digitally signed message part. ___ kde-freebsd mailing list kde-freebsd@kde.org https://mail.kde.org/mailman/listinfo/kde-freebsd See also http://freebsd.kde.org/ for latest information
[kde-freebsd] Re: icon for optical disk
On Thursday 10 March 2011 08:07:41 Andriy Gapon wrote: The function expects that for optical disks info.category would be volume and info.capabilities would contain volume.disc. But our hal gives volume.disc value in the info.category property as I can see with lshal. And thus the match fails and an empty icon name is returned from the function. I've just double-checked with OpenSUSE installation that I have and their hal supplies the values that the solid code expects. i'm not sure if that is supposed to be correct. this is from doc/spec/hal- spec-properties.xml: entry literalinfo.category/literal (string) /entry entryexample: storage.cdrom/entry entryNo/entry entryThe prominent capability describing what the device is/entry googling for info.category examples, though, reveals only simple words for it on linux (volume, storage...). a linuxism, maybe? i'll try to get our hal behave as in linux, and we'll see -- Alberto Villa, FreeBSD committer avi...@freebsd.org http://people.FreeBSD.org/~avilla At work, the authority of a person is inversely proportional to the number of pens that person is carrying. signature.asc Description: This is a digitally signed message part. ___ kde-freebsd mailing list kde-freebsd@kde.org https://mail.kde.org/mailman/listinfo/kde-freebsd See also http://freebsd.kde.org/ for latest information
[kde-freebsd] Re: icon for optical disk
On Thursday 10 March 2011 12:32:02 Alberto Villa wrote: googling for info.category examples, though, reveals only simple words for it on linux (volume, storage...). a linuxism, maybe? yes, both linux and solaris backends don't set volume.disc and storage.cdrom, then it might be safe to do the same on freebsd (which is the only system where that happens). apparently freebsd does the right thing, but linux developers all over the world have sticked to the linux convention breaking software here and there. i don't think that this kde issue is the only one in the world, so, who knows, we might end up fixing other small issues anyway, apart from net.* stuff (which works like this on linux too), no other categories contain more than one word i'll try to get our hal behave as in linux, and we'll see cd /usr/ports/sysutils/hal/files patch $attached_patch then, reinstall hal and restart its service -- Alberto Villa, FreeBSD committer avi...@freebsd.org http://people.FreeBSD.org/~avilla You will attract cultured and artistic people to your home. signature.asc Description: This is a digitally signed message part. ___ kde-freebsd mailing list kde-freebsd@kde.org https://mail.kde.org/mailman/listinfo/kde-freebsd See also http://freebsd.kde.org/ for latest information
[kde-freebsd] Re: icon for optical disk
on 10/03/2011 13:32 Alberto Villa said the following: On Thursday 10 March 2011 08:07:41 Andriy Gapon wrote: The function expects that for optical disks info.category would be volume and info.capabilities would contain volume.disc. But our hal gives volume.disc value in the info.category property as I can see with lshal. And thus the match fails and an empty icon name is returned from the function. I've just double-checked with OpenSUSE installation that I have and their hal supplies the values that the solid code expects. i'm not sure if that is supposed to be correct. this is from doc/spec/hal- spec-properties.xml: entry literalinfo.category/literal (string) /entry entryexample: storage.cdrom/entry entryNo/entry entryThe prominent capability describing what the device is/entry googling for info.category examples, though, reveals only simple words for it on linux (volume, storage...). a linuxism, maybe? i'll try to get our hal behave as in linux, and we'll see Well, an example is not a definitive specification. And I thought that the hal was one big linuxism :-) Anyway, thanks a lot for the patch, I will test it. -- Andriy Gapon ___ kde-freebsd mailing list kde-freebsd@kde.org https://mail.kde.org/mailman/listinfo/kde-freebsd See also http://freebsd.kde.org/ for latest information
[kde-freebsd] Re: icon for optical disk
on 10/03/2011 14:02 Alberto Villa said the following: On Thursday 10 March 2011 13:01:13 Alberto Villa wrote: cd /usr/ports/sysutils/hal/files patch $attached_patch ehm... patch attached Thanks a lot! The patch works as expected and optical disc icon(s) do show up in kde now. -- Andriy Gapon ___ kde-freebsd mailing list kde-freebsd@kde.org https://mail.kde.org/mailman/listinfo/kde-freebsd See also http://freebsd.kde.org/ for latest information
[kde-freebsd] Re: icon for optical disk
On Thursday 10 March 2011 14:45:52 Andriy Gapon wrote: Thanks a lot! The patch works as expected and optical disc icon(s) do show up in kde now. yes! i think we should keep the patch running for some days before submitting it to gnome@ -- Alberto Villa, FreeBSD committer avi...@freebsd.org http://people.FreeBSD.org/~avilla It is not enough to have a good mind. The main thing is to use it well. -- Rene Descartes signature.asc Description: This is a digitally signed message part. ___ kde-freebsd mailing list kde-freebsd@kde.org https://mail.kde.org/mailman/listinfo/kde-freebsd See also http://freebsd.kde.org/ for latest information
[kde-freebsd] Re: icon for optical disk
on 26/02/2011 18:33 Andriy Gapon said the following: Very minor issue really. Whatever kind of optical disk I insert KDE 4 just shows its label, but never a nice-looking icon. Examples with a CD-RW disk: http://people.freebsd.org/~avg/cd-noicon.png http://people.freebsd.org/~avg/cd-noicon1.png TRANT r is a label of an ISO filesystem on the disk. Am I alone with this issue? I guess that I wasn't but everyone is too busy (embarassed?) to discuss this issue :) So it seems that the problem is between the solid library and our hal. In kdelibs4, in the file solid/solid/backends/hal/haldevice.cpp, there is the function 'QString HalDevice::icon() const' that returns an icon name based on information that hal provides about a device. The function expects that for optical disks info.category would be volume and info.capabilities would contain volume.disc. But our hal gives volume.disc value in the info.category property as I can see with lshal. And thus the match fails and an empty icon name is returned from the function. I've just double-checked with OpenSUSE installation that I have and their hal supplies the values that the solid code expects. BTW, the similar mismatch exists also for an optical drive itself. With linux hal info.category is storage and info.capabilities contains storage.cdrom, but with our hal info.category is storage.cdrom. Not sure if the upcoming KDE 4.6.1 will be affected (i.e. if it still uses hal backend). But I think that our hal is still worth fixing. Thanks! -- Andriy Gapon ___ kde-freebsd mailing list kde-freebsd@kde.org https://mail.kde.org/mailman/listinfo/kde-freebsd See also http://freebsd.kde.org/ for latest information
[kde-freebsd] Re: icon for optical disk
On Thu, 10 Mar 2011 09:07:41 +0200, Andriy Gapon wrote: on 26/02/2011 18:33 Andriy Gapon said the following: Very minor issue really. Whatever kind of optical disk I insert KDE 4 just shows its label, but never a nice-looking icon. Examples with a CD-RW disk: http://people.freebsd.org/~avg/cd-noicon.png http://people.freebsd.org/~avg/cd-noicon1.png TRANT r is a label of an ISO filesystem on the disk. Am I alone with this issue? I guess that I wasn't but everyone is too busy (embarassed?) to discuss this issue :) I can't remember when I used cd last time, so I just don't bother about this. So it seems that the problem is between the solid library and our hal. In kdelibs4, in the file solid/solid/backends/hal/haldevice.cpp, there is the function 'QString HalDevice::icon() const' that returns an icon name based on information that hal provides about a device. The function expects that for optical disks info.category would be volume and info.capabilities would contain volume.disc. But our hal gives volume.disc value in the info.category property as I can see with lshal. And thus the match fails and an empty icon name is returned from the function. I've just double-checked with OpenSUSE installation that I have and their hal supplies the values that the solid code expects. BTW, the similar mismatch exists also for an optical drive itself. With linux hal info.category is storage and info.capabilities contains storage.cdrom, but with our hal info.category is storage.cdrom. Not sure if the upcoming KDE 4.6.1 will be affected (i.e. if it still uses hal backend). But I think that our hal is still worth fixing. yes, Solid will continue to use hal backend on FreeBSD. ___ kde-freebsd mailing list kde-freebsd@kde.org https://mail.kde.org/mailman/listinfo/kde-freebsd See also http://freebsd.kde.org/ for latest information
