Re: [kde-freebsd] ports/133078: [PATCH] kmix (multimedia/kdemultimedia4) incorrectly binds to mixer devices
Synopsis: [PATCH] kmix (multimedia/kdemultimedia4) incorrectly binds to mixer devices Responsible-Changed-From-To: freebsd-ports-bugs->kde Responsible-Changed-By: edwin Responsible-Changed-When: Thu Mar 26 00:20:15 UTC 2009 Responsible-Changed-Why: Over to maintainer (via the GNATS Auto Assign Tool) http://www.freebsd.org/cgi/query-pr.cgi?pr=133078 ___ kde-freebsd mailing list kde-freebsd@kde.org https://mail.kde.org/mailman/listinfo/kde-freebsd See also http://freebsd.kde.org/ for latest information
Re: [kde-freebsd] ports/133078: [PATCH] kmix (multimedia/kdemultimedia4) incorrectly binds to mixer devices
The following reply was made to PR ports/133078; it has been noted by GNATS. From: Max Brazhnikov To: bug-follo...@freebsd.org, a...@raisa.eu.org Cc: Subject: Re: ports/133078: [PATCH] kmix (multimedia/kdemultimedia4) incorrectly binds to mixer devices Date: Thu, 2 Apr 2009 12:31:41 +0300 Hi Emil, Looks it's not FreeBSD specific, shouldn't this go directly upstream? Max ___ kde-freebsd mailing list kde-freebsd@kde.org https://mail.kde.org/mailman/listinfo/kde-freebsd See also http://freebsd.kde.org/ for latest information
Re: [kde-freebsd] ports/133078: [PATCH] kmix (multimedia/kdemultimedia4) incorrectly binds to mixer devices
The following reply was made to PR ports/133078; it has been noted by GNATS.
From: "Emil Smolenski"
To: "Max Brazhnikov" , bug-follo...@freebsd.org
Cc:
Subject: Re: ports/133078: [PATCH] kmix (multimedia/kdemultimedia4)
incorrectly binds to mixer devices
Date: Fri, 03 Apr 2009 03:15:39 +0200
On Thu, 02 Apr 2009 11:31:41 +0200, Max Brazhnikov wrote:
Hi,
> Looks it's not FreeBSD specific, shouldn't this go directly upstream?
Maybe.
I'm sure it is OSS specific. I know nothing about mixers in other
OSS-based systems. Perhaps in other systems /dev/mixer is always
/dev/mixer0. If somewhere there is /dev/mixer _instead_ of /dev/mixer0
(there is no /dev/mixer0 device), this patch would broke these systems.
If such systems don't exist, I don't see any reason to bind to /dev/mixer
instead of /dev/mixer0 directly[1] (and it should go upstream).
[1]:
case 0:
return QString("/dev/mixer");
break;
default:
QString devname("/dev/mixer");
devname += ('0'+devnum);
return devname;
--
am
___
kde-freebsd mailing list
kde-freebsd@kde.org
https://mail.kde.org/mailman/listinfo/kde-freebsd
See also http://freebsd.kde.org/ for latest information
Re: [kde-freebsd] ports/133078: [PATCH] kmix (multimedia/kdemultimedia4) incorrectly binds to mixer devices
Synopsis: [PATCH] kmix (multimedia/kdemultimedia4) incorrectly binds to mixer devices State-Changed-From-To: open->closed State-Changed-By: miwi State-Changed-When: Sat Feb 13 16:12:40 UTC 2010 State-Changed-Why: should be fixed long time ago. http://www.freebsd.org/cgi/query-pr.cgi?pr=133078 ___ kde-freebsd mailing list kde-freebsd@kde.org https://mail.kde.org/mailman/listinfo/kde-freebsd See also http://freebsd.kde.org/ for latest information
Re: [kde-freebsd] ports/133078: [PATCH] kmix (multimedia/kdemultimedia4) incorrectly binds to mixer devices
On Sat, 13 Feb 2010 17:12:41 +0100, wrote:
> Synopsis: [PATCH] kmix (multimedia/kdemultimedia4) incorrectly binds to
> mixer devices
>
> State-Changed-From-To: open->closed
> State-Changed-By: miwi
> State-Changed-When: Sat Feb 13 16:12:40 UTC 2010
> State-Changed-Why:
> should be fixed long time ago.
No. Unfortunately it is still broken. This code from "kmix/mixer_oss.cpp"
file hasn't changed:
switch (devnum) {
case 0:
return QString("/dev/mixer");
break;
default:
QString devname("/dev/mixer");
devname += ('0'+devnum);
return devname;
% pkg_info -xI kdem
kdemultimedia-4.3.5 KDE Multimedia applications
% lsof -c kmix -a /dev/mixer /dev/mixer*
COMMAND PID USER FD TYPE DEVICE SIZE/OFF NODE NAME
kmix21289 ameel 10u VCHR 0,34 0t0 34 /dev/mixer1
kmix21289 ameel 12u VCHR 0,34 0t0 34 /dev/mixer1
^^^
Kmix still binds to the same mixer twice. There is no possibility to
control mixer0 from kmix when hw.snd.default_unit is set to 1. The switch
construction above is obviously wrong.
Also, all mixer devices have still the same name (meaningless "OSS Audio
Mixer"). My patch still applies (with small offset).
> http://www.freebsd.org/cgi/query-pr.cgi?pr=133078
--
am
___
kde-freebsd mailing list
kde-freebsd@kde.org
https://mail.kde.org/mailman/listinfo/kde-freebsd
See also http://freebsd.kde.org/ for latest information
Re: [kde-freebsd] ports/133078: [PATCH] kmix (multimedia/kdemultimedia4) incorrectly binds to mixer devices
The following reply was made to PR ports/133078; it has been noted by GNATS.
From: "Emil Smolenski"
To: m...@freebsd.org
Cc: bug-follo...@freebsd.org, k...@freebsd.org
Subject: Re: ports/133078: [PATCH] kmix (multimedia/kdemultimedia4)
incorrectly binds to mixer devices
Date: Sat, 13 Feb 2010 22:51:14 +0100
On Sat, 13 Feb 2010 17:12:41 +0100, wrote:
> Synopsis: [PATCH] kmix (multimedia/kdemultimedia4) incorrectly binds to
> mixer devices
>
> State-Changed-From-To: open->closed
> State-Changed-By: miwi
> State-Changed-When: Sat Feb 13 16:12:40 UTC 2010
> State-Changed-Why:
> should be fixed long time ago.
No. Unfortunately it is still broken. This code from "kmix/mixer_oss.cpp"
file hasn't changed:
switch (devnum) {
case 0:
return QString("/dev/mixer");
break;
default:
QString devname("/dev/mixer");
devname += ('0'+devnum);
return devname;
% pkg_info -xI kdem
kdemultimedia-4.3.5 KDE Multimedia applications
% lsof -c kmix -a /dev/mixer /dev/mixer*
COMMAND PID USER FD TYPE DEVICE SIZE/OFF NODE NAME
kmix21289 ameel 10u VCHR 0,34 0t0 34 /dev/mixer1
kmix21289 ameel 12u VCHR 0,34 0t0 34 /dev/mixer1
^^^
Kmix still binds to the same mixer twice. There is no possibility to
control mixer0 from kmix when hw.snd.default_unit is set to 1. The switch
construction above is obviously wrong.
Also, all mixer devices have still the same name (meaningless "OSS Audio
Mixer"). My patch still applies (with small offset).
> http://www.freebsd.org/cgi/query-pr.cgi?pr=133078
--
am
___
kde-freebsd mailing list
kde-freebsd@kde.org
https://mail.kde.org/mailman/listinfo/kde-freebsd
See also http://freebsd.kde.org/ for latest information
