Re: [kde-freebsd] How to remove erroneous deps from pkgng
On Monday, July 23, 2012 20:50:34 Baptiste Daroussin wrote: Here is a plan for pkg-config, I hope it will statisfy everyone. First we need to get rid of pkg-config, since 0.26 we can't boostrap it anymore because it depends on glib which depends on pkg-config. Hopefully we have a viable alternative. What I will do is : step 1/ introduce a new pkgconf port (https://github.com/nenolod/pkgconf) which is 100% compatible with pkg-config and considers any incompatibility as a bug. along with this, I will introduce a new MACRO: http://people.freebsd.org/~bapt/USE_PKGCONFIG.diff USE_PKGCONFIG= yes or USE_PKGCONFIG= build will bring pkgconf only has a build dependency USE_PKGCONFIG= run will bring pkgconf has a run dependency (some things like ruby wrapper or perl wrapper) USE_PKGCONFIG= both will bring both run and build deps. Why a MACRO, because some ports may need en environnement variable in CONFIGURE_ENV PKG_CONFIG=pkgconf do work correctly. the USE_GNOME=pkgconfig will be automatically add USE_PKGCONFIG= both Yeah sorry for step one will keep pkgconf in both dependencies. This is necessary because too much ports rely on one of their deps bringing pkgconfig, and this concerns about 4k+ ports. All the gnome one (mostly), all the xorg one (xproto bring pkgconfig) most of the gtk ones, most of things depending on libxml2 and curl, from what I have seen. step 2/ advertise the maintainers to stop using USE_GNOME= pkgconfig but rather switch to USE_PKGCONFIG, and do it actively. setp 3/ drop USE_GNOME= pkgconfig from bsd.gnome.mk when switching to USE_PKGCONFIG becare full about the ports that depend on your ports to make sure, it doesn't expect pkgconfig being brought by your port. regards, Bapt I think it might be a good idea to factor out the pkg-config hacks provided by USE_GNOME=gnomehack as well, and expand it to work with CMake (or other build systems if needed). Most ports that install .pc files must be fixed to install them in libdata instead of lib. Jason E. Hale ___ kde-freebsd mailing list kde-freebsd@kde.org https://mail.kde.org/mailman/listinfo/kde-freebsd See also http://freebsd.kde.org/ for latest information
Re: [kde-freebsd] How to remove erroneous deps from pkgng
On Mon, 23 Jul 2012 04:37:08 +0300 Kimmo Paasiala wrote: Looking at the bsd.kde4.mk it looks like there's not much logic to detect the right kind of dependency. It seems to use suffixes _build and _run to achieve the same effect as pkgconfig:build and pkgconfig:run would have. Right. It defaults to both build and run dependency if no type is specified. This is not correct. For example, USE_KDE4= automoc4 (without any suffix) will bring BUILD only dependency on devel/automoc4. The great majority ports don't need ever possibility to run depend on build tools like automoc4, but kde4.mk still provides it (the only consumer if automoc4_run can be IDE, I suppose). The way USE_KDE4 is implemented allows to minimize the use of suffixes, that's the right way in my understanding. Max ___ kde-freebsd mailing list kde-freebsd@kde.org https://mail.kde.org/mailman/listinfo/kde-freebsd See also http://freebsd.kde.org/ for latest information
Re: [kde-freebsd] How to remove erroneous deps from pkgng
On Mon, Jul 23, 2012 at 01:31:52PM +, Max Brazhnikov wrote: On Mon, 23 Jul 2012 04:37:08 +0300 Kimmo Paasiala wrote: Looking at the bsd.kde4.mk it looks like there's not much logic to detect the right kind of dependency. It seems to use suffixes _build and _run to achieve the same effect as pkgconfig:build and pkgconfig:run would have. Right. It defaults to both build and run dependency if no type is specified. This is not correct. For example, USE_KDE4= automoc4 (without any suffix) will bring BUILD only dependency on devel/automoc4. The great majority ports don't need ever possibility to run depend on build tools like automoc4, but kde4.mk still provides it (the only consumer if automoc4_run can be IDE, I suppose). The way USE_KDE4 is implemented allows to minimize the use of suffixes, that's the right way in my understanding. Max ___ freebsd-po...@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org Here is a plan for pkg-config, I hope it will statisfy everyone. First we need to get rid of pkg-config, since 0.26 we can't boostrap it anymore because it depends on glib which depends on pkg-config. Hopefully we have a viable alternative. What I will do is : step 1/ introduce a new pkgconf port (https://github.com/nenolod/pkgconf) which is 100% compatible with pkg-config and considers any incompatibility as a bug. along with this, I will introduce a new MACRO: http://people.freebsd.org/~bapt/USE_PKGCONFIG.diff USE_PKGCONFIG= yes or USE_PKGCONFIG= build will bring pkgconf only has a build dependency USE_PKGCONFIG= run will bring pkgconf has a run dependency (some things like ruby wrapper or perl wrapper) USE_PKGCONFIG= both will bring both run and build deps. Why a MACRO, because some ports may need en environnement variable in CONFIGURE_ENV PKG_CONFIG=pkgconf do work correctly. the USE_GNOME= pkgconfig will be automatically add USE_PKGCONFIG= both Yeah sorry for step one will keep pkgconf in both dependencies. This is necessary because too much ports rely on one of their deps bringing pkgconfig, and this concerns about 4k+ ports. All the gnome one (mostly), all the xorg one (xproto bring pkgconfig) most of the gtk ones, most of things depending on libxml2 and curl, from what I have seen. step 2/ advertise the maintainers to stop using USE_GNOME= pkgconfig but rather switch to USE_PKGCONFIG, and do it actively. setp 3/ drop USE_GNOME= pkgconfig from bsd.gnome.mk when switching to USE_PKGCONFIG becare full about the ports that depend on your ports to make sure, it doesn't expect pkgconfig being brought by your port. regards, Bapt pgpNRMvhK05Or.pgp Description: PGP signature ___ kde-freebsd mailing list kde-freebsd@kde.org https://mail.kde.org/mailman/listinfo/kde-freebsd See also http://freebsd.kde.org/ for latest information
Re: [kde-freebsd] How to remove erroneous deps from pkgng
On Sat, 21 Jul 2012 21:56:49 -0700 Doug Barton wrote: KDE folks Jason's suggestion (by private e-mail for some reason) was that we add pkgconfig to USE_GNOME= for every port that depends on kdelibs that doesn't already have it; since almost, if not actually all of them are currently relying on the run-dep side effect. I can't see any reason NOT to do this, but if you have an objection please speak up sooner rather than later. KDE 4 ports don't require pkgconfig although they may use it if available. If some ports strongly rely on pkgconfig and don't set USE_GNOME properly they must be fixed. So let have exp-run first. Max ___ kde-freebsd mailing list kde-freebsd@kde.org https://mail.kde.org/mailman/listinfo/kde-freebsd See also http://freebsd.kde.org/ for latest information
Re: [kde-freebsd] How to remove erroneous deps from pkgng
On 07/22/2012 07:51, Jeremy Messenger wrote: You need to start to respect the people's work and plan, Doug. Also I am part of team that maintaining the bsd.gnome.mk. Yes it will be re-add if anyone plan to remove it, because I already have planned add the :build/:run feature in the bsd.gnome.mk that the without :* will be both build/run time dependency. It is impossible for me to not re-add it. It is not going to be long because I already have function :build/:run in the bsd.mate.mk (was repocopied from bsd.gnome.mk) available. The only thing that I don't plan is to chase thousands of port to have the 'pkgconfig;build'. If anyone want to take up this task is cool with me. So what you're saying is that in spite of the fact that the community has identified a bug that it wants to fix, a bug which was added by the team maintaining bsd.gnome.mk, that you are refusing to modify your patch to handle the bug; but instead are demanding your right to reintroduce the bug, and then further demanding the right to not fix it after the patch is in? And furthermore, you're refusing to even look at the other dependencies which are handled by bsd.gnome.mk to see if similar bugs were introduced *by your team*, but you're happy to let everyone else sort out the problems in thousands of ports for you. And you want me to respect that? -- Change is hard. ___ kde-freebsd mailing list kde-freebsd@kde.org https://mail.kde.org/mailman/listinfo/kde-freebsd See also http://freebsd.kde.org/ for latest information
Re: [kde-freebsd] How to remove erroneous deps from pkgng
On 07/22/2012 06:10, Max Brazhnikov wrote: On Sat, 21 Jul 2012 21:56:49 -0700 Doug Barton wrote: KDE folks Jason's suggestion (by private e-mail for some reason) was that we add pkgconfig to USE_GNOME= for every port that depends on kdelibs that doesn't already have it; since almost, if not actually all of them are currently relying on the run-dep side effect. I can't see any reason NOT to do this, but if you have an objection please speak up sooner rather than later. KDE 4 ports don't require pkgconfig although they may use it if available. If some ports strongly rely on pkgconfig and don't set USE_GNOME properly they must be fixed. So let have exp-run first. Okey dokey. -- Change is hard. ___ kde-freebsd mailing list kde-freebsd@kde.org https://mail.kde.org/mailman/listinfo/kde-freebsd See also http://freebsd.kde.org/ for latest information
Re: [kde-freebsd] How to remove erroneous deps from pkgng
On Sat, Jul 21, 2012 at 11:56 PM, Doug Barton do...@freebsd.org wrote: KDE folks Jason's suggestion (by private e-mail for some reason) was that we add pkgconfig to USE_GNOME= for every port that depends on kdelibs that doesn't already have it; since almost, if not actually all of them are currently relying on the run-dep side effect. I can't see any reason NOT to do this, but if you have an objection please speak up sooner rather than later. On 07/21/2012 21:33, Jeremy Messenger wrote: On Sat, Jul 21, 2012 at 4:04 PM, Doug Barton do...@freebsd.org wrote: On 07/21/2012 13:48, Jason E. Hale wrote: IMO I don't really see what the hurry is. This has been the behavior for years. Yes, and some of us have been annoyed by it for years as well. :) The current behavior is wrong, and becomes increasingly painful in a world where most FreeBSD users are using packages because it drags in a totally pointless package to essentially every FreeBSD system. Fixing this bug is a good thing, and needs to be done sooner rather than later. snip It is unnecessary to be in hurry when that pkg-config has been in the bsd.gnome.mk for about nine years. The sooner we start fixing it, the better off we are. I already have a better solution available for weeks. Therefore, you (and others) need to be patient because when I add the :build/:run dependency in the bsd.gnome.mk then that pkg-config runtime dependency will be re-added. Um, yeah ... don't do that. You need to start to respect the people's work and plan, Doug. Also I am part of team that maintaining the bsd.gnome.mk. Yes it will be re-add if anyone plan to remove it, because I already have planned add the :build/:run feature in the bsd.gnome.mk that the without :* will be both build/run time dependency. It is impossible for me to not re-add it. It is not going to be long because I already have function :build/:run in the bsd.mate.mk (was repocopied from bsd.gnome.mk) available. The only thing that I don't plan is to chase thousands of port to have the 'pkgconfig;build'. If anyone want to take up this task is cool with me. I mis-attributed your patch to Jason previously, sorry about that. But before it goes in your patch should have the logic I spoke about in my previous posts, to make sure that the USE_GNOME bits cannot get added as the wrong kinds of deps. And no I am not going to work on chase all ports to have the 'pkgconfig:build' (sorry). Not asking you to. I'm asking you to fix your patch so that things that should only be one kind of dep or the other (like pkgconfig, but not necessarily limited to it) are handled properly by default if the right :label is not attached, and error out if the wrong one is. That way the work that's being done now to fix ports that need explicit build deps for pkg-config will solve this part of the problem for you. As you pointed out, the current situation has existed for a long time already. If we have to wait another week or 2 for the pkg-config run dep problem to be fixed properly before your patch gets committed, that's not really a problem. Doug -- Change is hard. -- mezz.free...@gmail.com - m...@freebsd.org FreeBSD GNOME Team http://www.FreeBSD.org/gnome/ - gn...@freebsd.org ___ kde-freebsd mailing list kde-freebsd@kde.org https://mail.kde.org/mailman/listinfo/kde-freebsd See also http://freebsd.kde.org/ for latest information
Re: [kde-freebsd] How to remove erroneous deps from pkgng
On Sun, 22 Jul 2012 09:51:40 -0500 Jeremy Messenger wrote: You need to start to respect the people's work and plan, Doug. Also I am part of team that maintaining the bsd.gnome.mk. Yes it will be re-add if anyone plan to remove it, because I already have planned add the :build/:run feature in the bsd.gnome.mk that the without :* will be both build/run time dependency. in kde4.mk we support not only run/build suffixes, but also have default dependence type if suffix is not set. The only thing that I don't plan is to chase thousands of port to have the 'pkgconfig;build'. If anyone want to take up this task is cool with me. Why should we change lots of ports and always keep eyes on new ports, if it can be altered once in .mk ?? Max ___ kde-freebsd mailing list kde-freebsd@kde.org https://mail.kde.org/mailman/listinfo/kde-freebsd See also http://freebsd.kde.org/ for latest information
Re: [kde-freebsd] How to remove erroneous deps from pkgng
On Sun, Jul 22, 2012 at 6:22 PM, Max Brazhnikov m...@freebsd.org wrote: On Sun, 22 Jul 2012 09:51:40 -0500 Jeremy Messenger wrote: You need to start to respect the people's work and plan, Doug. Also I am part of team that maintaining the bsd.gnome.mk. Yes it will be re-add if anyone plan to remove it, because I already have planned add the :build/:run feature in the bsd.gnome.mk that the without :* will be both build/run time dependency. in kde4.mk we support not only run/build suffixes, but also have default dependence type if suffix is not set. The only thing that I don't plan is to chase thousands of port to have the 'pkgconfig;build'. If anyone want to take up this task is cool with me. Why should we change lots of ports and always keep eyes on new ports, if it can be altered once in .mk ?? Because it's not a right solution. There are very few need pkg-config in the runtime dependency. Also I already have designed feature that way (it's not for pkg-config, but all stuff in the bsd.gnome.mk) and it doesn't break anything by defaut. But don't worry because bapt, kwm and I have discussed about add USE_PKGCONFIG in the bsd.port.mk and rip pkg-config out of bsd.gnome.mk. It's even better, but I know it's more work like USE_GNOME=pkgconfig:build. Cheers, Mezz Max -- mezz.free...@gmail.com - m...@freebsd.org FreeBSD GNOME Team http://www.FreeBSD.org/gnome/ - gn...@freebsd.org ___ kde-freebsd mailing list kde-freebsd@kde.org https://mail.kde.org/mailman/listinfo/kde-freebsd See also http://freebsd.kde.org/ for latest information
Re: [kde-freebsd] How to remove erroneous deps from pkgng
On 07/22/2012 17:50, Jeremy Messenger wrote: On Sun, Jul 22, 2012 at 4:16 PM, Doug Barton do...@freebsd.org wrote: On 07/22/2012 07:51, Jeremy Messenger wrote: You need to start to respect the people's work and plan, Doug. Also I am part of team that maintaining the bsd.gnome.mk. Yes it will be re-add if anyone plan to remove it, because I already have planned add the :build/:run feature in the bsd.gnome.mk that the without :* will be both build/run time dependency. It is impossible for me to not re-add it. It is not going to be long because I already have function :build/:run in the bsd.mate.mk (was repocopied from bsd.gnome.mk) available. The only thing that I don't plan is to chase thousands of port to have the 'pkgconfig;build'. If anyone want to take up this task is cool with me. So what you're saying is that in spite of the fact that the community has identified a bug that it wants to fix, a bug which was added by the team maintaining bsd.gnome.mk, that you are refusing to modify your patch to handle the bug; but instead are demanding your right to reintroduce the bug, and then further demanding the right to not fix it after the patch is in? Remove the runtime dependency is a bug either because there are a few that need it in the runtime dependency. Which ports are those? And even if these ports exist, an explicit run dep can be added for them. Better to add one more dep for a few ports than bogus ones for thousands. I have written a best solution than remove that runtime line. It will be 99% bug free when all ports have the right :build/:run. I'm interested in your feedback to Max' point that the equivalent functionality for kde.mk already has the right logic to handle proper defaults if the right :label isn't set. And furthermore, you're refusing to even look at the other dependencies which are handled by bsd.gnome.mk to see if similar bugs were introduced *by your team*, but you're happy to let everyone else sort out the problems in thousands of ports for you. Quiet simple, I do not have time for that huge project. That's fine, stand aside and let people who are willing to solve the problem properly do the work. Then when your patch is in proper shape it can be committed without fear of adding new bugs, or re-adding old ones. The position you're taking that we can't fix the bug because you demand your right to get *your* patch in is entirely unreasonable. Doug -- Change is hard. ___ kde-freebsd mailing list kde-freebsd@kde.org https://mail.kde.org/mailman/listinfo/kde-freebsd See also http://freebsd.kde.org/ for latest information
Re: [kde-freebsd] How to remove erroneous deps from pkgng
On Sun, Jul 22, 2012 at 4:16 PM, Doug Barton do...@freebsd.org wrote: On 07/22/2012 07:51, Jeremy Messenger wrote: You need to start to respect the people's work and plan, Doug. Also I am part of team that maintaining the bsd.gnome.mk. Yes it will be re-add if anyone plan to remove it, because I already have planned add the :build/:run feature in the bsd.gnome.mk that the without :* will be both build/run time dependency. It is impossible for me to not re-add it. It is not going to be long because I already have function :build/:run in the bsd.mate.mk (was repocopied from bsd.gnome.mk) available. The only thing that I don't plan is to chase thousands of port to have the 'pkgconfig;build'. If anyone want to take up this task is cool with me. So what you're saying is that in spite of the fact that the community has identified a bug that it wants to fix, a bug which was added by the team maintaining bsd.gnome.mk, that you are refusing to modify your patch to handle the bug; but instead are demanding your right to reintroduce the bug, and then further demanding the right to not fix it after the patch is in? Remove the runtime dependency is a bug either because there are a few that need it in the runtime dependency. I have written a best solution than remove that runtime line. It will be 99% bug free when all ports have the right :build/:run. And furthermore, you're refusing to even look at the other dependencies which are handled by bsd.gnome.mk to see if similar bugs were introduced *by your team*, but you're happy to let everyone else sort out the problems in thousands of ports for you. Quiet simple, I do not have time for that huge project. I already have added :build/:run feature before anyone complain about the pkg-config dependency. The feature happened to address this issue and fix all pkg-config dependency was not part of my TODO list. My method does not break before or after patch any port, but still have the wrong dependency which it's minor and can be fixed by edit to pkgconfig:build. And you want me to respect that? -- Change is hard. -- mezz.free...@gmail.com - m...@freebsd.org FreeBSD GNOME Team http://www.FreeBSD.org/gnome/ - gn...@freebsd.org ___ kde-freebsd mailing list kde-freebsd@kde.org https://mail.kde.org/mailman/listinfo/kde-freebsd See also http://freebsd.kde.org/ for latest information
Re: [kde-freebsd] How to remove erroneous deps from pkgng
On Mon, Jul 23, 2012 at 4:22 AM, Doug Barton do...@freebsd.org wrote: On 07/22/2012 17:50, Jeremy Messenger wrote: On Sun, Jul 22, 2012 at 4:16 PM, Doug Barton do...@freebsd.org wrote: On 07/22/2012 07:51, Jeremy Messenger wrote: You need to start to respect the people's work and plan, Doug. Also I am part of team that maintaining the bsd.gnome.mk. Yes it will be re-add if anyone plan to remove it, because I already have planned add the :build/:run feature in the bsd.gnome.mk that the without :* will be both build/run time dependency. It is impossible for me to not re-add it. It is not going to be long because I already have function :build/:run in the bsd.mate.mk (was repocopied from bsd.gnome.mk) available. The only thing that I don't plan is to chase thousands of port to have the 'pkgconfig;build'. If anyone want to take up this task is cool with me. So what you're saying is that in spite of the fact that the community has identified a bug that it wants to fix, a bug which was added by the team maintaining bsd.gnome.mk, that you are refusing to modify your patch to handle the bug; but instead are demanding your right to reintroduce the bug, and then further demanding the right to not fix it after the patch is in? Remove the runtime dependency is a bug either because there are a few that need it in the runtime dependency. Which ports are those? And even if these ports exist, an explicit run dep can be added for them. Better to add one more dep for a few ports than bogus ones for thousands. I have written a best solution than remove that runtime line. It will be 99% bug free when all ports have the right :build/:run. I'm interested in your feedback to Max' point that the equivalent functionality for kde.mk already has the right logic to handle proper defaults if the right :label isn't set. And furthermore, you're refusing to even look at the other dependencies which are handled by bsd.gnome.mk to see if similar bugs were introduced *by your team*, but you're happy to let everyone else sort out the problems in thousands of ports for you. Quiet simple, I do not have time for that huge project. That's fine, stand aside and let people who are willing to solve the problem properly do the work. Then when your patch is in proper shape it can be committed without fear of adding new bugs, or re-adding old ones. The position you're taking that we can't fix the bug because you demand your right to get *your* patch in is entirely unreasonable. Doug -- Change is hard. ___ freebsd-po...@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org Looking at the bsd.kde4.mk it looks like there's not much logic to detect the right kind of dependency. It seems to use suffixes _build and _run to achieve the same effect as pkgconfig:build and pkgconfig:run would have. It defaults to both build and run dependency if no type is specified. In my opinion Jeremy's solution would be fine for now, least amount of immediate destruction :P Regards, Kimmo Paasiala ___ kde-freebsd mailing list kde-freebsd@kde.org https://mail.kde.org/mailman/listinfo/kde-freebsd See also http://freebsd.kde.org/ for latest information
Re: [kde-freebsd] How to remove erroneous deps from pkgng
KDE folks Jason's suggestion (by private e-mail for some reason) was that we add pkgconfig to USE_GNOME= for every port that depends on kdelibs that doesn't already have it; since almost, if not actually all of them are currently relying on the run-dep side effect. I can't see any reason NOT to do this, but if you have an objection please speak up sooner rather than later. On 07/21/2012 21:33, Jeremy Messenger wrote: On Sat, Jul 21, 2012 at 4:04 PM, Doug Barton do...@freebsd.org wrote: On 07/21/2012 13:48, Jason E. Hale wrote: IMO I don't really see what the hurry is. This has been the behavior for years. Yes, and some of us have been annoyed by it for years as well. :) The current behavior is wrong, and becomes increasingly painful in a world where most FreeBSD users are using packages because it drags in a totally pointless package to essentially every FreeBSD system. Fixing this bug is a good thing, and needs to be done sooner rather than later. snip It is unnecessary to be in hurry when that pkg-config has been in the bsd.gnome.mk for about nine years. The sooner we start fixing it, the better off we are. I already have a better solution available for weeks. Therefore, you (and others) need to be patient because when I add the :build/:run dependency in the bsd.gnome.mk then that pkg-config runtime dependency will be re-added. Um, yeah ... don't do that. I mis-attributed your patch to Jason previously, sorry about that. But before it goes in your patch should have the logic I spoke about in my previous posts, to make sure that the USE_GNOME bits cannot get added as the wrong kinds of deps. And no I am not going to work on chase all ports to have the 'pkgconfig:build' (sorry). Not asking you to. I'm asking you to fix your patch so that things that should only be one kind of dep or the other (like pkgconfig, but not necessarily limited to it) are handled properly by default if the right :label is not attached, and error out if the wrong one is. That way the work that's being done now to fix ports that need explicit build deps for pkg-config will solve this part of the problem for you. As you pointed out, the current situation has existed for a long time already. If we have to wait another week or 2 for the pkg-config run dep problem to be fixed properly before your patch gets committed, that's not really a problem. Doug -- Change is hard. ___ kde-freebsd mailing list kde-freebsd@kde.org https://mail.kde.org/mailman/listinfo/kde-freebsd See also http://freebsd.kde.org/ for latest information
