Re: [Kde-hardware-devel] Review Request 107415: [High-dpi issues] Fix BluetoothDevicesDelegate with huge fonts and icon sizes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107415/#review52421 --- This review has been submitted with commit 191bbd733218c99bb6952243351a59ddcac565f4 by Àlex Fiestas to branch master. - Commit Hook On Jan. 8, 2014, 7:52 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107415/ --- (Updated Jan. 8, 2014, 7:52 p.m.) Review request for Bluedevil, Àlex Fiestas and Michael Zanetti. Repository: bluedevil Description --- This fixes bluetooth devices delegate having overlapping fonts and small icons when using them with high dpi settings and big icon sizes, which is likely on high-dpi screens such as the Macbook Pro Retina. Diffs - src/kcmodule/bluedevildevices.cpp ff15398 Diff: https://git.reviewboard.kde.org/r/107415/diff/ Testing --- Tested with up to 200 dpi and bigger icons. This does not fix the initial problem but is an easy fix for the most common case (ie. if I have huge fonts I am likely to have huge icons as well, so when the icons are bigger, the fonts don't overlap if they are bigger as well). Since there is no 48px default size, I am using Dialog icon size (default is 32) and multiply it by 1.5 to get the 48 which matches SizeLarge. Screenshots --- Bluedevil with 200 dpi https://git.reviewboard.kde.org/r/107415/s/846/ Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
Re: [Kde-hardware-devel] Review Request 107415: [High-dpi issues] Fix BluetoothDevicesDelegate with huge fonts and icon sizes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107415/ --- (Updated Jan. 8, 2014, 7:52 p.m.) Review request for Bluedevil, Àlex Fiestas and Michael Zanetti. Changes --- Adressed Michael's comments and also made sure text never overlaps by returning an appropriate sizeHint. I am now using qMax(font height * 2 + font xheight, icon size) I couldn't find a method in QFontMetrics that gives me the distance between to lines of text, or an absolute height including everything. The lineSpacing() is the spacing from one line to another which is height() + leading() (leading was -1 in my case). If you have a better idea, go ahead, but it looks fine now :) Repository: bluedevil Description --- This fixes bluetooth devices delegate having overlapping fonts and small icons when using them with high dpi settings and big icon sizes, which is likely on high-dpi screens such as the Macbook Pro Retina. Diffs (updated) - src/kcmodule/bluedevildevices.cpp ff15398 Diff: https://git.reviewboard.kde.org/r/107415/diff/ Testing --- Tested with up to 200 dpi and bigger icons. This does not fix the initial problem but is an easy fix for the most common case (ie. if I have huge fonts I am likely to have huge icons as well, so when the icons are bigger, the fonts don't overlap if they are bigger as well). Since there is no 48px default size, I am using Dialog icon size (default is 32) and multiply it by 1.5 to get the 48 which matches SizeLarge. Screenshots --- Bluedevil with 200 dpi https://git.reviewboard.kde.org/r/107415/s/846/ Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
Re: [Kde-hardware-devel] Review Request 107415: [High-dpi issues] Fix BluetoothDevicesDelegate with huge fonts and icon sizes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107415/#review46944 --- Kai can you finish the patch please? I'd like to include it in next releases. Thanks ! - Àlex Fiestas On Feb. 11, 2013, 10:50 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107415/ --- (Updated Feb. 11, 2013, 10:50 p.m.) Review request for Bluedevil, Àlex Fiestas and Michael Zanetti. Repository: bluedevil Description --- This fixes bluetooth devices delegate having overlapping fonts and small icons when using them with high dpi settings and big icon sizes, which is likely on high-dpi screens such as the Macbook Pro Retina. Diffs - src/kcmodule/bluedevildevices.cpp 86accf5 Diff: https://git.reviewboard.kde.org/r/107415/diff/ Testing --- Tested with up to 200 dpi and bigger icons. This does not fix the initial problem but is an easy fix for the most common case (ie. if I have huge fonts I am likely to have huge icons as well, so when the icons are bigger, the fonts don't overlap if they are bigger as well). Since there is no 48px default size, I am using Dialog icon size (default is 32) and multiply it by 1.5 to get the 48 which matches SizeLarge. Screenshots --- Bluedevil with 200 dpi https://git.reviewboard.kde.org/r/107415/s/846/ Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
Re: [Kde-hardware-devel] Review Request 107415: [High-dpi issues] Fix BluetoothDevicesDelegate with huge fonts and icon sizes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107415/#review30619 --- Can someone review the new patch? - Albert Astals Cid On Feb. 11, 2013, 10:50 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107415/ --- (Updated Feb. 11, 2013, 10:50 p.m.) Review request for Bluedevil, Àlex Fiestas and Michael Zanetti. Description --- This fixes bluetooth devices delegate having overlapping fonts and small icons when using them with high dpi settings and big icon sizes, which is likely on high-dpi screens such as the Macbook Pro Retina. Diffs - src/kcmodule/bluedevildevices.cpp 86accf5 Diff: http://git.reviewboard.kde.org/r/107415/diff/ Testing --- Tested with up to 200 dpi and bigger icons. This does not fix the initial problem but is an easy fix for the most common case (ie. if I have huge fonts I am likely to have huge icons as well, so when the icons are bigger, the fonts don't overlap if they are bigger as well). Since there is no 48px default size, I am using Dialog icon size (default is 32) and multiply it by 1.5 to get the 48 which matches SizeLarge. Screenshots --- Bluedevil with 200 dpi http://git.reviewboard.kde.org/r/107415/s/846/ Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
