Re: [Kde-hardware-devel] Review Request 114393: Add support for logind interfaces on upstart >= 1.11

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114393/#review47041
---


This review has been submitted with commit 
98c07b557a65c5f0f2b3846a3b5cb786bc874b48 by Rohan Garg to branch KDE/4.11.

- Commit Hook


On Dec. 18, 2013, 6:54 p.m., Rohan Garg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114393/
> ---
> 
> (Updated Dec. 18, 2013, 6:54 p.m.)
> 
> 
> Review request for Solid, Àlex Fiestas and Harald Sitter.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> Upstart implemented logind API's and powerdevil can use these interfaces on 
> upstart systems by just fixing the check for the version inside the upower 
> daemon.
> 
> 
> Diffs
> -
> 
>   powerdevil/daemon/BackendConfig.cmake 71eeef3 
>   powerdevil/daemon/backends/upower/dbus/com.ubuntu.Upstart.xml PRE-CREATION 
>   powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp ab53ffd 
> 
> Diff: https://git.reviewboard.kde.org/r/114393/diff/
> 
> 
> Testing
> ---
> 
> System suspends to disk and RAM
> System resumes successfully.
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 114393: Add support for logind interfaces on upstart >= 1.11

[Rohan Garg]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114393/
---

(Updated Jan. 8, 2014, 10:45 a.m.)


Status
--

This change has been marked as submitted.


Review request for Solid, Àlex Fiestas and Harald Sitter.


Repository: kde-workspace


Description
---

Upstart implemented logind API's and powerdevil can use these interfaces on 
upstart systems by just fixing the check for the version inside the upower 
daemon.


Diffs
-

  powerdevil/daemon/BackendConfig.cmake 71eeef3 
  powerdevil/daemon/backends/upower/dbus/com.ubuntu.Upstart.xml PRE-CREATION 
  powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp ab53ffd 

Diff: https://git.reviewboard.kde.org/r/114393/diff/


Testing
---

System suspends to disk and RAM
System resumes successfully.


Thanks,

Rohan Garg

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 114393: Add support for logind interfaces on upstart >= 1.11

[Àlex Fiestas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114393/#review46941
---


Has this been submitted? if so, please close the review.

- Àlex Fiestas


On Dec. 18, 2013, 6:54 p.m., Rohan Garg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114393/
> ---
> 
> (Updated Dec. 18, 2013, 6:54 p.m.)
> 
> 
> Review request for Solid, Àlex Fiestas and Harald Sitter.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> Upstart implemented logind API's and powerdevil can use these interfaces on 
> upstart systems by just fixing the check for the version inside the upower 
> daemon.
> 
> 
> Diffs
> -
> 
>   powerdevil/daemon/BackendConfig.cmake 71eeef3 
>   powerdevil/daemon/backends/upower/dbus/com.ubuntu.Upstart.xml PRE-CREATION 
>   powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp ab53ffd 
> 
> Diff: https://git.reviewboard.kde.org/r/114393/diff/
> 
> 
> Testing
> ---
> 
> System suspends to disk and RAM
> System resumes successfully.
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 114393: Add support for logind interfaces on upstart >= 1.11

[Harald Sitter]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114393/#review45917
---

Ship it!


Ship It!

- Harald Sitter


On Dec. 18, 2013, 6:54 p.m., Rohan Garg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114393/
> ---
> 
> (Updated Dec. 18, 2013, 6:54 p.m.)
> 
> 
> Review request for Solid, Àlex Fiestas and Harald Sitter.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> Upstart implemented logind API's and powerdevil can use these interfaces on 
> upstart systems by just fixing the check for the version inside the upower 
> daemon.
> 
> 
> Diffs
> -
> 
>   powerdevil/daemon/BackendConfig.cmake 71eeef3 
>   powerdevil/daemon/backends/upower/dbus/com.ubuntu.Upstart.xml PRE-CREATION 
>   powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp ab53ffd 
> 
> Diff: http://git.reviewboard.kde.org/r/114393/diff/
> 
> 
> Testing
> ---
> 
> System suspends to disk and RAM
> System resumes successfully.
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 114393: Add support for logind interfaces on upstart >= 1.11

[Rohan Garg]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114393/
---

(Updated Dec. 19, 2013, 12:24 a.m.)


Review request for Solid, Àlex Fiestas and Harald Sitter.


Changes
---

Update with suggestions.


Repository: kde-workspace


Description
---

Upstart implemented logind API's and powerdevil can use these interfaces on 
upstart systems by just fixing the check for the version inside the upower 
daemon.


Diffs (updated)
-

  powerdevil/daemon/BackendConfig.cmake 71eeef3 
  powerdevil/daemon/backends/upower/dbus/com.ubuntu.Upstart.xml PRE-CREATION 
  powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp ab53ffd 

Diff: http://git.reviewboard.kde.org/r/114393/diff/


Testing
---

System suspends to disk and RAM
System resumes successfully.


Thanks,

Rohan Garg

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 114393: Add support for logind interfaces on upstart >= 1.11

[Àlex Fiestas]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114393/#review45912
---

Ship it!


Add a comment explaining why we have to deal with upstart if the method is 
called "checkSsytemdVersion".

Once that's done, please commit.

- Àlex Fiestas


On Dec. 10, 2013, 6:25 p.m., Rohan Garg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114393/
> ---
> 
> (Updated Dec. 10, 2013, 6:25 p.m.)
> 
> 
> Review request for Solid, Àlex Fiestas and Harald Sitter.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> Upstart implemented logind API's and powerdevil can use these interfaces on 
> upstart systems by just fixing the check for the version inside the upower 
> daemon.
> 
> 
> Diffs
> -
> 
>   powerdevil/daemon/BackendConfig.cmake 71eeef3 
>   powerdevil/daemon/backends/upower/dbus/com.ubuntu.Upstart.xml PRE-CREATION 
>   powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp ab53ffd 
> 
> Diff: http://git.reviewboard.kde.org/r/114393/diff/
> 
> 
> Testing
> ---
> 
> System suspends to disk and RAM
> System resumes successfully.
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 114393: Add support for logind interfaces on upstart >= 1.11

[Àlex Fiestas]

> On Dec. 18, 2013, 6:02 p.m., Àlex Fiestas wrote:
> > Add a comment explaining why we have to deal with upstart if the method is 
> > called "checkSsytemdVersion".
> > 
> > Once that's done, please commit.

Oh and also explain it in the commit message, plus say that this won't affect 
systems using systemd because the systemd check is before the upstart one (just 
so nobdoy yells at us for the commit)


- Àlex


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114393/#review45912
---


On Dec. 10, 2013, 6:25 p.m., Rohan Garg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114393/
> ---
> 
> (Updated Dec. 10, 2013, 6:25 p.m.)
> 
> 
> Review request for Solid, Àlex Fiestas and Harald Sitter.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> Upstart implemented logind API's and powerdevil can use these interfaces on 
> upstart systems by just fixing the check for the version inside the upower 
> daemon.
> 
> 
> Diffs
> -
> 
>   powerdevil/daemon/BackendConfig.cmake 71eeef3 
>   powerdevil/daemon/backends/upower/dbus/com.ubuntu.Upstart.xml PRE-CREATION 
>   powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp ab53ffd 
> 
> Diff: http://git.reviewboard.kde.org/r/114393/diff/
> 
> 
> Testing
> ---
> 
> System suspends to disk and RAM
> System resumes successfully.
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 114393: Add support for logind interfaces on upstart >= 1.11

[Harald Sitter]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114393/#review45506
---

Ship it!



powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp


I think a regex would be more readable really.


- Harald Sitter


On Dec. 10, 2013, 6:25 p.m., Rohan Garg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114393/
> ---
> 
> (Updated Dec. 10, 2013, 6:25 p.m.)
> 
> 
> Review request for Solid, Àlex Fiestas and Harald Sitter.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> Upstart implemented logind API's and powerdevil can use these interfaces on 
> upstart systems by just fixing the check for the version inside the upower 
> daemon.
> 
> 
> Diffs
> -
> 
>   powerdevil/daemon/BackendConfig.cmake 71eeef3 
>   powerdevil/daemon/backends/upower/dbus/com.ubuntu.Upstart.xml PRE-CREATION 
>   powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp ab53ffd 
> 
> Diff: http://git.reviewboard.kde.org/r/114393/diff/
> 
> 
> Testing
> ---
> 
> System suspends to disk and RAM
> System resumes successfully.
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 114393: Add support for logind interfaces on upstart >= 1.11

[Lukáš Tinkl]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114393/#review45504
---

Ship it!


Looks good to me.

- Lukáš Tinkl


On Dec. 10, 2013, 7:25 p.m., Rohan Garg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114393/
> ---
> 
> (Updated Dec. 10, 2013, 7:25 p.m.)
> 
> 
> Review request for Solid, Àlex Fiestas and Harald Sitter.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> ---
> 
> Upstart implemented logind API's and powerdevil can use these interfaces on 
> upstart systems by just fixing the check for the version inside the upower 
> daemon.
> 
> 
> Diffs
> -
> 
>   powerdevil/daemon/BackendConfig.cmake 71eeef3 
>   powerdevil/daemon/backends/upower/dbus/com.ubuntu.Upstart.xml PRE-CREATION 
>   powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp ab53ffd 
> 
> Diff: http://git.reviewboard.kde.org/r/114393/diff/
> 
> 
> Testing
> ---
> 
> System suspends to disk and RAM
> System resumes successfully.
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

Re: [Kde-hardware-devel] Review Request 114393: Add support for logind interfaces on upstart >= 1.11

[Rohan Garg]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114393/
---

(Updated Dec. 10, 2013, 11:55 p.m.)


Review request for Solid, Àlex Fiestas and Harald Sitter.


Repository: kde-workspace


Description
---

Upstart implemented logind API's and powerdevil can use these interfaces on 
upstart systems by just fixing the check for the version inside the upower 
daemon.


Diffs
-

  powerdevil/daemon/BackendConfig.cmake 71eeef3 
  powerdevil/daemon/backends/upower/dbus/com.ubuntu.Upstart.xml PRE-CREATION 
  powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp ab53ffd 

Diff: http://git.reviewboard.kde.org/r/114393/diff/


Testing
---

System suspends to disk and RAM
System resumes successfully.


Thanks,

Rohan Garg

___
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel