Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid
> On July 31, 2015, 9:38 p.m., Aleix Pol Gonzalez wrote: > > Is it done yet? What's the status? > > Kai Uwe Broulik wrote: > I don't know, someone marked it as submitted but it cearly isn't. > > Albert Vaca Cintora wrote: > What's left before we can merge it? Bump. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123263/#review83263 --- On July 31, 2015, 9:15 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123263/ > --- > > (Updated July 31, 2015, 9:15 p.m.) > > > Review request for kdeconnect, Solid, Albert Vaca Cintora, and Emmanuel > Pescosta. > > > Repository: solid > > > Description > --- > > This adds a KDE Connect backend to Solid enabling us to show phone battery > status in the device notifier, and have the phone appear in the device > notifier like an external storage. > > It is pretty synchronous at the moment. Any ideas how I could improve that? I > guess when someone wants to get devices, it creates a new device interface > and calls allDevices() or devicesFromQuery() immediately afterwards, so I > cannot just do that stuff async and defer population? Or call deviceAdded for > each of the initial ones once I have them? > > It requires adjustment in the kdeconnect KIO slave so it can handle addresses > like kdeconnect://org/kde/kdeconnect/123456 or > kdeconnect:udi=/org/kde/kdeconnect/123456 (like mtp kio does) because all > Dolphin or the device notifier have is the UDI. It also needs a new device > action that matches "Portable Media Player" with the "kdeconnect" protocol, > similar to mtp. > > By adjusting the predicate in Dolphin's Places sidebar (and probably the file > dialog) to query for the "kdeconnect" protocol, we can have its places > automatically updated without having KDE Connect manually mess with > KFilePlaces. > > > Diffs > - > > src/solid/devices/CMakeLists.txt 9271ae1 > src/solid/devices/backends/kdeconnect/CMakeLists.txt PRE-CREATION > src/solid/devices/backends/kdeconnect/kdeconnectbattery.h PRE-CREATION > src/solid/devices/backends/kdeconnect/kdeconnectbattery.cpp PRE-CREATION > src/solid/devices/backends/kdeconnect/kdeconnectdevice.h PRE-CREATION > src/solid/devices/backends/kdeconnect/kdeconnectdevice.cpp PRE-CREATION > src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.h > PRE-CREATION > src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.cpp > PRE-CREATION > src/solid/devices/backends/kdeconnect/kdeconnectmanager.h PRE-CREATION > src/solid/devices/backends/kdeconnect/kdeconnectmanager.cpp PRE-CREATION > src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.h > PRE-CREATION > src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.cpp > PRE-CREATION > src/solid/devices/managerbase.cpp eee4de5 > > Diff: https://git.reviewboard.kde.org/r/123263/diff/ > > > Testing > --- > > With some crash fixes already pushed to plasma-workspace it works pretty well. > > > Thanks, > > Kai Uwe Broulik > > ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid
On July 31, 2015, 12:38 p.m., Aleix Pol Gonzalez wrote: Is it done yet? What's the status? Kai Uwe Broulik wrote: I don't know, someone marked it as submitted but it cearly isn't. What's left before we can merge it? - Albert --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123263/#review83263 --- On July 31, 2015, 12:15 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123263/ --- (Updated July 31, 2015, 12:15 p.m.) Review request for kdeconnect, Solid, Albert Vaca Cintora, and Emmanuel Pescosta. Repository: solid Description --- This adds a KDE Connect backend to Solid enabling us to show phone battery status in the device notifier, and have the phone appear in the device notifier like an external storage. It is pretty synchronous at the moment. Any ideas how I could improve that? I guess when someone wants to get devices, it creates a new device interface and calls allDevices() or devicesFromQuery() immediately afterwards, so I cannot just do that stuff async and defer population? Or call deviceAdded for each of the initial ones once I have them? It requires adjustment in the kdeconnect KIO slave so it can handle addresses like kdeconnect://org/kde/kdeconnect/123456 or kdeconnect:udi=/org/kde/kdeconnect/123456 (like mtp kio does) because all Dolphin or the device notifier have is the UDI. It also needs a new device action that matches Portable Media Player with the kdeconnect protocol, similar to mtp. By adjusting the predicate in Dolphin's Places sidebar (and probably the file dialog) to query for the kdeconnect protocol, we can have its places automatically updated without having KDE Connect manually mess with KFilePlaces. Diffs - src/solid/devices/CMakeLists.txt 9271ae1 src/solid/devices/backends/kdeconnect/CMakeLists.txt PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectbattery.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectbattery.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdevice.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdevice.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectmanager.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectmanager.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.cpp PRE-CREATION src/solid/devices/managerbase.cpp eee4de5 Diff: https://git.reviewboard.kde.org/r/123263/diff/ Testing --- With some crash fixes already pushed to plasma-workspace it works pretty well. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid
On Juli 31, 2015, 7:38 nachm., Aleix Pol Gonzalez wrote: Is it done yet? What's the status? I don't know, someone marked it as submitted but it cearly isn't. - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123263/#review83263 --- On Juli 31, 2015, 7:15 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123263/ --- (Updated Juli 31, 2015, 7:15 nachm.) Review request for kdeconnect, Solid, Albert Vaca Cintora, and Emmanuel Pescosta. Repository: solid Description --- This adds a KDE Connect backend to Solid enabling us to show phone battery status in the device notifier, and have the phone appear in the device notifier like an external storage. It is pretty synchronous at the moment. Any ideas how I could improve that? I guess when someone wants to get devices, it creates a new device interface and calls allDevices() or devicesFromQuery() immediately afterwards, so I cannot just do that stuff async and defer population? Or call deviceAdded for each of the initial ones once I have them? It requires adjustment in the kdeconnect KIO slave so it can handle addresses like kdeconnect://org/kde/kdeconnect/123456 or kdeconnect:udi=/org/kde/kdeconnect/123456 (like mtp kio does) because all Dolphin or the device notifier have is the UDI. It also needs a new device action that matches Portable Media Player with the kdeconnect protocol, similar to mtp. By adjusting the predicate in Dolphin's Places sidebar (and probably the file dialog) to query for the kdeconnect protocol, we can have its places automatically updated without having KDE Connect manually mess with KFilePlaces. Diffs - src/solid/devices/CMakeLists.txt 9271ae1 src/solid/devices/backends/kdeconnect/CMakeLists.txt PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectbattery.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectbattery.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdevice.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdevice.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectmanager.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectmanager.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.cpp PRE-CREATION src/solid/devices/managerbase.cpp eee4de5 Diff: https://git.reviewboard.kde.org/r/123263/diff/ Testing --- With some crash fixes already pushed to plasma-workspace it works pretty well. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123263/#review83263 --- Is it done yet? What's the status? - Aleix Pol Gonzalez On jul. 31, 2015, 9:15 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123263/ --- (Updated jul. 31, 2015, 9:15 p.m.) Review request for kdeconnect, Solid, Albert Vaca Cintora, and Emmanuel Pescosta. Repository: solid Description --- This adds a KDE Connect backend to Solid enabling us to show phone battery status in the device notifier, and have the phone appear in the device notifier like an external storage. It is pretty synchronous at the moment. Any ideas how I could improve that? I guess when someone wants to get devices, it creates a new device interface and calls allDevices() or devicesFromQuery() immediately afterwards, so I cannot just do that stuff async and defer population? Or call deviceAdded for each of the initial ones once I have them? It requires adjustment in the kdeconnect KIO slave so it can handle addresses like kdeconnect://org/kde/kdeconnect/123456 or kdeconnect:udi=/org/kde/kdeconnect/123456 (like mtp kio does) because all Dolphin or the device notifier have is the UDI. It also needs a new device action that matches Portable Media Player with the kdeconnect protocol, similar to mtp. By adjusting the predicate in Dolphin's Places sidebar (and probably the file dialog) to query for the kdeconnect protocol, we can have its places automatically updated without having KDE Connect manually mess with KFilePlaces. Diffs - src/solid/devices/CMakeLists.txt 9271ae1 src/solid/devices/backends/kdeconnect/CMakeLists.txt PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectbattery.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectbattery.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdevice.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdevice.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectmanager.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectmanager.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.cpp PRE-CREATION src/solid/devices/managerbase.cpp eee4de5 Diff: https://git.reviewboard.kde.org/r/123263/diff/ Testing --- With some crash fixes already pushed to plasma-workspace it works pretty well. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123263/ --- (Updated jul. 31, 2015, 9:15 p.m.) Status -- This change has been marked as submitted. Review request for kdeconnect, Solid, Albert Vaca Cintora, and Emmanuel Pescosta. Repository: solid Description --- This adds a KDE Connect backend to Solid enabling us to show phone battery status in the device notifier, and have the phone appear in the device notifier like an external storage. It is pretty synchronous at the moment. Any ideas how I could improve that? I guess when someone wants to get devices, it creates a new device interface and calls allDevices() or devicesFromQuery() immediately afterwards, so I cannot just do that stuff async and defer population? Or call deviceAdded for each of the initial ones once I have them? It requires adjustment in the kdeconnect KIO slave so it can handle addresses like kdeconnect://org/kde/kdeconnect/123456 or kdeconnect:udi=/org/kde/kdeconnect/123456 (like mtp kio does) because all Dolphin or the device notifier have is the UDI. It also needs a new device action that matches Portable Media Player with the kdeconnect protocol, similar to mtp. By adjusting the predicate in Dolphin's Places sidebar (and probably the file dialog) to query for the kdeconnect protocol, we can have its places automatically updated without having KDE Connect manually mess with KFilePlaces. Diffs - src/solid/devices/CMakeLists.txt 9271ae1 src/solid/devices/backends/kdeconnect/CMakeLists.txt PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectbattery.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectbattery.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdevice.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdevice.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectmanager.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectmanager.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.cpp PRE-CREATION src/solid/devices/managerbase.cpp eee4de5 Diff: https://git.reviewboard.kde.org/r/123263/diff/ Testing --- With some crash fixes already pushed to plasma-workspace it works pretty well. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid
On April 19, 2015, 8:20 nachm., Albert Vaca Cintora wrote: I don't understand the portable media player part. Does it do something? Besides that, I think we need to fix the issues opened by Lamarque and Alex, but looks good to me :) Solid has been designed in the pre-Smartphone era, it only has a concept of a Portable Media Player, no Smartphone type. I only did what the MTP KIO did, however I do see that we should probably add a Mobile device type for phones, tablets, wearables, and stuff. - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123263/#review79218 --- On April 5, 2015, 8:56 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123263/ --- (Updated April 5, 2015, 8:56 nachm.) Review request for kdeconnect, Solid, Albert Vaca Cintora, and Emmanuel Pescosta. Repository: solid Description --- This adds a KDE Connect backend to Solid enabling us to show phone battery status in the device notifier, and have the phone appear in the device notifier like an external storage. It is pretty synchronous at the moment. Any ideas how I could improve that? I guess when someone wants to get devices, it creates a new device interface and calls allDevices() or devicesFromQuery() immediately afterwards, so I cannot just do that stuff async and defer population? Or call deviceAdded for each of the initial ones once I have them? It requires adjustment in the kdeconnect KIO slave so it can handle addresses like kdeconnect://org/kde/kdeconnect/123456 or kdeconnect:udi=/org/kde/kdeconnect/123456 (like mtp kio does) because all Dolphin or the device notifier have is the UDI. It also needs a new device action that matches Portable Media Player with the kdeconnect protocol, similar to mtp. By adjusting the predicate in Dolphin's Places sidebar (and probably the file dialog) to query for the kdeconnect protocol, we can have its places automatically updated without having KDE Connect manually mess with KFilePlaces. Diffs - src/solid/devices/CMakeLists.txt 9271ae1 src/solid/devices/backends/kdeconnect/CMakeLists.txt PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectbattery.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectbattery.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdevice.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdevice.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectmanager.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectmanager.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.cpp PRE-CREATION src/solid/devices/managerbase.cpp eee4de5 Diff: https://git.reviewboard.kde.org/r/123263/diff/ Testing --- With some crash fixes already pushed to plasma-workspace it works pretty well. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid
On April 19, 2015, 8:20 nachm., Albert Vaca Cintora wrote: I don't understand the portable media player part. Does it do something? Besides that, I think we need to fix the issues opened by Lamarque and Alex, but looks good to me :) Kai Uwe Broulik wrote: Solid has been designed in the pre-Smartphone era, it only has a concept of a Portable Media Player, no Smartphone type. I only did what the MTP KIO did, however I do see that we should probably add a Mobile device type for phones, tablets, wearables, and stuff. Why add another type? Just rename Portable Media Player. - Markus --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123263/#review79218 --- On April 5, 2015, 8:56 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123263/ --- (Updated April 5, 2015, 8:56 nachm.) Review request for kdeconnect, Solid, Albert Vaca Cintora, and Emmanuel Pescosta. Repository: solid Description --- This adds a KDE Connect backend to Solid enabling us to show phone battery status in the device notifier, and have the phone appear in the device notifier like an external storage. It is pretty synchronous at the moment. Any ideas how I could improve that? I guess when someone wants to get devices, it creates a new device interface and calls allDevices() or devicesFromQuery() immediately afterwards, so I cannot just do that stuff async and defer population? Or call deviceAdded for each of the initial ones once I have them? It requires adjustment in the kdeconnect KIO slave so it can handle addresses like kdeconnect://org/kde/kdeconnect/123456 or kdeconnect:udi=/org/kde/kdeconnect/123456 (like mtp kio does) because all Dolphin or the device notifier have is the UDI. It also needs a new device action that matches Portable Media Player with the kdeconnect protocol, similar to mtp. By adjusting the predicate in Dolphin's Places sidebar (and probably the file dialog) to query for the kdeconnect protocol, we can have its places automatically updated without having KDE Connect manually mess with KFilePlaces. Diffs - src/solid/devices/CMakeLists.txt 9271ae1 src/solid/devices/backends/kdeconnect/CMakeLists.txt PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectbattery.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectbattery.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdevice.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdevice.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectmanager.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectmanager.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.cpp PRE-CREATION src/solid/devices/managerbase.cpp eee4de5 Diff: https://git.reviewboard.kde.org/r/123263/diff/ Testing --- With some crash fixes already pushed to plasma-workspace it works pretty well. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid
On April 19, 2015, 8:20 nachm., Albert Vaca Cintora wrote: I don't understand the portable media player part. Does it do something? Besides that, I think we need to fix the issues opened by Lamarque and Alex, but looks good to me :) Kai Uwe Broulik wrote: Solid has been designed in the pre-Smartphone era, it only has a concept of a Portable Media Player, no Smartphone type. I only did what the MTP KIO did, however I do see that we should probably add a Mobile device type for phones, tablets, wearables, and stuff. Markus Slopianka wrote: Why add another type? Just rename Portable Media Player. We need to remain binary and source compatible. - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123263/#review79218 --- On April 5, 2015, 8:56 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123263/ --- (Updated April 5, 2015, 8:56 nachm.) Review request for kdeconnect, Solid, Albert Vaca Cintora, and Emmanuel Pescosta. Repository: solid Description --- This adds a KDE Connect backend to Solid enabling us to show phone battery status in the device notifier, and have the phone appear in the device notifier like an external storage. It is pretty synchronous at the moment. Any ideas how I could improve that? I guess when someone wants to get devices, it creates a new device interface and calls allDevices() or devicesFromQuery() immediately afterwards, so I cannot just do that stuff async and defer population? Or call deviceAdded for each of the initial ones once I have them? It requires adjustment in the kdeconnect KIO slave so it can handle addresses like kdeconnect://org/kde/kdeconnect/123456 or kdeconnect:udi=/org/kde/kdeconnect/123456 (like mtp kio does) because all Dolphin or the device notifier have is the UDI. It also needs a new device action that matches Portable Media Player with the kdeconnect protocol, similar to mtp. By adjusting the predicate in Dolphin's Places sidebar (and probably the file dialog) to query for the kdeconnect protocol, we can have its places automatically updated without having KDE Connect manually mess with KFilePlaces. Diffs - src/solid/devices/CMakeLists.txt 9271ae1 src/solid/devices/backends/kdeconnect/CMakeLists.txt PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectbattery.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectbattery.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdevice.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdevice.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectmanager.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectmanager.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.cpp PRE-CREATION src/solid/devices/managerbase.cpp eee4de5 Diff: https://git.reviewboard.kde.org/r/123263/diff/ Testing --- With some crash fixes already pushed to plasma-workspace it works pretty well. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid
On April 5, 2015, 5:54 p.m., Lamarque Souza wrote: src/solid/devices/backends/kdeconnect/kdeconnectbattery.cpp, line 79 https://git.reviewboard.kde.org/r/123263/diff/1/?file=360131#file360131line79 Is it possible to retrieve a correct value for this and the other values below (timeToEmpty, timeToFull, etc)? Kai Uwe Broulik wrote: I suppose, but that needs implementing on the KDE Connect side Albert Vaca Cintora wrote: From Android we could expose any of these: http://developer.android.com/reference/android/os/BatteryManager.html Which ones would be useful in solid? According to /usr/include/solid/battery.h the ones we really need are: for isPlugged we need BATTERY_PLUGGED_AC, BATTERY_PLUGGED_USB and BATTERY_PLUGGED_WIRELESS. isPowerSupply: I think it is always false in this case. type: always PhoneBattery. chargePercent: BATTERY_PROPERTY_CAPACITY. capacity: BATTERY_PROPERTY_CHARGE_COUNTER. isRechargeable: always true. chargeState: BATTERY_STATUS_CHARGING, BATTERY_STATUS_DISCHARGING, BATTERY_STATUS_FULL and BATTERY_STATUS_NOT_CHARGING; BATTERY_STATUS_UNKNOWN can also be used, but Solid does not expose such a value. - Lamarque --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123263/#review78531 --- On April 5, 2015, 8:56 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123263/ --- (Updated April 5, 2015, 8:56 p.m.) Review request for kdeconnect, Solid, Albert Vaca Cintora, and Emmanuel Pescosta. Repository: solid Description --- This adds a KDE Connect backend to Solid enabling us to show phone battery status in the device notifier, and have the phone appear in the device notifier like an external storage. It is pretty synchronous at the moment. Any ideas how I could improve that? I guess when someone wants to get devices, it creates a new device interface and calls allDevices() or devicesFromQuery() immediately afterwards, so I cannot just do that stuff async and defer population? Or call deviceAdded for each of the initial ones once I have them? It requires adjustment in the kdeconnect KIO slave so it can handle addresses like kdeconnect://org/kde/kdeconnect/123456 or kdeconnect:udi=/org/kde/kdeconnect/123456 (like mtp kio does) because all Dolphin or the device notifier have is the UDI. It also needs a new device action that matches Portable Media Player with the kdeconnect protocol, similar to mtp. By adjusting the predicate in Dolphin's Places sidebar (and probably the file dialog) to query for the kdeconnect protocol, we can have its places automatically updated without having KDE Connect manually mess with KFilePlaces. Diffs - src/solid/devices/CMakeLists.txt 9271ae1 src/solid/devices/backends/kdeconnect/CMakeLists.txt PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectbattery.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectbattery.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdevice.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdevice.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectmanager.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectmanager.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.cpp PRE-CREATION src/solid/devices/managerbase.cpp eee4de5 Diff: https://git.reviewboard.kde.org/r/123263/diff/ Testing --- With some crash fixes already pushed to plasma-workspace it works pretty well. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123263/#review79218 --- I don't understand the portable media player part. Does it do something? Besides that, I think we need to fix the issues opened by Lamarque and Alex, but looks good to me :) - Albert Vaca Cintora On abr. 5, 2015, 1:56 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123263/ --- (Updated abr. 5, 2015, 1:56 p.m.) Review request for kdeconnect, Solid, Albert Vaca Cintora, and Emmanuel Pescosta. Repository: solid Description --- This adds a KDE Connect backend to Solid enabling us to show phone battery status in the device notifier, and have the phone appear in the device notifier like an external storage. It is pretty synchronous at the moment. Any ideas how I could improve that? I guess when someone wants to get devices, it creates a new device interface and calls allDevices() or devicesFromQuery() immediately afterwards, so I cannot just do that stuff async and defer population? Or call deviceAdded for each of the initial ones once I have them? It requires adjustment in the kdeconnect KIO slave so it can handle addresses like kdeconnect://org/kde/kdeconnect/123456 or kdeconnect:udi=/org/kde/kdeconnect/123456 (like mtp kio does) because all Dolphin or the device notifier have is the UDI. It also needs a new device action that matches Portable Media Player with the kdeconnect protocol, similar to mtp. By adjusting the predicate in Dolphin's Places sidebar (and probably the file dialog) to query for the kdeconnect protocol, we can have its places automatically updated without having KDE Connect manually mess with KFilePlaces. Diffs - src/solid/devices/CMakeLists.txt 9271ae1 src/solid/devices/backends/kdeconnect/CMakeLists.txt PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectbattery.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectbattery.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdevice.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdevice.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectmanager.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectmanager.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.cpp PRE-CREATION src/solid/devices/managerbase.cpp eee4de5 Diff: https://git.reviewboard.kde.org/r/123263/diff/ Testing --- With some crash fixes already pushed to plasma-workspace it works pretty well. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid
On abr. 5, 2015, 10:54 a.m., Lamarque Souza wrote: src/solid/devices/backends/kdeconnect/kdeconnectbattery.cpp, line 79 https://git.reviewboard.kde.org/r/123263/diff/1/?file=360131#file360131line79 Is it possible to retrieve a correct value for this and the other values below (timeToEmpty, timeToFull, etc)? Kai Uwe Broulik wrote: I suppose, but that needs implementing on the KDE Connect side From Android we could expose any of these: http://developer.android.com/reference/android/os/BatteryManager.html Which ones would be useful in solid? - Albert --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123263/#review78531 --- On abr. 5, 2015, 1:56 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123263/ --- (Updated abr. 5, 2015, 1:56 p.m.) Review request for kdeconnect, Solid, Albert Vaca Cintora, and Emmanuel Pescosta. Repository: solid Description --- This adds a KDE Connect backend to Solid enabling us to show phone battery status in the device notifier, and have the phone appear in the device notifier like an external storage. It is pretty synchronous at the moment. Any ideas how I could improve that? I guess when someone wants to get devices, it creates a new device interface and calls allDevices() or devicesFromQuery() immediately afterwards, so I cannot just do that stuff async and defer population? Or call deviceAdded for each of the initial ones once I have them? It requires adjustment in the kdeconnect KIO slave so it can handle addresses like kdeconnect://org/kde/kdeconnect/123456 or kdeconnect:udi=/org/kde/kdeconnect/123456 (like mtp kio does) because all Dolphin or the device notifier have is the UDI. It also needs a new device action that matches Portable Media Player with the kdeconnect protocol, similar to mtp. By adjusting the predicate in Dolphin's Places sidebar (and probably the file dialog) to query for the kdeconnect protocol, we can have its places automatically updated without having KDE Connect manually mess with KFilePlaces. Diffs - src/solid/devices/CMakeLists.txt 9271ae1 src/solid/devices/backends/kdeconnect/CMakeLists.txt PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectbattery.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectbattery.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdevice.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdevice.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectmanager.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectmanager.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.cpp PRE-CREATION src/solid/devices/managerbase.cpp eee4de5 Diff: https://git.reviewboard.kde.org/r/123263/diff/ Testing --- With some crash fixes already pushed to plasma-workspace it works pretty well. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid
On April 5, 2015, 5:54 p.m., Lamarque Souza wrote: src/solid/devices/backends/kdeconnect/kdeconnectmanager.cpp, line 116 https://git.reviewboard.kde.org/r/123263/diff/1/?file=360137#file360137line116 Answering your question from this patch's description: yes, I prefer that you call onDeviceAdded() slot for each device appended here. You can also use a watcher in this class' constructor to update m_devices asynchronously. Otherwise, no KdeConnectManager::deviceAdded() signal is emitted during KdeConnectManager startup even though m_devices is not empty. This method should just return the ids from m_devices. Kai Uwe Broulik wrote: Ok, thanks, I wasn't sure how that internally works. So I populate the list async and emit a deviceAdded signal for each of them no matter whether I found them on the first sweep or when they were actually added afterwards. Yes. - Lamarque --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123263/#review78531 --- On April 5, 2015, 3:57 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123263/ --- (Updated April 5, 2015, 3:57 p.m.) Review request for Solid, Albert Vaca Cintora and Emmanuel Pescosta. Repository: solid Description --- This adds a KDE Connect backend to Solid enabling us to show phone battery status in the device notifier, and have the phone appear in the device notifier like an external storage. It is pretty synchronous at the moment. Any ideas how I could improve that? I guess when someone wants to get devices, it creates a new device interface and calls allDevices() or devicesFromQuery() immediately afterwards, so I cannot just do that stuff async and defer population? Or call deviceAdded for each of the initial ones once I have them? It requires adjustment in the kdeconnect KIO slave so it can handle addresses like kdeconnect://org/kde/kdeconnect/123456 or kdeconnect:udi=/org/kde/kdeconnect/123456 (like mtp kio does) because all Dolphin or the device notifier have is the UDI. It also needs a new device action that matches Portable Media Player with the kdeconnect protocol, similar to mtp. By adjusting the predicate in Dolphin's Places sidebar (and probably the file dialog) to query for the kdeconnect protocol, we can have its places automatically updated without having KDE Connect manually mess with KFilePlaces. Diffs - src/solid/devices/CMakeLists.txt 9271ae1 src/solid/devices/backends/kdeconnect/CMakeLists.txt PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectbattery.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectbattery.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdevice.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdevice.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectdeviceinterface.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectmanager.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectmanager.cpp PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.h PRE-CREATION src/solid/devices/backends/kdeconnect/kdeconnectportablemediaplayer.cpp PRE-CREATION src/solid/devices/managerbase.cpp eee4de5 Diff: https://git.reviewboard.kde.org/r/123263/diff/ Testing --- With some crash fixes already pushed to plasma-workspace it works pretty well. Thanks, Kai Uwe Broulik ___ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
