[kmail2] [Bug 358049] URLs that end in . or ? aren't parsed correctly

2016-05-23 Thread Erik Quaeghebeur via KDE Bugzilla 
https://bugs.kde.org/show_bug.cgi?id=358049

Erik Quaeghebeur  changed:

   What|Removed |Added

 CC||kdebugs@equaeghe.nospammail
   ||.net

--- Comment #3 from Erik Quaeghebeur  ---
(In reply to kdex from comment #2)
> No; then the URI wouldn't *end* in the question mark.

Clearly, the parsing code needs to take into account both what valid URLs are
*and* what people type in mails. When a URL comes at the end of a sentence,
people write punctuation after it, such as a period and a question mark. So if
nothing comes after that, i.e., there is white space or a line break, the most
likely situation is that those symbols are punctuation and not part of the URL,
although they could be. So the question is, do those user names in URLs you
mention end with a period?

I tested the following (in 4.14.10):

http://example.com/whatever.
http://example.com/whatever. you
http://example.com/whatever.you

http://example.com/whatever?
http://example.com/whatever? q
http://example.com/whatever?q

In both cases, the first two links in KMail end before the punctuation and the
last one includes the punctuation and what follows. (So, FWIW, I would say this
issue can be CONFIRMED.) This seems a reasonable choice to me. I guess there
need to be a sufficient number of URLs in the wild ending with punctuation
symbols for it to counteract the argument that these symbols are usually not
part of URLs in email messages.

I suggest closing as WONTFIX based on that argument.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs

[kmail2] [Bug 363427] New: unsafe characters incorrectly parsed as part of URL

2016-05-23 Thread Erik Quaeghebeur via KDE Bugzilla 
https://bugs.kde.org/show_bug.cgi?id=363427

Bug ID: 363427
   Summary: unsafe characters incorrectly parsed as part of URL
   Product: kmail2
   Version: 4.14.10
  Platform: Gentoo Packages
OS: Linux
Status: UNCONFIRMED
  Severity: minor
  Priority: NOR
 Component: general
  Assignee: kdepim-bugs@kde.org
  Reporter: kdeb...@equaeghe.nospammail.net

Unsafe characters are incorrectly parsed as part of URL when showing plain text
emails. This sometimes result in spurious ‘dangerous-URL’-warnings .

Consider the following text, a type not uncommon in multipart/alternative
mails:

[Please visit our booth 24-25
http://example.com/][cid:image004.png@01D1B286.A42C3F20][Please visit our booth
24-25
http://example.com/][cid:image004.png@01D1B286.A42C3F20][cid:image012.png@01D19A5C.4369C910]

The following two links are extracted by kmail:

http://example.com/%5D%5Bcid:image004.png@01D1B286.A42C3F20%5D%5BPlease

http://example.com/%5D%5Bcid:image004.png@01D1B286.A42C3F20%5D%5Bcid:image012.png@01D19A5C.4369C910%5D%3Chttp://example.com/

So what happens is that the unsafe characters such as ‘]’, ‘[’, and ‘<’ are
considered part of the URL and then encoded (given the former, the latter makes
sense).
What IMHO should happen is that unsafe characters should be considered as
URL-delimiting, given that they should always be URL-encoded. In fact, this is
usually done by kmail, but in this case, this failed because there was a space
before the initial URL. Namely, consider

[http://www.example.org/][whatever]
[http://www.example.org/] [whatever]
[http://www.example.org/]

[a http://www.example.org/][whatever]
[a http://www.example.org/] [whatever]
[a http://www.example.org/]

In the first set of three, parsing is always correct. In the latter set of
three, it is incorrect for the first line, i.e., a link

http://www.example.org/%5D%5Bwhatever%5D

is generated.

So I think the parsing code should be modified to deal with such cases.

Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs

[kmail2] [Bug 363427] unsafe characters incorrectly parsed as part of URL

2016-05-23 Thread Erik Quaeghebeur via KDE Bugzilla 
https://bugs.kde.org/show_bug.cgi?id=363427

--- Comment #1 from Erik Quaeghebeur  ---
(In reply to Erik Quaeghebeur from comment #0)
>
> [http://www.example.org/][whatever]

Where do I file bugs against the KDE's bug tracking system? ;-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs

[kmail2] [Bug 346390] Cannot add list of contacts to BCC in mail

2016-05-23 Thread Phil thane via KDE Bugzilla 
https://bugs.kde.org/show_bug.cgi?id=346390

--- Comment #12 from Phil thane  ---
Since posting this bug I have switched to Mint 17.3 (KDE version) which uses
KMail 4.14.2. Same problem. Would seem to be a long-standing issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs

[kmail2] [Bug 358049] URLs that end in . or ? aren't parsed correctly

2016-05-23 Thread kdex via KDE Bugzilla 
https://bugs.kde.org/show_bug.cgi?id=358049

--- Comment #4 from kdex  ---
I don't see a clear benefit from teaching people to misunderstand URLs.
Suggesting that they might not end in a dot will naturally break lots of valid
URLs, and the same goes for question marks (and potentially other tokens that I
haven't checked).

Also, expecting that users will put punctuation symbols after their URLs to end
a sentence is a constructed heuristic; the majority of my sent and received
mails actually contain footnotes such as "[1]", which will be completed with
their URLs at the bottom of the mail, line by line. This format is also very
wide-spread and suffers from KMail's heuristic.

Next, observe that this is not just about usernames that might end in
punctuation. See [1] to agree that a dot at the end of a domain is, too, valid
syntax and should be parsed to reflect that. In the case of usernames or other
dynamic parts in a URL, KMail *will* break websites (like [2], which allows
trailing dots in usernames and thus, in their profile page URLs).

[1]
https://webmasters.stackexchange.com/questions/73934/how-can-urls-have-a-dot-at-the-end-e-g-www-bla-de/73937
[2] https://www.npmjs.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs

[kontact] [Bug 363431] New: kontact crashes when closing

2016-05-23 Thread Herr Schmidt via KDE Bugzilla 
https://bugs.kde.org/show_bug.cgi?id=363431

Bug ID: 363431
   Summary: kontact crashes when closing
   Product: kontact
   Version: unspecified
  Platform: Debian testing
OS: Linux
Status: UNCONFIRMED
  Keywords: drkonqi
  Severity: crash
  Priority: NOR
 Component: general
  Assignee: kdepim-bugs@kde.org
  Reporter: wettererschein...@bb-goettingen.de

Application: kontact (4.14.10)
KDE Platform Version: 4.14.14
Qt Version: 4.8.7
Operating System: Linux 4.5.0-2-amd64 x86_64
Distribution: Debian GNU/Linux testing (stretch)

-- Information about the crash:
Dear maintainers,
kontact was opened automatically after login because it was open when I shutted
down my computer last time. I just looked at the task planner and clicked on
akregator (it said this is a different instance or sth like that and the window
has to brought up to foreground, but that never happened it just showed the
window from the planner before) then I switched to calendar and planner back
and forth. I decided to quit and hitted the window quit button at the upper
right window corner. Then this dialogue about crashing came up. This happened
just a few minutes ago as well in a similar situation.

Things I noticed:
First time this happened I quitted because I did not see my mouse cursor
anymore, although it was obviously there as several buttons where highlited
when the invisible mouse passed them. This just happend again and might be
correlated to using the console with Ctrl-Alt-F1 and installing the debug
symbols. (It happened when I switched back (Ctrl-Alt-F7) while the install was
going. Switching back to the console and after the install back to KDE made the
mouse visible again.

Thanks for your work!

The crash can be reproduced sometimes.

-- Backtrace:
Application: Kontact (kontact), signal: Segmentation fault
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
[Current thread is 1 (Thread 0x7f40b8927940 (LWP 24599))]

Thread 4 (Thread 0x7f4098ab8700 (LWP 24608)):
#0  pthread_cond_wait@@GLIBC_2.3.2 () at
../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
#1  0x7f40b5047f5d in ?? () from /usr/lib/x86_64-linux-gnu/libQtWebKit.so.4
#2  0x7f40b5047fb9 in ?? () from /usr/lib/x86_64-linux-gnu/libQtWebKit.so.4
#3  0x7f40afb4f454 in start_thread (arg=0x7f4098ab8700) at
pthread_create.c:334
#4  0x7f40b5df6e5d in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Thread 3 (Thread 0x7f40581ad700 (LWP 24609)):
#0  pthread_cond_wait@@GLIBC_2.3.2 () at
../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
#1  0x7f40b4d6bef1 in ?? () from /usr/lib/x86_64-linux-gnu/libQtWebKit.so.4
#2  0x7f40b5078536 in ?? () from /usr/lib/x86_64-linux-gnu/libQtWebKit.so.4
#3  0x7f40afb4f454 in start_thread (arg=0x7f40581ad700) at
pthread_create.c:334
#4  0x7f40b5df6e5d in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Thread 2 (Thread 0x7f40428be700 (LWP 24667)):
#0  0x7f40b5deddcd in poll () at ../sysdeps/unix/syscall-template.S:84
#1  0x7f40af66739c in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
#2  0x7f40af6674ac in g_main_context_iteration () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
#3  0x7f40b65ed266 in QEventDispatcherGlib::processEvents
(this=0x7f403c0008c0, flags=...) at kernel/qeventdispatcher_glib.cpp:427
#4  0x7f40b65bb18f in QEventLoop::processEvents
(this=this@entry=0x7f40428bdc90, flags=...) at kernel/qeventloop.cpp:149
#5  0x7f40b65bb4f5 in QEventLoop::exec (this=this@entry=0x7f40428bdc90,
flags=...) at kernel/qeventloop.cpp:204
#6  0x7f40b64aa549 in QThread::exec (this=) at
thread/qthread.cpp:538
#7  0x7f40b64ace3c in QThreadPrivate::start (arg=0x244ca10) at
thread/qthread_unix.cpp:352
#8  0x7f40afb4f454 in start_thread (arg=0x7f40428be700) at
pthread_create.c:334
#9  0x7f40b5df6e5d in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Thread 1 (Thread 0x7f40b8927940 (LWP 24599)):
[KCrash Handler]
#6  QAbstractSlider::maximum (this=0x20) at widgets/qabstractslider.cpp:366
#7  0x7f40b7d30584 in KViewStateSaverPrivate::restoreScrollBarState
(this=0x22ca1a0) at
/build/kde4libs-3hgzgp/kde4libs-4.14.14/kdeui/itemviews/kviewstatesaver.cpp:67
#8  KViewStateSaver::qt_static_metacall (_o=, _id=, _a=, _c=) at
/build/kde4libs-3hgzgp/kde4libs-4.14.14/obj-x86_64-linux-gnu/kdeui/kviewstatesaver.moc:52
#9  0x7f40b65d6db1 in QObject::event (this=0x4a5e900, e=) at
kernel/qobject.cpp:1222
#10 0x7f40b6fe190c in QApplicationPrivate::notify_helper
(this=this@entry=0x22cf300, receiver=receiver@entry=0x4a5e900,
e=e@entry=0x4fc7120) at kernel/qapplication.cpp:4570
#11 0x7f40b6fe8846 in QApplication::notify (this=this@entry=0x7fffda223c40,
receiver=receiver@entry=0x4a5e900, e=e@entry=0x4fc7120) at
kernel/qapplication.cpp:4356
#12 0x7f40b7d623ca in KApplication::notify (this=0x7fffda223c40,
receive

[kdelibs] [Bug 363431] kontact crashes when closing

2016-05-23 Thread Allen Winter via KDE Bugzilla 
https://bugs.kde.org/show_bug.cgi?id=363431

Allen Winter  changed:

   What|Removed |Added

  Component|general |kdeui
Product|kontact |kdelibs
 CC||win...@kde.org
Version|unspecified |4.14.0
   Assignee|kdepim-bugs@kde.org |kdelibs-b...@kde.org

--- Comment #1 from Allen Winter  ---
this is a bug in kdelibs/itemviews. reassigning

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs

[kleopatra] [Bug 355084] key:// link not working in verify result html

2016-05-23 Thread Andre Heinecke via KDE Bugzilla 
https://bugs.kde.org/show_bug.cgi?id=355084

Andre Heinecke  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
  Latest Commit||http://commits.kde.org/kleo
   ||patra/a0c04348d7d2067fef3f6
   ||35f17612c56e2a951fe
 Resolution|--- |FIXED

--- Comment #2 from Andre Heinecke  ---
Git commit a0c04348d7d2067fef3f635f17612c56e2a951fe by Andre Heinecke.
Committed on 23/05/2016 at 16:00.
Pushed by aheinecke into branch 'master'.

Fix key links in results

This handles the keyLink directly in the resultitemwidget and
fixes the behavior, by matching the expected format with the
actual keylink format.

M  +14   -5src/crypto/gui/resultitemwidget.cpp

http://commits.kde.org/kleopatra/a0c04348d7d2067fef3f635f17612c56e2a951fe

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs

[kmail2] [Bug 358049] URLs that end in . or ? aren't parsed correctly

2016-05-23 Thread Erik Quaeghebeur via KDE Bugzilla 
https://bugs.kde.org/show_bug.cgi?id=358049

--- Comment #5 from Erik Quaeghebeur  ---
(In reply to kdex from comment #4)

Thanks for your reply.

> I don't see a clear benefit from teaching people to misunderstand URLs.
> Suggesting that they might not end in a dot will naturally break lots of
> valid URLs, and the same goes for question marks (and potentially other
> tokens that I haven't checked).

Well, that is an URL entry issue. KMail could suggest people to encapsulate
URLs it detects in mails about to be sent out using <...>.

> Also, expecting that users will put punctuation symbols after their URLs to
> end a sentence is a constructed heuristic; the majority of my sent and
> received mails actually contain footnotes such as "[1]", which will be
> completed with their URLs at the bottom of the mail, line by line. This
> format is also very wide-spread and suffers from KMail's heuristic.

Indeed this format is common. URLs ending with periods or question marks less
so, and that is where it breaks. Nevertheless a valid point.

> Next, observe that this is not just about usernames that might end in
> punctuation. See [1] to agree that a dot at the end of a domain is, too,
> valid syntax and should be parsed to reflect that.

I would need to be convinced that this is a practical issue. I haven't come
across mails with domains in this format. I have come across plenty of mails
with periods as punctuation at the end of URLs, i.e., that won't resolve if the
period is parsed as part of the URL.

> In the case of usernames
> or other dynamic parts in a URL, KMail *will* break websites (like [2],
> which allows trailing dots in usernames and thus, in their profile page
> URLs).

Indeed; that is problematic. You've convinced me that this is a real issue.
Nevertheless, always parsing periods as part of the URL will also break links.
The KMail devs will have to decide what is most important.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs

[kcalcore] [Bug 363454] New: [vcc.y:445]: (warning) Size of pointer 'p2' used instead of size of its data.

2016-05-23 Thread via KDE Bugzilla 
https://bugs.kde.org/show_bug.cgi?id=363454

Bug ID: 363454
   Summary: [vcc.y:445]: (warning) Size of pointer 'p2' used
instead of size of its data.
   Product: kcalcore
   Version: git
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: minor
  Priority: NOR
 Component: general
  Assignee: kdepim-bugs@kde.org
  Reporter: dcb...@hotmail.com

Source code is

p2 = malloc(sizeof(char *) * (strlen(p1)+strlen(value)+1));

Suggest new code

p2 = malloc( strlen(p1) + strlen(value) + 1);



Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs