[Bug 151155] computed size for big mail foders is wrong. It shows 16 777 216, 0 TB.
--- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=151155 --- Additional Comments From jcd tribudubois net 2008-01-02 09:15 --- It looks like I forgot one change in kmail/foldertreebase.cpp that is now required. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[Bug 151155] computed size for big mail foders is wrong. It shows 16 777 216, 0 TB.
--- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=151155 jcd tribudubois net changed: What|Removed |Added Attachment #22749|0 |1 is obsolete|| --- Additional Comments From jcd tribudubois net 2008-01-02 09:20 --- Created an attachment (id=22794) -- (http://bugs.kde.org/attachment.cgi?id=22794action=view) Patch for the enterprise branch of kdepim This is a patch to correct the integer overflow in folder size computation for the enterprise branch of kdepim. I tested it on an i686 platform (kubuntu 7.10) and the size is now displayed correctly if the folder is 2GB. This patch is a corrected version of the previous one (adding foldertreebase.cpp fix) and should apply cleanly on the enterprise branch of kdepim. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[Bug 151155] computed size for big mail foders is wrong. It shows 16 777 216, 0 TB.
--- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=151155 jcd tribudubois net changed: What|Removed |Added Attachment #22644|0 |1 is obsolete|| --- Additional Comments From jcd tribudubois net 2007-12-29 10:50 --- Created an attachment (id=22749) -- (http://bugs.kde.org/attachment.cgi?id=22749action=view) Patch for the enterprise branch of kdepim This is a patch to correct the integer overflow in folder size computation for the enterprise branch of kdepim. I tested it on an i686 platform (kubuntu 7.10) and the size is now displayed correctly if the folder is 2GB. This patch is a corrected version of the previous one and should apply cleanly on the enterprise branch of kdepim. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[Bug 151155] computed size for big mail foders is wrong. It shows 16 777 216, 0 TB.
--- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=151155 --- Additional Comments From Thomas.McGuire gmx net 2007-12-28 14:15 --- Patch for the enterprise branch of kdepim That patch doesn't apply cleanly, your enterprise version is too outdated (in paticular: favoritefolderview.cpp). use svn co svn://anonsvn.kde.org/home/kde/branches/kdepim/enterprise to get the lastest version, then do your changes, then use svn diff to generate the patch. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[Bug 151155] computed size for big mail foders is wrong. It shows 16 777 216, 0 TB.
--- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=151155 --- Additional Comments From jcd tribudubois net 2007-12-28 14:54 --- Sorry, I was working with whatever source package is provided with kubuntu 7.10. I'll revise the patch for the enterprise/LATEST branch. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[Bug 151155] computed size for big mail foders is wrong. It shows 16 777 216, 0 TB.
--- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=151155 --- Additional Comments From Thomas.McGuire gmx net 2007-12-21 17:44 --- SVN commit 751307 by tmcguire: Fix the folder size in two more places. Thanks to Jean-Christophe for noticing this. CCBUG: 151155 M +1 -1 kmail/kmfoldertree.cpp M +1 -1 libkdepim/kfoldertree.cpp WebSVN link: http://websvn.kde.org/?view=revrevision=751307 ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[Bug 151155] computed size for big mail foders is wrong. It shows 16 777 216, 0 TB.
--- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=151155 --- Additional Comments From jcd tribudubois net 2007-12-20 13:31 --- Looking at the kmail code, it seems the size is always considered as a signed int. Therefore the max size that can be computed is 2GB. So it looks like all the size computation API will need to be reworked ... ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[Bug 151155] computed size for big mail foders is wrong. It shows 16 777 216, 0 TB.
--- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=151155 --- Additional Comments From winter kde org 2007-12-20 19:54 --- quint64 This type is guaranteed to be 64-bit on all platforms supported by Qt. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[Bug 151155] computed size for big mail foders is wrong. It shows 16 777 216, 0 TB.
--- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=151155 --- Additional Comments From jcd tribudubois net 2007-12-20 21:43 --- quint64 seems to be a QT4 thing. Is QT3 not supported anymore? What is the official position about this kind of portability (Sorry I don't follow the KDE development that close)? ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[Bug 151155] computed size for big mail foders is wrong. It shows 16 777 216, 0 TB.
--- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=151155 --- Additional Comments From winter kde org 2007-12-20 22:05 --- Try Q_INT64 for KDE3/Qt3 We are concentrating on fixing stuff for KDE4/Qt4. But I will look at your patches for KDE3/Qt3. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[Bug 151155] computed size for big mail foders is wrong. It shows 16 777 216, 0 TB.
--- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=151155 --- Additional Comments From jcd tribudubois net 2007-12-20 22:37 --- I am working with Kubuntu (7.10) as may desktop/development system so I will base my patch on the Ubuntu source package. Is this acceptable? ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[Bug 151155] computed size for big mail foders is wrong. It shows 16 777 216, 0 TB.
--- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. http://bugs.kde.org/show_bug.cgi?id=151155 --- Additional Comments From Thomas.McGuire gmx net 2007-12-20 23:55 --- OK that was quick. Too bad I was not fast enough to make a first contribution to the project. Uups, sorry, I didn't know you were working on it too. While this patch seems OK (Sorry I haven't tested it), would it make sense to use Q_INT64 instead of qint64. Q_INT64 is defined in both QT3 and QT4 while qint64 is QT4 specific. Well, my patch was commited to trunk, which is Qt4-only anyway. If this patch is available for the 3.5 branch, it can of course use Q_INT64. I guess there are still people/distributions using QT3/KDE3 out there ... Once again I am not sure what is the policy regarding keeping compatibility with previous versions of QT/KDE. Well, I don't have time to work on the 3.5 version. However, if someone sends a patch against the 3.5 branch, I'll commit it. So you can probably convert this patch to the 3.5 version. However, I think the actual version you are using is the enterprise branch (branches/kdepim/enterprise), since the normal 3.5 branch doesn't have this feature. Anyway, if you manage to convert this patch to the enterprise branch (which is probably the version of the ubuntu source package), I'll commit it. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
