[Bug 174942] Forwarding mails containing non-ascii characters using a filter can produce garbage

2009-03-18 Thread Thomas McGuire
https://bugs.kde.org/show_bug.cgi?id=174942





--- Comment #5 from Thomas McGuire   2009-03-18 10:32:24 ---
SVN commit 940772 by tmcguire:

Backport r940441 by tmcguire from trunk to the 4.2 branch:

Don't produce garbage when forwarding a mail with a filter.

For this, I had to remove the code duplication in
KMFilterActionForward::process()
and use KMMessage::createForward() instead.

This uncovered a bug in createForward (content type boundary was not saved) and
a
small bug in the template parser.

Also, I added a KMMessage::dump() function to help with debugging mimelib 
related troubles.

Not perfect yet, the way the template parser copies the message needs to be
improved, right now, when forwarding a signed message, the signed text gets
replaced with the template text, resulting in an invalid signature ...

CCBUG: 174942



 M  +11 -72kmfilteraction.cpp  
 M  +44 -7 kmmessage.cpp  
 M  +22 -1 kmmessage.h  
 M  +1 -0  templateparser.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=940772

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[Bug 174942] Forwarding mails containing non-ascii characters using a filter can produce garbage

2009-03-17 Thread Thomas McGuire
https://bugs.kde.org/show_bug.cgi?id=174942


Thomas McGuire  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Comment #4 from Thomas McGuire   2009-03-17 14:59:07 ---
SVN commit 940441 by tmcguire:

Don't produce garbage when forwarding a mail with a filter.

For this, I had to remove the code duplication in
KMFilterActionForward::process()
and use KMMessage::createForward() instead.

This uncovered a bug in createForward (content type boundary was not saved) and
a
small bug in the template parser.

Also, I added a KMMessage::dump() function to help with debugging mimelib 
related troubles.

Not perfect yet, the way the template parser copies the message needs to be
improved, right now, when forwarding a signed message, the signed text gets
replaced with the template text, resulting in an invalid signature ...

BUG: 174942


 M  +11 -72kmfilteraction.cpp  
 M  +44 -7 kmmessage.cpp  
 M  +22 -1 kmmessage.h  
 M  +1 -0  templateparser.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=940441

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[Bug 174942] Forwarding mails containing non-ascii characters using a filter can produce garbage

2009-03-16 Thread Thomas McGuire
https://bugs.kde.org/show_bug.cgi?id=174942


Thomas McGuire  changed:

   What|Removed |Added

Version|1.9.9   |1.11.1




-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[Bug 174942] Forwarding mails containing non-ascii characters using a filter can produce garbage

2009-03-15 Thread Michael Leupold
https://bugs.kde.org/show_bug.cgi?id=174942





--- Comment #3 from Michael Leupold   2009-03-15 13:13:18 
---
Created an attachment (id=32133)
 --> (http://bugs.kde.org/attachment.cgi?id=32133)
Generated forward mail

This is the forward that was generated by the filter.
(shadowed email addresses, message-id and removed part of the route)

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[Bug 174942] Forwarding mails containing non-ascii characters using a filter can produce garbage

2009-03-15 Thread Michael Leupold
https://bugs.kde.org/show_bug.cgi?id=174942





--- Comment #2 from Michael Leupold   2009-03-15 13:12:39 
---
Created an attachment (id=32132)
 --> (http://bugs.kde.org/attachment.cgi?id=32132)
Original mail

This is the original mail I sent.
(shadowed email addresses, message-id and removed part of the route)

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[Bug 174942] Forwarding mails containing non-ascii characters using a filter can produce garbage

2009-03-15 Thread Michael Leupold
https://bugs.kde.org/show_bug.cgi?id=174942


Michael Leupold  changed:

   What|Removed |Added

   Keywords||triaged
 Status|UNCONFIRMED |NEW
 CC||le...@confuego.org
 AssignedTo|bugsquad-tri...@kde.org |kdepim-bugs@kde.org
Summary|filters inline forwarding   |Forwarding mails containing
   |of 8bit works differ then   |non-ascii characters using
   |manual forwarding + added   |a filter can produce
   |garbage symbols |garbage
 Ever Confirmed|0   |1




--- Comment #1 from Michael Leupold   2009-03-15 13:08:57 
---
I can reproduce this behaviour using the following instructions:
1. Add a new incoming mail filter.
2. Set it to forward messages to another account
3. Send yourself a mail that triggers this filter. Add non-ascii characters
(eg. chinese, cyrillic, ...) and let KMail choose the encoding automatically.
4. Wait for the message to be sent and forwarded using the filter.

Result: The original message displays correctly. The forwarded message is
displayed encoded. It actually looks as if the encoded mime-part was inlined
without adding appropriate mime-headers (original message encoded using base64,
forwarded mail is sent as 7bit).

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs