[Bug 260751] Kmail was in the background when crash occured
https://bugs.kde.org/show_bug.cgi?id=260751 S. Burmeister changed: What|Removed |Added CC||sven.burmeis...@gmx.net -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[Bug 260751] Kmail was in the background when crash occured
https://bugs.kde.org/show_bug.cgi?id=260751 Christophe Giboudeaux changed: What|Removed |Added CC||robby.engelm...@igfs-ev.de --- Comment #6 from Christophe Giboudeaux 2011-09-05 22:43:34 --- *** Bug 281425 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[Bug 260751] Kmail was in the background when crash occured
https://bugs.kde.org/show_bug.cgi?id=260751 Christophe Giboudeaux changed: What|Removed |Added CC||otter...@gmail.com --- Comment #7 from Christophe Giboudeaux 2011-09-06 13:49:48 --- *** Bug 281477 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[Bug 260751] Kmail was in the background when crash occured
https://bugs.kde.org/show_bug.cgi?id=260751 Laurent Montel changed: What|Removed |Added CC||mon...@kde.org --- Comment #1 from Laurent Montel 2010-12-20 09:59:28 --- Ok I can't see in code why it crashs, but perhaps a deleteLater() is calling by an other function. -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[Bug 260751] Kmail was in the background when crash occured
https://bugs.kde.org/show_bug.cgi?id=260751 omega changed: What|Removed |Added CC||biasq...@inwind.it -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[Bug 260751] Kmail was in the background when crash occured
https://bugs.kde.org/show_bug.cgi?id=260751 --- Comment #2 from omega 2010-12-31 11:44:03 --- Created an attachment (id=55409) --> (http://bugs.kde.org/attachment.cgi?id=55409) New crash information added by DrKonqi kmail (2.0.89) on KDE Platform 4.5.90 (4.6 RC1) using Qt 4.7.1 - What I was doing when the application crashed: i had this crash when i had a kmail conflit (maybe header of message) -- Backtrace (Reduced): #6 QCoreApplication::postEvent (receiver=0x14fc280, event=0x13ab3d0, priority=0) at kernel/qcoreapplication.cpp:1133 #7 0x7fd3847576bc in KPIM::AgentProgressMonitor::Private::instanceStatusChanged (this=0x15c16c0, instance=...) at ../../libkdepim/agentprogressmonitor.cpp:85 #8 0x7fd38475775a in KPIM::AgentProgressMonitor::qt_metacall (this=0x15c1590, _c=QMetaObject::InvokeMetaMethod, _id=, _a=0x7fff94f4ec10) at ./agentprogressmonitor.moc:78 [...] #10 0x7fd386cab435 in Akonadi::AgentManager::instanceStatusChanged (this=, _t1=) at ./agentmanager.moc:177 #11 0x7fd386cafb6a in Akonadi::AgentManagerPrivate::agentInstanceStatusChanged (this=0xbb50b0, identifier=, status=0, msg=...) at ../../akonadi/agentmanager.cpp:129 -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[Bug 260751] Kmail was in the background when crash occured
https://bugs.kde.org/show_bug.cgi?id=260751 Tobias Koenig changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution||FIXED --- Comment #3 from Tobias Koenig 2011-01-02 16:47:01 --- commit e2af53f0794533454a372db970e5d8587294f084 branch master Author: Tobias Koenig Date: Sun Jan 2 16:33:39 2011 +0100 Do not crash on invalid progress item A KPIM::ProgressItem can be deleted at any time, so keep a QPointer on it and check for validity before accessing it. BUG: 260751 diff --git a/libkdepim/agentprogressmonitor.cpp b/libkdepim/agentprogressmonitor.cpp index 320586a..afb6977 100644 --- a/libkdepim/agentprogressmonitor.cpp +++ b/libkdepim/agentprogressmonitor.cpp @@ -19,9 +19,11 @@ #include "agentprogressmonitor.h" +#include + #include -#include +#include using namespace Akonadi; using namespace KPIM; @@ -43,7 +45,7 @@ class AgentProgressMonitor::Private AgentProgressMonitor *const q; AgentInstance agent; -ProgressItem *const item; +QPointer const item; }; void AgentProgressMonitor::Private::abort() @@ -53,10 +55,12 @@ void AgentProgressMonitor::Private::abort() void AgentProgressMonitor::Private::instanceProgressChanged( const AgentInstance &instance ) { - if( agent == instance ) { + if ( !item ) +return; + + if ( agent == instance ) { agent = instance; -// kDebug() << "Progress changed to" << agent.progress(); -if( agent.progress() >= 0 ) { +if ( agent.progress() >= 0 ) { item->setProgress( agent.progress() ); } } @@ -64,28 +68,25 @@ void AgentProgressMonitor::Private::instanceProgressChanged( const AgentInstance void AgentProgressMonitor::Private::instanceStatusChanged( const AgentInstance &instance ) { - if( agent == instance ) { + if ( !item ) +return; + + if ( agent == instance ) { agent = instance; -// kDebug() << "Status changed to" << agent.status() << "message" << agent.statusMessage(); item->setStatus( agent.statusMessage() ); -switch( agent.status() ) { +switch ( agent.status() ) { case AgentInstance::Idle: - { item->setComplete(); break; - } case AgentInstance::Running: - { break; - } case AgentInstance::Broken: - { item->disconnect( q ); // avoid abort call item->cancel(); item->setComplete(); break; - } - default: Q_ASSERT( false ); + default: +Q_ASSERT( false ); } } } diff --git a/libkdepim/agentprogressmonitor.h b/libkdepim/agentprogressmonitor.h index 30403d2..da3b252 100644 --- a/libkdepim/agentprogressmonitor.h +++ b/libkdepim/agentprogressmonitor.h @@ -40,8 +40,7 @@ class AgentProgressMonitor : public QObject protected: // used by our friend ProgressManager -AgentProgressMonitor( const Akonadi::AgentInstance &agent, -ProgressItem *item ); +AgentProgressMonitor( const Akonadi::AgentInstance &agent, ProgressItem *item ); ~AgentProgressMonitor(); private: @@ -51,7 +50,6 @@ class AgentProgressMonitor : public QObject Q_PRIVATE_SLOT( d, void abort() ) Q_PRIVATE_SLOT( d, void instanceProgressChanged( const Akonadi::AgentInstance& ) ) Q_PRIVATE_SLOT( d, void instanceStatusChanged( const Akonadi::AgentInstance& ) ) - }; } -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[Bug 260751] Kmail was in the background when crash occured
https://bugs.kde.org/show_bug.cgi?id=260751 --- Comment #4 from Tobias Koenig 2011-01-02 17:03:09 --- *** Bug 261487 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs