[Bug 279809] KMail2 crash on viewing mail in gb2312 encoding, edit to UTF-8 fixes it

2011-08-17 Thread Laurent Montel
https://bugs.kde.org/show_bug.cgi?id=279809


Laurent Montel  changed:

   What|Removed |Added

 CC||mon...@kde.org




--- Comment #1 from Laurent Montel   2011-08-17 21:32:31 ---
backtrace ?

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[Bug 279809] KMail2 crash on viewing mail in gb2312 encoding, edit to UTF-8 fixes it

2011-08-17 Thread Laurent Montel
https://bugs.kde.org/show_bug.cgi?id=279809





--- Comment #2 from Laurent Montel   2011-08-17 21:34:55 ---
I try your method but works fine here no crash.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[Bug 279809] KMail2 crash on viewing mail in gb2312 encoding, edit to UTF-8 fixes it

2011-08-17 Thread Oliver
https://bugs.kde.org/show_bug.cgi?id=279809





--- Comment #3 from Oliver   2011-08-17 22:02:17 ---
I'm afraid the backtrace won't be of much help. I'll try to get kdepim to
rebuild with debugging. This one is without:

http://heesakkers.info/showandtell/kmail-20110817-235648.kcrash.txt

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[Bug 279809] KMail2 crash on viewing mail in gb2312 encoding, edit to UTF-8 fixes it

2011-08-17 Thread Laurent Montel
https://bugs.kde.org/show_bug.cgi?id=279809





--- Comment #4 from Laurent Montel   2011-08-17 22:04:38 ---
Thanks.
Perhaps you can forward email in private if possible.
Perhaps I will able to reproduce it.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[Bug 279809] KMail2 crash on viewing mail in gb2312 encoding, edit to UTF-8 fixes it

2011-08-17 Thread Oliver
https://bugs.kde.org/show_bug.cgi?id=279809





--- Comment #5 from Oliver   2011-08-17 22:39:52 ---
The debugging rebuild was surprisingly simple:
http://heesakkers.info/showandtell/kmail-20110818-003415.kcrash.txt

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[Bug 279809] KMail2 crash on viewing mail in gb2312 encoding, edit to UTF-8 fixes it

2011-08-28 Thread Christophe Giboudeaux
https://bugs.kde.org/show_bug.cgi?id=279809





--- Comment #6 from Christophe Giboudeaux   2011-08-28 
23:22:54 ---
pasting inline: 
Thread 3 (Thread 80fc041c0 (LWP 100481/kmail)):
[KCrash Handler]
#7  0x000802ea9717 in KMime::Content::decodedText () from
/usr/local/kde4/lib/libkmime.so.5
#8  0x000808d4bea9 in
MessageViewer::ObjectTreeParser::processTextHtmlSubtype () from
/usr/local/kde4/lib/libmessageviewer.so.5
#9  0x000808cfde22 in (anonymous
namespace)::TextHtmlBodyPartFormatter::process () from
/usr/local/kde4/lib/libmessageviewer.so.5
#10 0x000808d5c648 in
MessageViewer::ObjectTreeParser::parseObjectTreeInternal () from
/usr/local/kde4/lib/libmessageviewer.so.5
#11 0x000808d8cb2e in MessageViewer::ViewerPrivate::parseContent () from
/usr/local/kde4/lib/libmessageviewer.so.5
#12 0x000808d8e12b in MessageViewer::ViewerPrivate::displayMessage () from
/usr/local/kde4/lib/libmessageviewer.so.5
#13 0x000808d90196 in MessageViewer::ViewerPrivate::updateReaderWin () from
/usr/local/kde4/lib/libmessageviewer.so.5
#14 0x000808da1e3d in MessageViewer::ViewerPrivate::qt_metacall () from
/usr/local/kde4/lib/libmessageviewer.so.5
#15 0x0008049f877a in QMetaObject::activate () from
/usr/local/lib/qt4/libQtCore.so.4

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[Bug 279809] KMail2 crash on viewing mail in gb2312 encoding, edit to UTF-8 fixes it

2011-08-29 Thread Laurent Montel
https://bugs.kde.org/show_bug.cgi?id=279809





--- Comment #7 from Laurent Montel   2011-08-29 07:27:34 ---
Christophe do you success to reproduce it ?

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[Bug 279809] KMail2 crash on viewing mail in gb2312 encoding, edit to UTF-8 fixes it

2011-08-29 Thread Christophe Giboudeaux
https://bugs.kde.org/show_bug.cgi?id=279809





--- Comment #8 from Christophe Giboudeaux   2011-08-29 
12:39:08 ---
no, maybe a real message using chinese symbols would help.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[Bug 279809] KMail2 crash on viewing mail in gb2312 encoding, edit to UTF-8 fixes it

2011-09-26 Thread Axel Gonzalez
https://bugs.kde.org/show_bug.cgi?id=279809


Axel Gonzalez  changed:

   What|Removed |Added

 CC||l...@e-shell.net




--- Comment #9 from Axel Gonzalez   2011-09-26 19:41:40 ---
I tested this with kdepim-4.7.1 and kdepimlibs-4.7.1 so YMMV

The problem is a NULL pointer reference in Content::decodedText() ,
kmime/kmime_content.cpp

This patch fixes it. The code is borrowed from Content::fromUnicodeString().

--- kmime/kmime_content.cpp.orig2011-09-26 13:33:53.0 -0500
+++ kmime/kmime_content.cpp 2011-09-26 14:35:15.0 -0500
@@ -408,6 +408,12 @@
   QTextCodec *codec =
 KGlobal::charsets()->codecForName( QLatin1String( contentType()->charset()
), ok );

+  if ( !ok  || codec == NULL ) { // no suitable codec found => try local
settings and hope the best ;-)
+codec = KGlobal::locale()->codecForEncoding();
+QByteArray chset = KGlobal::locale()->encoding();
+contentType()->setCharset( chset );
+  }
+
   QString s = codec->toUnicode( d_ptr->body.data(), d_ptr->body.length() );

   if ( trimText || removeTrailingNewlines ) {

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[Bug 279809] KMail2 crash on viewing mail in gb2312 encoding, edit to UTF-8 fixes it

2011-09-26 Thread Oliver
https://bugs.kde.org/show_bug.cgi?id=279809





--- Comment #10 from Oliver   2011-09-26 20:05:04 ---
Yes, patching kdepimlibs4 with this patch fixes the problem for me. Great work,
thanks!

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[Bug 279809] KMail2 crash on viewing mail in gb2312 encoding, edit to UTF-8 fixes it

2011-09-27 Thread Laurent Montel
https://bugs.kde.org/show_bug.cgi?id=279809


Laurent Montel  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
   Version Fixed In||4.7.2
 Resolution||FIXED




--- Comment #11 from Laurent Montel   2011-09-27 07:09:29 ---
Git commit 8fc508c5f90149f8b97e0f3560f81f92b2bea7ac by Montel Laurent.
Committed on 27/09/2011 at 09:08.
Pushed by mlaurent into branch 'master'.

Fix Bug 279809 - KMail2 crash on viewing mail in gb2312 encoding, edit to UTF-8
fixes it

Patch from Axel Gonzalez tested by Oliver
The code is borrowed from Content::fromUnicodeString().
FIXED-IN:4.7.2
BUG: 279809

M  +6-1kmime/kmime_content.cpp

http://commits.kde.org/kdepimlibs/8fc508c5f90149f8b97e0f3560f81f92b2bea7ac

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[Bug 279809] KMail2 crash on viewing mail in gb2312 encoding, edit to UTF-8 fixes it

2011-09-27 Thread Laurent Montel
https://bugs.kde.org/show_bug.cgi?id=279809





--- Comment #12 from Laurent Montel   2011-09-27 07:10:35 ---
Git commit 027da4d98f9b9099a51db4e8091de425acbea0f9 by Montel Laurent.
Committed on 27/09/2011 at 09:08.
Pushed by mlaurent into branch 'KDE/4.7'.

Fix Bug 279809 - KMail2 crash on viewing mail in gb2312 encoding, edit to UTF-8
fixes it

Patch from Axel Gonzalez tested by Oliver
The code is borrowed from Content::fromUnicodeString().
FIXED-IN:4.7.2
BUG: 279809
(cherry picked from commit 8fc508c5f90149f8b97e0f3560f81f92b2bea7ac)

M  +6-1kmime/kmime_content.cpp

http://commits.kde.org/kdepimlibs/027da4d98f9b9099a51db4e8091de425acbea0f9

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[Bug 279809] KMail2 crash on viewing mail in gb2312 encoding, edit to UTF-8 fixes it

2011-09-27 Thread Laurent Montel
https://bugs.kde.org/show_bug.cgi?id=279809





--- Comment #13 from Laurent Montel   2011-09-27 07:11:03 ---
Ok thanks for this patch.
I applied to 4.7.2/master.
Regards

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs