[Bug 292283] Filters don't work because headers are not downloaded
https://bugs.kde.org/show_bug.cgi?id=292283 --- Comment #3 from András Manţia --- Git commit 8846d44b217108351c35f8afd883f72ee88388ec by Andras Mantia. Committed on 06/07/2012 at 11:12. Pushed by amantia into branch 'KDE/4.8'. Backport part of the filter fix: this is the actual fix, the rest were optimizations and safety checks, but it is difficult to backport. An unwanted side-effect might be that more data is downloaded than before, based on the type of filters used. FIXED-IN: 4.8.5 Related: bug 287752, bug 288109, bug 286043, bug 295484, bug 302337, bug 295000, bug 295684, bug 293768, bug 275233, bug 293918, bug 284310, bug 286364, bug 283682 M +0-1mailfilteragent/mailfilteragent.cpp http://commits.kde.org/kdepim/8846d44b217108351c35f8afd883f72ee88388ec -- You are receiving this mail because: You are the assignee for the bug. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[Bug 292283] Filters don't work because headers are not downloaded
https://bugs.kde.org/show_bug.cgi?id=292283 András Manţia changed: What|Removed |Added Version Fixed In||4.9 Latest Commit|http://commits.kde.org/kdep |http://commits.kde.org/kdep |im/d64d61b470c56b92294f6ade |im/e3a03f1d704838a9ced4ff41 |e6d74305a217628d|358785392774ae69 --- Comment #2 from András Manţia --- Git commit e3a03f1d704838a9ced4ff41358785392774ae69 by Andras Mantia. Committed on 04/07/2012 at 17:35. Pushed by amantia into branch 'KDE/4.9'. (Backport filter fix from master) A biggish refactoring of the filter functionality: 1) Do not take the items from the cache only, as they might be incomplete (especially in online imap case, but not only). This should fix the body loss bug on spam filtering.(Bug 287752 and similar ones + countless of reports on user list) Might fix 293768. 2) Download only what is really needed for the filter and add safety checks that the mail is not modified if the requested part is missing. So far the distinction was only betwee the body and rest. This should speed up filtering. Also related to 287752, but should fix also 292283, 288109. 3) Rename qDebug->kDebug + fix some includes 4) The code should also fix the duplicate mails appearing after filtering (some of the duplicates with empty content), eg. 275233 All bug reporters: in case you still see the bug, reopen the corresponding one. For the reports that were CC'd, but not closed, please try to reproduce and tell the result. So far the bug is fixed on master, but might be backported later to 4.9. Related: bug 287752, bug 288109, bug 286043, bug 295484, bug 302337, bug 295000, bug 295684, bug 293768, bug 275233, bug 293918, bug 284310, bug 286364, bug 283682 (cherry picked from commit d64d61b470c56b92294f6adee6d74305a217628d) FIXED-IN: 4.9 M +7-11 kmail/kmcommands.cpp M +10 -7kmail/kmcommands.h M +1-1kmail/kmmainwidget.cpp M +1-5mailcommon/filter/filteraction.cpp M +6-5mailcommon/filter/filteraction.h M +6-0mailcommon/filter/filteractionaddheader.cpp M +2-0mailcommon/filter/filteractionaddheader.h M +2-2mailcommon/filter/filteractionaddtag.cpp M +1-1mailcommon/filter/filteractionaddtag.h M +9-3mailcommon/filter/filteractionaddtoaddressbook.cpp M +2-0mailcommon/filter/filteractionaddtoaddressbook.h M +7-0mailcommon/filter/filteractionbeep.cpp M +1-0mailcommon/filter/filteractionbeep.h M +18 -1mailcommon/filter/filteractioncopy.cpp M +7-0mailcommon/filter/filteractioncopy.h M +6-0mailcommon/filter/filteractiondelete.cpp M +1-0mailcommon/filter/filteractiondelete.h M +5-0mailcommon/filter/filteractionexec.cpp M +1-0mailcommon/filter/filteractionexec.h M +5-0mailcommon/filter/filteractionforward.cpp M +1-0mailcommon/filter/filteractionforward.h M +6-0mailcommon/filter/filteractionmove.cpp M +2-0mailcommon/filter/filteractionmove.h M +6-0mailcommon/filter/filteractionpipethrough.cpp M +1-0mailcommon/filter/filteractionpipethrough.h M +6-0mailcommon/filter/filteractionplaysound.cpp M +2-0mailcommon/filter/filteractionplaysound.h M +5-0mailcommon/filter/filteractionredirect.cpp M +1-0mailcommon/filter/filteractionredirect.h M +6-1mailcommon/filter/filteractionremoveheader.cpp M +1-0mailcommon/filter/filteractionremoveheader.h M +6-0mailcommon/filter/filteractionreplyto.cpp M +1-0mailcommon/filter/filteractionreplyto.h M +6-0mailcommon/filter/filteractionrewriteheader.cpp M +1-0mailcommon/filter/filteractionrewriteheader.h M +6-0mailcommon/filter/filteractionsendfakedisposition.cpp M +1-0mailcommon/filter/filteractionsendfakedisposition.h M +8-2mailcommon/filter/filteractionsendreceipt.cpp M +1-0mailcommon/filter/filteractionsendreceipt.h M +6-0mailcommon/filter/filteractionsetidentity.cpp M +1-0mailcommon/filter/filteractionsetidentity.h M +6-0mailcommon/filter/filteractionsetstatus.cpp M +1-0mailcommon/filter/filteractionsetstatus.h M +6-0mailcommon/filter/filteractionsettransport.cpp M +1-0mailcommon/filter/filteractionsettransport.h M +5-0mailcommon/filter/filteractionstatus.cpp M +2-0mailcommon/filter/filteractionstatus.h M +5-2mailcommon/filter/filteractionunsetstatus.cpp M +2-1mailcommon/filter/filteractionunsetstatus.h M +4-4mailcommon/filter/filterimporter/filterimporterevolution.cpp M +1-1mailcommon/filter/filterimporter/filterimporterprocmail.cpp M +1-1mailcommon/filter/filterimporter/filterimportersylpheed.cpp M +2-2mailcommon/filter/filterman
[Bug 292283] Filters don't work because headers are not downloaded
https://bugs.kde.org/show_bug.cgi?id=292283 András Manţia changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED Latest Commit||http://commits.kde.org/kdep ||im/d64d61b470c56b92294f6ade ||e6d74305a217628d --- Comment #1 from András Manţia --- Git commit d64d61b470c56b92294f6adee6d74305a217628d by Andras Mantia. Committed on 04/07/2012 at 17:35. Pushed by amantia into branch 'master'. A biggish refactoring of the filter functionality: 1) Do not take the items from the cache only, as they might be incomplete (especially in online imap case, but not only). This should fix the body loss bug on spam filtering.(Bug 287752 and similar ones + countless of reports on user list) Might fix 293768. 2) Download only what is really needed for the filter and add safety checks that the mail is not modified if the requested part is missing. So far the distinction was only betwee the body and rest. This should speed up filtering. Also related to 287752, but should fix also 292283, 288109. 3) Rename qDebug->kDebug + fix some includes 4) The code should also fix the duplicate mails appearing after filtering (some of the duplicates with empty content), eg. 275233 All bug reporters: in case you still see the bug, reopen the corresponding one. For the reports that were CC'd, but not closed, please try to reproduce and tell the result. So far the bug is fixed on master, but might be backported later to 4.9. Related: bug 287752, bug 288109, bug 286043, bug 295484, bug 302337, bug 295000, bug 295684, bug 293768, bug 275233, bug 293918, bug 284310, bug 286364, bug 283682 M +7-11 kmail/kmcommands.cpp M +10 -7kmail/kmcommands.h M +1-1kmail/kmmainwidget.cpp M +1-5mailcommon/filter/filteraction.cpp M +6-5mailcommon/filter/filteraction.h M +6-0mailcommon/filter/filteractionaddheader.cpp M +2-0mailcommon/filter/filteractionaddheader.h M +2-2mailcommon/filter/filteractionaddtag.cpp M +1-1mailcommon/filter/filteractionaddtag.h M +9-3mailcommon/filter/filteractionaddtoaddressbook.cpp M +2-0mailcommon/filter/filteractionaddtoaddressbook.h M +7-0mailcommon/filter/filteractionbeep.cpp M +1-0mailcommon/filter/filteractionbeep.h M +18 -1mailcommon/filter/filteractioncopy.cpp M +7-0mailcommon/filter/filteractioncopy.h M +6-0mailcommon/filter/filteractiondelete.cpp M +1-0mailcommon/filter/filteractiondelete.h M +5-0mailcommon/filter/filteractionexec.cpp M +1-0mailcommon/filter/filteractionexec.h M +5-0mailcommon/filter/filteractionforward.cpp M +1-0mailcommon/filter/filteractionforward.h M +6-0mailcommon/filter/filteractionmove.cpp M +2-0mailcommon/filter/filteractionmove.h M +6-0mailcommon/filter/filteractionpipethrough.cpp M +1-0mailcommon/filter/filteractionpipethrough.h M +6-0mailcommon/filter/filteractionplaysound.cpp M +2-0mailcommon/filter/filteractionplaysound.h M +5-0mailcommon/filter/filteractionredirect.cpp M +1-0mailcommon/filter/filteractionredirect.h M +6-1mailcommon/filter/filteractionremoveheader.cpp M +1-0mailcommon/filter/filteractionremoveheader.h M +6-0mailcommon/filter/filteractionreplyto.cpp M +1-0mailcommon/filter/filteractionreplyto.h M +6-0mailcommon/filter/filteractionrewriteheader.cpp M +1-0mailcommon/filter/filteractionrewriteheader.h M +6-0mailcommon/filter/filteractionsendfakedisposition.cpp M +1-0mailcommon/filter/filteractionsendfakedisposition.h M +8-2mailcommon/filter/filteractionsendreceipt.cpp M +1-0mailcommon/filter/filteractionsendreceipt.h M +6-0mailcommon/filter/filteractionsetidentity.cpp M +1-0mailcommon/filter/filteractionsetidentity.h M +6-0mailcommon/filter/filteractionsetstatus.cpp M +1-0mailcommon/filter/filteractionsetstatus.h M +6-0mailcommon/filter/filteractionsettransport.cpp M +1-0mailcommon/filter/filteractionsettransport.h M +5-0mailcommon/filter/filteractionstatus.cpp M +2-0mailcommon/filter/filteractionstatus.h M +5-2mailcommon/filter/filteractionunsetstatus.cpp M +2-1mailcommon/filter/filteractionunsetstatus.h M +4-4mailcommon/filter/filterimporter/filterimporterevolution.cpp M +1-1mailcommon/filter/filterimporter/filterimporterprocmail.cpp M +1-1mailcommon/filter/filterimporter/filterimportersylpheed.cpp M +2-2mailcommon/filter/filtermanager.cpp M +2-8mailcommon/filter/filtermanager.h M
[Bug 292283] Filters don't work because headers are not downloaded
https://bugs.kde.org/show_bug.cgi?id=292283 Andreas Hartmetz changed: What|Removed |Added CC||ahartm...@gmail.com -- You are receiving this mail because: You are the assignee for the bug. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[Bug 292283] Filters don't work because headers are not downloaded
https://bugs.kde.org/show_bug.cgi?id=292283 András Manţia changed: What|Removed |Added CC||aman...@kde.org Component|general |Mail Filter Agent Product|kmail2 |Akonadi -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[Bug 292283] Filters don't work because headers are not downloaded
https://bugs.kde.org/show_bug.cgi?id=292283 Paul Eggleton changed: What|Removed |Added CC||bluelightning@bluelightning ||.org -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
