[kaddressbook] [Bug 365192] kaddressbook corrupts or discards information in it does not know (carddav)

2016-07-08 Thread Erik Quaeghebeur via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365192

--- Comment #14 from Erik Quaeghebeur  ---
(In reply to Laurent Montel from comment #13)
>
> FIXED-IN: 5.3

Thanks for your expedient handling of this issue! I'll keep an eye on the
version I get through my distribution and test once it's at 5.3.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[kaddressbook] [Bug 365192] kaddressbook corrupts or discards information in it does not know (carddav)

2016-07-08 Thread Laurent Montel via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365192

Laurent Montel  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/kcon
   ||tacts/5d8492acd0d57a77305b0
   ||12e2726cc6b0e8eedbe
   Version Fixed In||5.3

--- Comment #12 from Laurent Montel  ---
Git commit 390166ad96f946554d36bb9296c04cac1fddfa2e by Montel Laurent.
Committed on 08/07/2016 at 11:36.
Pushed by mlaurent into branch 'master'.

Add support for fieldgroup

M  +1-0autotests/CMakeLists.txt
A  +261  -0autotests/fieldgrouptest.cpp [License: LGPL (v2+)]
A  +46   -0autotests/fieldgrouptest.h [License: LGPL (v2+)]
M  +2-0src/CMakeLists.txt
M  +29   -0src/addressee.cpp
M  +7-0src/addressee.h
A  +154  -0src/fieldgroup.cpp [License: LGPL (v2+)]
A  +76   -0src/fieldgroup.h [License: LGPL (v2+)]

http://commits.kde.org/kcontacts/390166ad96f946554d36bb9296c04cac1fddfa2e

--- Comment #13 from Laurent Montel  ---
Git commit 5d8492acd0d57a77305b012e2726cc6b0e8eedbe by Montel Laurent.
Committed on 08/07/2016 at 11:52.
Pushed by mlaurent into branch 'master'.

Fix Bug 365192 kaddressbook corrupts or discards information in it does not
know (carddav)

Fix group support

FIXED-IN: 5.3

M  +2-2autotests/data/vcard15.vcf.ref
M  +0-1src/vcardparser/vcardparser.cpp
M  +1-2src/vcardtool.cpp

http://commits.kde.org/kcontacts/5d8492acd0d57a77305b012e2726cc6b0e8eedbe

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[kaddressbook] [Bug 365192] kaddressbook corrupts or discards information in it does not know (carddav)

2016-07-08 Thread Laurent Montel via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365192

Laurent Montel  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/kcon
   ||tacts/5d8492acd0d57a77305b0
   ||12e2726cc6b0e8eedbe
   Version Fixed In||5.3

--- Comment #12 from Laurent Montel  ---
Git commit 390166ad96f946554d36bb9296c04cac1fddfa2e by Montel Laurent.
Committed on 08/07/2016 at 11:36.
Pushed by mlaurent into branch 'master'.

Add support for fieldgroup

M  +1-0autotests/CMakeLists.txt
A  +261  -0autotests/fieldgrouptest.cpp [License: LGPL (v2+)]
A  +46   -0autotests/fieldgrouptest.h [License: LGPL (v2+)]
M  +2-0src/CMakeLists.txt
M  +29   -0src/addressee.cpp
M  +7-0src/addressee.h
A  +154  -0src/fieldgroup.cpp [License: LGPL (v2+)]
A  +76   -0src/fieldgroup.h [License: LGPL (v2+)]

http://commits.kde.org/kcontacts/390166ad96f946554d36bb9296c04cac1fddfa2e

--- Comment #13 from Laurent Montel  ---
Git commit 5d8492acd0d57a77305b012e2726cc6b0e8eedbe by Montel Laurent.
Committed on 08/07/2016 at 11:52.
Pushed by mlaurent into branch 'master'.

Fix Bug 365192 kaddressbook corrupts or discards information in it does not
know (carddav)

Fix group support

FIXED-IN: 5.3

M  +2-2autotests/data/vcard15.vcf.ref
M  +0-1src/vcardparser/vcardparser.cpp
M  +1-2src/vcardtool.cpp

http://commits.kde.org/kcontacts/5d8492acd0d57a77305b012e2726cc6b0e8eedbe

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[kaddressbook] [Bug 365192] kaddressbook corrupts or discards information in it does not know (carddav)

2016-07-08 Thread Laurent Montel via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365192

--- Comment #11 from Laurent Montel  ---
Git commit ad8892fd98a401ffe9a6aafc3bc0a109da22c7b8 by Montel Laurent.
Committed on 08/07/2016 at 06:56.
Pushed by mlaurent into branch 'master'.

Add autotests for vcardline support. Test group support

M  +1-0autotests/CMakeLists.txt
A  +36   -0autotests/vcardlinetest.cpp [License: LGPL (v2+)]
A  +35   -0autotests/vcardlinetest.h [License: LGPL (v2+)]
M  +3-1src/vcardparser/vcardline.h
M  +1-0src/vcardparser/vcardparser.cpp
M  +5-0src/vcardtool.cpp

http://commits.kde.org/kcontacts/ad8892fd98a401ffe9a6aafc3bc0a109da22c7b8

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[kaddressbook] [Bug 365192] kaddressbook corrupts or discards information in it does not know (carddav)

2016-07-07 Thread Laurent Montel via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365192

--- Comment #10 from Laurent Montel  ---
still group support problem. But kcontact support it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[kaddressbook] [Bug 365192] kaddressbook corrupts or discards information in it does not know (carddav)

2016-07-07 Thread Laurent Montel via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365192

--- Comment #8 from Laurent Montel  ---
Git commit 166de982de7d977dfdc10262e63fe2c910943502 by Montel Laurent.
Committed on 08/07/2016 at 05:46.
Pushed by mlaurent into branch 'master'.

Add new autotest from bug 365192

A  +10   -0autotests/data/vcard15.vcf
A  +10   -0autotests/data/vcard15.vcf.ref

http://commits.kde.org/kcontacts/166de982de7d977dfdc10262e63fe2c910943502

--- Comment #9 from Laurent Montel  ---
Git commit ee98321a1f4ab94726c734fd508bcd54e4fc9c68 by Montel Laurent.
Committed on 08/07/2016 at 06:33.
Pushed by mlaurent into branch 'master'.

Make sure that we don't lose some data. When some server export as vcard3

they export all vcard4 variable too.
So export them too.

M  +4-3autotests/data/vcard15.vcf.ref
M  +1-0autotests/relatedtest.cpp
M  +0-2autotests/testroundtrip.cpp
M  +2-0autotests/testroundtrip.qrc
M  +10   -12   src/vcardtool.cpp

http://commits.kde.org/kcontacts/ee98321a1f4ab94726c734fd508bcd54e4fc9c68

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[kaddressbook] [Bug 365192] kaddressbook corrupts or discards information in it does not know (carddav)

2016-07-07 Thread Laurent Montel via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365192

--- Comment #8 from Laurent Montel  ---
Git commit 166de982de7d977dfdc10262e63fe2c910943502 by Montel Laurent.
Committed on 08/07/2016 at 05:46.
Pushed by mlaurent into branch 'master'.

Add new autotest from bug 365192

A  +10   -0autotests/data/vcard15.vcf
A  +10   -0autotests/data/vcard15.vcf.ref

http://commits.kde.org/kcontacts/166de982de7d977dfdc10262e63fe2c910943502

--- Comment #9 from Laurent Montel  ---
Git commit ee98321a1f4ab94726c734fd508bcd54e4fc9c68 by Montel Laurent.
Committed on 08/07/2016 at 06:33.
Pushed by mlaurent into branch 'master'.

Make sure that we don't lose some data. When some server export as vcard3

they export all vcard4 variable too.
So export them too.

M  +4-3autotests/data/vcard15.vcf.ref
M  +1-0autotests/relatedtest.cpp
M  +0-2autotests/testroundtrip.cpp
M  +2-0autotests/testroundtrip.qrc
M  +10   -12   src/vcardtool.cpp

http://commits.kde.org/kcontacts/ee98321a1f4ab94726c734fd508bcd54e4fc9c68

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[kaddressbook] [Bug 365192] kaddressbook corrupts or discards information in it does not know (carddav)

2016-07-07 Thread Laurent Montel via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365192

--- Comment #7 from Laurent Montel  ---
Ok I exclude export RELATED as it's vcard4 support not v3 but ok I will export
it too to be sure that no info are lost.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[kaddressbook] [Bug 365192] kaddressbook corrupts or discards information in it does not know (carddav)

2016-07-07 Thread Laurent Montel via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365192

--- Comment #6 from Laurent Montel  ---
(In reply to Erik Quaeghebeur from comment #2)
> (In reply to Laurent Montel from comment #1)
> > I improved a lot vcard4 support in kf5
> 
> Please note, this issue is not vcard4-specific.

Yep I know :)
I fixed some bugs about it in kf5. But perhaps it's not all fixed :)

> > could you provide some vcard4 file where info are discarded please ?
> 
> Yes, I'll attach test-pre.vcf for the vcard as it was before manipulation in
> kaddressbook, text-post.vcf after manipulation, and test.vcf.diff to show
> the changes explicitly. The manipulation consisted of adding the NICKNAME
> Testy.

Thanks a lot

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[kaddressbook] [Bug 365192] kaddressbook corrupts or discards information in it does not know (carddav)

2016-07-07 Thread Erik Quaeghebeur via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365192

--- Comment #5 from Erik Quaeghebeur  ---
Created attachment 99935
  --> https://bugs.kde.org/attachment.cgi?id=99935&action=edit
diff of pre and post vcard files

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[kaddressbook] [Bug 365192] kaddressbook corrupts or discards information in it does not know (carddav)

2016-07-07 Thread Erik Quaeghebeur via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365192

--- Comment #3 from Erik Quaeghebeur  ---
Created attachment 99933
  --> https://bugs.kde.org/attachment.cgi?id=99933&action=edit
pre-manipulation vcard file

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[kaddressbook] [Bug 365192] kaddressbook corrupts or discards information in it does not know (carddav)

2016-07-07 Thread Erik Quaeghebeur via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365192

--- Comment #4 from Erik Quaeghebeur  ---
Created attachment 99934
  --> https://bugs.kde.org/attachment.cgi?id=99934&action=edit
post-manipulation vcard file

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[kaddressbook] [Bug 365192] kaddressbook corrupts or discards information in it does not know (carddav)

2016-07-07 Thread Erik Quaeghebeur via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365192

--- Comment #2 from Erik Quaeghebeur  ---
(In reply to Laurent Montel from comment #1)
> I improved a lot vcard4 support in kf5

Please note, this issue is not vcard4-specific.

> could you provide some vcard4 file where info are discarded please ?

Yes, I'll attach test-pre.vcf for the vcard as it was before manipulation in
kaddressbook, text-post.vcf after manipulation, and test.vcf.diff to show the
changes explicitly. The manipulation consisted of adding the NICKNAME Testy.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs


[kaddressbook] [Bug 365192] kaddressbook corrupts or discards information in it does not know (carddav)

2016-07-07 Thread Laurent Montel via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365192

Laurent Montel  changed:

   What|Removed |Added

 CC||mon...@kde.org

--- Comment #1 from Laurent Montel  ---
I improved a lot vcard4 support in kf5
but perhaps it"s still not perfect.
could you provide some vcard4 file where info are discarded please ?
I will continue to improve it.

thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs