[kdepim] [Bug 356093] Kmail does not display PGP/Inline signed mails

[Sandro Knauß via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=356093

Sandro Knauß  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
   Version Fixed In||15.12.1
  Latest Commit||http://commits.kde.org/mess
   ||agelib/d3fcd2a4790cbe261181
   ||ddea29392178fb2e0dbb
 CC||kna...@kolabsys.com

--- Comment #12 from Sandro Knauß  ---
Git commit d3fcd2a4790cbe261181ddea29392178fb2e0dbb by Sandro Knauß.
Committed on 22/12/2015 at 00:44.
Pushed by knauss into branch 'master'.

Don't endup in a endless loop for inline signed messages

For inline signed messages the reference node is a null pointer
so we also need to set the memento for this null sign pointer, to
be able to refind the memento again.

This patch makes it impossible to have multiple inline signed messages blocks.
But one the other side it wasn't working before, too :)
REVIEW: 126451

M  +25   -0messageviewer/autotests/objecttreeparsertest.cpp
M  +1-0messageviewer/autotests/objecttreeparsertest.h
M  +1-3messageviewer/src/viewer/objecttreeparser.cpp

http://commits.kde.org/messagelib/d3fcd2a4790cbe261181ddea29392178fb2e0dbb

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs

[kdepim] [Bug 356093] Kmail does not display PGP/Inline signed mails

[Martin Steigerwald via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=356093

--- Comment #11 from Martin Steigerwald  ---
In a debugging session together with Sandro we found that messageviewer renders
such a mail okay, but kmail does not check that it already verified the mail,
the verification failed and then tries it all again. It basically loops over:

(gdb) continue
Continuing.
[Thread 0x7fbd2bbed700 (LWP 21855) exited]
[New Thread 0x7fbd2bbed700 (LWP 21859)]
[Thread 0x7fbd2bbed700 (LWP 21859) exited]
[New Thread 0x7fbd2bbed700 (LWP 21862)]
[Thread 0x7fbd2bbed700 (LWP 21862) exited]

Breakpoint 1, MessageViewer::ViewerPrivate::displayMessage (this=0x182daf0) at
/home/kde/sources/messagelib/messageviewer/src/viewer/viewer_p.cpp:804
804 showHideMimeTree();
(gdb) continue
Continuing.
[New Thread 0x7fbd2bbed700 (LWP 21865)]
[Thread 0x7fbd2bbed700 (LWP 21865) exited]
[New Thread 0x7fbd2bbed700 (LWP 21868)]
[Thread 0x7fbd2bbed700 (LWP 21868) exited]

Breakpoint 1, MessageViewer::ViewerPrivate::displayMessage (this=0x182daf0) at
/home/kde/sources/messagelib/messageviewer/src/viewer/viewer_p.cpp:804
804 showHideMimeTree();
(gdb) continue
Continuing.
[New Thread 0x7fbd2bbed700 (LWP 21873)]
[Thread 0x7fbd2bbed700 (LWP 21873) exited]
[New Thread 0x7fbd2bbed700 (LWP 21876)]
[Thread 0x7fbd2bbed700 (LWP 21876) exited]

Breakpoint 1, MessageViewer::ViewerPrivate::displayMessage (this=0x182daf0) at
/home/kde/sources/messagelib/messageviewer/src/viewer/viewer_p.cpp:804
804 showHideMimeTree();

Sandro is working on a fix I will test then. Thanks, Martin

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs

[kdepim] [Bug 356093] Kmail does not display PGP/Inline signed mails

[Martin Steigerwald via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=356093

--- Comment #10 from Martin Steigerwald  ---
Created attachment 96168
  --> https://bugs.kde.org/attachment.cgi?id=96168&action=edit
dirmngr.conf used for previous test

gnugp is from Debian Sid packages – I don´t know which one KMail is running:

martin@merkaba:~> apt-show-versions | grep "^gnupg"
gnupg:amd64/sid 1.4.19-6 uptodate
gnupg:i386 not installed
gnupg-agent:amd64/sid 2.1.10-3 uptodate
gnupg-agent:i386 not installed
gnupg-curl:amd64/sid 1.4.19-6 uptodate
gnupg-curl:i386 not installed
gnupg2:amd64/sid 2.1.10-3 uptodate
gnupg2:i386 not installed

martin@merkaba:~> LANG=C gpg --version
gpg: /home/martin/.gnupg/gpg.conf:98: invalid option
gpg (GnuPG) 1.4.19
Copyright (C) 2015 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later 
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Home: ~/.gnupg
Supported algorithms:
Pubkey: RSA, RSA-E, RSA-S, ELG-E, DSA
Cipher: IDEA, 3DES, CAST5, BLOWFISH, AES, AES192, AES256, TWOFISH,
CAMELLIA128, CAMELLIA192, CAMELLIA256
Hash: MD5, SHA1, RIPEMD160, SHA256, SHA384, SHA512, SHA224
Compression: Uncompressed, ZIP, ZLIB, BZIP2

martin@merkaba:~> LANG=C gpg2 --version
gpg: keyserver option 'ca-cert-file' is obsolete; please use 'hkp-cacert' in
dirmngr.conf
gpg: keyserver option 'no-try-dns-srv' is unknown
gpg (GnuPG) 2.1.10
libgcrypt 1.6.4
Copyright (C) 2015 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later 
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Home: ~/.gnupg
Supported algorithms:
Pubkey: RSA, ELG, DSA, ECDH, ECDSA, EDDSA
Cipher: IDEA, 3DES, CAST5, BLOWFISH, AES, AES192, AES256, TWOFISH,
CAMELLIA128, CAMELLIA192, CAMELLIA256
Hash: SHA1, RIPEMD160, SHA256, SHA384, SHA512, SHA224
Compression: Uncompressed, ZIP, ZLIB, BZIP2

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs

[kdepim] [Bug 356093] Kmail does not display PGP/Inline signed mails

[Martin Steigerwald via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=356093

--- Comment #9 from Martin Steigerwald  ---
Created attachment 96167
  --> https://bugs.kde.org/attachment.cgi?id=96167&action=edit
gpg.conf I used for previous test

may it stumble over keyid-format 0xlong

The config is a recommendation from they example gpg.conf linked
onhttps://people.debian.org/~anibal/ksp-dc15/ksp-dc15.html under "Check your
key and fix any problem with your key"

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs

[kdepim] [Bug 356093] Kmail does not display PGP/Inline signed mails

[Marcus Behrendt via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=356093

--- Comment #8 from Marcus Behrendt  ---
(In reply to Sandro Knauß from comment #6)
> what about gpg.conf, dirmgr.conf? gnugpg changed behaviour in the last
> releases / what version is installed?
> 
> Are all signed mails broken or only some parts of it?
> 
> Martin, Adrian is taking about auto decryption - I also didn't found
> something to disable the verification

I also thought that may be the cause. But downgrading kmail to 4.14.10 solved
my problem.
The problem was not present in the 15.08.x release. And as mentioned before
only affects PGP/Inline signed/encrypted mails. PGP/Mime still works. I will
post kmail's stdout this evening and hope there might be something useful in
it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs

[kdepim] [Bug 356093] Kmail does not display PGP/Inline signed mails

[Adrian Piotrowicz via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=356093

--- Comment #7 from Adrian Piotrowicz  ---
I do not have a problem described in this report.
I can read both signed and encrypted messages (almost) without problem.
For me it's a problem with lack of information that the message is encrypted if
auto decryption is turned off. It's a different issue.
I thought that maybe it's just lack of indication about message being
signed/encrypted and connected it with my issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs

[kdepim] [Bug 356093] Kmail does not display PGP/Inline signed mails

[Sandro Knauß via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=356093

--- Comment #6 from Sandro Knauß  ---
what about gpg.conf, dirmgr.conf? gnugpg changed behaviour in the last releases
/ what version is installed?

Are all signed mails broken or only some parts of it?

Martin, Adrian is taking about auto decryption - I also didn't found something
to disable the verification

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs

[kdepim] [Bug 356093] Kmail does not display PGP/Inline signed mails

[Martin Steigerwald via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=356093

--- Comment #5 from Martin Steigerwald  ---
Created attachment 96161
  --> https://bugs.kde.org/attachment.cgi?id=96161&action=edit
example mail from debian-devel-changes-ml I used for creating kwatchgnupg log

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs

[kdepim] [Bug 356093] Kmail does not display PGP/Inline signed mails

[Martin Steigerwald via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=356093

--- Comment #4 from Martin Steigerwald  ---
Created attachment 96160
  --> https://bugs.kde.org/attachment.cgi?id=96160&action=edit
kwatchgnupg.log

It basically restarts gnupg again and again and again as it can´t verify the
signature.

Adrian, I do not find the setting for automatically checking signatures. It is
enabled here, I want to disable it, until this bug is fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs

[kdepim] [Bug 356093] Kmail does not display PGP/Inline signed mails

[Martin Steigerwald via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=356093

Martin Steigerwald  changed:

   What|Removed |Added

 CC||mar...@lichtvoll.de
 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

--- Comment #3 from Martin Steigerwald  ---
I have this as well with KF5, Akonadi, KDEPIM compiled from Git master as of
yesterday. I have it since quite some time already. Basically it fires up gpg
again and again. I attach gnupg log and a mail which triggers the issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs

[kdepim] [Bug 356093] Kmail does not display PGP/Inline signed mails

[Laurent Montel via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=356093

Laurent Montel  changed:

   What|Removed |Added

 CC||mon...@kde.org,
   ||skna...@kde.org

--- Comment #2 from Laurent Montel  ---
I cc Sandro Knauß which changed some code in messageview about it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs

[kdepim] [Bug 356093] Kmail does not display PGP/Inline signed mails

[Adrian Piotrowicz via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=356093

Adrian Piotrowicz  changed:

   What|Removed |Added

 CC||nex...@nxstudio.pl

--- Comment #1 from Adrian Piotrowicz  ---
Do you have enabled option "Attempt decryption of encrypted messages when
viewing" under "Security" -> "Reading" in KMail settings?
I do not have high CPU usage but I have no mail body and no information about
body being encrypted without that option enabled.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs

[kdepim] [Bug 356093] Kmail does not display PGP/Inline signed mails

[Marcus Behrendt via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=356093

Marcus Behrendt  changed:

   What|Removed |Added

  Component|general |general
Version|Git (master)|GIT (master)
Product|kmail2  |kdepim

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Kdepim-bugs mailing list
Kdepim-bugs@kde.org
https://mail.kde.org/mailman/listinfo/kdepim-bugs