[kdepimlibs] [Bug 317834] Wrong date for Ching Ming Festival (HK holiday)
https://bugs.kde.org/show_bug.cgi?id=317834 --- Comment #1 from Christophe Giboudeaux cgiboude...@gmx.com --- It's defined following this rule: : Ching Ming Festival 5 April or 4 April in leap years (or if that day is a Sunday, then the following day) Isn't that correct ? -- You are receiving this mail because: You are on the CC list for the bug. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[kdepimlibs] [Bug 317834] Wrong date for Ching Ming Festival (HK holiday)
https://bugs.kde.org/show_bug.cgi?id=317834 Christophe Giboudeaux cgiboude...@gmx.com changed: What|Removed |Added CC||mikl...@gmail.com, ||pariah...@gmail.com --- Comment #2 from Christophe Giboudeaux cgiboude...@gmx.com --- Glen, Michael, what do you think ? -- You are receiving this mail because: You are on the CC list for the bug. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[kdepimlibs] [Bug 317834] Wrong date for Ching Ming Festival (HK holiday)
https://bugs.kde.org/show_bug.cgi?id=317834 --- Comment #3 from Christophe Giboudeaux cgiboude...@gmx.com --- Ah, I didn't see https://bugs.kde.org/show_bug.cgi?id=254073#c12 However, the proposed change in comment 13 and 14 will make the holiday incorrect for years 2013 -- You are receiving this mail because: You are on the CC list for the bug. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[kdepimlibs] [Bug 317834] Wrong date for Ching Ming Festival (HK holiday)
https://bugs.kde.org/show_bug.cgi?id=317834 --- Comment #4 from Glen Ng pariah...@gmail.com --- Ching Ming Festival follows the Chinese Calendar, which most average Hong Kong people (like me) don't really understand. I remember that I was told when I was a kid that Ching Ming Festival is always Apr 4, 5 or 6 but I don't really know the rule behind. I think it might better be hard coded. Here's a link from Hong Kong Observatory conversion table between Gregorian and Chinese Calendar (1901-2100): http://www.hko.gov.hk/gts/time/conversion.htm -- You are receiving this mail because: You are on the CC list for the bug. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[kdepimlibs] [Bug 317834] Wrong date for Ching Ming Festival (HK holiday)
https://bugs.kde.org/show_bug.cgi?id=317834 --- Comment #5 from Glen Ng pariah...@gmail.com --- I forgot to mention: In the conversion table a literal translation of Ching Ming is used, i.e. Bright Clear. (In reply to comment #4) Ching Ming Festival follows the Chinese Calendar, which most average Hong Kong people (like me) don't really understand. I remember that I was told when I was a kid that Ching Ming Festival is always Apr 4, 5 or 6 but I don't really know the rule behind. I think it might better be hard coded. Here's a link from Hong Kong Observatory conversion table between Gregorian and Chinese Calendar (1901-2100): http://www.hko.gov.hk/gts/time/conversion.htm -- You are receiving this mail because: You are on the CC list for the bug. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[kdepimlibs] [Bug 317834] Wrong date for Ching Ming Festival (HK holiday)
https://bugs.kde.org/show_bug.cgi?id=317834 --- Comment #6 from Christophe Giboudeaux cgiboude...@gmx.com --- Thanks. The files were updated -- You are receiving this mail because: You are on the CC list for the bug. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[kdepimlibs] [Bug 317834] Wrong date for Ching Ming Festival (HK holiday)
https://bugs.kde.org/show_bug.cgi?id=317834 Christophe Giboudeaux cgiboude...@gmx.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Version Fixed In||4.10.3 Resolution|--- |FIXED Latest Commit||http://commits.kde.org/kdep ||imlibs/3f1cdbeec40f87d41f8a ||29211133d3dbb13d3799 --- Comment #7 from Christophe Giboudeaux cgiboude...@gmx.com --- Fixed with http://commits.kde.org/kdepimlibs/3f1cdbeec40f87d41f8a29211133d3dbb13d3799 -- You are receiving this mail because: You are on the CC list for the bug. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
[kdepimlibs] [Bug 317834] Wrong date for Ching Ming Festival (HK holiday)
https://bugs.kde.org/show_bug.cgi?id=317834 Christophe Giboudeaux cgiboude...@gmx.com changed: What|Removed |Added Latest Commit|http://commits.kde.org/kdep |http://commits.kde.org/kdep |imlibs/3f1cdbeec40f87d41f8a |imlibs/af11cf34fb3099797956 |29211133d3dbb13d3799|1deadbe95fc3280bfb97 --- Comment #8 from Christophe Giboudeaux cgiboude...@gmx.com --- Git commit af11cf34fb30997979561deadbe95fc3280bfb97 by Christophe Giboudeaux. Committed on 17/04/2013 at 22:21. Pushed by cgiboudeaux into branch 'master'. Hardcode the Ching Ming Festival date FIXED-IN: 4.10.3 M +13 -12 kholidays/holidays/plan2/holiday_hk_en-gb M +13 -12 kholidays/holidays/plan2/holiday_hk_zh-cn http://commits.kde.org/kdepimlibs/af11cf34fb30997979561deadbe95fc3280bfb97 -- You are receiving this mail because: You are on the CC list for the bug. ___ Kdepim-bugs mailing list Kdepim-bugs@kde.org https://mail.kde.org/mailman/listinfo/kdepim-bugs
