[korganizer] [Bug 225498] agenda view day labels do not match the day

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=225498

gjditchfi...@acm.org changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/pim/
   ||eventviews/commit/36941c611
   ||c4c4ff45abc1af5c354853dedfa
   ||4c25
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #15 from gjditchfi...@acm.org ---
Git commit 36941c611c4c4ff45abc1af5c354853dedfa4c25 by Glen Ditchfield, on
behalf of Glen Ditchfield.
Committed on 06/07/2021 at 00:15.
Pushed by gditchfield into branch 'master'.

Shorten holiday names to fit the Agenda view's header

If the Agenda view displays many days, holiday names may be too wide to
fit in their days' column headers, causing the misalignments reported in

This patch shortens the name to ft.  Original patch by m4rkusxxl at web.de.

M  +3-3src/agenda/agendaview.cpp

https://invent.kde.org/pim/eventviews/commit/36941c611c4c4ff45abc1af5c354853dedfa4c25

-- 
You are receiving this mail because:
You are the assignee for the bug.

[korganizer] [Bug 225498] agenda view day labels do not match the day

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=225498

Bug Janitor Service  changed:

   What|Removed |Added

 Status|REOPENED|ASSIGNED

--- Comment #14 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/pim/eventviews/-/merge_requests/31

-- 
You are receiving this mail because:
You are the assignee for the bug.

[korganizer] [Bug 225498] agenda view day labels do not match the day

[Allen Winter]

https://bugs.kde.org/show_bug.cgi?id=225498

--- Comment #13 from Allen Winter  ---
thanks. in all my 15+ years working on KOrganizer I never ever used that
option.  but I sorta like it :)

I'll review and test your patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[korganizer] [Bug 225498] agenda view day labels do not match the day

[Markus]

https://bugs.kde.org/show_bug.cgi?id=225498

--- Comment #12 from Markus  ---
I also configured the "next x days" to be 21 days. So I can as well "Goto->Next
21 days".

Alternativly you could as well select less days and shrink the window
horizontally.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[korganizer] [Bug 225498] agenda view day labels do not match the day

[Martin Koller]

https://bugs.kde.org/show_bug.cgi?id=225498

--- Comment #11 from Martin Koller  ---
Simply select 21 days in the left top month grid

-- 
You are receiving this mail because:
You are the assignee for the bug.

[korganizer] [Bug 225498] agenda view day labels do not match the day

[Allen Winter]

https://bugs.kde.org/show_bug.cgi?id=225498

Allen Winter  changed:

   What|Removed |Added

 CC||win...@kde.org

--- Comment #10 from Allen Winter  ---
patch looks fine but I'd like to be able to reproduce first.

How are you looking at 21 days at a time in agendaview?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[korganizer] [Bug 225498] agenda view day labels do not match the day

[Markus]

https://bugs.kde.org/show_bug.cgi?id=225498

--- Comment #9 from Markus  ---
Created attachment 108484
  --> https://bugs.kde.org/attachment.cgi?id=108484=edit
eventviews-agendaview.patch

This patch applies to eventviews-17.08.2 and fixes the issue for me.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[korganizer] [Bug 225498] agenda view day labels do not match the day

[Markus]

https://bugs.kde.org/show_bug.cgi?id=225498

--- Comment #8 from Markus  ---
The problem is in eventviews-17.08.2/src/agenda/agendaview.cpp.

There we use createDayLabels to setup all the labels with "AlternateLabel" and
generate the "short version" to fit the topDayLabelBox, but that has no real
size yet. (Actually the size is always 100.)

I see two options:
1. Generate three strings of fixed length and let AlternateLabel decide which
one to choose.
2. Estimate the available size from e.g. mTopDayLabelsFrame and mSelectedDates.
(This has do be redone on resize as well)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[korganizer] [Bug 225498] agenda view day labels do not match the day

[Markus]

https://bugs.kde.org/show_bug.cgi?id=225498

--- Comment #7 from Markus  ---
I would think showing the appointments at the correct dates should be a major
requirement. Cant believe this is unfixed for over seven years...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[korganizer] [Bug 225498] agenda view day labels do not match the day

[Markus]

https://bugs.kde.org/show_bug.cgi?id=225498

--- Comment #6 from Markus  ---
Created attachment 108481
  --> https://bugs.kde.org/attachment.cgi?id=108481=edit
Screenshot from 17.08.2.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[korganizer] [Bug 225498] agenda view day labels do not match the day

[Markus]

https://bugs.kde.org/show_bug.cgi?id=225498

Markus  changed:

   What|Removed |Added

 CC||m4rkus...@web.de

--- Comment #5 from Markus  ---
Still valid in apps 17.08.2 / plasma 5.11.1 / framework 5.39.0.

-- 
You are receiving this mail because:
You are the assignee for the bug.