[korganizer] [Bug 347045] Sunday is always automatically selected once weekly recurrence drop down is clicked
https://bugs.kde.org/show_bug.cgi?id=347045 Volker Krause changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED Latest Commit||https://invent.kde.org/pim/ ||libkdepim/-/commit/bda4e47a ||7872769abbdfb82464585d379be ||34fb0 --- Comment #10 from Volker Krause --- Git commit bda4e47a7872769abbdfb82464585d379be34fb0 by Volker Krause, on behalf of Thomas Karpiniec. Committed on 09/07/2023 at 07:20. Pushed by vkrause into branch 'master'. Avoid spurious checkcombobox toggle where indexes don't match When clicking on a KCheckComboBox that has an item already selected, QComboBox will fire activated (via _q_editingFinished). When this popup is opening for the first time the currentIndex of the combo box is correct but the view's current index is still row 0. This leads to spuriously toggling the first item in the list. Since this activation from QComboBox happens programatically, care must also be taken not to process this event for a disabled item. M +3-2src/widgets/kcheckcombobox.cpp https://invent.kde.org/pim/libkdepim/-/commit/bda4e47a7872769abbdfb82464585d379be34fb0 -- You are receiving this mail because: You are the assignee for the bug.
[korganizer] [Bug 347045] Sunday is always automatically selected once weekly recurrence drop down is clicked
https://bugs.kde.org/show_bug.cgi?id=347045 Bug Janitor Service changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|ASSIGNED --- Comment #9 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/pim/libkdepim/-/merge_requests/13 -- You are receiving this mail because: You are the assignee for the bug.
[korganizer] [Bug 347045] Sunday is always automatically selected once weekly recurrence drop down is clicked
https://bugs.kde.org/show_bug.cgi?id=347045
Thomas Karpiniec changed:
What|Removed |Added
CC||t...@1.21jiggawatts.net
--- Comment #8 from Thomas Karpiniec ---
I've tracked this down to this connection in `KCheckComboBox`:
https://invent.kde.org/pim/libkdepim/-/blob/master/src/widgets/kcheckcombobox.cpp#L122
connect(this, &QComboBox::activated, this, [this]() {
d->toggleCheckState();
});
The idea is that the `activated` signal will fire when the user clicks on an
item in the list, so its check state should be toggled. The problem is that
this signal is _also_ firing when you first click the drop-down. I tested a
hack that swallows the first `activated` event after `showPopup()` and this
made it work correctly.
This doesn't appear to be normal behaviour for QComboBox which makes me wonder
if we have the signal connected somewhere else and causing problems. I captured
the following backtrace but haven't quite figured out where this is coming from
yet:
#0 KPIM::KCheckComboBox::KCheckComboBoxPrivate::toggleCheckState
(this=0x12ccc90) at
/home/tk/kde/src/libkdepim/src/widgets/kcheckcombobox.cpp:113
#1 0x74f25232 in QtPrivate::QSlotObjectBase::call (a=0x7fffc170,
r=0x12cc800, this=0x12cccf0) at
../../include/QtCore/../../src/corelib/kernel/qobjectdefs_impl.h:398
#2 doActivate (sender=0x12cc800, signal_index=8, argv=0x7fffc170)
at kernel/qobject.cpp:3923
#3 0x74f1de2f in QMetaObject::activate (sender=sender@entry=0x12cc800,
m=m@entry=0x760c25c0 ,
local_signal_index=local_signal_index@entry=1, argv=argv@entry=0x7fffc170)
at kernel/qobject.cpp:3983
#4 0x75ca8a91 in QComboBox::activated (this=this@entry=0x12cc800,
_t1=) at .moc/moc_qcombobox.cpp:510
#5 0x75caa23e in QComboBoxPrivate::emitActivated
(this=this@entry=0x12cc840, index=...) at
../../include/QtCore/../../src/corelib/itemmodels/qabstractitemmodel.h:62
#6 0x75caf322 in QComboBoxPrivate::_q_editingFinished (this=0x12cc840)
at widgets/qcombobox.cpp:1358
#7 0x74f251d3 in doActivate (sender=0x12cd930, signal_index=11,
argv=0x7fffc2d0) at kernel/qobject.cpp:3935
#8 0x74f1de2f in QMetaObject::activate (sender=sender@entry=0x12cd930,
m=m@entry=0x760c5b20 ,
local_signal_index=local_signal_index@entry=4, argv=argv@entry=0x0) at
kernel/qobject.cpp:3983
#9 0x75ceafd3 in QLineEdit::editingFinished
(this=this@entry=0x12cd930) at .moc/moc_qlineedit.cpp:473
#10 0x75cf1d61 in QLineEdit::focusOutEvent (this=0x12cd930,
e=0x7fffc530) at widgets/qlineedit.cpp:1959
#11 0x75be6ee0 in QWidget::event (this=0x12cd930, event=0x7fffc530)
at kernel/qwidget.cpp:8793
#12 0x75be6ee0 in QWidget::event (this=0x12cc800, event=0x7fffc530)
at kernel/qwidget.cpp:8793
#13 0x75ba51ae in QApplicationPrivate::notify_helper (this=, receiver=0x12cc800, e=0x7fffc530) at kernel/qapplication.cpp:3640
#14 0x74eec978 in QCoreApplication::notifyInternal2
(receiver=0x12cc800, event=0x7fffc530) at kernel/qcoreapplication.cpp:1064
#15 0x75baa160 in QApplicationPrivate::openPopup (this=,
popup=, popup@entry=0x12cf790) at kernel/qapplication.cpp:3767
#16 0x75be3ab0 in QWidgetPrivate::show_helper
(this=this@entry=0x12d4aa0) at kernel/qwidget.cpp:7844
#17 0x75be6823 in QWidgetPrivate::setVisible (this=0x12d4aa0,
visible=) at kernel/qwidget.cpp:8137
#18 0x75cb034e in QComboBox::showPopup (this=0x12cc800) at
widgets/qcombobox.cpp:2953
#19 0x75cb10de in QComboBoxPrivate::showPopupFromMouseEvent
(this=0x12cc840, e=) at widgets/qcombobox.cpp:3303
#20 0x75be6d78 in QWidget::event (this=0x12cc800, event=0x7fffcd50)
at kernel/qwidget.cpp:9045
#21 0x75ba51ae in QApplicationPrivate::notify_helper
(this=this@entry=0x435230, receiver=receiver@entry=0x12cc800,
e=e@entry=0x7fffcd50) at kernel/qapplication.cpp:3640
#22 0x75bad5df in QApplication::notify (this=,
receiver=, e=0x7fffcd50) at kernel/qapplication.cpp:3084
#23 0x74eec978 in QCoreApplication::notifyInternal2
(receiver=0x12cc800, event=0x7fffcd50) at kernel/qcoreapplication.cpp:1064
#24 0x75bab93e in QApplicationPrivate::sendMouseEvent
(receiver=receiver@entry=0x12cc800, event=event@entry=0x7fffcd50,
alienWidget=, nativeWidget=0x7fffe0003430,
buttonDown=buttonDown@entry=0x760f2330 ,
lastMouseReceiver=..., spontaneous=true, onlyDispatchEnterLeave=false) at
kernel/qapplication.cpp:2622
#25 0x75bff80d in QWidgetWindow::handleMouseEvent (this=0x18dd660,
event=0x7fffd000) at kernel/qwidgetwindow.cpp:684
#26 0x75c02d2f in QWidgetWindow::event (this=0x18dd660,
event=0x7fffd000) at kernel/qwidgetwindow.cpp:300
#27 0x75ba51ae in QApplicationPrivate::notify_helper (this=, receiver=0x18dd660, e=0x7fffd000) at
[korganizer] [Bug 347045] Sunday is always automatically selected once weekly recurrence drop down is clicked
https://bugs.kde.org/show_bug.cgi?id=347045 bugzy changed: What|Removed |Added Version|5.4.3 |5.21.2 Status|NEEDSINFO |REPORTED Resolution|WAITINGFORINFO |--- --- Comment #7 from bugzy --- Still reproducable on korganizer 5.21.2 -- You are receiving this mail because: You are the assignee for the bug.
[korganizer] [Bug 347045] Sunday is always automatically selected once weekly recurrence drop down is clicked
https://bugs.kde.org/show_bug.cgi?id=347045 Justin Zobel changed: What|Removed |Added Resolution|--- |WAITINGFORINFO Status|REPORTED|NEEDSINFO --- Comment #6 from Justin Zobel --- Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version? If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you! -- You are receiving this mail because: You are the assignee for the bug.
[korganizer] [Bug 347045] Sunday is always automatically selected once weekly recurrence drop down is clicked
https://bugs.kde.org/show_bug.cgi?id=347045 --- Comment #5 from bugzy --- Created attachment 106275 --> https://bugs.kde.org/attachment.cgi?id=106275&action=edit Video Showing the bug and how to reproduce it Attached video of the bug and how to reproduce it -- You are receiving this mail because: You are the assignee for the bug.
[korganizer] [Bug 347045] Sunday is always automatically selected once weekly recurrence drop down is clicked
https://bugs.kde.org/show_bug.cgi?id=347045 bugzy changed: What|Removed |Added Status|NEEDSINFO |UNCONFIRMED Resolution|WAITINGFORINFO |--- Version|unspecified |5.4.3 --- Comment #4 from bugzy --- The bug still exists in korganizer (5.4.3) and kdepim 16.12.3. Whereas I have not tested the 17.04.x versions of the same, I strongly doubt that the problem is fixed. Nevertheless, I will update this bug as soon as fedora kde applications packages are updated to match kde release. When I have a chance I will also try to upload a video of this issue. -- You are receiving this mail because: You are the assignee for the bug.
[korganizer] [Bug 347045] Sunday is always automatically selected once weekly recurrence drop down is clicked
https://bugs.kde.org/show_bug.cgi?id=347045 Denis Kurz changed: What|Removed |Added Resolution|--- |WAITINGFORINFO Status|UNCONFIRMED |NEEDSINFO --- Comment #3 from Denis Kurz --- This bug has never been confirmed for a KDE PIM version that is based on KDE Frameworks (5.x). Those versions differ significantly from the old 4.x series. Therefore, I plan to close it in around two or three months. In the meantime, it is set to WAITINGFORINFO to give reporters the oportunity to check if it is still valid. As soon as someone confirms it for a recent version (at least 5.1, ideally even more recent), I'll gladly reopen it. Please understand that we lack the manpower to triage bugs reported for versions almost two years beyond their end of life. -- You are receiving this mail because: You are the assignee for the bug.
