Re: [OS-BUILD PATCH 0/2] blk-mq: fix kernel panic in blk_mq_put_rq_ref
From: Ming Lei on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1315#note_653472658 This one is just for patch test purpose. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[OS-BUILD PATCH 1/2] blk-mq: fix kernel panic during iterating over flush request
From: Ming Lei
blk-mq: fix kernel panic during iterating over flush request
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1994424
Upstream Status: merged to for-5.14/block
For fixing use-after-free during iterating over requests, we grabbed
request's refcount before calling ->fn in commit 2e315dc07df0 ("blk-mq:
grab rq->refcount before calling ->fn in blk_mq_tagset_busy_iter").
Turns out this way may cause kernel panic when iterating over one flush
request:
1) old flush request's tag is just released, and this tag is reused by
one new request, but ->rqs[] isn't updated yet
2) the flush request can be re-used for submitting one new flush command,
so blk_rq_init() is called at the same time
3) meantime blk_mq_queue_tag_busy_iter() is called, and old flush request
is retrieved from ->rqs[tag]; when blk_mq_put_rq_ref() is called,
flush_rq->end_io may not be updated yet, so NULL pointer dereference
is triggered in blk_mq_put_rq_ref().
Fix the issue by calling refcount_set(_rq->ref, 1) after
flush_rq->end_io is set. So far the only other caller of blk_rq_init() is
scsi_ioctl_reset() in which the request doesn't enter block IO stack and
the request reference count isn't used, so the change is safe.
Fixes: 2e315dc07df0 ("blk-mq: grab rq->refcount before calling ->fn in
blk_mq_tagset_busy_iter")
Reported-by: "Blank-Burian, Markus, Dr."
Tested-by: "Blank-Burian, Markus, Dr."
Signed-off-by: Ming Lei
Reviewed-by: Christoph Hellwig
Reviewed-by: John Garry
Link: https://lore.kernel.org/r/20210811142624.618598-1-ming@redhat.com
Signed-off-by: Jens Axboe
diff --git a/block/blk-core.c b/block/blk-core.c
index blahblah..blahblah 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -122,7 +122,6 @@ void blk_rq_init(struct request_queue *q, struct request
*rq)
rq->internal_tag = BLK_MQ_NO_TAG;
rq->start_time_ns = ktime_get_ns();
rq->part = NULL;
- refcount_set(>ref, 1);
blk_crypto_rq_set_defaults(rq);
}
EXPORT_SYMBOL(blk_rq_init);
diff --git a/block/blk-flush.c b/block/blk-flush.c
index blahblah..blahblah 100644
--- a/block/blk-flush.c
+++ b/block/blk-flush.c
@@ -329,6 +329,14 @@ static void blk_kick_flush(struct request_queue *q, struct
blk_flush_queue *fq,
flush_rq->rq_flags |= RQF_FLUSH_SEQ;
flush_rq->rq_disk = first_rq->rq_disk;
flush_rq->end_io = flush_end_io;
+ /*
+* Order WRITE ->end_io and WRITE rq->ref, and its pair is the one
+* implied in refcount_inc_not_zero() called from
+* blk_mq_find_and_get_req(), which orders WRITE/READ flush_rq->ref
+* and READ flush_rq->end_io
+*/
+ smp_wmb();
+ refcount_set(_rq->ref, 1);
blk_flush_queue_rq(flush_rq, false);
}
--
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1315
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[OS-BUILD PATCH 2/2] blk-mq: fix is_flush_rq
From: Ming Lei
blk-mq: fix is_flush_rq
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1994424
Upstream Status: not merged to upstream, just posted on linux-block
is_flush_rq() is called from bt_iter()/bt_tags_iter(), and runs the
following check:
hctx->fq->flush_rq == req
but the passed hctx from bt_iter()/bt_tags_iter() may be NULL because:
1) memory re-order in blk_mq_rq_ctx_init():
rq->mq_hctx = data->hctx;
...
refcount_set(>ref, 1);
OR
2) tag re-use and ->rqs[] isn't updated with new request.
Fix the issue by re-writing is_flush_rq() as:
return rq->end_io == flush_end_io;
which turns out simpler to follow and immune to data race since we have
ordered WRITE rq->end_io and refcount_set(>ref, 1).
Fixes: 2e315dc07df0 ("blk-mq: grab rq->refcount before calling ->fn in
blk_mq_tagset_busy_iter")
Cc: "Blank-Burian, Markus, Dr."
Cc: Yufen Yu
Signed-off-by: Ming Lei
diff --git a/block/blk-flush.c b/block/blk-flush.c
index blahblah..blahblah 100644
--- a/block/blk-flush.c
+++ b/block/blk-flush.c
@@ -262,6 +262,11 @@ static void flush_end_io(struct request *flush_rq,
blk_status_t error)
spin_unlock_irqrestore(>mq_flush_lock, flags);
}
+bool is_flush_rq(struct request *rq)
+{
+ return rq->end_io == flush_end_io;
+}
+
/**
* blk_kick_flush - consider issuing flush request
* @q: request_queue being kicked
diff --git a/block/blk-mq.c b/block/blk-mq.c
index blahblah..blahblah 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -911,7 +911,7 @@ static bool blk_mq_req_expired(struct request *rq, unsigned
long *next)
void blk_mq_put_rq_ref(struct request *rq)
{
- if (is_flush_rq(rq, rq->mq_hctx))
+ if (is_flush_rq(rq))
rq->end_io(rq, 0);
else if (refcount_dec_and_test(>ref))
__blk_mq_free_request(rq);
diff --git a/block/blk.h b/block/blk.h
index blahblah..blahblah 100644
--- a/block/blk.h
+++ b/block/blk.h
@@ -44,11 +44,7 @@ static inline void __blk_get_queue(struct request_queue *q)
kobject_get(>kobj);
}
-static inline bool
-is_flush_rq(struct request *req, struct blk_mq_hw_ctx *hctx)
-{
- return hctx->fq->flush_rq == req;
-}
+bool is_flush_rq(struct request *req);
struct blk_flush_queue *blk_alloc_flush_queue(int node, int cmd_size,
gfp_t flags);
--
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1315
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
[OS-BUILD PATCH 0/2] blk-mq: fix kernel panic in blk_mq_put_rq_ref
From: Ming Lei on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1315 Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1994424 Upstream Status: one is merged to for-5.14/block; anthoer not merged to upstream, just posted on linux-block Signed-off-by: Ming Lei --- block/blk-core.c | 1 - block/blk-flush.c | 13 + block/blk-mq.c| 2 +- block/blk.h | 6 +- 4 files changed, 15 insertions(+), 7 deletions(-) ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCH 0/4] CI: c9s updates
From: Iñaki Malerba on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1313#note_653031915 Acked-by: Iñaki Malerba (via approve button) ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCH 0/4] CI: c9s updates
From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1313#note_652998444 Acked-by: Herton R. Krzesinski (via approve button) ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCH 0/4] CI: c9s updates
From: Veronika Kabátová on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1313#note_652971912 Potential infra issues: c9s distro is not yet imported into Beaker, and we're lacking the ppc64le RHEL container. As nobody should be developing against those repos the MR should be safe to merge, but I want the current limitations to be clear. Neither of those two problems would need CI changes to be resolved, the fixes would go in through different parts of the pipeline. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[OS-BUILD PATCH 3/4] CI: Finish up c9s config
From: Veronika Kabatova CI: Finish up c9s config The configuration for c9s was, up till now, a commented out placeholder. The plans are finished now so we can also update the config accordingly. We want two pipelines: - A full c9s pipeline (build and test), publicly available - A build for RHEL9 (RH internal only), to ensure nothing breaks (this should not happen, but better be safe) Add a new anchor for RHEL build-only and the extra pipelines. As we now have a lot of pipelines defined in this file, add comments to mark where the actual definitions start for easier orientation. Bugzilla: INTERNAL Upstream Status: RHEL-only Signed-off-by: Veronika Kabatova diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index blahblah..blahblah 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -27,7 +27,7 @@ workflow: REQUESTED_PIPELINE_TYPE: 'internal' - if: '$CI_MERGE_REQUEST_PROJECT_PATH =~ /^redhat.centos-stream/ || $CI_PROJECT_PATH =~ /^redhat.centos-stream/' variables: -REQUESTED_PIPELINE_TYPE: 'trusted' +REQUESTED_PIPELINE_TYPE: '/^(trusted|centos-rhel)$/' # We need to differentiate between the pipeline types that are triggered from this # single file. Once the mirroring to c9s stops this anchor can be dropped and the @@ -81,18 +81,34 @@ workflow: builder_image: quay.io/cki/builder-rhel9 kpet_tree_family: rhel9 +.trigger_rhel9_build: + extends: .trigger_rhel9_pipeline + variables: +skip_test: 'true' +skip_results: 'true' + +# ARK CI ark_merge_request: extends: [.trusted-ark, .merge_request, .trigger_ark_pipeline] -# Only enable c9s pipelines once we have the composes available in Beaker -# c9s_merge_request: -# extends: [.trusted, .merge_request, .rhel_common, -# .9-common, .trigger_c9s_pipeline] -# -# c9s_baseline: -# extends: [.trusted, .baseline, .rhel_common, -# .9-common, .trigger_c9s_pipeline] +# c9s CI +c9s_merge_request: + extends: [.trusted, .merge_request, .rhel_common, +.9-common, .trigger_c9s_pipeline] + +c9s_baseline: + extends: [.trusted, .baseline, .rhel_common, +.9-common, .trigger_c9s_pipeline] + +c9s_rhel9_compat_merge_request: + extends: [.centos_stream_rhel_internal, .merge_request, .rhel_common, +.9-common, .trigger_rhel9_build] + +c9s_rhel9_compat_baseline: + extends: [.centos_stream_rhel_internal, .baseline, .rhel_common, +.9-common, .trigger_rhel9_build] +# RHEL9 CI rhel9_merge_request: extends: [.internal, .merge_request, .rhel_common, .9-common, .trigger_rhel9_pipeline] -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1313 ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[OS-BUILD PATCH 4/4] CI: Rename ARK CI pipeline type
From: Veronika Kabatova CI: Rename ARK CI pipeline type To enable CentOS Stream double pipelines, the pipeline type check now uses regexes. This means that both "trusted" (c9s) and "trusted-ark" (ARK) pipelines would get picked and be executed for ARK MRs which is not what we want. Rename the ARK pipeline type to avoid this. Bugzilla: INTERNAL Upstream Status: RHEL-only Signed-off-by: Veronika Kabatova diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index blahblah..blahblah 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -19,7 +19,7 @@ workflow: - if: '$CI_PIPELINE_SOURCE == "schedule"' # ARK release pipelines - if: '$CI_MERGE_REQUEST_PROJECT_PATH =~ /^cki-project.kernel-ark/' # ARK MR CI variables: -REQUESTED_PIPELINE_TYPE: 'trusted-ark' +REQUESTED_PIPELINE_TYPE: 'ark-ci' # We cannot merge rules through !reference and have to copy them over from the # CKI pipeline: https://gitlab.com/gitlab-org/gitlab/-/issues/322992 - if: '$CI_MERGE_REQUEST_PROJECT_PATH =~ /^redhat.rhel/ || $CI_PROJECT_PATH =~ /^redhat.rhel/' @@ -38,7 +38,7 @@ workflow: project: redhat/red-hat-ci-tools/kernel/cki-internal-pipelines/cki-trusted-contributors strategy: depend variables: -PIPELINE_TYPE: 'trusted-ark' +PIPELINE_TYPE: 'ark-ci' kernel_type: 'upstream' .trigger_ark_pipeline: -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1313 ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[OS-BUILD PATCH 2/4] CI: Update ppc64le config
From: Veronika Kabatova CI: Update ppc64le config The RHEL container is now available so we can unify the architecture list. We also need to specify which CKI power builder should be used, as CKI has more of them and not all are supported for c9s/RHEL9. Bugzilla: INTERNAL Upstream Status: RHEL-only Signed-off-by: Veronika Kabatova diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index blahblah..blahblah 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -61,6 +61,8 @@ workflow: builder_image_tag: latest srpm_make_target: dist-srpm native_tools: 'true' +architectures: 'x86_64 ppc64le aarch64 s390x' +POWER_BUILDER_SUFFIX: '-p9' .trigger_c9s_pipeline: trigger: @@ -68,7 +70,6 @@ workflow: variables: name: centos-stream-9 builder_image: registry.gitlab.com/cki-project/containers/builder-stream9 -architectures: 'x86_64 ppc64le aarch64 s390x' kpet_tree_family: c9s kernel_type: 'upstream' # Needs to be overriden due to inheriting from .rhel_common @@ -78,7 +79,6 @@ workflow: variables: name: rhel9 builder_image: quay.io/cki/builder-rhel9 -architectures: 'x86_64 aarch64 s390x' #ppc64le container is not available yet kpet_tree_family: rhel9 ark_merge_request: -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1313 ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[OS-BUILD PATCH 1/4] CI: use more templates
From: Veronika Kabatova CI: use more templates Since the initial implementation, we've added a few more common options and anchors into the kernel templates. Relevant here is .rhel_common which we can now use, so we don't forget to update any of the options. Also split the lines of the "extends" lists to make a visual distinction between the common (imported) anchors and the ones defined in this CI file. Bugzilla: INTERNAL Upstream Status: RHEL-only Signed-off-by: Veronika Kabatova diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index blahblah..blahblah 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -60,9 +60,6 @@ workflow: variables: builder_image_tag: latest srpm_make_target: dist-srpm -build_kabi_stablelist: 'true' -tree_yaml_name: rhel -publish_elsewhere: 'true' native_tools: 'true' .trigger_c9s_pipeline: @@ -73,6 +70,7 @@ workflow: builder_image: registry.gitlab.com/cki-project/containers/builder-stream9 architectures: 'x86_64 ppc64le aarch64 s390x' kpet_tree_family: c9s +kernel_type: 'upstream' # Needs to be overriden due to inheriting from .rhel_common .trigger_rhel9_pipeline: trigger: @@ -88,16 +86,20 @@ ark_merge_request: # Only enable c9s pipelines once we have the composes available in Beaker # c9s_merge_request: -# extends: [.trusted, .merge_request, .9-common, .trigger_c9s_pipeline] +# extends: [.trusted, .merge_request, .rhel_common, +# .9-common, .trigger_c9s_pipeline] # # c9s_baseline: -# extends: [.trusted, .baseline, .9-common, .trigger_c9s_pipeline] +# extends: [.trusted, .baseline, .rhel_common, +# .9-common, .trigger_c9s_pipeline] rhel9_merge_request: - extends: [.internal, .merge_request, .9-common, .trigger_rhel9_pipeline] + extends: [.internal, .merge_request, .rhel_common, +.9-common, .trigger_rhel9_pipeline] rhel9_baseline: - extends: [.internal, .baseline, .9-common, .trigger_rhel9_pipeline] + extends: [.internal, .baseline, .rhel_common, +.9-common, .trigger_rhel9_pipeline] # scheduled job -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1313 ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[OS-BUILD PATCH 0/4] CI: c9s updates
From: Veronika Kabátová on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1313 Bugzilla: INTERNAL Upstream Status: RHEL-only Signed-off-by: Veronika Kabatova --- .gitlab-ci.yml | 50 ++ 1 files changed, 34 insertions(+), 16 deletions(-) ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCH 0/0] [redhat] New configs in sound/soc
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1220#note_652966221 Absolutely. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCH 0/0] [redhat] New configs in sound/soc
From: Jaroslav Kysela on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1220#note_652942187 I think that this should be closed now - resolved in https://gitlab.com/cki- project/kernel-ark/-/merge_requests/1294 . ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCH] increase CONFIG_NODES_SHIFT for aarch64
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1312#note_652852405 Acked-by: Prarit Bhargava (via approve button) ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[OS-BUILD PATCH] increase CONFIG_NODES_SHIFT for aarch64
From: Chris von Recklinghausen increase CONFIG_NODES_SHIFT for aarch64 Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1890304 Upstream status: RHEL-only Ampere has requested that CONFIG_NODES_SHIFT be increased to allow for a larger number of nodes on future platforms. Increase from 4 to 6 to allow for up to 32 nodes. Signed-off-by: Chris von Recklinghausen diff --git a/redhat/configs/ark/generic/arm/aarch64/CONFIG_NODES_SHIFT b/redhat/configs/ark/generic/arm/aarch64/CONFIG_NODES_SHIFT index blahblah..blahblah 100644 --- a/redhat/configs/ark/generic/arm/aarch64/CONFIG_NODES_SHIFT +++ b/redhat/configs/ark/generic/arm/aarch64/CONFIG_NODES_SHIFT @@ -1 +1 @@ -CONFIG_NODES_SHIFT=3 +CONFIG_NODES_SHIFT=6 -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1312 ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCHv2 0/2] redhat/configs: sound configuration cleanups and updates
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1294#note_652819259 Acked-by: Patrick Talbert (via approve button) ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[OS-BUILD PATCHv2 2/2] filter-modules.sh: add more sound modules to filter
From: Jaroslav Kysela filter-modules.sh: add more sound modules to filter - add regmap-sdw[-mbq] and arizona-micsupp modules - add drivers/soundwire directory Signed-off-by: Jaroslav Kysela diff --git a/redhat/fedora_files/filter-modules.sh.fedora b/redhat/fedora_files/filter-modules.sh.fedora index blahblah..blahblah 100755 --- a/redhat/fedora_files/filter-modules.sh.fedora +++ b/redhat/fedora_files/filter-modules.sh.fedora @@ -39,7 +39,7 @@ netprots="6lowpan appletalk atm ax25 batman-adv bluetooth can dsa ieee802154 l2t drmdrvs="amd ast bridge gma500 i2c i915 mgag200 nouveau panel radeon" -singlemods="ntb_netdev iscsi_ibft iscsi_boot_sysfs megaraid pmcraid qedi qla1280 9pnet_rdma rpcrdma nvmet-rdma nvme-rdma hid-picolcd hid-prodikeys hwpoison-inject target_core_user sbp_target cxgbit chcr parport_serial regmap-sdw hid-asus iTCO_wdt rnbd-client rnbd-server mlx5_vdpa spi-altera-dfl" +singlemods="ntb_netdev iscsi_ibft iscsi_boot_sysfs megaraid pmcraid qedi qla1280 9pnet_rdma rpcrdma nvmet-rdma nvme-rdma hid-picolcd hid-prodikeys hwpoison-inject target_core_user sbp_target cxgbit chcr parport_serial regmap-sdw regmap-sdw-mbq arizona-micsupp hid-asus iTCO_wdt rnbd-client rnbd-server mlx5_vdpa spi-altera-dfl" # Grab the arch-specific filter list overrides source ./filter-$2.sh @@ -146,6 +146,7 @@ done # Just kill sound. filter_dir $1 kernel/sound +filter_dir $1 kernel/drivers/soundwire # Now go through and filter any single .ko files that might have deps on the # things we filtered above diff --git a/redhat/rhel_files/filter-modules.sh.rhel b/redhat/rhel_files/filter-modules.sh.rhel index blahblah..blahblah 100755 --- a/redhat/rhel_files/filter-modules.sh.rhel +++ b/redhat/rhel_files/filter-modules.sh.rhel @@ -37,7 +37,7 @@ netprots="6lowpan appletalk atm ax25 batman-adv bluetooth can dccp dsa ieee80215 drmdrvs="amd ast gma500 i2c i915 mgag200 nouveau radeon via " -singlemods="ntb_netdev iscsi_ibft iscsi_boot_sysfs megaraid pmcraid qedi qla1280 9pnet_rdma rpcrdma nvmet-rdma nvme-rdma hid-picolcd hid-prodikeys hwa-hc hwpoison-inject hid-sensor-hub target_core_user sbp_target cxgbit iw_cxgb3 iw_cxgb4 cxgb3i cxgb3i cxgb3i_ddp cxgb4i chcr chtls parport_serial ism hid-asus" +singlemods="ntb_netdev iscsi_ibft iscsi_boot_sysfs megaraid pmcraid qedi qla1280 9pnet_rdma rpcrdma nvmet-rdma nvme-rdma hid-picolcd hid-prodikeys hwa-hc hwpoison-inject hid-sensor-hub target_core_user sbp_target cxgbit iw_cxgb3 iw_cxgb4 cxgb3i cxgb3i cxgb3i_ddp cxgb4i chcr chtls parport_serial ism regmap-sdw regmap-sdw-mbq arizona-micsupp hid-asus" # Grab the arch-specific filter list overrides source ./filter-$2.sh @@ -138,6 +138,7 @@ done # Just kill sound. filter_dir $1 kernel/sound +filter_dir $1 kernel/drivers/soundwire # Now go through and filter any single .ko files that might have deps on the # things we filtered above -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1294 ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[OS-BUILD PATCHv2 0/2] redhat/configs: sound configuration cleanups and updates
From: Jaroslav Kysela on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1294 NOTE: Truncated patchset since committer email 'ptalb...@redhat.com' does not match the submitter's GitLab public email address 'jkys...@redhat.com'. Ensure that the ARK configuration follows RHEL 8.5. Especially the Intel SoundWire drivers were not included and many Intel SOF driver configurations were not in sync. Also use power save settings for HDA and AC97 drivers from Fedora. Hopefully, the drivers are fixed now (the problematic hardware is detected automatically and the power save is turned off unless the user force this functionality). The patchset contains also many cleanups (reshuffling) for common tree for CONFIG_SND and CONFIG_SOUNDWIRE configuration options. --- redhat/configs/ark/generic/x86/x86_64/CONFIG_SND_SOC => redhat/configs/ark/generic/x86/CONFIG_SND_SOC | 0 redhat/configs/ark/generic/x86/CONFIG_SND_SOC_NAU8824 | 1 + redhat/configs/ark/generic/CONFIG_SND_AC97_POWER_SAVE_DEFAULT | 1 - redhat/configs/ark/generic/CONFIG_SND_HDA_PREALLOC_SIZE | 1 - redhat/configs/ark/generic/CONFIG_SND_SEQUENCER_OSS | 1 + redhat/configs/ark/generic/CONFIG_SND_SIMPLE_CARD_UTILS | 1 + redhat/configs/common/debug/CONFIG_SND_SOC_SOF_DEBUG | 1 + redhat/configs/fedora/generic/x86/x86_64/CONFIG_SND_SOC_SSM4567 => redhat/configs/common/generic/x86/i686/CONFIG_SND_SOC_SSM4567 | 0 redhat/configs/common/generic/x86/CONFIG_SND_AD1889 | 1 + redhat/configs/common/generic/x86/CONFIG_SND_ALI5451 | 1 + redhat/configs/common/generic/x86/CONFIG_SND_ASIHPI | 1 + redhat/configs/common/generic/x86/CONFIG_SND_ATIIXP | 1 + redhat/configs/common/generic/x86/CONFIG_SND_ATIIXP_MODEM | 1 + redhat/configs/fedora/generic/x86/CONFIG_SND_HDA_PREALLOC_SIZE => redhat/configs/common/generic/x86/CONFIG_SND_HDA_PREALLOC_SIZE | 0 redhat/configs/ark/generic/CONFIG_SND_INTEL8X0 => redhat/configs/common/generic/x86/CONFIG_SND_INTEL8X0 | 0 redhat/configs/ark/generic/CONFIG_SND_INTEL8X0M => redhat/configs/common/generic/x86/CONFIG_SND_INTEL8X0M | 0 redhat/configs/ark/generic/CONFIG_SND_PCSP => redhat/configs/common/generic/x86/CONFIG_SND_PCSP | 0 redhat/configs/common/generic/x86/CONFIG_SND_SOC_CS42L42 | 1 + redhat/configs/common/generic/x86/CONFIG_SND_SOC_DA7213 | 1 + redhat/configs/common/generic/x86/CONFIG_SND_SOC_DMIC | 1 + redhat/configs/common/generic/x86/CONFIG_SND_SOC_ES8316 | 1 + redhat/configs/common/generic/x86/CONFIG_SND_SOC_HDAC_HDA | 1 + redhat/configs/common/generic/x86/CONFIG_SND_SOC_HDAC_HDMI
[OS-BUILD PATCHv2 1/2] redhat/configs: sound configuration cleanups and updates
From: Jaroslav Kysela redhat/configs: sound configuration cleanups and updates Ensure that the ARK configuration follows RHEL 8.5. Especially the Intel SoundWire drivers were not included and many Intel SOF driver configurations were not in sync. Also use power save settings for HDA and AC97 drivers from Fedora. Hopefully, the drivers are fixed now (the problematic hardware is detected automatically and the power save is turned off unless the user force this functionality). The patchset contains also many cleanups (reshuffling) for common tree for CONFIG_SND and CONFIG_SOUNDWIRE configuration options. Signed-off-by: Jaroslav Kysela diff --git a/redhat/configs/ark/generic/CONFIG_SND_AC97_POWER_SAVE_DEFAULT b/redhat/configs/ark/generic/CONFIG_SND_AC97_POWER_SAVE_DEFAULT deleted file mode 100644 index blahblah..blahblah 0 --- a/redhat/configs/ark/generic/CONFIG_SND_AC97_POWER_SAVE_DEFAULT +++ /dev/null @@ -1 +0,0 @@ -CONFIG_SND_AC97_POWER_SAVE_DEFAULT=5 diff --git a/redhat/configs/ark/generic/CONFIG_SND_HDA_PREALLOC_SIZE b/redhat/configs/ark/generic/CONFIG_SND_HDA_PREALLOC_SIZE deleted file mode 100644 index blahblah..blahblah 0 --- a/redhat/configs/ark/generic/CONFIG_SND_HDA_PREALLOC_SIZE +++ /dev/null @@ -1 +0,0 @@ -CONFIG_SND_HDA_PREALLOC_SIZE=512 diff --git a/redhat/configs/ark/generic/CONFIG_SND_SEQUENCER_OSS b/redhat/configs/ark/generic/CONFIG_SND_SEQUENCER_OSS new file mode 100644 index blahblah..blahblah 100644 --- /dev/null +++ b/redhat/configs/ark/generic/CONFIG_SND_SEQUENCER_OSS @@ -0,0 +1 @@ +# CONFIG_SND_SEQUENCER_OSS is not set diff --git a/redhat/configs/ark/generic/CONFIG_SND_SIMPLE_CARD_UTILS b/redhat/configs/ark/generic/CONFIG_SND_SIMPLE_CARD_UTILS new file mode 100644 index blahblah..blahblah 100644 --- /dev/null +++ b/redhat/configs/ark/generic/CONFIG_SND_SIMPLE_CARD_UTILS @@ -0,0 +1 @@ +# CONFIG_SND_SIMPLE_CARD_UTILS is not set diff --git a/redhat/configs/ark/generic/x86/x86_64/CONFIG_SND_SOC b/redhat/configs/ark/generic/x86/CONFIG_SND_SOC rename from redhat/configs/ark/generic/x86/x86_64/CONFIG_SND_SOC rename to redhat/configs/ark/generic/x86/CONFIG_SND_SOC index blahblah..blahblah 100644 --- a/redhat/configs/ark/generic/x86/x86_64/CONFIG_SND_SOC +++ b/redhat/configs/ark/generic/x86/CONFIG_SND_SOC diff --git a/redhat/configs/ark/generic/x86/CONFIG_SND_SOC_NAU8824 b/redhat/configs/ark/generic/x86/CONFIG_SND_SOC_NAU8824 new file mode 100644 index blahblah..blahblah 100644 --- /dev/null +++ b/redhat/configs/ark/generic/x86/CONFIG_SND_SOC_NAU8824 @@ -0,0 +1 @@ +CONFIG_SND_SOC_NAU8824=m diff --git a/redhat/configs/common/debug/CONFIG_SND_SOC_SOF_DEBUG b/redhat/configs/common/debug/CONFIG_SND_SOC_SOF_DEBUG new file mode 100644 index blahblah..blahblah 100644 --- /dev/null +++ b/redhat/configs/common/debug/CONFIG_SND_SOC_SOF_DEBUG @@ -0,0 +1 @@ +CONFIG_SND_SOC_SOF_DEBUG=y diff --git a/redhat/configs/fedora/generic/CONFIG_SND_AC97_POWER_SAVE_DEFAULT b/redhat/configs/common/generic/CONFIG_SND_AC97_POWER_SAVE_DEFAULT rename from redhat/configs/fedora/generic/CONFIG_SND_AC97_POWER_SAVE_DEFAULT rename to redhat/configs/common/generic/CONFIG_SND_AC97_POWER_SAVE_DEFAULT index blahblah..blahblah 100644 --- a/redhat/configs/fedora/generic/CONFIG_SND_AC97_POWER_SAVE_DEFAULT +++ b/redhat/configs/common/generic/CONFIG_SND_AC97_POWER_SAVE_DEFAULT diff --git a/redhat/configs/common/generic/CONFIG_SND_AD1889 b/redhat/configs/common/generic/CONFIG_SND_AD1889 index blahblah..blahblah 100644 --- a/redhat/configs/common/generic/CONFIG_SND_AD1889 +++ b/redhat/configs/common/generic/CONFIG_SND_AD1889 @@ -1 +1 @@ -CONFIG_SND_AD1889=m +# CONFIG_SND_AD1889 is not set diff --git a/redhat/configs/common/generic/CONFIG_SND_ALI5451 b/redhat/configs/common/generic/CONFIG_SND_ALI5451 index blahblah..blahblah 100644 --- a/redhat/configs/common/generic/CONFIG_SND_ALI5451 +++ b/redhat/configs/common/generic/CONFIG_SND_ALI5451 @@ -1 +1 @@ -CONFIG_SND_ALI5451=m +# CONFIG_SND_ALI5451 is not set diff --git a/redhat/configs/common/generic/CONFIG_SND_ASIHPI b/redhat/configs/common/generic/CONFIG_SND_ASIHPI index blahblah..blahblah 100644 --- a/redhat/configs/common/generic/CONFIG_SND_ASIHPI +++ b/redhat/configs/common/generic/CONFIG_SND_ASIHPI @@ -1 +1 @@ -CONFIG_SND_ASIHPI=m +# CONFIG_SND_ASIHPI is not set diff --git a/redhat/configs/common/generic/CONFIG_SND_ATIIXP b/redhat/configs/common/generic/CONFIG_SND_ATIIXP index blahblah..blahblah 100644 --- a/redhat/configs/common/generic/CONFIG_SND_ATIIXP +++ b/redhat/configs/common/generic/CONFIG_SND_ATIIXP @@ -1 +1 @@ -CONFIG_SND_ATIIXP=m +# CONFIG_SND_ATIIXP is not set diff --git a/redhat/configs/common/generic/CONFIG_SND_ATIIXP_MODEM b/redhat/configs/common/generic/CONFIG_SND_ATIIXP_MODEM index blahblah..blahblah 100644 --- a/redhat/configs/common/generic/CONFIG_SND_ATIIXP_MODEM +++ b/redhat/configs/common/generic/CONFIG_SND_ATIIXP_MODEM @@ -1 +1 @@ -CONFIG_SND_ATIIXP_MODEM=m +# CONFIG_SND_ATIIXP_MODEM is not set diff --git
Re: [OS-BUILD PATCH] Revert "redhat: ark: disable CONFIG_NET_SCH_MULTIQ"
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1309#note_652741351 Acked-by: Patrick Talbert (via approve button) ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCH] redhat/configs: Disable Soft-RoCE driver
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1299#note_652728351 Taking this as is given it was submitted by the subsystem's maintainer and only reviewer. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
