Re: [OS-BUILD PATCH] Revert "redhat: configs: Disable xtables and ipset"
From: Jonathan Toppins on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2267#note_1254156562 `Maybe moving the modules to kernel-modules-extra could be an option?` Sure, that might work. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH] Revert "Merge branch 'ark-make-help' into 'os-build'"
From: Jonathan Toppins on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2158#note_1180311795
It won't work without the second colon either as make doesn't like rules that
rewrite previously defined rules. The issue is the upstream kernel Makefile is
included and the help target is being defined. The solution is to not define
the `help:` target when Makefile is included.
Another possible solution is to use submake for all targets, maybe something
like:
```
# if only upstream goals or empty in $(MAKECMDGOALS)
%:
$(MAKE) -f Makefile $(MAKECMDGOALS)
# else
help:
# do help goal
_OUTPUT := "."
# this section is needed in order to make O= to work
ifeq ("$(origin O)", "command line")
_OUTPUT := "$(abspath $(O))"
_EXTRA_ARGS := O=$(_OUTPUT)
endif
dist-%::
$(MAKE) -C redhat $(@) $(_EXTRA_ARGS)
distg-%::
$(MAKE) -C redhat $(@) $(_EXTRA_ARGS)
# endif
```
This obviously prevents someone from doing something like `make dist-brew
mrproper`, I don't know how many are doing that.
A longer term solution is to convince upstream to reserve the `dist%:` target
namespace and use an optional file `scripts/Makefile.dist` which would
implement the `dist%` targets. Then the standard upstream help and other
infrastructure could be directly extended to present more information if this
optional Makefile.dist file exists.
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[OS-BUILD PATCHv2 1/2] redhat: make RHTEST stricter
From: Jonathan Toppins redhat: make RHTEST stricter The test would originally match on any `-n` that existed in the MAKEFLAGS variable. This is not correct. Signed-off-by: Jonathan Toppins diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -19,7 +19,7 @@ SPECRELEASED_KERNEL=$(RELEASED_KERNEL) SPECINCLUDE_FEDORA_FILES=$(INCLUDE_FEDORA_FILES) SPECINCLUDE_RHEL_FILES=$(INCLUDE_RHEL_FILES) -ifneq (,$(findstring n,$(MAKEFLAGS))) +ifneq (,$(findstring n,$(filter-out --%,$(MAKEFLAGS # Do not set RHTEST on the command line. Use the make command built-in options # -n, --just-print, --dry-run, --recon on the command line. RHTEST=1 -- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2144 ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[OS-BUILD PATCHv2 2/2] redhat: override `make help` to include dist-help
From: Jonathan Toppins
redhat: override `make help` to include dist-help
Override the upstream kernel `make help` target so we can inject
distribution targets at the top of the help output.
Signed-off-by: Jonathan Toppins
diff --git a/makefile b/makefile
index blahblah..blahblah 100644
--- a/makefile
+++ b/makefile
@@ -1,16 +1,24 @@
-ifeq ($(filter dist-% distg-%,$(MAKECMDGOALS)),)
+ifeq ($(filter help dist-% distg-%,$(MAKECMDGOALS)),)
include Makefile
endif
+MAKEFLAGS += --no-print-directory
_OUTPUT := "."
# this section is needed in order to make O= to work
ifeq ("$(origin O)", "command line")
_OUTPUT := "$(abspath $(O))"
_EXTRA_ARGS := O=$(_OUTPUT)
endif
+help::
+ @echo "## Distribution Targets"
+ @$(MAKE) -C redhat dist-help
+ @echo ""
+ @echo "## Kernel Targets"
+ @$(MAKE) -f Makefile $(@)
+
dist-%::
- $(MAKE) -C redhat $(@) $(_EXTRA_ARGS)
+ @$(MAKE) -C redhat $(@) $(_EXTRA_ARGS)
distg-%::
- $(MAKE) -C redhat $(@) $(_EXTRA_ARGS)
+ @$(MAKE) -C redhat $(@) $(_EXTRA_ARGS)
--
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2144
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
[OS-BUILD PATCHv2 0/2] redhat: override `make help` to include dist-help
From: Jonathan Toppins on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2144 Override the upstream kernel `make help` target so we can inject distribution targets at the top of the help output. Signed-off-by: Jonathan Toppins --- redhat/Makefile | 2 +- makefile| 14 +++--- 2 files changed, 12 insertions(+), 4 deletions(-) ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH] redhat: override `make help` to include dist-help
From: Jonathan Toppins on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2144#note_1171607519 Nice find. How would you like me to deal with it? Create a new commit, rebase, something else? ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH] redhat: override `make help` to include dist-help
From: Jonathan Toppins on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2144#note_1171422514 The only change that would even have a possibility is the `MAKEFLAGS += --no- print-directory` change. I don't see why not printing the directory descending into would cause an issue with dist-srpm. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH] redhat: override `make help` to include dist-help
From: Jonathan Toppins on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2144#note_1169651942 Doesn't look like anything I touched. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH] redhat: override `make help` to include dist-help
From: Jonathan Toppins on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2144#note_1169391956 Don't know what you expect me to do about a failed merge label, without some sort of log. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv2] redhat/configs/common: Turn on CONFIG_IKCONFIG_PROC
From: Jonathan Toppins on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2041#note_1124315349 All of these reasons are why I do not recommend using the `/proc` config entry unless the system has a non-standard storage configuration that prevents the storage of the config in `/boot`. For example if we store an initramfs in NVRAM and no real packages exist, then ok store the kernel config in the kernel because multiple kernels can boot the same initramfs and we do not want to waste writes to the initramfs as we update the kernel. If the auto team is targeting a platform with this odd storage configuration then I would recommend an auto specific config change for this highly embedded platform. I do not recommend this configuration for general RHEL. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[OS-BUILD PATCH] Revert "ice: mark driver as tech-preview"
From: Jonathan Toppins
Revert "ice: mark driver as tech-preview"
This reverts commit 642c4ae991474c59124e20ad9531dcbd47743e58.
Signed-off-by: Jonathan Toppins
diff --git a/drivers/net/ethernet/intel/ice/ice_main.c
b/drivers/net/ethernet/intel/ice/ice_main.c
index blahblah..blahblah 100644
--- a/drivers/net/ethernet/intel/ice/ice_main.c
+++ b/drivers/net/ethernet/intel/ice/ice_main.c
@@ -5063,7 +5063,6 @@ static int __init ice_module_init(void)
pr_info("%s\n", ice_driver_string);
pr_info("%s\n", ice_copyright);
- mark_tech_preview(DRV_SUMMARY, THIS_MODULE);
ice_wq = alloc_workqueue("%s", WQ_MEM_RECLAIM, 0, KBUILD_MODNAME);
if (!ice_wq) {
--
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1298
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
