Re: [OS-BUILD PATCHv2] redhat/configs: create a separate config for gcov options

2021-10-21 Thread Jan Stancek (via Email Bridge) 
From: Jan Stancek on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1433#note_710461665

Scratch build failed on noarch build, I'm moving it to Draft so it's not
merged yet.
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Re: [OS-BUILD PATCHv2] redhat/configs: create a separate config for gcov options

2021-10-20 Thread Justin M. Forbes (via Email Bridge) 
From: Justin M. Forbes on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1433#note_709390882

I am generally okay with this approach. As a separate MR from someone, it
might be interesting to have the config scripts actually do a full check, but
instead of error, just print out issues so that people can be aware of what is
being changed.  Particularly in the gcov case, it would be interesting to see
what is not getting the coverage that we expect because the config was flipped
to off.
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Re: [OS-BUILD PATCHv2] redhat/configs: create a separate config for gcov options

2021-10-20 Thread Don Zickus (via Email Bridge) 
From: Don Zickus on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1433#note_709380590

@jstancek - interesting approach.  I am open to this latest change.  We might
be able to use something similar for -rt and/or -auto and future variants.
@jmflinuxtx - any thoughts on this approach.
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Re: [OS-BUILD PATCHv2] redhat/configs: create a separate config for gcov options

2021-10-20 Thread Don Zickus (via Email Bridge) 
From: Don Zickus on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1433#note_709358307

Just an FYI, the CKI team is looking to heavily use gcov as part of the
testing process.  In fact, this might be required for us to get certified for
Functional Safety Linux in Auto.  So I would like to add another level of
seriousness to the use of gcov.

That doesn't imply we need to add complexity, I just want to ensure some
control I think.
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[OS-BUILD PATCHv2] redhat/configs: create a separate config for gcov options

2021-10-20 Thread Jan Stancek (via Email Bridge) 
From: Jan Stancek 

redhat/configs: create a separate config for gcov options

Use existing config infrastructure to build and validate
gcov-enabled configs. Meaning for each arch we also apply
GCOV options on top and validate it.

From same options dir (kgcov) build also partial config, which
contains only GCOV options. We can merge this partial config
during build on top of existing config, which avoids the need
to store all possible combinations in dist-git and SRPM.

Signed-off-by: Jan Stancek 

diff --git a/redhat/Makefile b/redhat/Makefile
index blahblah..blahblah 100644
--- a/redhat/Makefile
+++ b/redhat/Makefile
@@ -141,6 +141,7 @@ dist-configs-check: dist-configs-prep
cd $(REDHAT)/configs; ./process_configs.sh 
$(PROCESS_CONFIGS_CHECK_OPTS) $(PACKAGE_NAME)
 
 dist-configs-prep: dist-clean-configs dist-buildreq-check
+   cd $(REDHAT)/configs; ./build_configs.sh "partial" "$(ARCH_MACH)" "snip"
cd $(REDHAT)/configs; ./build_configs.sh "$(PACKAGE_NAME)" 
"$(ARCH_MACH)" "$(FLAVOR)"
 
 dist-configs-arch: ARCH_MACH = $(MACH)
@@ -259,6 +260,7 @@ sources-rh: $(TARBALL) generate-testpatch-tmp setup-source 
dist-configs-check
keys/rhel*.x509 \
kabi/check-kabi \
configs/$(PACKAGE_NAME)-*.config \
+   configs/partial*.config \
gating.yaml \
rpminspect.yaml \
update_scripts.sh \
diff --git a/redhat/configs/.gitignore b/redhat/configs/.gitignore
index blahblah..blahblah 100644
--- a/redhat/configs/.gitignore
+++ b/redhat/configs/.gitignore
@@ -1,5 +1,6 @@
 *merged
 config-*
 kernel*config
+partial*config
 *.old
 *.tmp
diff --git a/redhat/configs/common/kgcov/CONFIG_GCOV_KERNEL 
b/redhat/configs/common/kgcov/CONFIG_GCOV_KERNEL
new file mode 100644
index blahblah..blahblah 100644
--- /dev/null
+++ b/redhat/configs/common/kgcov/CONFIG_GCOV_KERNEL
@@ -0,0 +1 @@
+CONFIG_GCOV_KERNEL=y
diff --git a/redhat/configs/common/kgcov/CONFIG_GCOV_PROFILE_ALL 
b/redhat/configs/common/kgcov/CONFIG_GCOV_PROFILE_ALL
new file mode 100644
index blahblah..blahblah 100644
--- /dev/null
+++ b/redhat/configs/common/kgcov/CONFIG_GCOV_PROFILE_ALL
@@ -0,0 +1 @@
+CONFIG_GCOV_PROFILE_ALL=y
diff --git a/redhat/configs/common/kgcov/CONFIG_GCOV_PROFILE_FTRACE 
b/redhat/configs/common/kgcov/CONFIG_GCOV_PROFILE_FTRACE
new file mode 100644
index blahblah..blahblah 100644
--- /dev/null
+++ b/redhat/configs/common/kgcov/CONFIG_GCOV_PROFILE_FTRACE
@@ -0,0 +1 @@
+# CONFIG_GCOV_PROFILE_FTRACE is not set
diff --git a/redhat/configs/priority.fedora b/redhat/configs/priority.fedora
index blahblah..blahblah 100644
--- a/redhat/configs/priority.fedora
+++ b/redhat/configs/priority.fedora
@@ -22,26 +22,33 @@ EMPTY=s390x-zfcpdump
 # x86_64
 x86_64=generic:generic-x86:generic-x86-x86_64
 x86_64-debug=generic:generic-x86:generic-x86-x86_64:debug:debug-x86-x86_64
+x86_64-kgcov=generic:generic-x86:generic-x86-x86_64:kgcov
 
 # i686
 i686=generic:generic-x86:generic-x86-i686
 i686-debug=generic:generic-x86:generic-x86-i686:debug:debug-x86
+i686-kgcov=generic:generic-x86:generic-x86-i686:kgcov
 
 # ppc64le
 ppc64le=generic:generic-powerpc
 ppc64le-debug=generic:generic-powerpc:debug:debug-powerpc
+ppc64le-kgcov=generic:generic-powerpc:kgcov
 
 # s390x
 s390x=generic:generic-s390x
 s390x-debug=generic:generic-s390x:debug:debug-s390x
+s390x-kgcov=generic:generic-s390x:kgcov
 
 # aarch64
 aarch64=generic:generic-arm:generic-arm-aarch64
 aarch64-debug=generic:generic-arm:generic-arm-aarch64:debug:debug-arm-aarch64
+aarch64-kgcov=generic:generic-arm:generic-arm-aarch64:kgcov
 
 # arm
 armv7hl=generic:generic-arm:generic-arm-armv7:generic-arm-armv7-armv7
 
armv7hl-debug=generic:generic-arm:generic-arm-armv7:generic-arm-armv7-armv7:debug:debug-arm
+armv7hl-kgcov=generic:generic-arm:generic-arm-armv7:generic-arm-armv7-armv7:kgcov
 armv7hl-lpae=generic:generic-arm:generic-arm-armv7:generic-arm-armv7-lpae
 
armv7hl-lpae-debug=generic:generic-arm:generic-arm-armv7:generic-arm-armv7-lpae:debug:debug-arm
+armv7hl-lpae-kgcov=generic:generic-arm:generic-arm-armv7:generic-arm-armv7-lpae:kgcov
 
diff --git a/redhat/configs/priority.rhel b/redhat/configs/priority.rhel
index blahblah..blahblah 100644
--- a/redhat/configs/priority.rhel
+++ b/redhat/configs/priority.rhel
@@ -22,15 +22,20 @@ EMPTY=armv7hl armv7hl-debug armv7hl-lpae armv7hl-lpae-debug 
i686 i686-debug
 # x86_64
 x86_64=generic:generic-x86:generic-x86-x86_64
 x86_64-debug=generic:generic-x86:generic-x86-x86_64:debug:debug-x86-x86_64
+x86_64-kgcov=generic:generic-x86:generic-x86-x86_64:kgcov
 
 # ppc64le
 ppc64le=generic:generic-powerpc
 ppc64le-debug=generic:generic-powerpc:debug:debug-powerpc
+ppc64le-kgcov=generic:generic-powerpc:kgcov
 
 # s390x
 s390x=generic:generic-s390x
 s390x-debug=generic:generic-s390x:debug:debug-s390x
 s390x-zfcpdump=generic:generic-s390x:generic-s390x-zfcpdump
+s390x-kgcov=generic:generic-s390x:kgcov
+
 # aarch64
 aarch64=generic:generic-arm:generic-arm-aarch64
 aarch6