Re: [OS-BUILD PATCH] Enable e1000 in rhel9 as unsupported
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1382#note_722529302 We're in the process of discussing. See draft MR https://gitlab.com/cki- project/kernel-ark/-/merge_requests/1459 ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCH] Enable e1000 in rhel9 as unsupported
From: pbrobinson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1382#note_722326367 According to a reference from elsewhere if it's enabled it's supported: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1307#note_660023445 ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCH] Enable e1000 in rhel9 as unsupported
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1382#note_722300776 @prarit - what is the current policy with mark_driver_unsupported? do you know? ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCH] Enable e1000 in rhel9 as unsupported
From: Justin M. Forbes on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1382#note_721117226
That is really a RHEL call, it just seemed the natural thing to do given it
exists. Either way, it needs to be wrapped, because this driver is just as
supported as anything else we build for Fedora, and should not taint the
Fedora kernel.
```
#ifdef CONFIG_RHEL_DIFFERENCES
add_taint(TAINT_SUPPORT_REMOVED, LOCKDEP_STILL_OK);
pr_warn("E1000 MODULE IS NOT SUPPORTED\n");
#endif
```
Or replace the pr_warn with mark_driver_unsupported.
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCH] Enable e1000 in rhel9 as unsupported
From: Ken Cox on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1382#note_721057450 Justin, Regarding mark_driver_unsupported, it looks like it only prints a warning. Don't we need to also set the tainted flag? I was using other unsupported drivers (mptsas) as a reference. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCH] Enable e1000 in rhel9 as unsupported
From: Jarod Wilson on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1382#note_691851133 Yeah, what Justin said. Some of this was already done in another MR... was that for CentOS Stream 9? Do we want to sync the CONFIG_RHEL_DIFFERENCES bit into there as well? ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCH] Enable e1000 in rhel9 as unsupported
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1382#note_679632977 This should be wrapped in CONFIG_RHEL_DIFFERENCES so that it does not impact Fedora. It should probably also use mark_driver_unsupported rather than TAINT_SUPPORT_REMOVED. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
