Re: [OS-BUILD PATCHv2 0/2] redhat/kernel.spec: add uki_addons to create UKI kernel cmdline addons
From: Daniel P. Berrangé on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2917#note_1760942365 So IIUC, essentially each '.addon' would become a new "SourceNNN" line in the kernel.spec. I prefer that to the CSV file as it makes it more configurable during build. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv2 0/2] redhat/kernel.spec: add uki_addons to create UKI kernel cmdline addons
From: Emanuele Giuseppe Esposito on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2917#note_1760866217 I am not sure I understand the question. What do you mean with where is it supposed to be needed? This is necessary in order to build the UKI addons -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv2 0/2] redhat/kernel.spec: add uki_addons to create UKI kernel cmdline addons
From: Emanuele Giuseppe Esposito on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2917#note_1760864399 @prudo1 what about the SBAT? we might want to add that too. But then that may be shared between all addons I guess @berrange what do you think of the filesystem based structure described above? I think it might make sense. We would have a root folder redhat/addons and inside an arch hierarchy (or anything you want). For example ``` ls redhat/addons x86_64 output sbat ... ls redhat/addons/sbat sbat.conf cat redhat/addons/sbat/sbat.conf sbat,1,.. uki.addon,1, ls redhat/addons/x86_64 fips.addon kdump ... cat redhat/addons/x86_64/fips # fips cmdline fips=1 ls redhat/addons/x86_64/kdump addon-something.addon cat redhat/addons/x86_64/kdump/addon-something # this addon is useful for ??? crashkernel= ``` And when the build is triggered, we get two addons in redhat/addons/output: ``` fips-x86_64.addon.efi (cmdline="fips=1" sbat="cat sbat.conf") addon-something-kdump-x86_64.addon.efi (cmdline="crashkernel=???" sbat="cat sbat.conf") ``` What do you think? -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv2 0/2] redhat/kernel.spec: add uki_addons to create UKI kernel cmdline addons
From: Philipp Rudo on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2917#note_1758222573 I'm also not convinced that having all the addons in a single config file makes sense. I'm looking at it from an kdump perspective. There we need to have the crashkernel= parameter on the command line. Where varies depending on the used hardware/setup. The only solution I came up with so far is to spam the system with a big number of predefined 's so users can pick the one they need. But IIUC this would require a huge amount of almost identical addon definitions in the config, which I don't think makes sense. Why don't you use a filesystem based structure similar to the kernel configs? Where the filename becomes the addon name, a comment replaces the description and, every following line is a command line to be signed. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv2 0/2] redhat/kernel.spec: add uki_addons to create UKI kernel cmdline addons
From: Michael Hofmann on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2917#note_1753957414 @eesposit this is not in the CKI buildroot yet - where is this supposed to be needed going forward? -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv2 0/2] redhat/kernel.spec: add uki_addons to create UKI kernel cmdline addons
From: Daniel P. Berrangé on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2917#note_1753784734 But at that point we might as well just use the ukify tool directly. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCHv2 0/2] redhat/kernel.spec: add uki_addons to create UKI kernel cmdline addons
From: Daniel P. Berrangé on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2917#note_1753782383 Looking at this config file, I'm not entirely convinced that we benefit from having this in a config file, and it has downsides in lack of flexibility. For example, consider that as we expand UKIs to multiple architectures, we'll almost certainly need to have different addons on each arch. We could create extra config files per arch for those, but the amount of info in the file doesn't appear all that compelling. Consider if the python tool just accepted the data on the cli: ``` # Enable fips in RHEL (https://issues.redhat.com/browse/RHEL-23049) python3 ukiaddon.py --output $KernelAddonsDir/fips.addon --cmdline "fips=1" ``` Then each invokation of ukiaddon.py can be conditionalized based on whatever rpm spec conditions are needed. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
