Re: [OS-BUILD PATCHv3 0/5] ark: Set Architecture Level Set to Z14 for s390
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1144#note_600799175 Editing a comment in GL does not generate a webhook event so the ack_nack bot won't be aware of the change until something else triggers a run of it. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCHv3 0/5] ark: Set Architecture Level Set to Z14 for s390
From: Daniel Horak on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1144#note_600764882 let retry :-) Acked-by: Dan Horák ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCHv3 0/5] ark: Set Architecture Level Set to Z14 for s390
From: Florian Weimer on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1144#note_598979089
Current GCC compiles this code to use the `msrkc` instruction:
```c
#include
int
f (int a, int b)
{
int result;
if (__builtin_mul_overflow (a, b, ))
abort ();
return result;
}
int
main (int argc, char **argv)
{
return f (atoi (argv[1]), atoi (argv[2]));
}
```
Maybe not exactly common, but also not super-obscure. I think the kernel uses
`__builtin_mul_overflow` in some places. `s390.md` in GCC has patterns for
the other instructions, too, search for `TARGET_Z14`.
The sort-of working aspect was the reason why I added the run-time check to
glibc. I was worried that without it, some z14 binaries will appear to work,
but crash in obscure ways for some operations because GCC happened to emit one
of the new instructions.
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCHv3 0/5] ark: Set Architecture Level Set to Z14 for s390
From: Daniel Horak on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1144#note_598845029 LGTM Acked-by: Dan Horák [dho...@redhat.com](mailto:dho...@redhat.com) ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCHv3 0/5] ark: Set Architecture Level Set to Z14 for s390
From: Cornelia Huck on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1144#note_598834211 Just for the record, re-adding my ack: Acked-by: Cornelia Huck ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCHv3 0/5] ark: Set Architecture Level Set to Z14 for s390
From: Thomas Huth on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1144#note_598697074 If I've got that right, the z14 introduced the "Miscellaneous-Instruction- Extensions Facility 2" which provides a bunch of new instructions: * ADD HALFWORD (AGH) * BRANCH INDIRECT ON CONDITION * MULTIPLY (MG, MGRK) * MULTIPLY HALFWORD (MGH) * MULTIPLY SINGLE (MSC, MSGC, MSGRKC, MSRKC) * SUBTRACT HALFWORD (SGH) Not sure whether compilers will make use of this, though... ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCHv3 0/5] ark: Set Architecture Level Set to Z14 for s390
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1144#note_598568514 thanks @jmflinuxtx ! I am fine with this change (namely the dummy-tools). @dhorak1 - any other issues? care to ack? I see @cohuck already acked. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCHv3 0/5] ark: Set Architecture Level Set to Z14 for s390
From: Justin Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1144#note_596135080 > is it worth throwing a 'include in release' label and seeing if this can build in eln? I have tagged it with "include in release" and done a test build with it against ELN koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=69629902 The test build was successful, though I can't boot it anywhere to verify that it is working as intended. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCHv3 0/5] ark: Set Architecture Level Set to Z14 for s390
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1144#note_595946671 @jmflinuxtx - is it worth throwing a 'include in release' label and seeing if this can build in eln? @veruu - i can probably hack up the gitlab-ci.yml file like i did in another MR to try a CKI build job? ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCHv3 0/5] ark: Set Architecture Level Set to Z14 for s390
From: Philipp Rudo on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1144#note_595925875 sure. BTW I'm joining RH so the email and accounts will still exist in the future. Nevertheless I guess it would be better if someone else takes over if we there's a delay. Don't know when I'll be back online again after I started. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCHv3 0/5] ark: Set Architecture Level Set to Z14 for s390
From: Philipp Rudo on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1144#note_595920020 @dzickusrh this MR can be build on any machine with an appropriate compiler (IIRC GCC10). Only the resulting kernel requires a z14+ to run. I know that the change is necessary. I was more afraid that there I introduce some suptle bug by accidentally enabling some config. But running make oldconfig should remedy that. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCHv3 0/5] ark: Set Architecture Level Set to Z14 for s390
From: Justin Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1144#note_595919862 > glibc 2.34 will detect `-march=z14` and refuse to run on z13 or earlier, to avoid hard-to-diagnose crashes later. We learned the hard way that this very desirable during the ppc64le bringup. Would it still detect this if the kernel running in the build root is a z13 kernel? There are kernel advantages to limiting supported hardware, but z13 added the vector bits, I don't recall z14 adding much instruction wise, so perhaps there is no benefit to building userspace with z14? ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCHv3 0/5] ark: Set Architecture Level Set to Z14 for s390
From: Florian Weimer on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1144#note_595913747 glibc 2.34 will detect `-march=z14` and refuse to run on z13 or earlier, to avoid hard-to-diagnose crashes later. We learned the hard way that this very desirable during the ppc64le bringup. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCHv3 0/5] ark: Set Architecture Level Set to Z14 for s390
From: Justin Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1144#note_595910611 > do we know which s390x machines ELN builds on? The koji builders are Z13. They are running a Fedora kernel to do the build, so the 5.13-rc5 eln build was done in koji running 5.12.8-300.fc34. These tend to be updated regularly with Fedora, but we do not plan to set to Z14 in Fedora. Of course the build root is running eln userspace packages, so we would need to ensure that nothing in userspace requires Z14, or it will fail. I don't recall Z14 adding a bunch of new instructions, so this might not be an issue. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCHv3 0/5] ark: Set Architecture Level Set to Z14 for s390
From: Veronika Kabátová on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1144#note_595904290 We should be all set, the containers are all built using qemu's experimental z14 support and we do have a native z14 (or temporary z15 in case of outages...) builder for the tools. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCHv3 0/5] ark: Set Architecture Level Set to Z14 for s390
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1144#note_595897703 @prudo1 - if for some reason you have to leave before this MR is merged, are you ok with RH resubmitting your work and retaining your SOB line? ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCHv3 0/5] ark: Set Architecture Level Set to Z14 for s390
From: Don Zickus on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1144#note_595896264 @veruu - this MR will require a z14 or higher to compile ARK. CKI can handle building os-build for that right? The srpm piece doesn't matter. @jmflinuxtx - do we know which s390x machines ELN builds on? @prudo1 - i think your dummy-tools change is not only fine, but necessary. make oldconfig is run again on native builders in brew and generates the same config output as you are seeing (at least LIVEPATCH is). So even though it shows up disabled on your x86_64 box, it ends up correct later. This is why I believe your change is _necessary_ to provide a correct view of the configs that a missing arch tool is not providing. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: [OS-BUILD PATCHv3 0/5] ark: Set Architecture Level Set to Z14 for s390
From: Philipp Rudo on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1144#note_595402767 Hi, sorry for the late response. here's the v3 with what I picked up from the discussion, in particular improve the wording of the first two commit messages and leave the rest as is. While preparing v3 I noticed a nit in the first commit. In v3 I have disabled (=n) the config instead of using its default (=y) as the config requires LLD to work. I'm wondering why the pipelines didn't find this the way I see it this should have caused a build bug. I took this as a reason to have a closer look on the resulting configs and found that there are more changes than I had expected. For example on ppc CONFIG_LIVEPATCH now gets enabled, where I'm not sure if it is intended or not. At least in RHEL8 there is no livepatch support for ppc. An other example (also ppc) is CONFIG_DYNAMIC_FTRACE_WITH_REGS which also gets enabled now. What surprised me in this case is that I couldn't find a way to disable that option. Every test I made resulted in process_configs.sh to abort complaining about a configs mismatch. What confuses me is that I couldn't find any other config that selects this one. So I have no clue what overwrites my manually set value. Long story short, I'm afraid that switching to the dummy-tools is less straight forward than I thought in the first place. Thus I'm wondering if it wouldn't be better to move the change to it's own MR together with a thorough review of the resulting configs. My problem with this is that I'll be leaving my current job end of next week and thus have tons of other stuff on my mind at the moment. Meaning that someone else would need to take over that task Any comments/opinions? Thanks and sorry for the long comment Philipp ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
