[Kernel-packages] [Bug 1990690] Re: Users belonging to video group may trigger a deadlock WARN

2022-10-14 Thread Mark Eichin 
I don't know if this is where you track it, but the problem described
here appears to have made it into Ubuntu Advantage 16.04-ESM as well,
specifically across the 4.15.0-189.200~16.04.1 -> 4.15.0-193.204~16.04.1
upgrade.  (Just based on changelog text this fix was not in
4.15.0-194.205~16.04.1 but I haven't dug far enough to track more
closely.)

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1990690

Title:
  Users belonging to video group may trigger a deadlock WARN

Status in linux package in Ubuntu:
  Invalid
Status in linux source package in Bionic:
  Fix Committed

Bug description:
  [Impact]
  One of the fixing commits for CVE-2021-33655, commit 159a96b199b4
  ("fbcon: Prevent that screen size is smaller than font size") introduced
  an extraneous lock_fb_info line into the ioctl flow in fbmem.c.

  This line only exists in bionic tree.

  Users belonging to video group may trigger a deadlock and potentially
  lock the system.

  
  WARNING: possible recursive locking detected
  4.15.0-195-generic #206 Not tainted
  
  refresh/1248 is trying to acquire lock:
    (_info->lock){+.+.}, at: [<4c154cfe>] lock_fb_info+0x1d/0x40

  but task is already holding lock:
    (_info->lock){+.+.}, at: [<4c154cfe>] lock_fb_info+0x1d/0x40

  other info that might help us debug this:
    Possible unsafe locking scenario:
  CPU0
  
     lock(_info->lock);
     lock(_info->lock);

  *** DEADLOCK ***
    May be due to missing lock nesting notation
   2 locks held by refresh/1248:
    #0:  (console_lock){+.+.}, at: [<8000aa2b>] do_fb_ioctl+0x435/0x5e0
    #1:  (_info->lock){+.+.}, at: [<4c154cfe>] lock_fb_info+0x1d/0x40

  stack backtrace:
   CPU: 0 PID: 1248 Comm: refresh Not tainted 4.15.0-195-generic #206
   Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.15.0-1 04/01/2014
   Call Trace:
    dump_stack+0x98/0xd2
    __lock_acquire+0x736/0x1480
    ? sched_clock_local+0x17/0x90
    ? sched_clock+0x9/0x10
    ? sched_clock_local+0x17/0x90
    lock_acquire+0xa3/0x1e0
    ? lock_acquire+0xa3/0x1e0
    ? lock_fb_info+0x1d/0x40
    ? lock_fb_info+0x1d/0x40
    __mutex_lock+0x65/0x970
    ? lock_fb_info+0x1d/0x40
    ? sched_clock_local+0x17/0x90
    ? lock_acquire+0xa3/0x1e0
    mutex_lock_nested+0x1b/0x20
    ? mutex_lock_nested+0x1b/0x20
    lock_fb_info+0x1d/0x40
    do_fb_ioctl+0x57a/0x5e0
    ? __fd_install+0x5/0x250
    fb_ioctl+0x33/0x40
    ? fb_ioctl+0x33/0x40
    do_vfs_ioctl+0xa9/0x6d0
    ? putname+0x4c/0x60
    ? do_sys_open+0x13d/0x370
    SyS_ioctl+0x79/0x90
    do_syscall_64+0x7b/0x1e0
    entry_SYSCALL_64_after_hwframe+0x46/0xbb
   RIP: 0033:0x7f22acca7217
   RSP: 002b:7ffe2a930b48 EFLAGS: 0213 ORIG_RAX: 0010
   RAX: ffda RBX:  RCX: 7f22acca7217
   RDX: 7ffe2a930c30 RSI: 4601 RDI: 0003
   RBP: 7ffe2a930d40 R08:  R09: 
   R10:  R11: 0213 R12: 5624ac8fc7c0
   R13: 7ffe2a930e20 R14:  R15: 

  [Test case]
  Run a sample framebuffer userspace test to call FBIOPUT_VSCREENINFO
  and verified with LOCKDEP.

  [Potential regressions]
  There are no new potential regressions.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1990690/+subscriptions


-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp

[Kernel-packages] [Bug 1762816] Re: chaoskey interferes with suspend on thinkpad

2018-04-10 Thread Mark Eichin 
big chunk of kern.log with addresses and serial numbers elided.

** Attachment added: "kern.log with some privacy filtering"
   
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1762816/+attachment/5109724/+files/kern.log

** Changed in: linux (Ubuntu)
   Status: Incomplete => Confirmed

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1762816

Title:
  chaoskey interferes with suspend on thinkpad

Status in linux package in Ubuntu:
  Confirmed

Bug description:
  Thinkpad T450s, docking station, Altus Metrum Chaoskey plugged into
  the docking station - suspend fails often (more than half the time,
  maybe not 100% but easily duplicated in my setup) in that it doesn't
  seem to go all the way down - and on wakeup, lsusb output doesn't
  update, `lsusb -t` hangs when run.  It *may* require "suspend, undock,
  unsuspend" but I'm not convinced...

  Interesting logs include a "blocked for more than 120 seconds"
  traceback after restore that goes through chaoskey_disconnect even
  though the laptop is undocked so it's no longer attached:

  [17038.103142] Call Trace:
__schedule+0x297/0x8b0
schedule+0x2c/0x80
schedule_timeout+0x1cf/0x350
? ttwu_do_activate+0x7a/0x90
wait_for_completion+0xba/0x140
? wake_up_q+0x80/0x80
hwrng_unregister+0x8f/0xa0
  ***  chaoskey_disconnect+0xbe/0x110 [chaoskey] ***
usb_unbind_interface+0x77/0x290
device_release_driver_internal+0x15b/0x220
device_release_driver+0x12/0x20
bus_remove_device+0xec/0x160
device_del+0x13d/0x360
? usb_remove_ep_devs+0x1f/0x30
usb_disable_device+0x9f/0x270
usb_disconnect+0xc6/0x270
hub_quiesce+0x48/0xa0
hub_event+0xfb/0xb10
process_one_work+0x1de/0x410
worker_thread+0x32/0x410
kthread+0x121/0x140
? process_one_work+0x410/0x410
? kthread_create_worker_on_cpu+0x70/0x70
? do_syscall_64+0x73/0x130
? SyS_exit_group+0x14/0x20
ret_from_fork+0x35/0x40

  Kernel is most recently `4.15.0-13-generic #14-Ubuntu` but it's been
  going on for the last month of bionic, and *possibly* longer but I
  only recently caught that the Chaoskey was related.

  $ lsb_release -rd
  Description:Ubuntu Bionic Beaver (development branch)
  Release:18.04

  $ uname -a
  Linux workbench 4.15.0-13-generic #14-Ubuntu SMP Sat Mar 17 13:44:27 UTC 2018 
x86_64 x86_64 x86_64 GNU/Linux

  $ dpkg --status linux-image-4.15.0-13-generic
  Package: linux-image-4.15.0-13-generic
  Status: install ok installed
  Priority: optional
  Section: kernel
  Installed-Size: 72167
  Maintainer: Ubuntu Kernel Team 
  Architecture: amd64
  Source: linux
  Version: 4.15.0-13.14
  Provides: aufs-dkms, fuse-module, ivtv-modules, kvm-api-4, linux-image, 
redhat-cluster-modules, spl-dkms, spl-modules, virtualbox-guest-modules, 
zfs-dkms, zfs-modules
  Depends: kmod
  Recommends: grub-pc | grub-efi-amd64 | grub-efi-ia32 | grub | lilo, 
initramfs-tools | linux-initramfs-tool
  Suggests: fdutils, linux-doc-4.15.0 | linux-source-4.15.0, linux-tools, 
linux-headers-4.15.0-13-generic
  Description: Linux kernel image for version 4.15.0 on 64 bit x86 SMP
   This package contains the Linux kernel image for version 4.15.0 on
   64 bit x86 SMP.
   .
   Also includes the corresponding System.map file, the modules built by the
   packager, and scripts that try to ensure that the system is not left in an
   unbootable state after an update.
   .
   Supports Generic processors.
   .
   Geared toward desktop and server systems.
   .
   You likely do not want to install this package directly. Instead, install
   the linux-generic meta-package, which will ensure that upgrades work
   correctly, and that supporting packages are also installed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1762816/+subscriptions

-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp

[Kernel-packages] [Bug 1762816] Re: chaoskey interferes with suspend on thinkpad

2018-04-10 Thread Mark Eichin 
Marked confirmed per auto-comment #1 but I'm happy to add other logs on
request (not going to audit 11,000 lines of apport output if I can at
all avoid it, though.)

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1762816

Title:
  chaoskey interferes with suspend on thinkpad

Status in linux package in Ubuntu:
  Confirmed

Bug description:
  Thinkpad T450s, docking station, Altus Metrum Chaoskey plugged into
  the docking station - suspend fails often (more than half the time,
  maybe not 100% but easily duplicated in my setup) in that it doesn't
  seem to go all the way down - and on wakeup, lsusb output doesn't
  update, `lsusb -t` hangs when run.  It *may* require "suspend, undock,
  unsuspend" but I'm not convinced...

  Interesting logs include a "blocked for more than 120 seconds"
  traceback after restore that goes through chaoskey_disconnect even
  though the laptop is undocked so it's no longer attached:

  [17038.103142] Call Trace:
__schedule+0x297/0x8b0
schedule+0x2c/0x80
schedule_timeout+0x1cf/0x350
? ttwu_do_activate+0x7a/0x90
wait_for_completion+0xba/0x140
? wake_up_q+0x80/0x80
hwrng_unregister+0x8f/0xa0
  ***  chaoskey_disconnect+0xbe/0x110 [chaoskey] ***
usb_unbind_interface+0x77/0x290
device_release_driver_internal+0x15b/0x220
device_release_driver+0x12/0x20
bus_remove_device+0xec/0x160
device_del+0x13d/0x360
? usb_remove_ep_devs+0x1f/0x30
usb_disable_device+0x9f/0x270
usb_disconnect+0xc6/0x270
hub_quiesce+0x48/0xa0
hub_event+0xfb/0xb10
process_one_work+0x1de/0x410
worker_thread+0x32/0x410
kthread+0x121/0x140
? process_one_work+0x410/0x410
? kthread_create_worker_on_cpu+0x70/0x70
? do_syscall_64+0x73/0x130
? SyS_exit_group+0x14/0x20
ret_from_fork+0x35/0x40

  Kernel is most recently `4.15.0-13-generic #14-Ubuntu` but it's been
  going on for the last month of bionic, and *possibly* longer but I
  only recently caught that the Chaoskey was related.

  $ lsb_release -rd
  Description:Ubuntu Bionic Beaver (development branch)
  Release:18.04

  $ uname -a
  Linux workbench 4.15.0-13-generic #14-Ubuntu SMP Sat Mar 17 13:44:27 UTC 2018 
x86_64 x86_64 x86_64 GNU/Linux

  $ dpkg --status linux-image-4.15.0-13-generic
  Package: linux-image-4.15.0-13-generic
  Status: install ok installed
  Priority: optional
  Section: kernel
  Installed-Size: 72167
  Maintainer: Ubuntu Kernel Team 
  Architecture: amd64
  Source: linux
  Version: 4.15.0-13.14
  Provides: aufs-dkms, fuse-module, ivtv-modules, kvm-api-4, linux-image, 
redhat-cluster-modules, spl-dkms, spl-modules, virtualbox-guest-modules, 
zfs-dkms, zfs-modules
  Depends: kmod
  Recommends: grub-pc | grub-efi-amd64 | grub-efi-ia32 | grub | lilo, 
initramfs-tools | linux-initramfs-tool
  Suggests: fdutils, linux-doc-4.15.0 | linux-source-4.15.0, linux-tools, 
linux-headers-4.15.0-13-generic
  Description: Linux kernel image for version 4.15.0 on 64 bit x86 SMP
   This package contains the Linux kernel image for version 4.15.0 on
   64 bit x86 SMP.
   .
   Also includes the corresponding System.map file, the modules built by the
   packager, and scripts that try to ensure that the system is not left in an
   unbootable state after an update.
   .
   Supports Generic processors.
   .
   Geared toward desktop and server systems.
   .
   You likely do not want to install this package directly. Instead, install
   the linux-generic meta-package, which will ensure that upgrades work
   correctly, and that supporting packages are also installed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1762816/+subscriptions

-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp

[Kernel-packages] [Bug 1762816] Re: chaoskey interferes with suspend on thinkpad

2018-04-10 Thread Mark Eichin 
On inspection of apport-collect output, it doesn't appear to filter out
serial numbers or SSIDs, so I can't submit it.  Also, it seems to have
left out any of the logs where the tracebacks mentioned above were
included; I'll add at least a useful chunk of kern.log surrounding the
problem as an attachment.

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1762816

Title:
  chaoskey interferes with suspend on thinkpad

Status in linux package in Ubuntu:
  Incomplete

Bug description:
  Thinkpad T450s, docking station, Altus Metrum Chaoskey plugged into
  the docking station - suspend fails often (more than half the time,
  maybe not 100% but easily duplicated in my setup) in that it doesn't
  seem to go all the way down - and on wakeup, lsusb output doesn't
  update, `lsusb -t` hangs when run.  It *may* require "suspend, undock,
  unsuspend" but I'm not convinced...

  Interesting logs include a "blocked for more than 120 seconds"
  traceback after restore that goes through chaoskey_disconnect even
  though the laptop is undocked so it's no longer attached:

  [17038.103142] Call Trace:
__schedule+0x297/0x8b0
schedule+0x2c/0x80
schedule_timeout+0x1cf/0x350
? ttwu_do_activate+0x7a/0x90
wait_for_completion+0xba/0x140
? wake_up_q+0x80/0x80
hwrng_unregister+0x8f/0xa0
  ***  chaoskey_disconnect+0xbe/0x110 [chaoskey] ***
usb_unbind_interface+0x77/0x290
device_release_driver_internal+0x15b/0x220
device_release_driver+0x12/0x20
bus_remove_device+0xec/0x160
device_del+0x13d/0x360
? usb_remove_ep_devs+0x1f/0x30
usb_disable_device+0x9f/0x270
usb_disconnect+0xc6/0x270
hub_quiesce+0x48/0xa0
hub_event+0xfb/0xb10
process_one_work+0x1de/0x410
worker_thread+0x32/0x410
kthread+0x121/0x140
? process_one_work+0x410/0x410
? kthread_create_worker_on_cpu+0x70/0x70
? do_syscall_64+0x73/0x130
? SyS_exit_group+0x14/0x20
ret_from_fork+0x35/0x40

  Kernel is most recently `4.15.0-13-generic #14-Ubuntu` but it's been
  going on for the last month of bionic, and *possibly* longer but I
  only recently caught that the Chaoskey was related.

  $ lsb_release -rd
  Description:Ubuntu Bionic Beaver (development branch)
  Release:18.04

  $ uname -a
  Linux workbench 4.15.0-13-generic #14-Ubuntu SMP Sat Mar 17 13:44:27 UTC 2018 
x86_64 x86_64 x86_64 GNU/Linux

  $ dpkg --status linux-image-4.15.0-13-generic
  Package: linux-image-4.15.0-13-generic
  Status: install ok installed
  Priority: optional
  Section: kernel
  Installed-Size: 72167
  Maintainer: Ubuntu Kernel Team 
  Architecture: amd64
  Source: linux
  Version: 4.15.0-13.14
  Provides: aufs-dkms, fuse-module, ivtv-modules, kvm-api-4, linux-image, 
redhat-cluster-modules, spl-dkms, spl-modules, virtualbox-guest-modules, 
zfs-dkms, zfs-modules
  Depends: kmod
  Recommends: grub-pc | grub-efi-amd64 | grub-efi-ia32 | grub | lilo, 
initramfs-tools | linux-initramfs-tool
  Suggests: fdutils, linux-doc-4.15.0 | linux-source-4.15.0, linux-tools, 
linux-headers-4.15.0-13-generic
  Description: Linux kernel image for version 4.15.0 on 64 bit x86 SMP
   This package contains the Linux kernel image for version 4.15.0 on
   64 bit x86 SMP.
   .
   Also includes the corresponding System.map file, the modules built by the
   packager, and scripts that try to ensure that the system is not left in an
   unbootable state after an update.
   .
   Supports Generic processors.
   .
   Geared toward desktop and server systems.
   .
   You likely do not want to install this package directly. Instead, install
   the linux-generic meta-package, which will ensure that upgrades work
   correctly, and that supporting packages are also installed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1762816/+subscriptions

-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp

[Kernel-packages] [Bug 1762816] [NEW] chaoskey interferes with suspend on thinkpad

2018-04-10 Thread Mark Eichin 
Public bug reported:

Thinkpad T450s, docking station, Altus Metrum Chaoskey plugged into the
docking station - suspend fails often (more than half the time, maybe
not 100% but easily duplicated in my setup) in that it doesn't seem to
go all the way down - and on wakeup, lsusb output doesn't update, `lsusb
-t` hangs when run.  It *may* require "suspend, undock, unsuspend" but
I'm not convinced...

Interesting logs include a "blocked for more than 120 seconds" traceback
after restore that goes through chaoskey_disconnect even though the
laptop is undocked so it's no longer attached:

[17038.103142] Call Trace:
  __schedule+0x297/0x8b0
  schedule+0x2c/0x80
  schedule_timeout+0x1cf/0x350
  ? ttwu_do_activate+0x7a/0x90
  wait_for_completion+0xba/0x140
  ? wake_up_q+0x80/0x80
  hwrng_unregister+0x8f/0xa0
***  chaoskey_disconnect+0xbe/0x110 [chaoskey] ***
  usb_unbind_interface+0x77/0x290
  device_release_driver_internal+0x15b/0x220
  device_release_driver+0x12/0x20
  bus_remove_device+0xec/0x160
  device_del+0x13d/0x360
  ? usb_remove_ep_devs+0x1f/0x30
  usb_disable_device+0x9f/0x270
  usb_disconnect+0xc6/0x270
  hub_quiesce+0x48/0xa0
  hub_event+0xfb/0xb10
  process_one_work+0x1de/0x410
  worker_thread+0x32/0x410
  kthread+0x121/0x140
  ? process_one_work+0x410/0x410
  ? kthread_create_worker_on_cpu+0x70/0x70
  ? do_syscall_64+0x73/0x130
  ? SyS_exit_group+0x14/0x20
  ret_from_fork+0x35/0x40

Kernel is most recently `4.15.0-13-generic #14-Ubuntu` but it's been
going on for the last month of bionic, and *possibly* longer but I only
recently caught that the Chaoskey was related.

$ lsb_release -rd
Description:Ubuntu Bionic Beaver (development branch)
Release:18.04

$ uname -a
Linux workbench 4.15.0-13-generic #14-Ubuntu SMP Sat Mar 17 13:44:27 UTC 2018 
x86_64 x86_64 x86_64 GNU/Linux

$ dpkg --status linux-image-4.15.0-13-generic
Package: linux-image-4.15.0-13-generic
Status: install ok installed
Priority: optional
Section: kernel
Installed-Size: 72167
Maintainer: Ubuntu Kernel Team 
Architecture: amd64
Source: linux
Version: 4.15.0-13.14
Provides: aufs-dkms, fuse-module, ivtv-modules, kvm-api-4, linux-image, 
redhat-cluster-modules, spl-dkms, spl-modules, virtualbox-guest-modules, 
zfs-dkms, zfs-modules
Depends: kmod
Recommends: grub-pc | grub-efi-amd64 | grub-efi-ia32 | grub | lilo, 
initramfs-tools | linux-initramfs-tool
Suggests: fdutils, linux-doc-4.15.0 | linux-source-4.15.0, linux-tools, 
linux-headers-4.15.0-13-generic
Description: Linux kernel image for version 4.15.0 on 64 bit x86 SMP
 This package contains the Linux kernel image for version 4.15.0 on
 64 bit x86 SMP.
 .
 Also includes the corresponding System.map file, the modules built by the
 packager, and scripts that try to ensure that the system is not left in an
 unbootable state after an update.
 .
 Supports Generic processors.
 .
 Geared toward desktop and server systems.
 .
 You likely do not want to install this package directly. Instead, install
 the linux-generic meta-package, which will ensure that upgrades work
 correctly, and that supporting packages are also installed.

** Affects: linux (Ubuntu)
 Importance: Undecided
 Status: Incomplete


** Tags: bionic

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1762816

Title:
  chaoskey interferes with suspend on thinkpad

Status in linux package in Ubuntu:
  Incomplete

Bug description:
  Thinkpad T450s, docking station, Altus Metrum Chaoskey plugged into
  the docking station - suspend fails often (more than half the time,
  maybe not 100% but easily duplicated in my setup) in that it doesn't
  seem to go all the way down - and on wakeup, lsusb output doesn't
  update, `lsusb -t` hangs when run.  It *may* require "suspend, undock,
  unsuspend" but I'm not convinced...

  Interesting logs include a "blocked for more than 120 seconds"
  traceback after restore that goes through chaoskey_disconnect even
  though the laptop is undocked so it's no longer attached:

  [17038.103142] Call Trace:
__schedule+0x297/0x8b0
schedule+0x2c/0x80
schedule_timeout+0x1cf/0x350
? ttwu_do_activate+0x7a/0x90
wait_for_completion+0xba/0x140
? wake_up_q+0x80/0x80
hwrng_unregister+0x8f/0xa0
  ***  chaoskey_disconnect+0xbe/0x110 [chaoskey] ***
usb_unbind_interface+0x77/0x290
device_release_driver_internal+0x15b/0x220
device_release_driver+0x12/0x20
bus_remove_device+0xec/0x160
device_del+0x13d/0x360
? usb_remove_ep_devs+0x1f/0x30
usb_disable_device+0x9f/0x270
usb_disconnect+0xc6/0x270
hub_quiesce+0x48/0xa0
hub_event+0xfb/0xb10
process_one_work+0x1de/0x410
worker_thread+0x32/0x410
kthread+0x121/0x140
? process_one_work+0x410/0x410
? kthread_create_worker_on_cpu+0x70/0x70
? do_syscall_64+0x73/0x130
? SyS_exit_group+0x14/0x20
ret_from_fork+0x35/0x40

  Kernel