[Kernel-packages] [Bug 1984103] Re: [UBUNTU 22.04] s390/qeth: cache link_info for ethtool
his bug only affected s390x, updating all other verification requests to
done (to unblock potential processes).
** Tags removed: verification-needed-jammy-linux-mtk
** Tags added: verification-done-jammy-linux-mtk
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1984103
Title:
[UBUNTU 22.04] s390/qeth: cache link_info for ethtool
Status in Ubuntu on IBM z Systems:
Fix Released
Status in linux package in Ubuntu:
Fix Released
Status in linux source package in Jammy:
Fix Released
Status in linux source package in Kinetic:
Fix Released
Bug description:
== SRU Justification ==
Since commit e6e771b3d897 ("s390/qeth: detach netdevice while card is
offline") there was a timing window during recovery, that qeth_query_card_info
could be sent to the card, even before it was ready for it, leading to a
failing cardrecovery. There is evidence that this window was hit, as not
all callers of get_link_ksettings() check for netif_device_present.
This patch (Mainline commit 7a07a29e4f67) fixes the regression caused
by commit e6e771b3d897.
Commit 7a07a29e4f67 is in mainline as of v6.0-rc1.
This patch is being requested in Jammy 5.15 and Kinetic 5.19.
== Fix ==
7a07a29e4f67 ("s390/qeth: cache link_info for ethtool")
== Regression Potential ==
Low. This patch has been accepted in upstream stable and is limited to
the s390/qeth card.
== Test Case ==
A test kernel was built with this patch and tested by the original bug
reporter.
The bug reporter states the test kernel resolved the bug.
== Comment: #0 - J?rn Siglen - 2022-08-09 07:38:27 ==
+++ This bug was initially created as a clone of Bug #199319 +++
Description: s390/qeth: cache link_info for ethtool
Symptom: lost of IP connection and log entries in journalctl:
kernel: qeth 0.0.0365: The qeth device driver failed to
recover an error on the device
Problem: Since commit e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
there was a timing window during recovery, that
qeth_query_card_info could be sent to the card, even before it
was ready for it, leading to a failing card recovery. There is
evidence that this window was hit, as not all callers of
get_link_ksettings() check for netif_device_present.
Solution: Use cached values in qeth_get_link_ksettings(), instead of
calling qeth_query_card_info() and falling back to default
values in case it fails. Link info is already updated when the
card goes online, e.g. after STARTLAN (physical link up). Set
the link info to default values, when the card goes offline or
at STOPLAN (physical link down). A follow-on patch will improve
values reported for link down.
Fixes: e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
Reproduction: enforce a eth device recvoery, while running ethtool multiple
times in parallel and using iperf to get load on the interface.
Upstream-ID: 7a07a29e4f6713b224f3bcde5f835e777301bdb8
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
applicable for most kernel > 3.14
== Comment: #3 - J?rn Siglen - 2022-08-09 07:54:41 ==
the inital update came in with kernel 5.1 upstream, but we found it
backported in many older kernel versions
== Comment: #4 - J?rn Siglen - 2022-08-09 08:03:09 ==
the acceptance info of the patch can be found here:
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1984103/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1984103] Re: [UBUNTU 22.04] s390/qeth: cache link_info for ethtool
This bug is awaiting verification that the linux-mtk/5.15.0-1030.34
kernel in -proposed solves the problem. Please test the kernel and
update this bug with the results. If the problem is solved, change the
tag 'verification-needed-jammy-linux-mtk' to 'verification-done-jammy-
linux-mtk'. If the problem still exists, change the tag 'verification-
needed-jammy-linux-mtk' to 'verification-failed-jammy-linux-mtk'.
If verification is not done by 5 working days from today, this fix will
be dropped from the source code, and this bug will be closed.
See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how
to enable and use -proposed. Thank you!
** Tags added: kernel-spammed-jammy-linux-mtk-v2
verification-needed-jammy-linux-mtk
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1984103
Title:
[UBUNTU 22.04] s390/qeth: cache link_info for ethtool
Status in Ubuntu on IBM z Systems:
Fix Released
Status in linux package in Ubuntu:
Fix Released
Status in linux source package in Jammy:
Fix Released
Status in linux source package in Kinetic:
Fix Released
Bug description:
== SRU Justification ==
Since commit e6e771b3d897 ("s390/qeth: detach netdevice while card is
offline") there was a timing window during recovery, that qeth_query_card_info
could be sent to the card, even before it was ready for it, leading to a
failing cardrecovery. There is evidence that this window was hit, as not
all callers of get_link_ksettings() check for netif_device_present.
This patch (Mainline commit 7a07a29e4f67) fixes the regression caused
by commit e6e771b3d897.
Commit 7a07a29e4f67 is in mainline as of v6.0-rc1.
This patch is being requested in Jammy 5.15 and Kinetic 5.19.
== Fix ==
7a07a29e4f67 ("s390/qeth: cache link_info for ethtool")
== Regression Potential ==
Low. This patch has been accepted in upstream stable and is limited to
the s390/qeth card.
== Test Case ==
A test kernel was built with this patch and tested by the original bug
reporter.
The bug reporter states the test kernel resolved the bug.
== Comment: #0 - J?rn Siglen - 2022-08-09 07:38:27 ==
+++ This bug was initially created as a clone of Bug #199319 +++
Description: s390/qeth: cache link_info for ethtool
Symptom: lost of IP connection and log entries in journalctl:
kernel: qeth 0.0.0365: The qeth device driver failed to
recover an error on the device
Problem: Since commit e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
there was a timing window during recovery, that
qeth_query_card_info could be sent to the card, even before it
was ready for it, leading to a failing card recovery. There is
evidence that this window was hit, as not all callers of
get_link_ksettings() check for netif_device_present.
Solution: Use cached values in qeth_get_link_ksettings(), instead of
calling qeth_query_card_info() and falling back to default
values in case it fails. Link info is already updated when the
card goes online, e.g. after STARTLAN (physical link up). Set
the link info to default values, when the card goes offline or
at STOPLAN (physical link down). A follow-on patch will improve
values reported for link down.
Fixes: e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
Reproduction: enforce a eth device recvoery, while running ethtool multiple
times in parallel and using iperf to get load on the interface.
Upstream-ID: 7a07a29e4f6713b224f3bcde5f835e777301bdb8
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
applicable for most kernel > 3.14
== Comment: #3 - J?rn Siglen - 2022-08-09 07:54:41 ==
the inital update came in with kernel 5.1 upstream, but we found it
backported in many older kernel versions
== Comment: #4 - J?rn Siglen - 2022-08-09 08:03:09 ==
the acceptance info of the patch can be found here:
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1984103/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1984103] Re: [UBUNTU 22.04] s390/qeth: cache link_info for ethtool
This bug was not opened against linux-nvidia/5.15.0-1011.11 and is also not
relevant for this kernel.
However, I'm setting the tag to done to unblock the process.
** Tags removed: verification-needed-jammy
** Tags added: verification-done-jammy
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1984103
Title:
[UBUNTU 22.04] s390/qeth: cache link_info for ethtool
Status in Ubuntu on IBM z Systems:
Fix Released
Status in linux package in Ubuntu:
Fix Released
Status in linux source package in Jammy:
Fix Released
Status in linux source package in Kinetic:
Fix Released
Bug description:
== SRU Justification ==
Since commit e6e771b3d897 ("s390/qeth: detach netdevice while card is
offline") there was a timing window during recovery, that qeth_query_card_info
could be sent to the card, even before it was ready for it, leading to a
failing cardrecovery. There is evidence that this window was hit, as not
all callers of get_link_ksettings() check for netif_device_present.
This patch (Mainline commit 7a07a29e4f67) fixes the regression caused
by commit e6e771b3d897.
Commit 7a07a29e4f67 is in mainline as of v6.0-rc1.
This patch is being requested in Jammy 5.15 and Kinetic 5.19.
== Fix ==
7a07a29e4f67 ("s390/qeth: cache link_info for ethtool")
== Regression Potential ==
Low. This patch has been accepted in upstream stable and is limited to
the s390/qeth card.
== Test Case ==
A test kernel was built with this patch and tested by the original bug
reporter.
The bug reporter states the test kernel resolved the bug.
== Comment: #0 - J?rn Siglen - 2022-08-09 07:38:27 ==
+++ This bug was initially created as a clone of Bug #199319 +++
Description: s390/qeth: cache link_info for ethtool
Symptom: lost of IP connection and log entries in journalctl:
kernel: qeth 0.0.0365: The qeth device driver failed to
recover an error on the device
Problem: Since commit e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
there was a timing window during recovery, that
qeth_query_card_info could be sent to the card, even before it
was ready for it, leading to a failing card recovery. There is
evidence that this window was hit, as not all callers of
get_link_ksettings() check for netif_device_present.
Solution: Use cached values in qeth_get_link_ksettings(), instead of
calling qeth_query_card_info() and falling back to default
values in case it fails. Link info is already updated when the
card goes online, e.g. after STARTLAN (physical link up). Set
the link info to default values, when the card goes offline or
at STOPLAN (physical link down). A follow-on patch will improve
values reported for link down.
Fixes: e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
Reproduction: enforce a eth device recvoery, while running ethtool multiple
times in parallel and using iperf to get load on the interface.
Upstream-ID: 7a07a29e4f6713b224f3bcde5f835e777301bdb8
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
applicable for most kernel > 3.14
== Comment: #3 - J?rn Siglen - 2022-08-09 07:54:41 ==
the inital update came in with kernel 5.1 upstream, but we found it
backported in many older kernel versions
== Comment: #4 - J?rn Siglen - 2022-08-09 08:03:09 ==
the acceptance info of the patch can be found here:
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1984103/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1984103] Re: [UBUNTU 22.04] s390/qeth: cache link_info for ethtool
This bug is awaiting verification that the linux-nvidia/5.15.0-1011.11
kernel in -proposed solves the problem. Please test the kernel and
update this bug with the results. If the problem is solved, change the
tag 'verification-needed-jammy' to 'verification-done-jammy'. If the
problem still exists, change the tag 'verification-needed-jammy' to
'verification-failed-jammy'.
If verification is not done by 5 working days from today, this fix will
be dropped from the source code, and this bug will be closed.
See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how
to enable and use -proposed. Thank you!
** Tags removed: verification-done-jammy
** Tags added: kernel-spammed-jammy-linux-nvidia verification-needed-jammy
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1984103
Title:
[UBUNTU 22.04] s390/qeth: cache link_info for ethtool
Status in Ubuntu on IBM z Systems:
Fix Released
Status in linux package in Ubuntu:
Fix Released
Status in linux source package in Jammy:
Fix Released
Status in linux source package in Kinetic:
Fix Released
Bug description:
== SRU Justification ==
Since commit e6e771b3d897 ("s390/qeth: detach netdevice while card is
offline") there was a timing window during recovery, that qeth_query_card_info
could be sent to the card, even before it was ready for it, leading to a
failing cardrecovery. There is evidence that this window was hit, as not
all callers of get_link_ksettings() check for netif_device_present.
This patch (Mainline commit 7a07a29e4f67) fixes the regression caused
by commit e6e771b3d897.
Commit 7a07a29e4f67 is in mainline as of v6.0-rc1.
This patch is being requested in Jammy 5.15 and Kinetic 5.19.
== Fix ==
7a07a29e4f67 ("s390/qeth: cache link_info for ethtool")
== Regression Potential ==
Low. This patch has been accepted in upstream stable and is limited to
the s390/qeth card.
== Test Case ==
A test kernel was built with this patch and tested by the original bug
reporter.
The bug reporter states the test kernel resolved the bug.
== Comment: #0 - J?rn Siglen - 2022-08-09 07:38:27 ==
+++ This bug was initially created as a clone of Bug #199319 +++
Description: s390/qeth: cache link_info for ethtool
Symptom: lost of IP connection and log entries in journalctl:
kernel: qeth 0.0.0365: The qeth device driver failed to
recover an error on the device
Problem: Since commit e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
there was a timing window during recovery, that
qeth_query_card_info could be sent to the card, even before it
was ready for it, leading to a failing card recovery. There is
evidence that this window was hit, as not all callers of
get_link_ksettings() check for netif_device_present.
Solution: Use cached values in qeth_get_link_ksettings(), instead of
calling qeth_query_card_info() and falling back to default
values in case it fails. Link info is already updated when the
card goes online, e.g. after STARTLAN (physical link up). Set
the link info to default values, when the card goes offline or
at STOPLAN (physical link down). A follow-on patch will improve
values reported for link down.
Fixes: e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
Reproduction: enforce a eth device recvoery, while running ethtool multiple
times in parallel and using iperf to get load on the interface.
Upstream-ID: 7a07a29e4f6713b224f3bcde5f835e777301bdb8
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
applicable for most kernel > 3.14
== Comment: #3 - J?rn Siglen - 2022-08-09 07:54:41 ==
the inital update came in with kernel 5.1 upstream, but we found it
backported in many older kernel versions
== Comment: #4 - J?rn Siglen - 2022-08-09 08:03:09 ==
the acceptance info of the patch can be found here:
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1984103/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1984103] Re: [UBUNTU 22.04] s390/qeth: cache link_info for ethtool
This bug was not requested for linux-bluefield.
Hence I'll just set the tag 'verification-done-jammy' to unblock the further
process.
** Tags removed: verification-needed-jammy
** Tags added: verification-done-jammy
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1984103
Title:
[UBUNTU 22.04] s390/qeth: cache link_info for ethtool
Status in Ubuntu on IBM z Systems:
Fix Released
Status in linux package in Ubuntu:
Fix Released
Status in linux source package in Jammy:
Fix Released
Status in linux source package in Kinetic:
Fix Released
Bug description:
== SRU Justification ==
Since commit e6e771b3d897 ("s390/qeth: detach netdevice while card is
offline") there was a timing window during recovery, that qeth_query_card_info
could be sent to the card, even before it was ready for it, leading to a
failing cardrecovery. There is evidence that this window was hit, as not
all callers of get_link_ksettings() check for netif_device_present.
This patch (Mainline commit 7a07a29e4f67) fixes the regression caused
by commit e6e771b3d897.
Commit 7a07a29e4f67 is in mainline as of v6.0-rc1.
This patch is being requested in Jammy 5.15 and Kinetic 5.19.
== Fix ==
7a07a29e4f67 ("s390/qeth: cache link_info for ethtool")
== Regression Potential ==
Low. This patch has been accepted in upstream stable and is limited to
the s390/qeth card.
== Test Case ==
A test kernel was built with this patch and tested by the original bug
reporter.
The bug reporter states the test kernel resolved the bug.
== Comment: #0 - J?rn Siglen - 2022-08-09 07:38:27 ==
+++ This bug was initially created as a clone of Bug #199319 +++
Description: s390/qeth: cache link_info for ethtool
Symptom: lost of IP connection and log entries in journalctl:
kernel: qeth 0.0.0365: The qeth device driver failed to
recover an error on the device
Problem: Since commit e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
there was a timing window during recovery, that
qeth_query_card_info could be sent to the card, even before it
was ready for it, leading to a failing card recovery. There is
evidence that this window was hit, as not all callers of
get_link_ksettings() check for netif_device_present.
Solution: Use cached values in qeth_get_link_ksettings(), instead of
calling qeth_query_card_info() and falling back to default
values in case it fails. Link info is already updated when the
card goes online, e.g. after STARTLAN (physical link up). Set
the link info to default values, when the card goes offline or
at STOPLAN (physical link down). A follow-on patch will improve
values reported for link down.
Fixes: e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
Reproduction: enforce a eth device recvoery, while running ethtool multiple
times in parallel and using iperf to get load on the interface.
Upstream-ID: 7a07a29e4f6713b224f3bcde5f835e777301bdb8
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
applicable for most kernel > 3.14
== Comment: #3 - J?rn Siglen - 2022-08-09 07:54:41 ==
the inital update came in with kernel 5.1 upstream, but we found it
backported in many older kernel versions
== Comment: #4 - J?rn Siglen - 2022-08-09 08:03:09 ==
the acceptance info of the patch can be found here:
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1984103/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1984103] Re: [UBUNTU 22.04] s390/qeth: cache link_info for ethtool
This bug is awaiting verification that the linux-
bluefield/5.15.0-1010.12 kernel in -proposed solves the problem. Please
test the kernel and update this bug with the results. If the problem is
solved, change the tag 'verification-needed-jammy' to 'verification-
done-jammy'. If the problem still exists, change the tag 'verification-
needed-jammy' to 'verification-failed-jammy'.
If verification is not done by 5 working days from today, this fix will
be dropped from the source code, and this bug will be closed.
See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how
to enable and use -proposed. Thank you!
** Tags removed: verification-done verification-done-jammy
** Tags added: kernel-spammed-jammy-linux-bluefield verification-needed-jammy
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1984103
Title:
[UBUNTU 22.04] s390/qeth: cache link_info for ethtool
Status in Ubuntu on IBM z Systems:
Fix Released
Status in linux package in Ubuntu:
Fix Released
Status in linux source package in Jammy:
Fix Released
Status in linux source package in Kinetic:
Fix Released
Bug description:
== SRU Justification ==
Since commit e6e771b3d897 ("s390/qeth: detach netdevice while card is
offline") there was a timing window during recovery, that qeth_query_card_info
could be sent to the card, even before it was ready for it, leading to a
failing cardrecovery. There is evidence that this window was hit, as not
all callers of get_link_ksettings() check for netif_device_present.
This patch (Mainline commit 7a07a29e4f67) fixes the regression caused
by commit e6e771b3d897.
Commit 7a07a29e4f67 is in mainline as of v6.0-rc1.
This patch is being requested in Jammy 5.15 and Kinetic 5.19.
== Fix ==
7a07a29e4f67 ("s390/qeth: cache link_info for ethtool")
== Regression Potential ==
Low. This patch has been accepted in upstream stable and is limited to
the s390/qeth card.
== Test Case ==
A test kernel was built with this patch and tested by the original bug
reporter.
The bug reporter states the test kernel resolved the bug.
== Comment: #0 - J?rn Siglen - 2022-08-09 07:38:27 ==
+++ This bug was initially created as a clone of Bug #199319 +++
Description: s390/qeth: cache link_info for ethtool
Symptom: lost of IP connection and log entries in journalctl:
kernel: qeth 0.0.0365: The qeth device driver failed to
recover an error on the device
Problem: Since commit e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
there was a timing window during recovery, that
qeth_query_card_info could be sent to the card, even before it
was ready for it, leading to a failing card recovery. There is
evidence that this window was hit, as not all callers of
get_link_ksettings() check for netif_device_present.
Solution: Use cached values in qeth_get_link_ksettings(), instead of
calling qeth_query_card_info() and falling back to default
values in case it fails. Link info is already updated when the
card goes online, e.g. after STARTLAN (physical link up). Set
the link info to default values, when the card goes offline or
at STOPLAN (physical link down). A follow-on patch will improve
values reported for link down.
Fixes: e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
Reproduction: enforce a eth device recvoery, while running ethtool multiple
times in parallel and using iperf to get load on the interface.
Upstream-ID: 7a07a29e4f6713b224f3bcde5f835e777301bdb8
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
applicable for most kernel > 3.14
== Comment: #3 - J?rn Siglen - 2022-08-09 07:54:41 ==
the inital update came in with kernel 5.1 upstream, but we found it
backported in many older kernel versions
== Comment: #4 - J?rn Siglen - 2022-08-09 08:03:09 ==
the acceptance info of the patch can be found here:
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1984103/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1984103] Re: [UBUNTU 22.04] s390/qeth: cache link_info for ethtool
This bug was not requested for linux-gkeop-5.15 nor for focal.
Hence I'll just set the tag 'verification-done-focal' to unblock the SRU
process.
** Tags added: verification-done-focal
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1984103
Title:
[UBUNTU 22.04] s390/qeth: cache link_info for ethtool
Status in Ubuntu on IBM z Systems:
Fix Released
Status in linux package in Ubuntu:
Fix Released
Status in linux source package in Jammy:
Fix Released
Status in linux source package in Kinetic:
Fix Released
Bug description:
== SRU Justification ==
Since commit e6e771b3d897 ("s390/qeth: detach netdevice while card is
offline") there was a timing window during recovery, that qeth_query_card_info
could be sent to the card, even before it was ready for it, leading to a
failing cardrecovery. There is evidence that this window was hit, as not
all callers of get_link_ksettings() check for netif_device_present.
This patch (Mainline commit 7a07a29e4f67) fixes the regression caused
by commit e6e771b3d897.
Commit 7a07a29e4f67 is in mainline as of v6.0-rc1.
This patch is being requested in Jammy 5.15 and Kinetic 5.19.
== Fix ==
7a07a29e4f67 ("s390/qeth: cache link_info for ethtool")
== Regression Potential ==
Low. This patch has been accepted in upstream stable and is limited to
the s390/qeth card.
== Test Case ==
A test kernel was built with this patch and tested by the original bug
reporter.
The bug reporter states the test kernel resolved the bug.
== Comment: #0 - J?rn Siglen - 2022-08-09 07:38:27 ==
+++ This bug was initially created as a clone of Bug #199319 +++
Description: s390/qeth: cache link_info for ethtool
Symptom: lost of IP connection and log entries in journalctl:
kernel: qeth 0.0.0365: The qeth device driver failed to
recover an error on the device
Problem: Since commit e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
there was a timing window during recovery, that
qeth_query_card_info could be sent to the card, even before it
was ready for it, leading to a failing card recovery. There is
evidence that this window was hit, as not all callers of
get_link_ksettings() check for netif_device_present.
Solution: Use cached values in qeth_get_link_ksettings(), instead of
calling qeth_query_card_info() and falling back to default
values in case it fails. Link info is already updated when the
card goes online, e.g. after STARTLAN (physical link up). Set
the link info to default values, when the card goes offline or
at STOPLAN (physical link down). A follow-on patch will improve
values reported for link down.
Fixes: e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
Reproduction: enforce a eth device recvoery, while running ethtool multiple
times in parallel and using iperf to get load on the interface.
Upstream-ID: 7a07a29e4f6713b224f3bcde5f835e777301bdb8
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
applicable for most kernel > 3.14
== Comment: #3 - J?rn Siglen - 2022-08-09 07:54:41 ==
the inital update came in with kernel 5.1 upstream, but we found it
backported in many older kernel versions
== Comment: #4 - J?rn Siglen - 2022-08-09 08:03:09 ==
the acceptance info of the patch can be found here:
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1984103/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1984103] Re: [UBUNTU 22.04] s390/qeth: cache link_info for ethtool
This bug is awaiting verification that the linux-
gkeop-5.15/5.15.0-1005.7~20.04.1 kernel in -proposed solves the problem.
Please test the kernel and update this bug with the results. If the
problem is solved, change the tag 'verification-needed-focal' to
'verification-done-focal'. If the problem still exists, change the tag
'verification-needed-focal' to 'verification-failed-focal'.
If verification is not done by 5 working days from today, this fix will
be dropped from the source code, and this bug will be closed.
See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how
to enable and use -proposed. Thank you!
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1984103
Title:
[UBUNTU 22.04] s390/qeth: cache link_info for ethtool
Status in Ubuntu on IBM z Systems:
Fix Released
Status in linux package in Ubuntu:
Fix Released
Status in linux source package in Jammy:
Fix Released
Status in linux source package in Kinetic:
Fix Released
Bug description:
== SRU Justification ==
Since commit e6e771b3d897 ("s390/qeth: detach netdevice while card is
offline") there was a timing window during recovery, that qeth_query_card_info
could be sent to the card, even before it was ready for it, leading to a
failing cardrecovery. There is evidence that this window was hit, as not
all callers of get_link_ksettings() check for netif_device_present.
This patch (Mainline commit 7a07a29e4f67) fixes the regression caused
by commit e6e771b3d897.
Commit 7a07a29e4f67 is in mainline as of v6.0-rc1.
This patch is being requested in Jammy 5.15 and Kinetic 5.19.
== Fix ==
7a07a29e4f67 ("s390/qeth: cache link_info for ethtool")
== Regression Potential ==
Low. This patch has been accepted in upstream stable and is limited to
the s390/qeth card.
== Test Case ==
A test kernel was built with this patch and tested by the original bug
reporter.
The bug reporter states the test kernel resolved the bug.
== Comment: #0 - J?rn Siglen - 2022-08-09 07:38:27 ==
+++ This bug was initially created as a clone of Bug #199319 +++
Description: s390/qeth: cache link_info for ethtool
Symptom: lost of IP connection and log entries in journalctl:
kernel: qeth 0.0.0365: The qeth device driver failed to
recover an error on the device
Problem: Since commit e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
there was a timing window during recovery, that
qeth_query_card_info could be sent to the card, even before it
was ready for it, leading to a failing card recovery. There is
evidence that this window was hit, as not all callers of
get_link_ksettings() check for netif_device_present.
Solution: Use cached values in qeth_get_link_ksettings(), instead of
calling qeth_query_card_info() and falling back to default
values in case it fails. Link info is already updated when the
card goes online, e.g. after STARTLAN (physical link up). Set
the link info to default values, when the card goes offline or
at STOPLAN (physical link down). A follow-on patch will improve
values reported for link down.
Fixes: e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
Reproduction: enforce a eth device recvoery, while running ethtool multiple
times in parallel and using iperf to get load on the interface.
Upstream-ID: 7a07a29e4f6713b224f3bcde5f835e777301bdb8
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
applicable for most kernel > 3.14
== Comment: #3 - J?rn Siglen - 2022-08-09 07:54:41 ==
the inital update came in with kernel 5.1 upstream, but we found it
backported in many older kernel versions
== Comment: #4 - J?rn Siglen - 2022-08-09 08:03:09 ==
the acceptance info of the patch can be found here:
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1984103/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1984103] Re: [UBUNTU 22.04] s390/qeth: cache link_info for ethtool
** Changed in: ubuntu-z-systems
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1984103
Title:
[UBUNTU 22.04] s390/qeth: cache link_info for ethtool
Status in Ubuntu on IBM z Systems:
Fix Released
Status in linux package in Ubuntu:
Fix Released
Status in linux source package in Jammy:
Fix Released
Status in linux source package in Kinetic:
Fix Released
Bug description:
== SRU Justification ==
Since commit e6e771b3d897 ("s390/qeth: detach netdevice while card is
offline") there was a timing window during recovery, that qeth_query_card_info
could be sent to the card, even before it was ready for it, leading to a
failing cardrecovery. There is evidence that this window was hit, as not
all callers of get_link_ksettings() check for netif_device_present.
This patch (Mainline commit 7a07a29e4f67) fixes the regression caused
by commit e6e771b3d897.
Commit 7a07a29e4f67 is in mainline as of v6.0-rc1.
This patch is being requested in Jammy 5.15 and Kinetic 5.19.
== Fix ==
7a07a29e4f67 ("s390/qeth: cache link_info for ethtool")
== Regression Potential ==
Low. This patch has been accepted in upstream stable and is limited to
the s390/qeth card.
== Test Case ==
A test kernel was built with this patch and tested by the original bug
reporter.
The bug reporter states the test kernel resolved the bug.
== Comment: #0 - J?rn Siglen - 2022-08-09 07:38:27 ==
+++ This bug was initially created as a clone of Bug #199319 +++
Description: s390/qeth: cache link_info for ethtool
Symptom: lost of IP connection and log entries in journalctl:
kernel: qeth 0.0.0365: The qeth device driver failed to
recover an error on the device
Problem: Since commit e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
there was a timing window during recovery, that
qeth_query_card_info could be sent to the card, even before it
was ready for it, leading to a failing card recovery. There is
evidence that this window was hit, as not all callers of
get_link_ksettings() check for netif_device_present.
Solution: Use cached values in qeth_get_link_ksettings(), instead of
calling qeth_query_card_info() and falling back to default
values in case it fails. Link info is already updated when the
card goes online, e.g. after STARTLAN (physical link up). Set
the link info to default values, when the card goes offline or
at STOPLAN (physical link down). A follow-on patch will improve
values reported for link down.
Fixes: e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
Reproduction: enforce a eth device recvoery, while running ethtool multiple
times in parallel and using iperf to get load on the interface.
Upstream-ID: 7a07a29e4f6713b224f3bcde5f835e777301bdb8
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
applicable for most kernel > 3.14
== Comment: #3 - J?rn Siglen - 2022-08-09 07:54:41 ==
the inital update came in with kernel 5.1 upstream, but we found it
backported in many older kernel versions
== Comment: #4 - J?rn Siglen - 2022-08-09 08:03:09 ==
the acceptance info of the patch can be found here:
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1984103/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1984103] Re: [UBUNTU 22.04] s390/qeth: cache link_info for ethtool
This bug was fixed in the package linux - 5.15.0-50.56
---
linux (5.15.0-50.56) jammy; urgency=medium
* jammy/linux: 5.15.0-50.56 -proposed tracker (LP: #1990148)
* CVE-2022-3176
- io_uring: refactor poll update
- io_uring: move common poll bits
- io_uring: kill poll linking optimisation
- io_uring: inline io_poll_complete
- io_uring: correct fill events helpers types
- io_uring: clean cqe filling functions
- io_uring: poll rework
- io_uring: remove poll entry from list when canceling all
- io_uring: bump poll refs to full 31-bits
- io_uring: fail links when poll fails
- io_uring: fix wrong arm_poll error handling
- io_uring: fix UAF due to missing POLLFREE handling
* ip/nexthop: fix default address selection for connected nexthop
(LP: #1988809)
- selftests/net: test nexthop without gw
* ip/nexthop: fix default address selection for connected nexthop
(LP: #1988809) // icmp_redirect.sh in ubuntu_kernel_selftests failed on
Jammy 5.15.0-49.55 (LP: #1990124)
- ip: fix triggering of 'icmp redirect'
linux (5.15.0-49.55) jammy; urgency=medium
* jammy/linux: 5.15.0-49.55 -proposed tracker (LP: #1989785)
* amdgpu module crash after 5.15 kernel update (LP: #1981883)
- drm/amdgpu: fix check in fbdev init
* scsi: hisi_sas: Increase debugfs_dump_index after dump is completed
(LP: #1982070)
- scsi: hisi_sas: Increase debugfs_dump_index after dump is completed
* [UBUNTU 22.04] s390/qeth: cache link_info for ethtool (LP: #1984103)
- s390/qeth: cache link_info for ethtool
* WARN in trace_event_dyn_put_ref (LP: #1987232)
- tracing/perf: Fix double put of trace event when init fails
* Jammy update: v5.15.60 upstream stable release (LP: #1989221)
- x86/speculation: Make all RETbleed mitigations 64-bit only
- selftests/bpf: Extend verifier and bpf_sock tests for dst_port loads
- selftests/bpf: Check dst_port only on the client socket
- block: fix default IO priority handling again
- tools/vm/slabinfo: Handle files in debugfs
- ACPI: video: Force backlight native for some TongFang devices
- ACPI: video: Shortening quirk list by identifying Clevo by board_name only
- ACPI: APEI: Better fix to avoid spamming the console with old error logs
- crypto: arm64/poly1305 - fix a read out-of-bound
- KVM: x86: do not report a vCPU as preempted outside instruction boundaries
- KVM: x86: do not set st->preempted when going back to user space
- KVM: selftests: Make hyperv_clock selftest more stable
- tools/kvm_stat: fix display of error when multiple processes are found
- selftests: KVM: Handle compiler optimizations in ucall
- KVM: x86/svm: add __GFP_ACCOUNT to __sev_dbg_{en,de}crypt_user()
- arm64: set UXN on swapper page tables
- btrfs: zoned: prevent allocation from previous data relocation BG
- btrfs: zoned: fix critical section of relocation inode writeback
- Bluetooth: hci_bcm: Add BCM4349B1 variant
- Bluetooth: hci_bcm: Add DT compatible for CYW55572
- dt-bindings: bluetooth: broadcom: Add BCM4349B1 DT binding
- Bluetooth: btusb: Add support of IMC Networks PID 0x3568
- Bluetooth: btusb: Add Realtek RTL8852C support ID 0x04CA:0x4007
- Bluetooth: btusb: Add Realtek RTL8852C support ID 0x04C5:0x1675
- Bluetooth: btusb: Add Realtek RTL8852C support ID 0x0CB8:0xC558
- Bluetooth: btusb: Add Realtek RTL8852C support ID 0x13D3:0x3587
- Bluetooth: btusb: Add Realtek RTL8852C support ID 0x13D3:0x3586
- macintosh/adb: fix oob read in do_adb_query() function
- x86/speculation: Add RSB VM Exit protections
- x86/speculation: Add LFENCE to RSB fill sequence
- Linux 5.15.60
* Jammy update: v5.15.59 upstream stable release (LP: #1989218)
- Bluetooth: L2CAP: Fix use-after-free caused by l2cap_chan_put
- Revert "ocfs2: mount shared volume without ha stack"
- ntfs: fix use-after-free in ntfs_ucsncmp()
- fs: sendfile handles O_NONBLOCK of out_fd
- secretmem: fix unhandled fault in truncate
- mm: fix page leak with multiple threads mapping the same page
- hugetlb: fix memoryleak in hugetlb_mcopy_atomic_pte
- asm-generic: remove a broken and needless ifdef conditional
- s390/archrandom: prevent CPACF trng invocations in interrupt context
- nouveau/svm: Fix to migrate all requested pages
- drm/simpledrm: Fix return type of
simpledrm_simple_display_pipe_mode_valid()
- watch_queue: Fix missing rcu annotation
- watch_queue: Fix missing locking in add_watch_to_object()
- tcp: Fix data-races around sysctl_tcp_dsack.
- tcp: Fix a data-race around sysctl_tcp_app_win.
- tcp: Fix a data-race around sysctl_tcp_adv_win_scale.
- tcp: Fix a data-race around sysctl_tcp_frto.
- tcp: Fix a data-race around sysctl_tcp_nometrics_save.
- tcp: Fix data-races around sysctl_tcp_no_ssthresh_metrics_save.
- ice: check (DD | EOF) bits on Rx descr
[Kernel-packages] [Bug 1984103] Re: [UBUNTU 22.04] s390/qeth: cache link_info for ethtool
This bug was fixed in the package linux - 5.19.0-18.18 --- linux (5.19.0-18.18) kinetic; urgency=medium * kinetic/linux: 5.19.0-18.18 -proposed tracker (LP: #1990366) * 5.19.0-17.17: kernel NULL pointer dereference, address: 0084 (LP: #1990236) - Revert "UBUNTU: SAUCE: apparmor: Fix regression in stacking due to label flags" - Revert "UBUNTU: [Config] disable SECURITY_APPARMOR_RESTRICT_USERNS" - Revert "UBUNTU: SAUCE: Revert "hwrng: virtio - add an internal buffer"" - Revert "UBUNTU: SAUCE: Revert "hwrng: virtio - don't wait on cleanup"" - Revert "UBUNTU: SAUCE: Revert "hwrng: virtio - don't waste entropy"" - Revert "UBUNTU: SAUCE: Revert "hwrng: virtio - always add a pending request"" - Revert "UBUNTU: SAUCE: Revert "hwrng: virtio - unregister device before reset"" - Revert "UBUNTU: SAUCE: Revert "virtio-rng: make device ready before making request"" - Revert "UBUNTU: [Config] update configs after apply new apparmor patch set" - Revert "UBUNTU: SAUCE: apparmor: add user namespace creation mediation" - Revert "UBUNTU: SAUCE: selinux: Implement userns_create hook" - Revert "UBUNTU: SAUCE: bpf-lsm: Make bpf_lsm_userns_create() sleepable" - Revert "UBUNTU: SAUCE: security, lsm: Introduce security_create_user_ns()" - Revert "UBUNTU: SAUCE: lsm stacking v37: AppArmor: Remove the exclusive flag" - Revert "UBUNTU: SAUCE: lsm stacking v37: LSM: Add /proc attr entry for full LSM context" - Revert "UBUNTU: SAUCE: lsm stacking v37: LSM: Removed scaffolding function lsmcontext_init" - Revert "UBUNTU: SAUCE: lsm stacking v37: netlabel: Use a struct lsmblob in audit data" - Revert "UBUNTU: SAUCE: lsm stacking v37: Audit: Add record for multiple object contexts" - Revert "UBUNTU: SAUCE: lsm stacking v37: audit: multiple subject lsm values for netlabel" - Revert "UBUNTU: SAUCE: lsm stacking v37: Audit: Add record for multiple task security contexts" - Revert "UBUNTU: SAUCE: lsm stacking v37: Audit: Allow multiple records in an audit_buffer" - Revert "UBUNTU: SAUCE: lsm stacking v37: LSM: Add a function to report multiple LSMs" - Revert "UBUNTU: SAUCE: lsm stacking v37: Audit: Create audit_stamp structure" - Revert "UBUNTU: SAUCE: lsm stacking v37: Audit: Keep multiple LSM data in audit_names" - Revert "UBUNTU: SAUCE: lsm stacking v37: LSM: security_secid_to_secctx module selection" - Revert "UBUNTU: SAUCE: lsm stacking v37: binder: Pass LSM identifier for confirmation" - Revert "UBUNTU: SAUCE: lsm stacking v37: NET: Store LSM netlabel data in a lsmblob" - Revert "UBUNTU: SAUCE: lsm stacking v37: LSM: security_secid_to_secctx in netlink netfilter" - Revert "UBUNTU: SAUCE: lsm stacking v37: LSM: Use lsmcontext in security_dentry_init_security" - Revert "UBUNTU: SAUCE: lsm stacking v37: LSM: Use lsmcontext in security_inode_getsecctx" - Revert "UBUNTU: SAUCE: lsm stacking v37: LSM: Use lsmcontext in security_secid_to_secctx" - Revert "UBUNTU: SAUCE: lsm stacking v37: LSM: Ensure the correct LSM context releaser" - Revert "UBUNTU: SAUCE: fixup lsm stacking v37: LSM: Specify which LSM to display" - Revert "UBUNTU: SAUCE: lsm stacking v37: LSM: Specify which LSM to display" - Revert "UBUNTU: SAUCE: lsm stacking v37: LSM: Use lsmblob in security_cred_getsecid" - Revert "UBUNTU: SAUCE: lsm stacking v37: LSM: Use lsmblob in security_inode_getsecid" - Revert "UBUNTU: SAUCE: lsm stacking v37: LSM: Use lsmblob in security_current_getsecid" - Revert "UBUNTU: SAUCE: lsm stacking v37: LSM: Use lsmblob in security_ipc_getsecid" - Revert "UBUNTU: SAUCE: lsm stacking v37: LSM: Use lsmblob in security_secid_to_secctx" - Revert "UBUNTU: SAUCE: lsm stacking v37: LSM: Use lsmblob in security_secctx_to_secid" - Revert "UBUNTU: SAUCE: lsm stacking v37: LSM: Use lsmblob in security_kernel_act_as" - Revert "UBUNTU: SAUCE: lsm stacking v37: LSM: Use lsmblob in security_audit_rule_match" - Revert "UBUNTU: SAUCE: lsm stacking v37: IMA: avoid label collisions with stacked LSMs" - Revert "UBUNTU: SAUCE: lsm stacking v37: LSM: provide lsm name and id slot mappings" - Revert "UBUNTU: SAUCE: lsm stacking v37: LSM: Add the lsmblob data structure." - Revert "UBUNTU: SAUCE: lsm stacking v37: LSM: Infrastructure management of the sock security" - Revert "UBUNTU: SAUCE: lsm stacking v37: integrity: disassociate ima_filter_rule from security_audit_rule" - Revert "UBUNTU: SAUCE: apparmor: LSM stacking: switch from SK_CTX() to aa_sock()" - Revert "UBUNTU: SAUCE: apparmor: Add fine grained mediation of posix mqueues" - Revert "UBUNTU: SAUCE: apparmor: rename aa_sock() to aa_unix_sk()" - Revert
[Kernel-packages] [Bug 1984103] Re: [UBUNTU 22.04] s390/qeth: cache link_info for ethtool
Verification done on jammy (on a slightly different setup):
root@s1lp15:~# uname -a
Linux s1lp15 5.15.0-27-generic #28-Ubuntu SMP Thu Apr 14 04:55:23 UTC 2022
s390x s390x s390x GNU/Linux
root@s1lp15:~# ethtool encc000 | grep Duplex
Duplex: Full
root@s1lp15:~# grep qcrdinfo /sys/kernel/debug/s390dbf/qeth*/hex_ascii | wc -l
3
root@s1lp15:~# grep qcrdinfo /sys/kernel/debug/s390dbf/qeth*/hex_ascii
/sys/kernel/debug/s390dbf/qeth_card_0.0.c000/hex_ascii:00 01664021373:134002 2
- 0001 03ff81066676 71 63 72 64 69 6e 66 6f | qcrdinfo
/sys/kernel/debug/s390dbf/qeth_card_0.0.c000/hex_ascii:00 01664021384:308308 2
- 0007 03ff81066676 71 63 72 64 69 6e 66 6f | qcrdinfo
/sys/kernel/debug/s390dbf/qeth_card_0.0.c000/hex_ascii:00 01664021384:308804 2
- 0007 03ff81066676 71 63 72 64 69 6e 66 6f | qcrdinfo
root@s1lp15:~# ethtool encc000
Settings for encc000:
Supported ports: [ FIBRE ]
Supported link modes: 1baseSR/Full
Supported pause frame use: No
Supports auto-negotiation: Yes
Supported FEC modes: Not reported
Advertised link modes: 1baseSR/Full
Advertised pause frame use: No
Advertised auto-negotiation: Yes
Advertised FEC modes: Not reported
Speed: 1Mb/s
Duplex: Full
Auto-negotiation: on
Port: FIBRE
PHYAD: 0
Transceiver: internal
Link detected: yes
(adjusting tags accordingly)
** Tags added: verification-done verification-done-jammy
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1984103
Title:
[UBUNTU 22.04] s390/qeth: cache link_info for ethtool
Status in Ubuntu on IBM z Systems:
Fix Committed
Status in linux package in Ubuntu:
Fix Committed
Status in linux source package in Jammy:
Fix Committed
Status in linux source package in Kinetic:
Fix Committed
Bug description:
== SRU Justification ==
Since commit e6e771b3d897 ("s390/qeth: detach netdevice while card is
offline") there was a timing window during recovery, that qeth_query_card_info
could be sent to the card, even before it was ready for it, leading to a
failing cardrecovery. There is evidence that this window was hit, as not
all callers of get_link_ksettings() check for netif_device_present.
This patch (Mainline commit 7a07a29e4f67) fixes the regression caused
by commit e6e771b3d897.
Commit 7a07a29e4f67 is in mainline as of v6.0-rc1.
This patch is being requested in Jammy 5.15 and Kinetic 5.19.
== Fix ==
7a07a29e4f67 ("s390/qeth: cache link_info for ethtool")
== Regression Potential ==
Low. This patch has been accepted in upstream stable and is limited to
the s390/qeth card.
== Test Case ==
A test kernel was built with this patch and tested by the original bug
reporter.
The bug reporter states the test kernel resolved the bug.
== Comment: #0 - J?rn Siglen - 2022-08-09 07:38:27 ==
+++ This bug was initially created as a clone of Bug #199319 +++
Description: s390/qeth: cache link_info for ethtool
Symptom: lost of IP connection and log entries in journalctl:
kernel: qeth 0.0.0365: The qeth device driver failed to
recover an error on the device
Problem: Since commit e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
there was a timing window during recovery, that
qeth_query_card_info could be sent to the card, even before it
was ready for it, leading to a failing card recovery. There is
evidence that this window was hit, as not all callers of
get_link_ksettings() check for netif_device_present.
Solution: Use cached values in qeth_get_link_ksettings(), instead of
calling qeth_query_card_info() and falling back to default
values in case it fails. Link info is already updated when the
card goes online, e.g. after STARTLAN (physical link up). Set
the link info to default values, when the card goes offline or
at STOPLAN (physical link down). A follow-on patch will improve
values reported for link down.
Fixes: e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
Reproduction: enforce a eth device recvoery, while running ethtool multiple
times in parallel and using iperf to get load on the interface.
Upstream-ID: 7a07a29e4f6713b224f3bcde5f835e777301bdb8
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
applicable for most kernel > 3.14
== Comment: #3 - J?rn Siglen - 2022-08-09 07:54:41 ==
the inital update came in with kernel 5.1 upstream, but we found it
backported in many older kernel versions
== Comme
[Kernel-packages] [Bug 1984103] Re: [UBUNTU 22.04] s390/qeth: cache link_info for ethtool
This bug is awaiting verification that the linux/5.15.0-50.56 kernel in
-proposed solves the problem. Please test the kernel and update this bug
with the results. If the problem is solved, change the tag
'verification-needed-jammy' to 'verification-done-jammy'. If the problem
still exists, change the tag 'verification-needed-jammy' to
'verification-failed-jammy'.
If verification is not done by 5 working days from today, this fix will
be dropped from the source code, and this bug will be closed.
See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how
to enable and use -proposed. Thank you!
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1984103
Title:
[UBUNTU 22.04] s390/qeth: cache link_info for ethtool
Status in Ubuntu on IBM z Systems:
Fix Committed
Status in linux package in Ubuntu:
Fix Committed
Status in linux source package in Jammy:
Fix Committed
Status in linux source package in Kinetic:
Fix Committed
Bug description:
== SRU Justification ==
Since commit e6e771b3d897 ("s390/qeth: detach netdevice while card is
offline") there was a timing window during recovery, that qeth_query_card_info
could be sent to the card, even before it was ready for it, leading to a
failing cardrecovery. There is evidence that this window was hit, as not
all callers of get_link_ksettings() check for netif_device_present.
This patch (Mainline commit 7a07a29e4f67) fixes the regression caused
by commit e6e771b3d897.
Commit 7a07a29e4f67 is in mainline as of v6.0-rc1.
This patch is being requested in Jammy 5.15 and Kinetic 5.19.
== Fix ==
7a07a29e4f67 ("s390/qeth: cache link_info for ethtool")
== Regression Potential ==
Low. This patch has been accepted in upstream stable and is limited to
the s390/qeth card.
== Test Case ==
A test kernel was built with this patch and tested by the original bug
reporter.
The bug reporter states the test kernel resolved the bug.
== Comment: #0 - J?rn Siglen - 2022-08-09 07:38:27 ==
+++ This bug was initially created as a clone of Bug #199319 +++
Description: s390/qeth: cache link_info for ethtool
Symptom: lost of IP connection and log entries in journalctl:
kernel: qeth 0.0.0365: The qeth device driver failed to
recover an error on the device
Problem: Since commit e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
there was a timing window during recovery, that
qeth_query_card_info could be sent to the card, even before it
was ready for it, leading to a failing card recovery. There is
evidence that this window was hit, as not all callers of
get_link_ksettings() check for netif_device_present.
Solution: Use cached values in qeth_get_link_ksettings(), instead of
calling qeth_query_card_info() and falling back to default
values in case it fails. Link info is already updated when the
card goes online, e.g. after STARTLAN (physical link up). Set
the link info to default values, when the card goes offline or
at STOPLAN (physical link down). A follow-on patch will improve
values reported for link down.
Fixes: e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
Reproduction: enforce a eth device recvoery, while running ethtool multiple
times in parallel and using iperf to get load on the interface.
Upstream-ID: 7a07a29e4f6713b224f3bcde5f835e777301bdb8
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
applicable for most kernel > 3.14
== Comment: #3 - J?rn Siglen - 2022-08-09 07:54:41 ==
the inital update came in with kernel 5.1 upstream, but we found it
backported in many older kernel versions
== Comment: #4 - J?rn Siglen - 2022-08-09 08:03:09 ==
the acceptance info of the patch can be found here:
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1984103/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1984103] Re: [UBUNTU 22.04] s390/qeth: cache link_info for ethtool
** Changed in: ubuntu-z-systems
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1984103
Title:
[UBUNTU 22.04] s390/qeth: cache link_info for ethtool
Status in Ubuntu on IBM z Systems:
Fix Committed
Status in linux package in Ubuntu:
Fix Committed
Status in linux source package in Jammy:
Fix Committed
Status in linux source package in Kinetic:
Fix Committed
Bug description:
== SRU Justification ==
Since commit e6e771b3d897 ("s390/qeth: detach netdevice while card is
offline") there was a timing window during recovery, that qeth_query_card_info
could be sent to the card, even before it was ready for it, leading to a
failing cardrecovery. There is evidence that this window was hit, as not
all callers of get_link_ksettings() check for netif_device_present.
This patch (Mainline commit 7a07a29e4f67) fixes the regression caused
by commit e6e771b3d897.
Commit 7a07a29e4f67 is in mainline as of v6.0-rc1.
This patch is being requested in Jammy 5.15 and Kinetic 5.19.
== Fix ==
7a07a29e4f67 ("s390/qeth: cache link_info for ethtool")
== Regression Potential ==
Low. This patch has been accepted in upstream stable and is limited to
the s390/qeth card.
== Test Case ==
A test kernel was built with this patch and tested by the original bug
reporter.
The bug reporter states the test kernel resolved the bug.
== Comment: #0 - J?rn Siglen - 2022-08-09 07:38:27 ==
+++ This bug was initially created as a clone of Bug #199319 +++
Description: s390/qeth: cache link_info for ethtool
Symptom: lost of IP connection and log entries in journalctl:
kernel: qeth 0.0.0365: The qeth device driver failed to
recover an error on the device
Problem: Since commit e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
there was a timing window during recovery, that
qeth_query_card_info could be sent to the card, even before it
was ready for it, leading to a failing card recovery. There is
evidence that this window was hit, as not all callers of
get_link_ksettings() check for netif_device_present.
Solution: Use cached values in qeth_get_link_ksettings(), instead of
calling qeth_query_card_info() and falling back to default
values in case it fails. Link info is already updated when the
card goes online, e.g. after STARTLAN (physical link up). Set
the link info to default values, when the card goes offline or
at STOPLAN (physical link down). A follow-on patch will improve
values reported for link down.
Fixes: e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
Reproduction: enforce a eth device recvoery, while running ethtool multiple
times in parallel and using iperf to get load on the interface.
Upstream-ID: 7a07a29e4f6713b224f3bcde5f835e777301bdb8
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
applicable for most kernel > 3.14
== Comment: #3 - J?rn Siglen - 2022-08-09 07:54:41 ==
the inital update came in with kernel 5.1 upstream, but we found it
backported in many older kernel versions
== Comment: #4 - J?rn Siglen - 2022-08-09 08:03:09 ==
the acceptance info of the patch can be found here:
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1984103/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1984103] Re: [UBUNTU 22.04] s390/qeth: cache link_info for ethtool
** Changed in: linux (Ubuntu Kinetic)
Status: In Progress => Fix Committed
** Changed in: linux (Ubuntu Jammy)
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1984103
Title:
[UBUNTU 22.04] s390/qeth: cache link_info for ethtool
Status in Ubuntu on IBM z Systems:
In Progress
Status in linux package in Ubuntu:
Fix Committed
Status in linux source package in Jammy:
Fix Committed
Status in linux source package in Kinetic:
Fix Committed
Bug description:
== SRU Justification ==
Since commit e6e771b3d897 ("s390/qeth: detach netdevice while card is
offline") there was a timing window during recovery, that qeth_query_card_info
could be sent to the card, even before it was ready for it, leading to a
failing cardrecovery. There is evidence that this window was hit, as not
all callers of get_link_ksettings() check for netif_device_present.
This patch (Mainline commit 7a07a29e4f67) fixes the regression caused
by commit e6e771b3d897.
Commit 7a07a29e4f67 is in mainline as of v6.0-rc1.
This patch is being requested in Jammy 5.15 and Kinetic 5.19.
== Fix ==
7a07a29e4f67 ("s390/qeth: cache link_info for ethtool")
== Regression Potential ==
Low. This patch has been accepted in upstream stable and is limited to
the s390/qeth card.
== Test Case ==
A test kernel was built with this patch and tested by the original bug
reporter.
The bug reporter states the test kernel resolved the bug.
== Comment: #0 - J?rn Siglen - 2022-08-09 07:38:27 ==
+++ This bug was initially created as a clone of Bug #199319 +++
Description: s390/qeth: cache link_info for ethtool
Symptom: lost of IP connection and log entries in journalctl:
kernel: qeth 0.0.0365: The qeth device driver failed to
recover an error on the device
Problem: Since commit e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
there was a timing window during recovery, that
qeth_query_card_info could be sent to the card, even before it
was ready for it, leading to a failing card recovery. There is
evidence that this window was hit, as not all callers of
get_link_ksettings() check for netif_device_present.
Solution: Use cached values in qeth_get_link_ksettings(), instead of
calling qeth_query_card_info() and falling back to default
values in case it fails. Link info is already updated when the
card goes online, e.g. after STARTLAN (physical link up). Set
the link info to default values, when the card goes offline or
at STOPLAN (physical link down). A follow-on patch will improve
values reported for link down.
Fixes: e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
Reproduction: enforce a eth device recvoery, while running ethtool multiple
times in parallel and using iperf to get load on the interface.
Upstream-ID: 7a07a29e4f6713b224f3bcde5f835e777301bdb8
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
applicable for most kernel > 3.14
== Comment: #3 - J?rn Siglen - 2022-08-09 07:54:41 ==
the inital update came in with kernel 5.1 upstream, but we found it
backported in many older kernel versions
== Comment: #4 - J?rn Siglen - 2022-08-09 08:03:09 ==
the acceptance info of the patch can be found here:
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1984103/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1984103] Re: [UBUNTU 22.04] s390/qeth: cache link_info for ethtool
** Changed in: ubuntu-z-systems
Status: Confirmed => In Progress
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1984103
Title:
[UBUNTU 22.04] s390/qeth: cache link_info for ethtool
Status in Ubuntu on IBM z Systems:
In Progress
Status in linux package in Ubuntu:
In Progress
Status in linux source package in Jammy:
In Progress
Status in linux source package in Kinetic:
In Progress
Bug description:
== SRU Justification ==
Since commit e6e771b3d897 ("s390/qeth: detach netdevice while card is
offline") there was a timing window during recovery, that qeth_query_card_info
could be sent to the card, even before it was ready for it, leading to a
failing cardrecovery. There is evidence that this window was hit, as not
all callers of get_link_ksettings() check for netif_device_present.
This patch (Mainline commit 7a07a29e4f67) fixes the regression caused
by commit e6e771b3d897.
Commit 7a07a29e4f67 is in mainline as of v6.0-rc1.
This patch is being requested in Jammy 5.15 and Kinetic 5.19.
== Fix ==
7a07a29e4f67 ("s390/qeth: cache link_info for ethtool")
== Regression Potential ==
Low. This patch has been accepted in upstream stable and is limited to
the s390/qeth card.
== Test Case ==
A test kernel was built with this patch and tested by the original bug
reporter.
The bug reporter states the test kernel resolved the bug.
== Comment: #0 - J?rn Siglen - 2022-08-09 07:38:27 ==
+++ This bug was initially created as a clone of Bug #199319 +++
Description: s390/qeth: cache link_info for ethtool
Symptom: lost of IP connection and log entries in journalctl:
kernel: qeth 0.0.0365: The qeth device driver failed to
recover an error on the device
Problem: Since commit e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
there was a timing window during recovery, that
qeth_query_card_info could be sent to the card, even before it
was ready for it, leading to a failing card recovery. There is
evidence that this window was hit, as not all callers of
get_link_ksettings() check for netif_device_present.
Solution: Use cached values in qeth_get_link_ksettings(), instead of
calling qeth_query_card_info() and falling back to default
values in case it fails. Link info is already updated when the
card goes online, e.g. after STARTLAN (physical link up). Set
the link info to default values, when the card goes offline or
at STOPLAN (physical link down). A follow-on patch will improve
values reported for link down.
Fixes: e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
Reproduction: enforce a eth device recvoery, while running ethtool multiple
times in parallel and using iperf to get load on the interface.
Upstream-ID: 7a07a29e4f6713b224f3bcde5f835e777301bdb8
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
applicable for most kernel > 3.14
== Comment: #3 - J?rn Siglen - 2022-08-09 07:54:41 ==
the inital update came in with kernel 5.1 upstream, but we found it
backported in many older kernel versions
== Comment: #4 - J?rn Siglen - 2022-08-09 08:03:09 ==
the acceptance info of the patch can be found here:
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1984103/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1984103] Re: [UBUNTU 22.04] s390/qeth: cache link_info for ethtool
SRU request submitted to UKT mailing list:
https://lists.ubuntu.com/archives/kernel-team/2022-September/133102.html
** Description changed:
+ == SRU Justification ==
+ Since commit e6e771b3d897 ("s390/qeth: detach netdevice while card is
offline") there was a timing window during recovery, that qeth_query_card_info
could be sent to the card, even before it was ready for it, leading to a
failing cardrecovery. There is evidence that this window was hit, as not
all callers of get_link_ksettings() check for netif_device_present.
+
+ This patch fixes the regression caused by commit e6e771b3d897.
+
+ Commit 7a07a29e4f67 is in mainline as of v6.0-rc1.
+
+ This patch is being requested in Jammy 5.15 and Kinetic 5.19. The
+
+
+ == Fix ==
+ 7a07a29e4f67 ("s390/qeth: cache link_info for ethtool")
+
+ == Regression Potential ==
+ Low. This patch has been accepted in upstream stable and is limited to
+ the s390/qeth card.
+
+ == Test Case ==
+ A test kernel was built with this patch and tested by the original bug
reporter.
+ The bug reporter states the test kernel resolved the bug.
+
+
+
+
+
== Comment: #0 - J?rn Siglen - 2022-08-09 07:38:27 ==
+++ This bug was initially created as a clone of Bug #199319 +++
Description: s390/qeth: cache link_info for ethtool
Symptom: lost of IP connection and log entries in journalctl:
- kernel: qeth 0.0.0365: The qeth device driver failed to
- recover an error on the device
+ kernel: qeth 0.0.0365: The qeth device driver failed to
+ recover an error on the device
Problem: Since commit e6e771b3d897
- ("s390/qeth: detach netdevice while card is offline")
-there was a timing window during recovery, that
-qeth_query_card_info could be sent to the card, even before it
-was ready for it, leading to a failing card recovery. There is
-evidence that this window was hit, as not all callers of
-get_link_ksettings() check for netif_device_present.
- Solution: Use cached values in qeth_get_link_ksettings(), instead of
-calling qeth_query_card_info() and falling back to default
-values in case it fails. Link info is already updated when the
-card goes online, e.g. after STARTLAN (physical link up). Set
-the link info to default values, when the card goes offline or
-at STOPLAN (physical link down). A follow-on patch will improve
-values reported for link down.
-Fixes: e6e771b3d897
-("s390/qeth: detach netdevice while card is offline")
+ ("s390/qeth: detach netdevice while card is offline")
+ there was a timing window during recovery, that
+ qeth_query_card_info could be sent to the card, even before it
+ was ready for it, leading to a failing card recovery. There is
+ evidence that this window was hit, as not all callers of
+ get_link_ksettings() check for netif_device_present.
+ Solution: Use cached values in qeth_get_link_ksettings(), instead of
+ calling qeth_query_card_info() and falling back to default
+ values in case it fails. Link info is already updated when the
+ card goes online, e.g. after STARTLAN (physical link up). Set
+ the link info to default values, when the card goes offline or
+ at STOPLAN (physical link down). A follow-on patch will improve
+ values reported for link down.
+ Fixes: e6e771b3d897
+ ("s390/qeth: detach netdevice while card is offline")
Reproduction: enforce a eth device recvoery, while running ethtool multiple
-times in parallel and using iperf to get load on the interface.
+
[Kernel-packages] [Bug 1984103] Re: [UBUNTU 22.04] s390/qeth: cache link_info for ethtool
** Changed in: linux (Ubuntu Jammy)
Importance: Undecided => High
** Changed in: linux (Ubuntu Kinetic)
Importance: Undecided => High
** Changed in: linux (Ubuntu Jammy)
Assignee: (unassigned) => Joseph Salisbury (jsalisbury)
** Changed in: linux (Ubuntu Kinetic)
Assignee: (unassigned) => Joseph Salisbury (jsalisbury)
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1984103
Title:
[UBUNTU 22.04] s390/qeth: cache link_info for ethtool
Status in Ubuntu on IBM z Systems:
Confirmed
Status in linux package in Ubuntu:
Confirmed
Status in linux source package in Jammy:
Confirmed
Status in linux source package in Kinetic:
Confirmed
Bug description:
== Comment: #0 - J?rn Siglen - 2022-08-09 07:38:27 ==
+++ This bug was initially created as a clone of Bug #199319 +++
Description: s390/qeth: cache link_info for ethtool
Symptom: lost of IP connection and log entries in journalctl:
kernel: qeth 0.0.0365: The qeth device driver failed to
recover an error on the device
Problem: Since commit e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
there was a timing window during recovery, that
qeth_query_card_info could be sent to the card, even before it
was ready for it, leading to a failing card recovery. There is
evidence that this window was hit, as not all callers of
get_link_ksettings() check for netif_device_present.
Solution: Use cached values in qeth_get_link_ksettings(), instead of
calling qeth_query_card_info() and falling back to default
values in case it fails. Link info is already updated when the
card goes online, e.g. after STARTLAN (physical link up). Set
the link info to default values, when the card goes offline or
at STOPLAN (physical link down). A follow-on patch will improve
values reported for link down.
Fixes: e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
Reproduction: enforce a eth device recvoery, while running ethtool multiple
times in parallel and using iperf to get load on the interface.
Upstream-ID: 7a07a29e4f6713b224f3bcde5f835e777301bdb8
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
applicable for most kernel > 3.14
== Comment: #3 - J?rn Siglen - 2022-08-09 07:54:41 ==
the inital update came in with kernel 5.1 upstream, but we found it
backported in many older kernel versions
== Comment: #4 - J?rn Siglen - 2022-08-09 08:03:09 ==
the acceptance info of the patch can be found here:
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1984103/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1984103] Re: [UBUNTU 22.04] s390/qeth: cache link_info for ethtool
** Tags removed: targetmilestone-inin---
** Tags added: targetmilestone-inin2204
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1984103
Title:
[UBUNTU 22.04] s390/qeth: cache link_info for ethtool
Status in Ubuntu on IBM z Systems:
Confirmed
Status in linux package in Ubuntu:
Confirmed
Status in linux source package in Jammy:
Confirmed
Status in linux source package in Kinetic:
Confirmed
Bug description:
== Comment: #0 - J?rn Siglen - 2022-08-09 07:38:27 ==
+++ This bug was initially created as a clone of Bug #199319 +++
Description: s390/qeth: cache link_info for ethtool
Symptom: lost of IP connection and log entries in journalctl:
kernel: qeth 0.0.0365: The qeth device driver failed to
recover an error on the device
Problem: Since commit e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
there was a timing window during recovery, that
qeth_query_card_info could be sent to the card, even before it
was ready for it, leading to a failing card recovery. There is
evidence that this window was hit, as not all callers of
get_link_ksettings() check for netif_device_present.
Solution: Use cached values in qeth_get_link_ksettings(), instead of
calling qeth_query_card_info() and falling back to default
values in case it fails. Link info is already updated when the
card goes online, e.g. after STARTLAN (physical link up). Set
the link info to default values, when the card goes offline or
at STOPLAN (physical link down). A follow-on patch will improve
values reported for link down.
Fixes: e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
Reproduction: enforce a eth device recvoery, while running ethtool multiple
times in parallel and using iperf to get load on the interface.
Upstream-ID: 7a07a29e4f6713b224f3bcde5f835e777301bdb8
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
applicable for most kernel > 3.14
== Comment: #3 - J?rn Siglen - 2022-08-09 07:54:41 ==
the inital update came in with kernel 5.1 upstream, but we found it
backported in many older kernel versions
== Comment: #4 - J?rn Siglen - 2022-08-09 08:03:09 ==
the acceptance info of the patch can be found here:
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1984103/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1984103] Re: [UBUNTU 22.04] s390/qeth: cache link_info for ethtool
** Tags added: patch
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1984103
Title:
[UBUNTU 22.04] s390/qeth: cache link_info for ethtool
Status in Ubuntu on IBM z Systems:
Confirmed
Status in linux package in Ubuntu:
Confirmed
Status in linux source package in Jammy:
Confirmed
Status in linux source package in Kinetic:
Confirmed
Bug description:
== Comment: #0 - J?rn Siglen - 2022-08-09 07:38:27 ==
+++ This bug was initially created as a clone of Bug #199319 +++
Description: s390/qeth: cache link_info for ethtool
Symptom: lost of IP connection and log entries in journalctl:
kernel: qeth 0.0.0365: The qeth device driver failed to
recover an error on the device
Problem: Since commit e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
there was a timing window during recovery, that
qeth_query_card_info could be sent to the card, even before it
was ready for it, leading to a failing card recovery. There is
evidence that this window was hit, as not all callers of
get_link_ksettings() check for netif_device_present.
Solution: Use cached values in qeth_get_link_ksettings(), instead of
calling qeth_query_card_info() and falling back to default
values in case it fails. Link info is already updated when the
card goes online, e.g. after STARTLAN (physical link up). Set
the link info to default values, when the card goes offline or
at STOPLAN (physical link down). A follow-on patch will improve
values reported for link down.
Fixes: e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
Reproduction: enforce a eth device recvoery, while running ethtool multiple
times in parallel and using iperf to get load on the interface.
Upstream-ID: 7a07a29e4f6713b224f3bcde5f835e777301bdb8
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
applicable for most kernel > 3.14
== Comment: #3 - J?rn Siglen - 2022-08-09 07:54:41 ==
the inital update came in with kernel 5.1 upstream, but we found it
backported in many older kernel versions
== Comment: #4 - J?rn Siglen - 2022-08-09 08:03:09 ==
the acceptance info of the patch can be found here:
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1984103/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1984103] Re: [UBUNTU 22.04] s390/qeth: cache link_info for ethtool
I prepared a test kernel with the proposed patch (that was a clear
cherry pick for 5.15). Frank do you think you can help me validating the
test kernel?
You can find a tarball with the debian packages for the test kernel at:
https://kernel.ubuntu.com/~mhcerri/test/lp1984103/linux-unsigned-
debs-5.15.0-48.54+lp1984103.1_s390x.tgz
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1984103
Title:
[UBUNTU 22.04] s390/qeth: cache link_info for ethtool
Status in Ubuntu on IBM z Systems:
Confirmed
Status in linux package in Ubuntu:
Confirmed
Status in linux source package in Jammy:
Confirmed
Status in linux source package in Kinetic:
Confirmed
Bug description:
== Comment: #0 - J?rn Siglen - 2022-08-09 07:38:27 ==
+++ This bug was initially created as a clone of Bug #199319 +++
Description: s390/qeth: cache link_info for ethtool
Symptom: lost of IP connection and log entries in journalctl:
kernel: qeth 0.0.0365: The qeth device driver failed to
recover an error on the device
Problem: Since commit e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
there was a timing window during recovery, that
qeth_query_card_info could be sent to the card, even before it
was ready for it, leading to a failing card recovery. There is
evidence that this window was hit, as not all callers of
get_link_ksettings() check for netif_device_present.
Solution: Use cached values in qeth_get_link_ksettings(), instead of
calling qeth_query_card_info() and falling back to default
values in case it fails. Link info is already updated when the
card goes online, e.g. after STARTLAN (physical link up). Set
the link info to default values, when the card goes offline or
at STOPLAN (physical link down). A follow-on patch will improve
values reported for link down.
Fixes: e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
Reproduction: enforce a eth device recvoery, while running ethtool multiple
times in parallel and using iperf to get load on the interface.
Upstream-ID: 7a07a29e4f6713b224f3bcde5f835e777301bdb8
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
applicable for most kernel > 3.14
== Comment: #3 - J?rn Siglen - 2022-08-09 07:54:41 ==
the inital update came in with kernel 5.1 upstream, but we found it
backported in many older kernel versions
== Comment: #4 - J?rn Siglen - 2022-08-09 08:03:09 ==
the acceptance info of the patch can be found here:
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1984103/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1984103] Re: [UBUNTU 22.04] s390/qeth: cache link_info for ethtool
** Patch added: "0001-s390-qeth-cache-link_info-for-ethtool.patch"
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1984103/+attachment/5612535/+files/0001-s390-qeth-cache-link_info-for-ethtool.patch
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1984103
Title:
[UBUNTU 22.04] s390/qeth: cache link_info for ethtool
Status in Ubuntu on IBM z Systems:
Confirmed
Status in linux package in Ubuntu:
Confirmed
Status in linux source package in Jammy:
Confirmed
Status in linux source package in Kinetic:
Confirmed
Bug description:
== Comment: #0 - J?rn Siglen - 2022-08-09 07:38:27 ==
+++ This bug was initially created as a clone of Bug #199319 +++
Description: s390/qeth: cache link_info for ethtool
Symptom: lost of IP connection and log entries in journalctl:
kernel: qeth 0.0.0365: The qeth device driver failed to
recover an error on the device
Problem: Since commit e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
there was a timing window during recovery, that
qeth_query_card_info could be sent to the card, even before it
was ready for it, leading to a failing card recovery. There is
evidence that this window was hit, as not all callers of
get_link_ksettings() check for netif_device_present.
Solution: Use cached values in qeth_get_link_ksettings(), instead of
calling qeth_query_card_info() and falling back to default
values in case it fails. Link info is already updated when the
card goes online, e.g. after STARTLAN (physical link up). Set
the link info to default values, when the card goes offline or
at STOPLAN (physical link down). A follow-on patch will improve
values reported for link down.
Fixes: e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
Reproduction: enforce a eth device recvoery, while running ethtool multiple
times in parallel and using iperf to get load on the interface.
Upstream-ID: 7a07a29e4f6713b224f3bcde5f835e777301bdb8
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
applicable for most kernel > 3.14
== Comment: #3 - J?rn Siglen - 2022-08-09 07:54:41 ==
the inital update came in with kernel 5.1 upstream, but we found it
backported in many older kernel versions
== Comment: #4 - J?rn Siglen - 2022-08-09 08:03:09 ==
the acceptance info of the patch can be found here:
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1984103/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1984103] Re: [UBUNTU 22.04] s390/qeth: cache link_info for ethtool
Yepp, it's all about kernel patches.
This bug was wrongly marked as affecting the ethtool (well, it affects the
ethtool, but not in the 'affects' send of Launchpad), which caused some
confusion.
I just changed that, pointing now to the kernel (which is "linux (Ubuntu)" in
the above affects section).
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1984103
Title:
[UBUNTU 22.04] s390/qeth: cache link_info for ethtool
Status in Ubuntu on IBM z Systems:
Confirmed
Status in linux package in Ubuntu:
Confirmed
Status in linux source package in Jammy:
Confirmed
Status in linux source package in Kinetic:
Confirmed
Bug description:
== Comment: #0 - J?rn Siglen - 2022-08-09 07:38:27 ==
+++ This bug was initially created as a clone of Bug #199319 +++
Description: s390/qeth: cache link_info for ethtool
Symptom: lost of IP connection and log entries in journalctl:
kernel: qeth 0.0.0365: The qeth device driver failed to
recover an error on the device
Problem: Since commit e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
there was a timing window during recovery, that
qeth_query_card_info could be sent to the card, even before it
was ready for it, leading to a failing card recovery. There is
evidence that this window was hit, as not all callers of
get_link_ksettings() check for netif_device_present.
Solution: Use cached values in qeth_get_link_ksettings(), instead of
calling qeth_query_card_info() and falling back to default
values in case it fails. Link info is already updated when the
card goes online, e.g. after STARTLAN (physical link up). Set
the link info to default values, when the card goes offline or
at STOPLAN (physical link down). A follow-on patch will improve
values reported for link down.
Fixes: e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
Reproduction: enforce a eth device recvoery, while running ethtool multiple
times in parallel and using iperf to get load on the interface.
Upstream-ID: 7a07a29e4f6713b224f3bcde5f835e777301bdb8
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
applicable for most kernel > 3.14
== Comment: #3 - J?rn Siglen - 2022-08-09 07:54:41 ==
the inital update came in with kernel 5.1 upstream, but we found it
backported in many older kernel versions
== Comment: #4 - J?rn Siglen - 2022-08-09 08:03:09 ==
the acceptance info of the patch can be found here:
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1984103/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1984103] Re: [UBUNTU 22.04] s390/qeth: cache link_info for ethtool
** Tags removed: rls-incoming-jj rls-incoming-kk
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1984103
Title:
[UBUNTU 22.04] s390/qeth: cache link_info for ethtool
Status in Ubuntu on IBM z Systems:
Confirmed
Status in linux package in Ubuntu:
Confirmed
Status in linux source package in Jammy:
Confirmed
Status in linux source package in Kinetic:
Confirmed
Bug description:
== Comment: #0 - J?rn Siglen - 2022-08-09 07:38:27 ==
+++ This bug was initially created as a clone of Bug #199319 +++
Description: s390/qeth: cache link_info for ethtool
Symptom: lost of IP connection and log entries in journalctl:
kernel: qeth 0.0.0365: The qeth device driver failed to
recover an error on the device
Problem: Since commit e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
there was a timing window during recovery, that
qeth_query_card_info could be sent to the card, even before it
was ready for it, leading to a failing card recovery. There is
evidence that this window was hit, as not all callers of
get_link_ksettings() check for netif_device_present.
Solution: Use cached values in qeth_get_link_ksettings(), instead of
calling qeth_query_card_info() and falling back to default
values in case it fails. Link info is already updated when the
card goes online, e.g. after STARTLAN (physical link up). Set
the link info to default values, when the card goes offline or
at STOPLAN (physical link down). A follow-on patch will improve
values reported for link down.
Fixes: e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
Reproduction: enforce a eth device recvoery, while running ethtool multiple
times in parallel and using iperf to get load on the interface.
Upstream-ID: 7a07a29e4f6713b224f3bcde5f835e777301bdb8
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
applicable for most kernel > 3.14
== Comment: #3 - J?rn Siglen - 2022-08-09 07:54:41 ==
the inital update came in with kernel 5.1 upstream, but we found it
backported in many older kernel versions
== Comment: #4 - J?rn Siglen - 2022-08-09 08:03:09 ==
the acceptance info of the patch can be found here:
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1984103/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
[Kernel-packages] [Bug 1984103] Re: [UBUNTU 22.04] s390/qeth: cache link_info for ethtool
** Also affects: linux (Ubuntu)
Importance: Undecided
Status: New
** No longer affects: ethtool (Ubuntu)
** Changed in: ethtool (Ubuntu Jammy)
Assignee: Ubuntu Server (ubuntu-server) => (unassigned)
** Changed in: ethtool (Ubuntu Kinetic)
Assignee: Ubuntu Server (ubuntu-server) => (unassigned)
** No longer affects: ethtool (Ubuntu Kinetic)
** No longer affects: ethtool (Ubuntu Jammy)
** Changed in: linux (Ubuntu Jammy)
Status: New => Confirmed
** Changed in: linux (Ubuntu Kinetic)
Status: New => Confirmed
--
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1984103
Title:
[UBUNTU 22.04] s390/qeth: cache link_info for ethtool
Status in Ubuntu on IBM z Systems:
Confirmed
Status in linux package in Ubuntu:
Confirmed
Status in linux source package in Jammy:
Confirmed
Status in linux source package in Kinetic:
Confirmed
Bug description:
== Comment: #0 - J?rn Siglen - 2022-08-09 07:38:27 ==
+++ This bug was initially created as a clone of Bug #199319 +++
Description: s390/qeth: cache link_info for ethtool
Symptom: lost of IP connection and log entries in journalctl:
kernel: qeth 0.0.0365: The qeth device driver failed to
recover an error on the device
Problem: Since commit e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
there was a timing window during recovery, that
qeth_query_card_info could be sent to the card, even before it
was ready for it, leading to a failing card recovery. There is
evidence that this window was hit, as not all callers of
get_link_ksettings() check for netif_device_present.
Solution: Use cached values in qeth_get_link_ksettings(), instead of
calling qeth_query_card_info() and falling back to default
values in case it fails. Link info is already updated when the
card goes online, e.g. after STARTLAN (physical link up). Set
the link info to default values, when the card goes offline or
at STOPLAN (physical link down). A follow-on patch will improve
values reported for link down.
Fixes: e6e771b3d897
("s390/qeth: detach netdevice while card is offline")
Reproduction: enforce a eth device recvoery, while running ethtool multiple
times in parallel and using iperf to get load on the interface.
Upstream-ID: 7a07a29e4f6713b224f3bcde5f835e777301bdb8
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
applicable for most kernel > 3.14
== Comment: #3 - J?rn Siglen - 2022-08-09 07:54:41 ==
the inital update came in with kernel 5.1 upstream, but we found it
backported in many older kernel versions
== Comment: #4 - J?rn Siglen - 2022-08-09 08:03:09 ==
the acceptance info of the patch can be found here:
https://lore.kernel.org/all/20220805184504.7f6f2...@kernel.org/T/#m2e3799a38d1d4630822db50f9a5d9b2ca018252f
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1984103/+subscriptions
--
Mailing list: https://launchpad.net/~kernel-packages
Post to : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help : https://help.launchpad.net/ListHelp
