[PowerPC] - Define error in arch/arch/powerpc/boot/io.h ??
Hi, Line 2 of arch/arch/powerpc/boot/io.h : 1 #ifndef _IO_H 2 #define __IO_H 3 4 #include types.h Should be _IO_H, not __IO_H. I'm right ? Thanks -- Lucas Tanure +55 (19) 988176559 ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: [PowerPC] - Define error in arch/arch/powerpc/boot/io.h ??
On 2014-07-24 09:00:22 (-0300), Lucas Tanure tan...@linux.com wrote: Line 2 of arch/arch/powerpc/boot/io.h : 1 #ifndef _IO_H 2 #define __IO_H 3 4 #include types.h Should be _IO_H, not __IO_H. I'm right ? That certainly looks wrong. It's also been wrong since October 2006, so it's probably not actually causing problems. Try sending it to the 'Trival Patch Monkey' (For small patches you may want to CC the Trivial Patch Monkey triv...@kernel.org which collects trivial patches.) -- Kristof ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: [PowerPC] - Define error in arch/arch/powerpc/boot/io.h ??
On 7/24/14, Lucas Tanure tan...@linux.com wrote: Hi, Line 2 of arch/arch/powerpc/boot/io.h : 1 #ifndef _IO_H 2 #define __IO_H 3 4 #include types.h Should be _IO_H, not __IO_H. I'm right ? Yes Thanks -- Lucas Tanure +55 (19) 988176559 -- Regards, Denis ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
[PATCH] powerpc: fix wrong defintion in boot/io.h
Fix wrong __IO_H definition in boot/io.h Reported-by: Fernando Silveira fsilve...@gmail.com Signed-off-by: Lucas Tanure tan...@linux.com --- arch/powerpc/boot/io.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/boot/io.h b/arch/powerpc/boot/io.h index 7c09f48..394da55 100644 --- a/arch/powerpc/boot/io.h +++ b/arch/powerpc/boot/io.h @@ -1,5 +1,5 @@ #ifndef _IO_H -#define __IO_H +#define _IO_H #include types.h -- 2.0.0 ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: [PowerPC] - Define error in arch/arch/powerpc/boot/io.h ??
On Thu, 24 Jul 2014 14:19:37 +0200, Kristof Provost said: On 2014-07-24 09:00:22 (-0300), Lucas Tanure tan...@linux.com wrote: Line 2 of arch/arch/powerpc/boot/io.h : 1 #ifndef _IO_H 2 #define __IO_H 3 4 #include types.h Should be _IO_H, not __IO_H. I'm right ? That certainly looks wrong. It's also been wrong since October 2006, so it's probably not actually causing problems. On the other hand, it would probably be a *really* good idea to test compile it on a powerpc box, see if it shakes out any latent bugs. All that fixing this will do is stop us from over-including io.h (and thus types.h) - but if there's any code that breaks because we don't include types.h and they don't pick it up otherwise. (In other words, it's probably not causing a problem, but it *could* potentially be papering over a problem elsewhere...) pgpcCThhzRMBO.pgp Description: PGP signature ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: [PowerPC] - Define error in arch/arch/powerpc/boot/io.h ??
Ok, I will ask for a embedded powerpc board to test this. Thanks -- Lucas Tanure +55 (19) 988176559 On Thu, Jul 24, 2014 at 12:43 PM, valdis.kletni...@vt.edu wrote: On Thu, 24 Jul 2014 14:19:37 +0200, Kristof Provost said: On 2014-07-24 09:00:22 (-0300), Lucas Tanure tan...@linux.com wrote: Line 2 of arch/arch/powerpc/boot/io.h : 1 #ifndef _IO_H 2 #define __IO_H 3 4 #include types.h Should be _IO_H, not __IO_H. I'm right ? That certainly looks wrong. It's also been wrong since October 2006, so it's probably not actually causing problems. On the other hand, it would probably be a *really* good idea to test compile it on a powerpc box, see if it shakes out any latent bugs. All that fixing this will do is stop us from over-including io.h (and thus types.h) - but if there's any code that breaks because we don't include types.h and they don't pick it up otherwise. (In other words, it's probably not causing a problem, but it *could* potentially be papering over a problem elsewhere...) ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Work
Is there any work for a kernel newbie that you guys known of? Cheers Nick ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Work
Take a look at drivers/staging/. You will find something there to work on. On Jul 24, 2014 6:38 PM, Nick Krause xerofo...@gmail.com wrote: Is there any work for a kernel newbie that you guys known of? Cheers Nick ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Work
Could start cleaning a driver ? http://kernelnewbies.org/OPWfirstpatch#head-4abafc61af197fb6e3d6cda623b00bdd90a52c26 The job here is about how to send patchs and not doing a awesome code. -- Lucas Tanure +55 (19) 988176559 On Thu, Jul 24, 2014 at 1:38 PM, Nick Krause xerofo...@gmail.com wrote: Is there any work for a kernel newbie that you guys known of? Cheers Nick ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Work
On Thu, Jul 24, 2014 at 12:44 PM, Lucas Tanure tan...@linux.com wrote: Could start cleaning a driver ? http://kernelnewbies.org/OPWfirstpatch#head-4abafc61af197fb6e3d6cda623b00bdd90a52c26 The job here is about how to send patchs and not doing a awesome code. -- Lucas Tanure +55 (19) 988176559 On Thu, Jul 24, 2014 at 1:38 PM, Nick Krause xerofo...@gmail.com wrote: Is there any work for a kernel newbie that you guys known of? Cheers Nick ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies I sent in some patches to Greg on the linux-next tree for staging. Cheers Nick ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Work
On Thu, Jul 24, 2014 at 12:38 PM, Nick Krause xerofo...@gmail.com wrote: Is there any work for a kernel newbie that you guys known of? Cheers Nick Your first task will be reading and _understanding_ the following: Greg Kroah-Hartman, How to piss off a kernel subsystem maintainer. http://www.kroah.com/log/linux/maintainer.html http://www.kroah.com/log/linux/maintainer-02.html http://www.kroah.com/log/linux/maintainer-03.html http://www.kroah.com/log/linux/maintainer-04.html http://www.kroah.com/log/linux/maintainer-05.html from Documentation/SubmittingPatches. -- Andev ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Work
On Thu, Jul 24, 2014 at 12:51 PM, Andev debian...@gmail.com wrote: On Thu, Jul 24, 2014 at 12:38 PM, Nick Krause xerofo...@gmail.com wrote: Is there any work for a kernel newbie that you guys known of? Cheers Nick Your first task will be reading and _understanding_ the following: Greg Kroah-Hartman, How to piss off a kernel subsystem maintainer. http://www.kroah.com/log/linux/maintainer.html http://www.kroah.com/log/linux/maintainer-02.html http://www.kroah.com/log/linux/maintainer-03.html http://www.kroah.com/log/linux/maintainer-04.html http://www.kroah.com/log/linux/maintainer-05.html from Documentation/SubmittingPatches. -- Andev Yes, I didn't build test and that is a huge mistake. Cheers Nick ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: printk or pr_level?
Thank-you Greg On Jul 23 2014, Greg KH wrote: On Wed, Jul 23, 2014 at 02:45:05PM -0700, Arlie Stephens wrote: On Jul 23 2014, Kristofer Hallin wrote: 1. No. Depending on what subsystem your are printing logs from you should use different functions for logging. In the networking subsystem netdev_dbg is suitable and so on. Otherwise pr_debug will always work and is always preferred over printk. Why? [snip] Ok, here's the rule in one sentance: Be as _descriptive_ as you can with the device that is emitting the message. So what does that mean in reality? Use the subsystem's logging macros for your messages. If you are not in a subsystem, then fall back to the default pr_* messages. So, if you are a network driver, then use netdev_dbg(). Other subsystems of class devices have their own form of logging macros, and they should be easy to find. If you aren't in a class driver, but are a driver, then use dev_dbg(), because you do have a device pointer accessable to you (if you don't, either you are in your module init or exit function, and you shouldn't be printing messages then anyway.) If you are not in a driver, and you do not have _any_ 'struct device' accessable to you, reconsider if you really want to be printing anything, as the use of it to a user is going to be really low. But if you have to, then fall back to the pr_* functions, as those tie into the dynamic debugging logic of the kernel, and provide a format that is unified that userspace tools can use to hopefully search and find things properly. So there is a method to this madness, and it is pretty simple if you think about it this way. Does that help out? Yes it does. Thank you. And I think I see why I needed help - I'm mentally a core kernel person, whatever I may happen to be working on at the moment ;-) So my archetypal kernel message would be something like the ones generated by BUG_ON() ;-) greg k-h -- Arlie (Arlie Stephens ar...@worldash.org) ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
How to force my usb mouse using a kernel module created by myself?
Hi everyone! It's a dumb question, but is not working with me. Does anybody knows how to force my usb mouse using a kernel module created by myself? When I plug my mouse it need to load my module and not the generic one. Thanks! *Julio Cesar Faracco* ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Task 1 of Eudyptula Challenge
Hey guys, I am need so I was wondering how to write the Makefile. Cheers Nick ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Task 1 of Eudyptula Challenge
Nick, There is https://www.kernel.org/doc/Documentation/kbuild/makefiles.txt and https://www.kernel.org/doc/Documentation/kbuild/modules.txt Thanks -- Lucas Tanure +55 (19) 988176559 On Thu, Jul 24, 2014 at 4:55 PM, Nick Krause xerofo...@gmail.com wrote: Hey guys, I am need so I was wondering how to write the Makefile. Cheers Nick ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Task 1 of Eudyptula Challenge
Hi, And example makefile is available in http://www.tldp.org/LDP/lkmpg/2.6/html/lkmpg.html Thanks On 25-Jul-2014 1:30 am, Lucas Tanure tan...@linux.com wrote: Nick, There is https://www.kernel.org/doc/Documentation/kbuild/makefiles.txt and https://www.kernel.org/doc/Documentation/kbuild/modules.txt Thanks -- Lucas Tanure +55 (19) 988176559 On Thu, Jul 24, 2014 at 4:55 PM, Nick Krause xerofo...@gmail.com wrote: Hey guys, I am need so I was wondering how to write the Makefile. Cheers Nick ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Task 1 of Eudyptula Challenge
Hi Nick, Please go through the file: linux/Documentatio/kbuild/modules.txt Good luck ! Aruna On Thu, Jul 24, 2014 at 3:55 PM, Nick Krause xerofo...@gmail.com wrote: Hey guys, I am need so I was wondering how to write the Makefile. Cheers Nick ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
hacking kernel-3.x with ncc
hi, is there anyone hacking/browsering kernel-3.x with ncc? If yes, could you please provide some suggestion how to do it? http://students.ceid.upatras.gr/~sxanth/ncc/ thanks ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Work
On Thu, Jul 24, 2014 at 1:10 PM, Nick Krause xerofo...@gmail.com wrote: On Thu, Jul 24, 2014 at 12:51 PM, Andev debian...@gmail.com wrote: On Thu, Jul 24, 2014 at 12:38 PM, Nick Krause xerofo...@gmail.com wrote: Is there any work for a kernel newbie that you guys known of? Cheers Nick Your first task will be reading and _understanding_ the following: Greg Kroah-Hartman, How to piss off a kernel subsystem maintainer. http://www.kroah.com/log/linux/maintainer.html http://www.kroah.com/log/linux/maintainer-02.html http://www.kroah.com/log/linux/maintainer-03.html http://www.kroah.com/log/linux/maintainer-04.html http://www.kroah.com/log/linux/maintainer-05.html from Documentation/SubmittingPatches. -- Andev Yes, I didn't build test and that is a huge mistake. Cheers Nick Andev, I having been doing build tests and checkpatch in staging for the last month. It doesn't seem like it's worth my time as so my other people are doing it. I want an interesting project one that is challenging and rewarding :). Nick ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Help with flame wars
On Wed, Jul 23, 2014 at 10:37 PM, Kristofer Hallin kristofer.hal...@gmail.com wrote: Seems like you got some great guidance too. https://lkml.org/lkml/2014/7/23/443 On 24 Jul 2014 06:38, Nick Krause xerofo...@gmail.com wrote: As a new kernel developer I seem to have sent out some bad patches and the other developers are stating I should stop working on the kernel and learn C , even though I known it. I would like to see if we can stop these flame wars as there really wanting me to quit. I don't think anyone said anything bad about the patch. They just want to know the motive behind the patch as it expected. Anyway would you stop walking if someone doesn't like you to walk? Nick ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Work
How to make environment like (build and test) for working on kernel patch, what are the resources should be available for that. thanks. On Fri, Jul 25, 2014 at 7:53 AM, Nick Krause xerofo...@gmail.com wrote: On Thu, Jul 24, 2014 at 1:10 PM, Nick Krause xerofo...@gmail.com wrote: On Thu, Jul 24, 2014 at 12:51 PM, Andev debian...@gmail.com wrote: On Thu, Jul 24, 2014 at 12:38 PM, Nick Krause xerofo...@gmail.com wrote: Is there any work for a kernel newbie that you guys known of? Cheers Nick Your first task will be reading and _understanding_ the following: Greg Kroah-Hartman, How to piss off a kernel subsystem maintainer. http://www.kroah.com/log/linux/maintainer.html http://www.kroah.com/log/linux/maintainer-02.html http://www.kroah.com/log/linux/maintainer-03.html http://www.kroah.com/log/linux/maintainer-04.html http://www.kroah.com/log/linux/maintainer-05.html from Documentation/SubmittingPatches. -- Andev Yes, I didn't build test and that is a huge mistake. Cheers Nick Andev, I having been doing build tests and checkpatch in staging for the last month. It doesn't seem like it's worth my time as so my other people are doing it. I want an interesting project one that is challenging and rewarding :). Nick ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
