Re: Build Error in Linux-next, intel ethernet driver
I updated my clean untouched linux-next tree, and tried to compile with the attached .config. But I got a build error with intel i40e driver. I tested a fix, and sent to LKML. But I don't have this device, I compiled and tested the kernel. Boots normally. Anyone had the same issue ? Thanks Lucas Tanure Fix missing include in intel i40e driver. Without this include linux next tree won't compile. Signed-off-by: Lucas Tanure tan...@linux.com --- drivers/net/ethernet/intel/i40e/i40e_fcoe.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/i40e/i40e_fcoe.c b/drivers/net/ethernet/intel/i40e/i40e_fcoe.c index 6938fc1..5d01db1 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_fcoe.c +++ b/drivers/net/ethernet/intel/i40e/i40e_fcoe.c @@ -33,6 +33,7 @@ #include scsi/fc/fc_fcoe.h #include scsi/libfc.h #include scsi/libfcoe.h +#include uapi/linux/dcbnl.h #include i40e.h #include i40e_fcoe.h -- 2.0.0 ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Bad Patches and Issues with other devolopers
I have sent out just ten bad patches and the developers seem very annoyed with me and think I am trolling. If someone on this list can find a way for me to improve my relationship with them and let me continue my work here that would be great. Nick ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Bad Patches and Issues with other devolopers
Hmm. What about stop sending patches? On Aug 5, 2014 7:43 PM, Nick Krause xerofo...@gmail.com wrote: I have sent out just ten bad patches and the developers seem very annoyed with me and think I am trolling. If someone on this list can find a way for me to improve my relationship with them and let me continue my work here that would be great. Nick ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Trace Help
I am tracing this , Aug 4 10:20:03 Horos kernel: [ cut here ] Aug 4 10:20:03 Horos kernel: WARNING: CPU: 3 PID: 31 at net/wireless/reg.c:1806 reg_process_hint+0x286/0x330 [cfg80211]() Aug 4 10:20:03 Horos kernel: Modules linked in: af_packet snd_pcm_oss snd_mixer_oss nls_iso8859_1 nls_cp850 vfat fat snd_hda_codec_realtek snd_hda_codec_generic snd_hda_codec_hdmi arc4 evdev ath9k ath9k_common ath9k_hw ath psmouse led_class mac80211 k10temp cfg80211 rfkill sr_mod r8169 cdrom mii 8250 serial_core snd_hda_intel snd_hda_controller snd_hda_codec radeon snd_pcm drm_kms_helper button snd_timer ttm processor snd wmi soundcore drm i2c_piix4 i2c_algo_bit i2c_core Aug 4 10:20:03 Horos kernel: CPU: 3 PID: 31 Comm: kworker/3:1 Not tainted 3.16.0-00115-g19583ca #58 Aug 4 10:20:03 Horos kernel: Hardware name: System manufacturer System Product Name/F2A85-M LE, BIOS 5012 08/28/2012 Aug 4 10:20:03 Horos kernel: Workqueue: events reg_todo [cfg80211] Aug 4 10:20:03 Horos kernel: 880237437d50 8134fc09 Aug 4 10:20:03 Horos kernel: 880237437d88 81036e05 a032dc4b 880235677500 Aug 4 10:20:03 Horos kernel: 880235ac4240 0003 88023567751c 880237437d98 Aug 4 10:20:03 Horos kernel: Call Trace: Aug 4 10:20:03 Horos kernel: [8134fc09] dump_stack+0x4d/0x6f Aug 4 10:20:03 Horos kernel: [81036e05] warn_slowpath_common+0x75/0x8e Aug 4 10:20:03 Horos kernel: [a032dc4b] ? reg_process_hint+0x286/0x330 [cfg80211] Aug 4 10:20:03 Horos kernel: [81036ec2] warn_slowpath_null+0x15/0x17 Aug 4 10:20:03 Horos kernel: [a032dc4b] reg_process_hint+0x286/0x330 [cfg80211] Aug 4 10:20:03 Horos kernel: [a032dd70] reg_todo+0x7b/0x157 [cfg80211] Aug 4 10:20:03 Horos kernel: [81048e92] process_one_work+0x1ba/0x2d6 Aug 4 10:20:03 Horos kernel: [81049adb] worker_thread+0x308/0x3f5 Aug 4 10:20:03 Horos kernel: [810497d3] ? cancel_delayed_work_sync+0x10/ 0x10 Aug 4 10:20:03 Horos kernel: [8104e13e] kthread+0xdf/0xe7 Aug 4 10:20:03 Horos kernel: [8104e05f] ? kthread_create_on_node+0x17b/0x17b Aug 4 10:20:03 Horos kernel: [81353eec] ret_from_fork+0x7c/0xb0 Aug 4 10:20:03 Horos kernel: [8104e05f] ? kthread_create_on_node+0x17b/0x17b Aug 4 10:20:03 Horos kernel: ---[ end trace 389490cbf61b0b3c ]--- My logic is this, I am assuming I am wrong again based on my bad patches record. 1. In reg_redo we are calling reg_process_prending_hints with rtnl_lock on this wireless driver 2. In that function we known there are two calls to reg_process_hint and we hit both so therefore, we are traced to that function as also if (lr !lr-processed) is true in the function we are in 3. In that function we hit the warn on with no default initialization and free the it in the function reg_free_request 4. And since this this is the last request free here and also since this a null value we hit the warn on for null as there is no set function we can use, the request being null 5.We then free the value as this is the last request in reg_free_request based on the if statement and we call reg_process_hint and we have already freed the request leading to the kernel panic Nick ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Bad Patches and Issues with other devolopers
On Tue, Aug 5, 2014 at 1:59 PM, Mandeep Sandhu mandeepsandhu@gmail.com wrote: Hi Nick, I came across some G+ posts from kernel developers discussing you and your recent patch submissions. I must say you're pretty (in)famous! :) Jokes aside, why not just follow on the advice given to you by so many people, i.e pick an area of interest (in the various kernel subsystems) for yourself, first pick really small ossues (but not the code formatting ones as they only tend to generate noise for the maintainer and not really fix anything), create the patch, see if the kernel builds with. TEST IT, most importantly (if you don't have the requisite hw then either acquire one, or pick another issue where you CAN test it). Basically check everything thats mentioned here: https://www.kernel.org/doc/Documentation/SubmittingPatches http://kernelnewbies.org/OPWfirstpatch Trust me, if you _do_ go through this process and submit a 'good' patch, all past issues that you've had with other developers will be forgotten. Don't be in a rush to get 'something' in the kernel. I know its a big deal to get things in one of the coolest piece of software on this planet, but you'll need a lot perseverance and patience to be a kernel contributor. HTH, -mandeep On Tue, Aug 5, 2014 at 10:42 AM, Nick Krause xerofo...@gmail.com wrote: I have sent out just ten bad patches and the developers seem very annoyed with me and think I am trolling. If someone on this list can find a way for me to improve my relationship with them and let me continue my work here that would be great. Nick ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies That's fine, I feel perhaps I am just really trying to force my code in(ego) and just is bad form. If anyone on this list can read my last trace to check my logic first, before I write a patch and let you check it, that would be great. Thanks A lot, Nick ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Trace Help
On Tue, Aug 5, 2014 at 2:02 PM, Nick Krause xerofo...@gmail.com wrote: I am tracing this , Aug 4 10:20:03 Horos kernel: [ cut here ] Aug 4 10:20:03 Horos kernel: WARNING: CPU: 3 PID: 31 at net/wireless/reg.c:1806 reg_process_hint+0x286/0x330 [cfg80211]() Aug 4 10:20:03 Horos kernel: Modules linked in: af_packet snd_pcm_oss snd_mixer_oss nls_iso8859_1 nls_cp850 vfat fat snd_hda_codec_realtek snd_hda_codec_generic snd_hda_codec_hdmi arc4 evdev ath9k ath9k_common ath9k_hw ath psmouse led_class mac80211 k10temp cfg80211 rfkill sr_mod r8169 cdrom mii 8250 serial_core snd_hda_intel snd_hda_controller snd_hda_codec radeon snd_pcm drm_kms_helper button snd_timer ttm processor snd wmi soundcore drm i2c_piix4 i2c_algo_bit i2c_core Aug 4 10:20:03 Horos kernel: CPU: 3 PID: 31 Comm: kworker/3:1 Not tainted 3.16.0-00115-g19583ca #58 Aug 4 10:20:03 Horos kernel: Hardware name: System manufacturer System Product Name/F2A85-M LE, BIOS 5012 08/28/2012 Aug 4 10:20:03 Horos kernel: Workqueue: events reg_todo [cfg80211] Aug 4 10:20:03 Horos kernel: 880237437d50 8134fc09 Aug 4 10:20:03 Horos kernel: 880237437d88 81036e05 a032dc4b 880235677500 Aug 4 10:20:03 Horos kernel: 880235ac4240 0003 88023567751c 880237437d98 Aug 4 10:20:03 Horos kernel: Call Trace: Aug 4 10:20:03 Horos kernel: [8134fc09] dump_stack+0x4d/0x6f Aug 4 10:20:03 Horos kernel: [81036e05] warn_slowpath_common+0x75/0x8e Aug 4 10:20:03 Horos kernel: [a032dc4b] ? reg_process_hint+0x286/0x330 [cfg80211] Aug 4 10:20:03 Horos kernel: [81036ec2] warn_slowpath_null+0x15/0x17 Aug 4 10:20:03 Horos kernel: [a032dc4b] reg_process_hint+0x286/0x330 [cfg80211] Aug 4 10:20:03 Horos kernel: [a032dd70] reg_todo+0x7b/0x157 [cfg80211] Aug 4 10:20:03 Horos kernel: [81048e92] process_one_work+0x1ba/0x2d6 Aug 4 10:20:03 Horos kernel: [81049adb] worker_thread+0x308/0x3f5 Aug 4 10:20:03 Horos kernel: [810497d3] ? cancel_delayed_work_sync+0x10/ 0x10 Aug 4 10:20:03 Horos kernel: [8104e13e] kthread+0xdf/0xe7 Aug 4 10:20:03 Horos kernel: [8104e05f] ? kthread_create_on_node+0x17b/0x17b Aug 4 10:20:03 Horos kernel: [81353eec] ret_from_fork+0x7c/0xb0 Aug 4 10:20:03 Horos kernel: [8104e05f] ? kthread_create_on_node+0x17b/0x17b Aug 4 10:20:03 Horos kernel: ---[ end trace 389490cbf61b0b3c ]--- My logic is this, I am assuming I am wrong again based on my bad patches record. 1. In reg_redo we are calling reg_process_prending_hints with rtnl_lock on this wireless driver 2. In that function we known there are two calls to reg_process_hint and we hit both so therefore, we are traced to that function as also if (lr !lr-processed) is true in the function we are in 3. In that function we hit the warn on with no default initialization and free the it in the function reg_free_request 4. And since this this is the last request free here and also since this a null value we hit the warn on for null as there is no set function we can use, the request being null 5.We then free the value as this is the last request in reg_free_request based on the if statement and we call reg_process_hint and we have already freed the request leading to the kernel panic Nick 5 is wrong we are freeing the null request as it's last meaning we are calling reg_process_hint again this time as the normal one and not the if statement leading to a kernel panic as the request in null. ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Bad Patches and Issues with other devolopers
On Tue, Aug 5, 2014 at 7:04 PM, Nick Krause xerofo...@gmail.com wrote: On Tue, Aug 5, 2014 at 1:59 PM, Mandeep Sandhu mandeepsandhu@gmail.com wrote: Hi Nick, I came across some G+ posts from kernel developers discussing you and your recent patch submissions. I must say you're pretty (in)famous! :) Jokes aside, why not just follow on the advice given to you by so many people, i.e pick an area of interest (in the various kernel subsystems) for yourself, first pick really small ossues (but not the code formatting ones as they only tend to generate noise for the maintainer and not really fix anything), create the patch, see if the kernel builds with. TEST IT, most importantly (if you don't have the requisite hw then either acquire one, or pick another issue where you CAN test it). Basically check everything thats mentioned here: https://www.kernel.org/doc/Documentation/SubmittingPatches http://kernelnewbies.org/OPWfirstpatch Trust me, if you _do_ go through this process and submit a 'good' patch, all past issues that you've had with other developers will be forgotten. Don't be in a rush to get 'something' in the kernel. I know its a big deal to get things in one of the coolest piece of software on this planet, but you'll need a lot perseverance and patience to be a kernel contributor. HTH, -mandeep On Tue, Aug 5, 2014 at 10:42 AM, Nick Krause xerofo...@gmail.com wrote: I have sent out just ten bad patches and the developers seem very annoyed with me and think I am trolling. If someone on this list can find a way for me to improve my relationship with them and let me continue my work here that would be great. Nick ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies That's fine, I feel perhaps I am just really trying to force my code in(ego) and just is bad form. If anyone on this list can read my last trace to check my logic first, before I write a patch and let you check it, that would be great. Thanks A lot, Nick ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies How about not sending patches at all until you develop a good understanding of kernel subsystems. read the books and read code for few months before you ever re-try sending patches? -- Thank you Warm Regards Anuz ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Bad Patches and Issues with other devolopers
On Aug 5, 2014 11:14 PM, Nick Krause xerofo...@gmail.com wrote: I have sent out just ten bad patches and the developers seem very annoyed with me and think I am trolling. If someone on this list can find a way for me to improve my relationship with them and let me continue my work here that would be great. Nick i saw that you sent a patch regarding videobuf2 on 3rd august , the reaction of that patch continues till 4th. on 4th you write that you will not send a patch again without testing. but surprisingly again on 5th you send a patch , which as usual , fails to build. have you really tested the patch before sending?? did you try to compile the kernel after making your modifications?? i think - no. ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Bad Patches and Issues with other devolopers
On Tue, Aug 5, 2014 at 11:55 PM, Sudip Mukherjee sudipm.mukher...@gmail.com wrote: On Aug 5, 2014 11:14 PM, Nick Krause xerofo...@gmail.com wrote: I have sent out just ten bad patches and the developers seem very annoyed with me and think I am trolling. If someone on this list can find a way for me to improve my relationship with them and let me continue my work here that would be great. Nick i saw that you sent a patch regarding videobuf2 on 3rd august , the reaction of that patch continues till 4th. on 4th you write that you will not send a patch again without testing. but surprisingly again on 5th you send a patch , which as usual , fails to build. have you really tested the patch before sending?? did you try to compile the kernel after making your modifications?? i think - no. ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies Hi Nick, The advice developers have given you is very valuable. As the above ppl have also said, please do hurry through submitting incorrect patches, you should really know what you are fixing and why that needs to be fixed. It should be compiled and tested. Above all, you need to ask yourself a question, why do you really want to do this? Please do not do this if you want to be famous or show that even you can do something technical. Do this only if you are really interested and have liking about OS development stuff. Then it will not matter that you have submitted 100s of patches in a month or just 1 patch in a year. Results should not matter, your goal should be to learn something new every day about linux kernel. This should be done through lots of conceptual code reading, using testing the kernel. To start of please read good books like : - 1. Linux kernel development 2. Understanding linux kernel 3. Linux device drivers 4. There are more but these 3 are enough for beginning. Once done, you would be interested in particular sub-system, then try to explore that sub-system more by code reading, making small changes not necessarily bug-fixes, validate your code understanding through those changes. Enjoy learning! - Rohan ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Bad Patches and Issues with other devolopers
On Tue, 05 Aug 2014 13:42:58 -0400, Nick Krause said: I have sent out just ten bad patches and the developers seem very annoyed with me and Let's face it - if you've sent ten bad patches in a row without getting one right, you're doing something wrong. And although total noob coders scale very well (there seems to be a never-ending supply of them), maintainers don't scale well at all - and they have a *huge* workload to review a lot of patches every release cycle. I can't think of a single maintainer that isn't willing to provide advice. I also can't think of a single maintainer who *doesn't* get torqued off massively when V2 of a patch, or another patch, comes in from the same person and it's obvious the advice wasn't listened to. They don't have time for that sort of foolishness. think I am trolling. If someone on this list can find a way for me to improve my relationship with them and let me continue my work here that would be great. First and foremost, when senior kernel developers give you specific advice, *listen to it*. If somebody like Ted T'so tells you that it's unacceptable to send patches that aren't compile-tested, *you should never be sending another patch that didn't compile clean*. Period. End Of Discussion. In fact, you should strive higher - don't submit a patch unless you are (a) booted onto the patched kernel, (b) verify it by checking uname -r, and (c) have done testing that your patch actually fixed the issue you were patching without breaking anything. Running around willy-nilly submitting patches all over the tree doesn't inspire confidence in your patches - especially after you've hit multiple subsystems and been told This is wrong and you obviously (a) don't understand the subsystem and (b) didn't bother figuring it out. Also, you may want to sit down for a few days, and think long and hard about *why* you're so desperate to submit kernel patches. Do you have a good reason to devote the time? Or is it just ego-stroking? (Personally, I've been around since the 2.5.47 or so kernel - and I'm only doing it because I have a Dell laptop on my desk and a quarter acre of servers across the hall, and lots of users on our campus - and every good bug report I file against linux-next means a crappy bug report from a user after the release escapes) pgp3qi1ro3f8e.pgp Description: PGP signature ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Eudyptula Challenge status
Hi Is someone taking the Eudyptula Challenge here? I was answering the tasks when suddenly it stopped returning my messages (with corrections or new tasks). Since Little Penguin tell us about any break, I was curious to ask. I've sent task 15 answer on 27th of July and got no reply since then. I've heard about a troll in the LKML trying to push non-sense patchs, so I decided to ask. https://lkml.org/lkml/2014/8/4/206 Has someone heard from Little Penguin recently? Thank you. ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Bad Patches and Issues with other devolopers
On Tue, Aug 5, 2014 at 3:54 PM, valdis.kletni...@vt.edu wrote: On Tue, 05 Aug 2014 13:42:58 -0400, Nick Krause said: I have sent out just ten bad patches and the developers seem very annoyed with me and Let's face it - if you've sent ten bad patches in a row without getting one right, you're doing something wrong. And although total noob coders scale very well (there seems to be a never-ending supply of them), maintainers don't scale well at all - and they have a *huge* workload to review a lot of patches every release cycle. I can't think of a single maintainer that isn't willing to provide advice. I also can't think of a single maintainer who *doesn't* get torqued off massively when V2 of a patch, or another patch, comes in from the same person and it's obvious the advice wasn't listened to. They don't have time for that sort of foolishness. think I am trolling. If someone on this list can find a way for me to improve my relationship with them and let me continue my work here that would be great. First and foremost, when senior kernel developers give you specific advice, *listen to it*. If somebody like Ted T'so tells you that it's unacceptable to send patches that aren't compile-tested, *you should never be sending another patch that didn't compile clean*. Period. End Of Discussion. In fact, you should strive higher - don't submit a patch unless you are (a) booted onto the patched kernel, (b) verify it by checking uname -r, and (c) have done testing that your patch actually fixed the issue you were patching without breaking anything. Running around willy-nilly submitting patches all over the tree doesn't inspire confidence in your patches - especially after you've hit multiple subsystems and been told This is wrong and you obviously (a) don't understand the subsystem and (b) didn't bother figuring it out. Also, you may want to sit down for a few days, and think long and hard about *why* you're so desperate to submit kernel patches. Do you have a good reason to devote the time? Or is it just ego-stroking? (Personally, I've been around since the 2.5.47 or so kernel - and I'm only doing it because I have a Dell laptop on my desk and a quarter acre of servers across the hall, and lots of users on our campus - and every good bug report I file against linux-next means a crappy bug report from a user after the release escapes) I want to help and improve the code plus get a code doing kernel development. I understand now and am not going to waste time anymore, I am going to make sure all my patches are tested correctly and to the best of my ability first. Regards NIck ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Eudyptula Challenge status
On Tue, Aug 05, 2014 at 05:11:46PM -0300, Raphael Philipe wrote: Hi Is someone taking the Eudyptula Challenge here? I was answering the tasks when suddenly it stopped returning my messages (with corrections or new tasks). Since Little Penguin tell us about any break, I was curious to ask. I've sent task 15 answer on 27th of July and got no reply since then. I've heard about a troll in the LKML trying to push non-sense patchs, so I decided to ask. https://lkml.org/lkml/2014/8/4/206 I don't think Nick has anything to do with this. Has someone heard from Little Penguin recently? I sent my last submission on July 28th, no answer since then. I guess Little is either really busy, or down for maintenance or something like that. Give it some time, he will come back, or at least send out a status email like the last time this happened. Thank you. -- Robin Schroer ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Eudyptula Challenge status
On Tue, Aug 5, 2014 at 5:24 PM, Robin Schroer sulamiificat...@gmail.com wrote: On Tue, Aug 05, 2014 at 05:11:46PM -0300, Raphael Philipe wrote: Hi Is someone taking the Eudyptula Challenge here? I was answering the tasks when suddenly it stopped returning my messages (with corrections or new tasks). Since Little Penguin tell us about any break, I was curious to ask. I've sent task 15 answer on 27th of July and got no reply since then. I've heard about a troll in the LKML trying to push non-sense patchs, so I decided to ask. https://lkml.org/lkml/2014/8/4/206 I don't think Nick has anything to do with this. Has someone heard from Little Penguin recently? I sent my last submission on July 28th, no answer since then. I guess Little is either really busy, or down for maintenance or something like that. Give it some time, he will come back, or at least send out a status email like the last time this happened. You are right Robin. Before that time (July 27th), Little was answering pretty quickly so I became anxious and decided to ask. The good side is that I discovered a new interesting mailing list. Thank you for let me known. Thank you. -- Robin Schroer ___ Raphael Silva ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Bad Patches and Issues with other devolopers
On Tue, Aug 5, 2014 at 5:21 PM, Robert P. J. Day rpj...@crashcourse.ca wrote: On Tue, 5 Aug 2014, Nick Krause wrote: I want to help and improve the code plus get a code [sic] doing kernel development. *sigh* ... assuming you mean you want a *job* doing kernel development, you may have already screwed yourself royally. it's obvious you want to get *some* kind of patches into the kernel, just so you can say, see? i patched the linux kernel! what you clearly don't understand is the unintended consequences of your scattershot patching attempts. while prospective employers will certainly want to know what you've contributed to the kernel, they will also simply google on your name with respect to the kernel, and *that*, my boy, is where you are quite simply f**ked. i googled on the words nick krause linux kernel (which is what any minimally competent employer would do), and on the very first page of results was this: http://www.themukt.com/2014/08/04/someone-trolling-linux-kernel-mailing-lists-really-hard/ what that page tells prospective employers is that you are in over your head, you don't listen to advice, and you have very bad work habits. regardless of whatever you do from now on, given your online reputation that any employer will certainly find, you may have already made yourself unemployable. rday -- Robert P. J. Day Ottawa, Ontario, CANADA http://crashcourse.ca Twitter: http://twitter.com/rpjday LinkedIn: http://ca.linkedin.com/in/rpjday Is there any way to fix this or am I just unemployable. Cheers Nick ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Build Error in Linux-next, intel ethernet driver
On Tue, Aug 5, 2014 at 9:25 AM, Lucas Tanure tan...@linux.com wrote: I updated my clean untouched linux-next tree, and tried to compile with the attached .config. Your .config got stripped from the mail, can you please send me your .config. But I got a build error with intel i40e driver. I tested a fix, and sent to LKML. But I don't have this device, I compiled and tested the kernel. Boots normally. Anyone had the same issue ? I have not been testing linux-next, but I do test David Miller's net-next and net tree's which compile just fine with allmodconfig. In the short term, I have added your patch to my queue so that our validation team can take a look at the issue. Please send me your .config so that we can reproduce your issue to ensure that your patch is the best solution for this issue. Thanks Lucas Tanure Fix missing include in intel i40e driver. Without this include linux next tree won't compile. Signed-off-by: Lucas Tanure tan...@linux.com --- drivers/net/ethernet/intel/i40e/i40e_fcoe.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/i40e/i40e_fcoe.c b/drivers/net/ethernet/intel/i40e/i40e_fcoe.c index 6938fc1..5d01db1 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_fcoe.c +++ b/drivers/net/ethernet/intel/i40e/i40e_fcoe.c @@ -33,6 +33,7 @@ #include scsi/fc/fc_fcoe.h #include scsi/libfc.h #include scsi/libfcoe.h +#include uapi/linux/dcbnl.h #include i40e.h #include i40e_fcoe.h -- ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Build Error in Linux-next, intel ethernet driver
Hi, Thanks for reviewing my patch. My .config was bigger than 40k ( max attachment size for kernelnewbies list). The quick way to share is through dropbox. https://www.dropbox.com/s/kyeecunmebouysk/config.xz Thanks -- Lucas Tanure +55 (19) 988176559 On Tue, Aug 5, 2014 at 6:44 PM, Jeff Kirsher jeffrey.t.kirs...@intel.com wrote: On Tue, Aug 5, 2014 at 9:25 AM, Lucas Tanure tan...@linux.com wrote: I updated my clean untouched linux-next tree, and tried to compile with the attached .config. Your .config got stripped from the mail, can you please send me your .config. But I got a build error with intel i40e driver. I tested a fix, and sent to LKML. But I don't have this device, I compiled and tested the kernel. Boots normally. Anyone had the same issue ? I have not been testing linux-next, but I do test David Miller's net-next and net tree's which compile just fine with allmodconfig. In the short term, I have added your patch to my queue so that our validation team can take a look at the issue. Please send me your .config so that we can reproduce your issue to ensure that your patch is the best solution for this issue. Thanks Lucas Tanure Fix missing include in intel i40e driver. Without this include linux next tree won't compile. Signed-off-by: Lucas Tanure tan...@linux.com --- drivers/net/ethernet/intel/i40e/i40e_fcoe.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/i40e/i40e_fcoe.c b/drivers/net/ethernet/intel/i40e/i40e_fcoe.c index 6938fc1..5d01db1 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_fcoe.c +++ b/drivers/net/ethernet/intel/i40e/i40e_fcoe.c @@ -33,6 +33,7 @@ #include scsi/fc/fc_fcoe.h #include scsi/libfc.h #include scsi/libfcoe.h +#include uapi/linux/dcbnl.h #include i40e.h #include i40e_fcoe.h -- ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Bad Patches and Issues with other devolopers
On Tue, Aug 5, 2014 at 5:35 PM, Nick Krause xerofo...@gmail.com wrote: Is there any way to fix this or am I just unemployable. Cheers Nick Get married and take your wife's name! Being more realistic, get good at a specific subsystem and earn a good reputation in that subsystem. If you're lucky someone will get to know your reputation and get you a shot regardless that you got off on the wrong foot. More importantly, except for kernel trainers like Robert, most companies hire linux kernel subsystem developers, not linux kernel developers. Thus you need to find a part of the kernel you want to delve into and get really good at just it. You can also research who the companies are that employ kernel developers and see which subsystems they are working in. As an example Redhat employs a couple of the XFS developers. SUSE employs one of the mdraid developers, etc. Greg -- Greg Freemyer ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Build Error in Linux-next, intel ethernet driver
of course drivers/net/ethernet/intel/i40e/i40e_fcoe.c: In function ‘i40e_get_fcoe_tc_map’: drivers/net/ethernet/intel/i40e/i40e_fcoe.c:354:23: error: ‘IEEE_8021QAZ_APP_SEL_ETHERTYPE’ undeclared (first use in this function) if (app.selector == IEEE_8021QAZ_APP_SEL_ETHERTYPE ^ drivers/net/ethernet/intel/i40e/i40e_fcoe.c:354:23: note: each undeclared identifier is reported only once for each function it appears in scripts/Makefile.build:257: recipe for target 'drivers/net/ethernet/intel/i40e/i40e_fcoe.o' failed make[5]: *** [drivers/net/ethernet/intel/i40e/i40e_fcoe.o] Error 1 scripts/Makefile.build:404: recipe for target 'drivers/net/ethernet/intel/i40e' failed make[4]: *** [drivers/net/ethernet/intel/i40e] Error 2 scripts/Makefile.build:404: recipe for target 'drivers/net/ethernet/intel' failed make[3]: *** [drivers/net/ethernet/intel] Error 2 make[3]: *** Waiting for unfinished jobs Thanks -- Lucas Tanure +55 (19) 988176559 On Tue, Aug 5, 2014 at 7:54 PM, Jeff Kirsher jeffrey.t.kirs...@intel.com wrote: On Tue, 2014-08-05 at 19:37 -0300, Lucas Tanure wrote: Thanks for reviewing my patch. My .config was bigger than 40k ( max attachment size for kernelnewbies list). First thing I noticed was that your config was missing CONFIG_I40E_DCB=y option. So it appears that some of the recent FCoE code that was added to the i40e driver needs to be wrapped with #ifdef CONFIG_I40E_DCB. Can you provide the error that you are receiving, without your patch applied? That will help me narrow down what code needs to be wrapped. ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Bad Patches and Issues with other devolopers
On Tue, Aug 5, 2014 at 6:49 PM, Greg Freemyer greg.freem...@gmail.com wrote: On Tue, Aug 5, 2014 at 5:35 PM, Nick Krause xerofo...@gmail.com wrote: Is there any way to fix this or am I just unemployable. Cheers Nick Get married and take your wife's name! Being more realistic, get good at a specific subsystem and earn a good reputation in that subsystem. If you're lucky someone will get to know your reputation and get you a shot regardless that you got off on the wrong foot. More importantly, except for kernel trainers like Robert, most companies hire linux kernel subsystem developers, not linux kernel developers. Thus you need to find a part of the kernel you want to delve into and get really good at just it. You can also research who the companies are that employ kernel developers and see which subsystems they are working in. As an example Redhat employs a couple of the XFS developers. SUSE employs one of the mdraid developers, etc. Greg -- Greg Freemyer I was really worried , that I would have to give up on this goal, but thanks for the advice. I am interested in working in schedulers, file systems and networking. If you guys want to help me , just tell me how to get started and again to all the maintainers, I feel terrible about wasting your time. Sorry and thanks A lot, Nick ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
