Re: Problem with netconsole and eth0 timing
On 9/27/18 3:16 PM, don fisher wrote: On 9/27/18 12:01 AM, valdis.kletni...@vt.edu wrote: On Wed, 26 Sep 2018 21:38:27 -0700, don fisher said: Thanks. I tried building with the driver embedded in the kernel, but the compile failed with a halt. No crash is apparent, just a halt. It turned out that this was repeated until I removed the netconsole command during boot. System appears stable now. I will try tomorrow to embed the driver, then add netconsole option in the command line. Wait, what? The *compile* "failed with a halt"? What the heck does that mean? Don't know what it means. The compile just happened to be what I was execution. The system just stopped with no output to screen, dmesg or journal. With trial an error I discovered that if I eliminated the netconsole command from the grub2 linux command line, the system appeared stable again. I put that netconsole command in /etc/default/grub, so it is sort of a pain to insert and remove it. Don As threatened, I rebuilt with the alx driver embedded. I tested this kernel just to make sure the alx driver still supported standard Ethernet, which it did. I then add the linux netconsole command and rebooted. Everything worked well for awhile, but the output remote output stopped at 11.909 sec, while dmesg has entries up to 12.627 sec, and later up to 206.453 sec. The last message from dmesg is "work still pending". Before, at 11.977 sec there was a "No iBFT detected" message. This is about the time output terminated. I do not know what iBFT is. The netconsole on the receiver, nc -u -l 64001, is still running at 100% cpu utilization. Journal ctrl on the source gave: 701:Sep 27 16:25:01 dfpc60 kernel: netpoll: netconsole: local port 64001 703:Sep 27 16:25:01 dfpc60 kernel: netpoll: netconsole: local IPv4 address 192.168.7.60 705:Sep 27 16:25:01 dfpc60 kernel: netpoll: netconsole: interface 'eth0' 706:Sep 27 16:25:01 dfpc60 kernel: netpoll: netconsole: remote port 64001 707:Sep 27 16:25:01 dfpc60 kernel: netpoll: netconsole: remote IPv4 address 192.168.7.55 709:Sep 27 16:25:01 dfpc60 kernel: netpoll: netconsole: remote ethernet address 34:e6:d7:01:2a:dd 711:Sep 27 16:25:01 dfpc60 kernel: netpoll: netconsole: device eth0 not up yet, forcing it 719:Sep 27 16:25:01 dfpc60 kernel: netconsole: network logging started 750:Sep 27 16:25:01 dfpc60 systemd-modules-load[186]: Module 'netconsole' is builtin Is the forcing it correct? Don ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Problem with netconsole and eth0 timing
On 9/27/18 12:01 AM, valdis.kletni...@vt.edu wrote: On Wed, 26 Sep 2018 21:38:27 -0700, don fisher said: Thanks. I tried building with the driver embedded in the kernel, but the compile failed with a halt. No crash is apparent, just a halt. It turned out that this was repeated until I removed the netconsole command during boot. System appears stable now. I will try tomorrow to embed the driver, then add netconsole option in the command line. Wait, what? The *compile* "failed with a halt"? What the heck does that mean? ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies Don't know what it means. The compile just happened to be what I was execution. The system just stopped with no output to screen, dmesg or journal. With trial an error I discovered that if I eliminated the netconsole command from the grub2 linux command line, the system appeared stable again. I put that netconsole command in /etc/default/grub, so it is sort of a pain to insert and remove it. Don ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: [PATCH] fix error handling in drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
On Wed, Sep 26, 2018 at 01:52:17PM -0400, valdis.kletni...@vt.edu wrote:
> John notes that if the kzalloc of ieee->pHTInfo fails, we fail to call
> ieee80211_networks_free(). In addition, that function has an un-needed check
> before kfree().
>
> Reported-by: John Whitmore
> Signed-off-by: Valdis Kletnieks
> ---
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
> b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
> index 90a097f2cd4e..97ff0371b5bb 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
> @@ -78,8 +78,6 @@ static inline int ieee80211_networks_allocate(struct
> ieee80211_device *ieee)
>
> static inline void ieee80211_networks_free(struct ieee80211_device *ieee)
> {
> - if (!ieee->networks)
> - return;
> kfree(ieee->networks);
> ieee->networks = NULL;
> }
> @@ -180,6 +178,7 @@ struct net_device *alloc_ieee80211(int sizeof_priv)
> return dev;
>
> failed:
> + ieee80211_networks_free(ieee);
> if (dev)
> free_netdev(dev);
When there is a "goto failed;" then it's called "one err style" error
handling and we're just asking for bugs... In this case the bug is that
we're not allowd to call ieee80211_networks_free() with a NULL
"ieee" parameter. The right thing to do is to only call
ieee80211_networks_free() if we know that ieee80211_networks_allocate()
succeeded.
regards,
dan carpenter
___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Problem with netconsole and eth0 timing
On Wed, 26 Sep 2018 21:38:27 -0700, don fisher said: > Thanks. I tried building with the driver embedded in the kernel, but the > compile failed with a halt. No crash is apparent, just a halt. It turned > out that this was repeated until I removed the netconsole command during > boot. System appears stable now. I will try tomorrow to embed the > driver, then add netconsole option in the command line. Wait, what? The *compile* "failed with a halt"? What the heck does that mean? pgp5U1nXlk_eM.pgp Description: PGP signature ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
