Fwd: Resend - ANNOUNCE: Netdev 0.1 conference

2014-11-20 Thread Jeff Kirsher
Please forward to all places you think are relevant.
[original email i sent had the wrong contact info at the
bottom should be:  i...@netdev01.info]


Netdev 0.1 (year 0, conference 1) is a community-driven conference
geared towards Linux netheads. Linux kernel networking and user
space utilization of the interfaces to the Linux kernel networking
subsystem are the focus.
If you are using Linux as a boot system for proprietary networking,
then this conference _may not be for you_.

The netdev conference this year is structured to be 50/50
by-invitation and talk submission. We are making sure that we
reach out to speakers who have interesting relevant topics because
we recognize most of these folks would typically not be submitting
papers to a conference. The invitation will be made by the technical
committee to the individual speakers both for paper and tutorial
sessions.

The call for papers is for the 50% submission portion of the
conference for both paper submission as well as tutorials.
We *highly discourage* submission of recycled talks.

Current topics include
- wireless
- performance analysis and improvement
- networking hardware and offload
- netfilter
- traffic control
- different networking layers (L2/3, etc)
- internet of things
- security
- additional topics can be suggested

We encourage submission of papers and tutorials. Unlike other
conferences, we are going to try and accommodate as many submissions
as possible - but please stay within the relevant topic focus and
tie to Linux networking to make it easier for the technical committee
to provide quick feedback. In order to give a talk you must be
registered. If your proposal is accepted you will not be charged
a conference fee or your conference fee will be refunded to you
when your talk gets accepted.
We will be posting more updates on how to submit in the near future.

We expect about 3-4 parallel tracks both during tutorials and main
talks. Tutorials will be on the first day and talks on subsequent days.

Why you should register
---
If you yearn for the old community tech driven conferences where
you mingle with fellow geeks (only these would be Linux networking
geeks) then this would be it. There will be no marketing flashy
openings. There will just be a pure feed of Linux networking.
netdev 0.1 will be held back to back with netconf 2015, the
by-invite Linux kernel networking workshop
(http://vger.kernel.org/netconf2015.html).
So gurus of all sorts will be there mingling and giving talks.
While there will be heavy Linux kernel influence we expect a lot
of user space presence as well.

Location:
-
Downtown Ottawa, Canada. Exact location to be announced.
www.netdev01.org

Important Dates:

November 26, 2014   Call for Papers opens
December 10, 2014   Registration opens
January 10, 2015Call for sessions deadline
January 20, 2015Conference schedule announced
February 14-17, 2015Conference days

Please register as soon as registration opens up on December 10.
Registering helps us plan properly for numbers of attendees,
ensuring venue sizes and supplies are appropriate without
wasting resources.

contact:

i...@netdev01.info


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


-- 
Cheers,
Jeff

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies


Re: [PATCH] staging: rtl8723au: Fix brace coding style issues reported by checkpatch

2014-10-28 Thread Jeff Kirsher
On Tue, 2014-10-28 at 22:01 -0400, nick wrote:
> Greg,
> That's fine, I was wondering how long Greg KH takes to get around to picking 
> this up as he is very busy with
> other kernel work.
> Cheers Nick 

I am Jeff and I was the one that responded...

> 
> On 14-10-28 09:58 PM, Jeff Kirsher wrote:
> > On Tue, 2014-10-28 at 21:49 -0400, nick wrote:
> >> Greg,
> >> Not picked up of yet. I would appreciate if this gets forwarded for me as 
> >> this may help it get picked up.
> >> Further more this issues I am were causing were not technical but not 
> >> listening and that's why I decided
> >> to state around and learn how to my patches properly.
> >> Cheers Nick  
> >>
> > 
> > I saw you updated you patch Nick, thanks.  I feel I can safely put my
> > Reviewed-by: on it.  Also, if Greg KH (staging maintainer) has not
> > picked up in the next day or so, I will submit your patch to the staging
> > tree for you.
> > 
> >>
> >> On 14-10-28 05:31 PM, Greg Donald wrote:
> >>> On Tue, Oct 28, 2014 at 2:52 PM, nick  wrote:
> >>>> I am trying to improve my code as much as possible now, I really am 
> >>>> finally understanding
> >>>> how terrible my code was before and I hope never again to make patches 
> >>>> that shitty.
> >>>
> >>> I don't think your recent progress has gone unnoticed.  Any word on
> >>> your latest patch getting picked up?  It looked good to me.
> >>>
> >>> You remind me of John Locke from Lost.  "Don't tell me what I can't do!"  
> >>> :)
> >>>
> >>>
> > 
> > 




signature.asc
Description: This is a digitally signed message part
___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies


Re: [PATCH] staging: rtl8723au: Fix brace coding style issues reported by checkpatch

2014-10-28 Thread Jeff Kirsher
On Tue, 2014-10-28 at 21:49 -0400, nick wrote:
> Greg,
> Not picked up of yet. I would appreciate if this gets forwarded for me as 
> this may help it get picked up.
> Further more this issues I am were causing were not technical but not 
> listening and that's why I decided
> to state around and learn how to my patches properly.
> Cheers Nick  
> 

I saw you updated you patch Nick, thanks.  I feel I can safely put my
Reviewed-by: on it.  Also, if Greg KH (staging maintainer) has not
picked up in the next day or so, I will submit your patch to the staging
tree for you.

> 
> On 14-10-28 05:31 PM, Greg Donald wrote:
> > On Tue, Oct 28, 2014 at 2:52 PM, nick  wrote:
> >> I am trying to improve my code as much as possible now, I really am 
> >> finally understanding
> >> how terrible my code was before and I hope never again to make patches 
> >> that shitty.
> > 
> > I don't think your recent progress has gone unnoticed.  Any word on
> > your latest patch getting picked up?  It looked good to me.
> > 
> > You remind me of John Locke from Lost.  "Don't tell me what I can't do!"  :)
> > 
> > 




signature.asc
Description: This is a digitally signed message part
___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies


Re: [PATCH] staging: rtl8723au: Fix brace coding style issues reported by checkpatch

2014-10-28 Thread Jeff Kirsher
On Sun, Oct 26, 2014 at 12:52 PM, Nicholas Krause  wrote:
> Fix all opening and closing braces issues reported by checkpatch.
> Signed-off-by: Nicholas Krause 
> ---
>  drivers/staging/rtl8723au/core/rtw_ap.c | 138 
> ++--
>  1 file changed, 43 insertions(+), 95 deletions(-)

Good job Nick, don't let the compliment go to your head now.  I am
going to be very nitpicky because of past patch problems, so with that
said, the patch description could be improve a little.  I know that
with simple changes like this, it is tough to not repeat yourself
(i.e. title is the same as the description).  Currently the title and
patch description are ok, but personally I prefer that the patch
description be more verbose and not an copy of the patch title.  So in
this case, a patch description  of:

"Fix the curley braces that do not reside on the same line because
this does not follow the kernel coding style and causes checkpatch.pl
warnings."

I am not saying you have to change it, but something to keep in mind.

>
> diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c 
> b/drivers/staging/rtl8723au/core/rtw_ap.c
> index 75ae249..3301a2c 100644
> --- a/drivers/staging/rtl8723au/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723au/core/rtw_ap.c
> @@ -231,12 +231,10 @@ void  expire_timeout_chk23a(struct rtw_adapter 
> *padapter)
> psta->expire_to--;
> }
>
> -   if (psta->expire_to <= 0)
> -   {
> +   if (psta->expire_to <= 0) {
> struct mlme_ext_priv *pmlmeext = 
> &padapter->mlmeextpriv;
>
> -   if (padapter->registrypriv.wifi_spec == 1)
> -   {
> +   if (padapter->registrypriv.wifi_spec == 1) {
> psta->expire_to = pstapriv->expire_to;
> continue;
> }
> @@ -308,15 +306,12 @@ void  expire_timeout_chk23a(struct rtw_adapter 
> *padapter)
> ret = issue_nulldata23a(padapter, psta->hwaddr, 0, 3, 
> 50);
>
> psta->keep_alive_trycnt++;
> -   if (ret == _SUCCESS)
> -   {
> +   if (ret == _SUCCESS) {
> DBG_8723A("asoc check, sta(" MAC_FMT ") is alive\n", 
> MAC_ARG(psta->hwaddr));
> psta->expire_to = pstapriv->expire_to;
> psta->keep_alive_trycnt = 0;
> continue;
> -   }
> -   else if (psta->keep_alive_trycnt <= 3)
> -   {
> +   } else if (psta->keep_alive_trycnt <= 3) {
> DBG_8723A("ack check for asoc expire, 
> keep_alive_trycnt =%d\n", psta->keep_alive_trycnt);
> psta->expire_to = 1;
> continue;
> @@ -363,8 +358,7 @@ void add_RATid23a(struct rtw_adapter *padapter, struct 
> sta_info *psta, u8 rssi_l
> return;
>
> /* b/g mode ra_bitmap */
> -   for (i = 0; i < sizeof(psta->bssrateset); i++)
> -   {
> +   for (i = 0; i < sizeof(psta->bssrateset); i++) {
> if (psta->bssrateset[i])
> tx_ra_bitmap |= 
> rtw_get_bit_value_from_ieee_value23a(psta->bssrateset[i]&0x7f);
> }
> @@ -406,8 +400,7 @@ void add_RATid23a(struct rtw_adapter *padapter, struct 
> sta_info *psta, u8 rssi_l
> raid = networktype_to_raid23a(sta_band);
> init_rate = get_highest_rate_idx23a(tx_ra_bitmap&0x0fff)&0x3f;
>
> -   if (psta->aid < NUM_STA)
> -   {
> +   if (psta->aid < NUM_STA) {
> u8 arg = 0;
>
> arg = psta->mac_id&0x1f;
> @@ -436,9 +429,7 @@ void add_RATid23a(struct rtw_adapter *padapter, struct 
> sta_info *psta, u8 rssi_l
> psta->raid = raid;
> psta->init_rate = init_rate;
>
> -   }
> -   else
> -   {
> +   } else {
> DBG_8723A("station aid %d exceed the max number\n", 
> psta->aid);
> }
>  }
> @@ -453,8 +444,7 @@ static void update_bmc_sta(struct rtw_adapter *padapter)
> struct wlan_bssid_ex *pcur_network = &pmlmepriv->cur_network.network;
> struct sta_info *psta = rtw_get_bcmc_stainfo23a(padapter);
>
> -   if (psta)
> -   {
> +   if (psta) {
> psta->aid = 0;/* default set to 0 */
> psta->mac_id = psta->aid + 1;
>
> @@ -474,8 +464,7 @@ static void update_bmc_sta(struct rtw_adapter *padapter)
> psta->bssratelen = supportRateNum;
>
> /* b/g mode ra_bitmap */
> -   for (i = 0; i < supportRateNum; i++)
> -   {
> +   for (i = 0; i < supportRateNum; i++) {
> if (psta->bssrateset[i])
> tx_ra_bitmap |= 
> rtw_get_bit_value_from_ieee_value23a(psta->bssrateset[i]&0x7f);
> }
> @@ -522,9 +511,7 @@ 

Re: [PATCH] staging: Fix checkpatch issue with brackets in rtw_ap.c

2014-10-21 Thread Jeff Kirsher
On Wed, 2014-10-22 at 01:05 -0400, nick wrote:
> Good to hear, I will try tomorrow to send it a correct patch fixing out the 
> issues like the one found 
> in this patch in the same file. I am pretty certain I known how to do a patch 
> how.
> Nick 

Take your time Nick, please do not rush it.  You have shown that when
you rush things, nothing but bad things happen.

> 
> On 14-10-22 12:50 AM, Sudip Mukherjee wrote:
> > On Tue, Oct 21, 2014 at 08:31:25PM -0700, Jeff Kirsher wrote:
> >> On Tue, Oct 21, 2014 at 10:34 AM, Nicholas Krause  
> >> wrote:
> >>> Fix checkpatch error message with opening bracket of if statement,
> >>> not being on the same line as a if statement in rtw_ap.c
> >>>
> >>> Signed-off-by: Nicholas Krause 
> >>> ---
> >>>  drivers/staging/rtl8723au/core/rtw_ap.c | 3 +--
> >>>  1 file changed, 1 insertion(+), 2 deletions(-)
> >>
> >> I will say, it does appear you finally got a patch right.  Only issue
> > i agree to that. Finally Nick has sent a patch which is not having any 
> > style error, applies properly , doesnot change the logic.
> >> I have is that you corrected only one of the many instances of the
> >> same problem in this file.
> >> If you are going to correct one instance, might as well fix them all.
> > don't you think if he tries to fix them all at one go, he will again mess 
> > up everything ?
> > 
> > thanks
> > sudip
> >>
> >>>
> >>> diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c 
> >>> b/drivers/staging/rtl8723au/core/rtw_ap.c
> >>> index 6b4092f..927b2a6 100644
> >>> --- a/drivers/staging/rtl8723au/core/rtw_ap.c
> >>> +++ b/drivers/staging/rtl8723au/core/rtw_ap.c
> >>> @@ -1567,8 +1567,7 @@ void bss_cap_update_on_sta_join23a(struct 
> >>> rtw_adapter *padapter, struct sta_info
> >>> }
> >>> }
> >>>
> >>> -   if (rtw_ht_operation_update(padapter) > 0)
> >>> -   {
> >>> +   if (rtw_ht_operation_update(padapter) > 0) {
> >>> update_beacon23a(padapter, WLAN_EID_HT_CAPABILITY, NULL, 
> >>> false);
> >>> update_beacon23a(padapter, WLAN_EID_HT_OPERATION, NULL, 
> >>> true);
> >>> }
> >>> --
> >>> 1.9.1
> >>>
> >>>
> >>> ___
> >>> Kernelnewbies mailing list
> >>> Kernelnewbies@kernelnewbies.org
> >>> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
> >>
> >>
> >>
> >> -- 
> >> Cheers,
> >> Jeff
> >>
> >> ___
> >> Kernelnewbies mailing list
> >> Kernelnewbies@kernelnewbies.org
> >> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies




signature.asc
Description: This is a digitally signed message part
___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies


Re: [PATCH] staging: Fix checkpatch issue with brackets in rtw_ap.c

2014-10-21 Thread Jeff Kirsher
On Wed, 2014-10-22 at 10:20 +0530, Sudip Mukherjee wrote:
> On Tue, Oct 21, 2014 at 08:31:25PM -0700, Jeff Kirsher wrote:
> > On Tue, Oct 21, 2014 at 10:34 AM, Nicholas Krause
>  wrote:
> > > Fix checkpatch error message with opening bracket of if statement,
> > > not being on the same line as a if statement in rtw_ap.c
> > >
> > > Signed-off-by: Nicholas Krause 
> > > ---
> > >  drivers/staging/rtl8723au/core/rtw_ap.c | 3 +--
> > >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > I will say, it does appear you finally got a patch right.  Only
> issue
> i agree to that. Finally Nick has sent a patch which is not having any
> style error, applies properly , doesnot change the logic.
> > I have is that you corrected only one of the many instances of the
> > same problem in this file.
> > If you are going to correct one instance, might as well fix them
> all.
> don't you think if he tries to fix them all at one go, he will again
> mess up everything ?

Possibly...  trust me, I am not jumping on the pro-nick band wagon here.
After many months of failed attempts, I am not holding my breath.


signature.asc
Description: This is a digitally signed message part
___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies


Re: [PATCH] staging: Fix checkpatch issue with brackets in rtw_ap.c

2014-10-21 Thread Jeff Kirsher
On Tue, Oct 21, 2014 at 10:34 AM, Nicholas Krause  wrote:
> Fix checkpatch error message with opening bracket of if statement,
> not being on the same line as a if statement in rtw_ap.c
>
> Signed-off-by: Nicholas Krause 
> ---
>  drivers/staging/rtl8723au/core/rtw_ap.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

I will say, it does appear you finally got a patch right.  Only issue
I have is that you corrected only one of the many instances of the
same problem in this file.
If you are going to correct one instance, might as well fix them all.

>
> diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c 
> b/drivers/staging/rtl8723au/core/rtw_ap.c
> index 6b4092f..927b2a6 100644
> --- a/drivers/staging/rtl8723au/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723au/core/rtw_ap.c
> @@ -1567,8 +1567,7 @@ void bss_cap_update_on_sta_join23a(struct rtw_adapter 
> *padapter, struct sta_info
> }
> }
>
> -   if (rtw_ht_operation_update(padapter) > 0)
> -   {
> +   if (rtw_ht_operation_update(padapter) > 0) {
> update_beacon23a(padapter, WLAN_EID_HT_CAPABILITY, NULL, 
> false);
> update_beacon23a(padapter, WLAN_EID_HT_OPERATION, NULL, true);
> }
> --
> 1.9.1
>
>
> ___
> Kernelnewbies mailing list
> Kernelnewbies@kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies



-- 
Cheers,
Jeff

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies


Re: Share the project directory or a patch?

2014-10-16 Thread Jeff Kirsher
On Wed, Oct 15, 2014 at 6:37 PM, Freeman Zhang
 wrote:
> Hi list,
>
> I'm building a kernel module (a stackable file system) with some
> userspace tools, and I'd like to share them. I don't know if I should
> share it in the form of patch or just as a pack of source codes. Under
> which circumstances do I need to make a patch?
>

Patch(es) please, I know I am very wary of attachments in emails from
developers I do not know.

You can also provide URLs to git trees or locations where you have the
userspace tools publicly posted.  If patches and userspace tools are
fairly large, it may be worth setting up a git tree on github (which
is free) and post a link to your source on github.  That may be the
easiest for large projects.

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies


Re: Build Error in Linux-next, intel ethernet driver

2014-08-15 Thread Jeff Kirsher
On Tue, 2014-08-05 at 19:37 -0300, Lucas Tanure wrote:
> Thanks for reviewing my patch. My .config was bigger than 40k ( max
> attachment size for kernelnewbies list).

First thing I noticed was that your config was missing CONFIG_I40E_DCB=y
option.  So it appears that some of the recent FCoE code that was added
to the i40e driver needs to be wrapped with #ifdef CONFIG_I40E_DCB.

Can you provide the error that you are receiving, without your patch
applied?  That will help me narrow down what code needs to be wrapped.


signature.asc
Description: This is a digitally signed message part
___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies


Re: [PATCH] drivers: net: ethernet: intel: i40e: Fix missing uapi/linux/dcbnl.h include in i40e_fcoe.c

2014-08-15 Thread Jeff Kirsher
On Tue, 2014-08-05 at 10:11 -0300, Lucas Tanure wrote:
> Fix missing include in intel i40e driver. Without this include linux
> next
> tree won't compile.
> 
> Signed-off-by: Lucas Tanure 
> ---
>  drivers/net/ethernet/intel/i40e/i40e_fcoe.c | 1 +
>  1 file changed, 1 insertion(+)

Interesting that linux-next does not compile, yet Dave's net-next tree
does and that is with allmodconfig.  Anyway, I will add your patch to my
queue, thanks Lucas.


signature.asc
Description: This is a digitally signed message part
___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies


Re: Build Error in Linux-next, intel ethernet driver

2014-08-05 Thread Jeff Kirsher
On Tue, Aug 5, 2014 at 9:25 AM, Lucas Tanure  wrote:
> I updated my clean untouched linux-next tree, and tried to compile
> with the attached .config.

Your .config got stripped from the mail, can you please send me your .config.

> But I got a build error with intel i40e driver.
>
> I tested a fix, and sent to LKML. But I don't have this device, I
> compiled and tested the kernel.
> Boots normally.
>
> Anyone had the same issue ?

I have not been testing linux-next, but I do test David Miller's
net-next and net tree's which compile just fine with allmodconfig.  In
the short term, I have added your patch to my queue so that our
validation team can take a look at the issue.  Please send me your
.config so that we can reproduce your issue to ensure that your patch
is the best solution for this issue.

>
> Thanks
> Lucas Tanure
>
>
> Fix missing include in intel i40e driver. Without this include linux next
> tree won't compile.
>
> Signed-off-by: Lucas Tanure 
> ---
>  drivers/net/ethernet/intel/i40e/i40e_fcoe.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_fcoe.c
> b/drivers/net/ethernet/intel/i40e/i40e_fcoe.c
> index 6938fc1..5d01db1 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_fcoe.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_fcoe.c
> @@ -33,6 +33,7 @@
>  #include 
>  #include 
>  #include 
> +#include 
>
>  #include "i40e.h"
>  #include "i40e_fcoe.h"
> --

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies


Re: Are Small Changes in kernel accepted as patches

2014-06-21 Thread Jeff Kirsher
On Sat, Jun 21, 2014 at 2:37 AM, karthik  wrote:
> Hey There,
> I was just going through the linux-next source and found a small change
> in one of the files. (Unnecessary else)
> Now should I make this a patch and submit it or is it too small to submit?
> Regards
> Karthik Nayak
>

Any patch can never be "to small", in fact small changes/patches are
preferred over large changes/patches.

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies


Re: [PATCH RFC] Remove useless return variables

2014-05-23 Thread Jeff Kirsher
On Sun, May 18, 2014 at 5:14 AM, Peter Senna Tschudin
 wrote:
> Added CC: triv...@vger.kernel.org
>
> On Sun, May 18, 2014 at 7:04 AM, Andi Kleen  wrote:
>> Peter Senna Tschudin  writes:
>>
>>> This patch remove variables that are initialized with a constant,
>>> are never updated, and are only used as parameter of return.
>>> Return the constant instead of using a variable.
>>
>> This ret variable pattern is pretty standard in Linux, as it makes it
>> easier to add new code that may trigger new errors
>> (using the usual "goto forest" error handling pattern)
> The average age in days of the return statements my patch changes is
> 1384, which is more than 3 years, so, in average, the plan of adding
> new code was lost...
> See: http://pastebin.com/2k13sHU2
>
>>
>> I don't see any benefit in whole-sale removing it. The compiler
>> doesn't care about it and will generate the same code in any
>> case.
> My goal is to make the code cleaner and easier to understand.
>
> Should I split this into a lot of patches?
>
>>
>> -Andi
>>
>> --
>> a...@linux.intel.com -- Speaking for myself only
>
>
>
> --
> Peter

NAK on the drivers/net/ethernet/intel/i40e/i40e_dcb.c change because I
have patches currently in my queue that make the return variable
necessary.

-- 
Cheers,
Jeff

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies


Re: error : insmod

2013-02-11 Thread Jeff Kirsher
On 02/11/2013 01:54 AM, sunil wrote:
> hi all,
> while inserting module to the linux kernel, m facing this problem
> ---ERROR-
>
> sunil@ubuntu:~/test/drive$ insmod helloworld.ko
> insmod: error inserting 'helloworld.ko': -1 Operation not permitted
>
> sunil@ubuntu:~/test/drive$ sudo modprobe helloworld
> FATAL: Module helloworld not found.
>
It is a path issue, you need to specify the entire path to helloworld.ko.

For example:

sudo insmod /path/to/your/helloworld.ko



signature.asc
Description: OpenPGP digital signature
___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies


Re: Question regarding patches

2012-12-20 Thread Jeff Kirsher
On 12/19/2012 12:47 AM, Shraddha Kamat wrote:
> Sorry if this is not relevant to kernel. But since I am 
> patching the kernel - Please consider this as a uber beginner
> question to ask on this mailing list - forgive me for that.
>
> Now my question is - 
>
> What "@@ -321,7 +321,8 @@" mean in this snippet from the patch -  

The first number -321 means the line number of the original file that
the change takes place.  The next number & means that before the change,
there were 7 lines of code.  The next number +321 is the line number
after the change.  Since this is the first (and only change) it is the
same as the first number.  If there multiple changes in a patch, this
number can differ greatly from the first number.  The last number is the
lines of code after the change.
>
> diff --git a/exec.h b/exec.h
> index 722c620..6abb687 100644
> --- a/exec.h
> +++ b/exec.h
> @@ -321,7 +321,8 @@ static void acct_arg_size(struct linux_binprm *bprm,
> unsigned long pages);
>
> -- Shraddha 
>
>
>
> ___
> Kernelnewbies mailing list
> Kernelnewbies@kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies




signature.asc
Description: OpenPGP digital signature
___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies


Re: kernel version incorporating a particular feature

2011-10-12 Thread Jeff Kirsher
On 10/12/2011 05:12 AM, amit mehta wrote:
> On Wed, Oct 12, 2011 at 4:46 PM, Jeff Kirsher  wrote:
>> On 10/12/2011 02:17 AM, amit mehta wrote:
>>> On Wed, Oct 12, 2011 at 2:20 PM, rohan puri  wrote:
>>>> On Wed, Oct 12, 2011 at 2:14 PM, amit mehta  wrote:
>>>>> How do i find the linux kernel version from which a certain
>>>>> feature was first incorporated. For example , How do i find the
>>>>> first kernel version which had support for
>>>>> GRO (generic receive offload) ?
>>>>>
>>>>> Thanks,
>>>>> Amit
>>>>>
>>>>> ___
>>>>> Kernelnewbies mailing list
>>>>> Kernelnewbies@kernelnewbies.org
>>>>> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
>>>> Hi Amit,
>>>>
>>>> Kernel version is 2.6.29 refer http://lwn.net/Articles/358910/
>>>>
>>>> Regards,
>>>> Rohan Puri
>>>>
>>> Thanks Rohan, But still there should be some information in a changelog
>>> for each kernel release somewhere. Currently looking for such information
>>> in Linus's tree(https://github.com/torvalds/linux/tree/),
>>> but it seems like getting such kind of information is quite engaging.
>>>
>>> - Amit
>>>
>> You can always use a LXR to find when a feature was first incorporated.
>> Here is a link to just one of the several LXR available:
>> http://lxr.free-electrons.com/
>>
> You mean to say browse the code, no changelog or something ?
>
> -Amit
>
>

Well I was not thinking of browsing the code, because that would take a
long time.  But I was thinking of an identifier search which is much
faster and you can cover several kernel versions in a lot less time than
it would take to read a changelog of every release looking for a
feature.



signature.asc
Description: OpenPGP digital signature
___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies


Re: kernel version incorporating a particular feature

2011-10-12 Thread Jeff Kirsher
On 10/12/2011 02:17 AM, amit mehta wrote:
> On Wed, Oct 12, 2011 at 2:20 PM, rohan puri  wrote:
>>
>> On Wed, Oct 12, 2011 at 2:14 PM, amit mehta  wrote:
>>> How do i find the linux kernel version from which a certain
>>> feature was first incorporated. For example , How do i find the
>>> first kernel version which had support for
>>> GRO (generic receive offload) ?
>>>
>>> Thanks,
>>> Amit
>>>
>>> ___
>>> Kernelnewbies mailing list
>>> Kernelnewbies@kernelnewbies.org
>>> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
>> Hi Amit,
>>
>> Kernel version is 2.6.29 refer http://lwn.net/Articles/358910/
>>
>> Regards,
>> Rohan Puri
>>
> Thanks Rohan, But still there should be some information in a changelog
> for each kernel release somewhere. Currently looking for such information
> in Linus's tree(https://github.com/torvalds/linux/tree/),
> but it seems like getting such kind of information is quite engaging.
>
> - Amit
>
You can always use a LXR to find when a feature was first incorporated. 
Here is a link to just one of the several LXR available:
http://lxr.free-electrons.com/




signature.asc
Description: OpenPGP digital signature
___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies


Re: how to apply patches from git ?

2011-07-13 Thread Jeff Kirsher
On Wed, Jul 13, 2011 at 00:22, RKK  wrote:
>  Hi all,
>
> Sorry if this is a basic question.
> How do i take patches from e-mail?
>  for example git send mail sends patches as e-mail
>
> if someone wants to apply that patch to his branch then how do i get
> that in . patch format and then use
> patch -p1 *.patch  or is there something im missing here? thanks.
> --
> Warm Regards,
> Ravi .
>

Save the email message in mbox format and then you can use git am
/path/to/mbox/file to apply the email patch to your tree.

-- 
Cheers,
Jeff

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies


Re: building a specific driver in kernel src tree

2011-05-08 Thread Jeff Kirsher
On Sun, May 8, 2011 at 23:05, sri  wrote:
> the config had it as CONFIG_E1000=y
> Does =y or =m make any difference?
>
> still not working.
>

If you have CONFIG_E1000=y, it will build the e1000 driver into the
kernel binary and not as a separate module.  If you want the e1000
driver to build as a module, you will need to have CONFIG_E1000=m.

> On Mon, May 9, 2011 at 11:32 AM, Jeff Kirsher 
> wrote:
>>
>> On Sun, May 8, 2011 at 22:49, sri  wrote:
>> > Hi,
>> >
>> > As part of learning, I have added few debug statements to the code at
>> > drivers/net/e1000/e1000_main.c (e1000_probe function).
>> > Now to compile this, am doing make -C
>> > /lib/modules/2.6.18-194.el5PAE/build
>> > M=`pwd` modules under drivers/net/e1000 dir.
>> >
>> > That is not compiling anything. But the same thing when I do in
>> > drivers/net/e1000e, it is compiling and creating e1000e.ko file.
>> >
>>
>> Check your kernel config file (which is .config) to make sure that
>> CONFIG_E1000=m
>>
>> Then you should be able to run ` make drivers/net/e1000` to build the
>> e1000 driver as a module
>>
>> > Any help on how to get e1000.ko?
>> >
>> > --Sri
>> > ___
>> > Kernelnewbies mailing list
>> > Kernelnewbies@kernelnewbies.org
>> > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
>> >
>> >
>>
>>
>>
>> --
>> Cheers,
>> Jeff
>
>
>
> --
> --
>  Krishna Mohan B
>
> ___
> Kernelnewbies mailing list
> Kernelnewbies@kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
>
>



-- 
Cheers,
Jeff

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies


Re: building a specific driver in kernel src tree

2011-05-08 Thread Jeff Kirsher
On Sun, May 8, 2011 at 22:49, sri  wrote:
> Hi,
>
> As part of learning, I have added few debug statements to the code at
> drivers/net/e1000/e1000_main.c (e1000_probe function).
> Now to compile this, am doing make -C /lib/modules/2.6.18-194.el5PAE/build
> M=`pwd` modules under drivers/net/e1000 dir.
>
> That is not compiling anything. But the same thing when I do in
> drivers/net/e1000e, it is compiling and creating e1000e.ko file.
>

Check your kernel config file (which is .config) to make sure that
CONFIG_E1000=m

Then you should be able to run ` make drivers/net/e1000` to build the
e1000 driver as a module

> Any help on how to get e1000.ko?
>
> --Sri
> ___
> Kernelnewbies mailing list
> Kernelnewbies@kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
>
>



-- 
Cheers,
Jeff

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies