Re: eudyptula challenge, stuck at task 06 - no reply for four weeks
Thanks, I'll check them out. On Sat, Nov 21, 2015, 1:34 AM Drew Fustini wrote: > yup, that advice has served me well during the challenge. > > I highly recommend Free Electrons's Embedded Linux kernel and driver > development training: > > slides: > http://free-electrons.com/doc/training/linux-kernel/linux-kernel-slides.pdf > labs: > http://free-electrons.com/doc/training/linux-kernel/linux-kernel-labs.pdf > code: > http://free-electrons.com/doc/training/linux-kernel/linux-kernel-labs.tar.xz > > cheers, > drew > > On Fri, Nov 20, 2015 at 7:57 AM, Karthik Nayak > wrote: > > Just wait you'll get it, in the meantime continue reading about Linux =) > > > > > > On Fri, Nov 20, 2015, 6:38 PM Lucas Tanure wrote: > >> > >> Hi, > >> > >> I'm waiting for task 8 since September 05: > >> " Just to provide some information, you are currently number 9 in > >> line, and the response that is next is from "05 Sep 2015 00:53:31 -0400" > >> so be aware of the potential wait time. " > >> > >> Thanks > >> > >> -- > >> Lucas Tanure > >> +55 (19) 988176559 > >> > >> On Thu, Nov 19, 2015 at 11:36 PM, Alexander Ivanov > >> wrote: > >>> > >>> Hi there, > >>> > >>> Is there anybody stuck at task 06 too? > >>> > >>> --ami > >>> > >>> ___ > >>> Kernelnewbies mailing list > >>> Kernelnewbies@kernelnewbies.org > >>> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies > >> > >> > >> ___ > >> Kernelnewbies mailing list > >> Kernelnewbies@kernelnewbies.org > >> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies > > > > -- > > > > Regards, > > Karthik > > > > > > ___ > > Kernelnewbies mailing list > > Kernelnewbies@kernelnewbies.org > > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies > > > -- Regards, Karthik ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: eudyptula challenge, stuck at task 06 - no reply for four weeks
Just wait you'll get it, in the meantime continue reading about Linux =) On Fri, Nov 20, 2015, 6:38 PM Lucas Tanure wrote: > Hi, > > I'm waiting for task 8 since September 05: > " Just to provide some information, you are currently number 9 in > line, and the response that is next is from "05 Sep 2015 00:53:31 -0400" > so be aware of the potential wait time. " > > Thanks > > -- > Lucas Tanure > +55 (19) 988176559 > > On Thu, Nov 19, 2015 at 11:36 PM, Alexander Ivanov > wrote: > >> Hi there, >> >> Is there anybody stuck at task 06 too? >> >> --ami >> >> ___ >> Kernelnewbies mailing list >> Kernelnewbies@kernelnewbies.org >> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies >> > > ___ > Kernelnewbies mailing list > Kernelnewbies@kernelnewbies.org > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies > -- Regards, Karthik ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Eudyptula challenge task 8 no reply so far
On Thu, Oct 8, 2015, 1:07 AM Vinicius Tinti wrote: On Wed, Oct 7, 2015 at 4:34 PM, Ksenija Stanojevic _ksen...@yahoo.com > wrote: > > > > On Wednesday, October 7, 2015 9:27 PM, Vinicius Tinti < viniciusti...@gmail.com> wrote: > Hi, > > Is anyone stuck on task 8 too? I have sent again my files and notice > that it is still processing September 5th. > > Could someone check? > > > I got a response for task 8 on september 5th, and i sent the task on august 14th. > But I'm still waiting for response for task 9, sent on september 13th :( The queue also has increased a lot. I wont be surprise if it is frozen. > Ksenija > -- > Simplicity is the ultimate sophistication > - Task NumberPeopleQueue Length - Finished111 20 36 12 19 15 0 18 34 22 17 8 0 16 37 0 15 19 11 14 17 7 13 3 1 12 7 0 11 52 1 10 75 0 09 61 14 08211173 07 51 2 06296 51 05899 16 04555 37 03303 5 02793 3 01 1239 24 - Should take a while -- Regards, Karthik ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Question about "Creating first patch" guide
On Thu, Sep 24, 2015 at 12:17 PM, 慕冬亮 wrote: > 2015-09-24 13:56 GMT+08:00 Karthik Nayak : >> On Thu, Sep 24, 2015 at 8:51 AM, 慕冬亮 wrote: >>> I don't know whether my procedure to generate patch is right.Share it >>> with you and you can comment it ,feed back to me! >>> >>> First, I change the document in the master branch, but don't commit to >>> master branch. Then I use "git diff" to generate the patch. >> >> Why not commit? >> A simple way to do this would be. > Why do I not commit? Because I don't this easy method to generate patch file. > I read SubmittingPatches, just to understand I can use git diff to get my > patch. > Then I don't search any advanced, good method. > This shows that I am not familiar with git. > I personally suggest having a different branch for each feature/bug you might want to work on and also committing these changes in their respective branches. Why use 'diff' when 'git format-patch' is solely meant to create patches? ;) -- Regards, Karthik Nayak ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Question about "Creating first patch" guide
On Thu, Sep 24, 2015 at 8:51 AM, 慕冬亮 wrote: > I don't know whether my procedure to generate patch is right.Share it > with you and you can comment it ,feed back to me! > > First, I change the document in the master branch, but don't commit to > master branch. Then I use "git diff" to generate the patch. Why not commit? A simple way to do this would be. 1. Make changes as per requirements 2. Commit them 3. Use `git format-patch` to generate patches. 4. Check using checkpatch 5. `Use git send-email` to mail those patches to the required list. -- Regards, Karthik Nayak ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: [PATCH 2662/2662] Staging: android: Fix 80 character length
On Fri, Sep 18, 2015 at 4:42 PM, punit vara wrote: > I have created one patch and already submitted. Now I have created > another patch for another directory . What should be the subject of > patch [Patch 2/2] or just [patch ] ??? If its different, keep it different ;) -- Regards, Karthik Nayak ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Advice on Linux Kernel Development
On Sun, Sep 13, 2015 at 11:40 PM, Mayur Patil wrote: > hi all, > > I want to ask > > if I want to get started with Linux Kernel Development then is it feasible > that > > I can do all my experiments on Virtual Machine as on Linux my Internet > dongle does > > not work, I am asking in terms of performance and efficiency. > Just curious, which dongle do you use? and what did you try? > Looking for guidance, > > Thanks ! > -- > Mayur S Patil, > > > ___ > Kernelnewbies mailing list > Kernelnewbies@kernelnewbies.org > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies > -- Regards, Karthik Nayak ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: I am new here
Hey leonardo, Go through the mailing list, for old mails on the same topic. Maybe have a look at the eudyptula challenge. Regards On Thu, Mar 12, 2015, 9:58 PM Leonardo Ariel Carreras Rodríguez < zc77...@gmail.com> wrote: > Hello! > I am new here, and I want to know how to get started, maybe with the > simplest way available. > Regards, > Leonardo > ___ > Kernelnewbies mailing list > Kernelnewbies@kernelnewbies.org > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies > ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Solving checkpatch error with lex
Thanks for your input. On Thu, Dec 18, 2014, 6:17 AM Greg KH wrote: > On Wed, Dec 17, 2014 at 04:24:15PM -0500, valdis.kletni...@vt.edu wrote: > > On Wed, 17 Dec 2014 19:10:24 +, karthik nayak said: > > > > > The only reason I didn't do that is cause the file is too large to > > > manually have a look at, even the diff tends to be very huge. > > > > [/usr/src/linux-next] grep '//' drivers/staging/rtl8192u/r8192U_dm.c | > wc -l > > 373 > > > > And why use lex when sed is up to the task? > > > > [/usr/src/linux-next] sed 's?//(.*)$?/* \1 */?' > drivers/staging/rtl8192u/r8192U_dm.c >| /tmp/z99 > > sed: -e expression #1, char 19: invalid reference \1 on `s' command's RHS > > 1 [/usr/src/linux-next] sed 's?//\(.*\)$?/* \1 */?' > drivers/staging/rtl8192u/r8192U_dm.c >| /tmp/z99 > > 0 [/usr/src/linux-next] diff -u drivers/staging/rtl8192u/r8192U_dm.c > /tmp/z99 | head -20 > > --- drivers/staging/rtl8192u/r8192U_dm.c2014-11-20 > 16:18:35.941071156 -0500 > > +++ /tmp/z992014-12-17 16:22:42.831566630 -0500 > > @@ -21,9 +21,9 @@ > > #include "r8190_rtl8256.h" > > #include "r819xU_cmdpkt.h" > > /*---Define Local > Constant---*/ > > -// > > -// Indicate different AP vendor for IOT issue. > > -// > > +/* */ > > +/* Indicate different AP vendor for IOT issue. */ > > +/* */ > > static u32 edca_setting_DL[HT_IOT_PEER_MAX] = > > { 0x5e4322, 0x5e4322, 0x5e4322, > 0x604322, 0xa44f, 0x5ea44f}; > > static u32 edca_setting_UL[HT_IOT_PEER_MAX] = > > @@ -36,11 +36,11 @@ > > > > > > /*Define global variable-- > ---*/ > > -// Debug variable ? > > 0 [/usr/src/linux-next] diff -u drivers/staging/rtl8192u/r8192U_dm.c > /tmp/z99 | wc -l > > 1960 > > What a mess, I'll gladly reject a patch that does this. > > Look at that multi-line crud. > > ick ick ick, don't run auto-formatting tools just to fix up checkpatch > issues. If that was all that is needed, I would have done that a long > time ago, that's not the goal here people... > > greg k-h > ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Solving checkpatch error with lex
On Thu, Dec 18, 2014, 12:37 AM Paul Bolle wrote: On Thu, 2014-12-18 at 00:04 +0530, karthik nayak wrote: > was trying to fix the checkpatch error of not using c99 comments in the > file > drivers/staging/rtl8192u/r8192U_dm.c > so I wrote a lex program to do so since there were way too many to do it > manually. > Could anyone have a look at my lex code and tell me if I need to change it. > I have attached the lex code. > As per my testing it works perfectly, would love a second opinion. I see no reason to review someone's lex code. I guess very few people are actually willing to do that. Why don't you just send in the diff? Or even better, the patch you intend to submit. Almost everybody here can read diffs or patches. Hope this helps, Paul Bolle Hello Paul, The only reason I didn't do that is cause the file is too large to manually have a look at, even the diff tends to be very huge. But if you think that would help, I wouldn't mind attaching the diff. Thanks Karthik ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Solving checkpatch error with lex
Hello, was trying to fix the checkpatch error of not using c99 comments in the file drivers/staging/rtl8192u/r8192U_dm.c so I wrote a lex program to do so since there were way too many to do it manually. Could anyone have a look at my lex code and tell me if I need to change it. I have attached the lex code. As per my testing it works perfectly, would love a second opinion. Thanks, Karthik %{ #include %} %% "//".* {fprintf(yyout, "/*%s*/", yytext + 2);} (.|\n) {fprintf(yyout, "%s", yytext);} %% main() { yyin = fopen("tmp.c", "r"); yyout = fopen("aaa.c", "w"); yylex(); fclose(yyin); fclose(yyout); } yywrap() { return 1; } ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: [PATCH] ATM: HE: Cleanup coding style
On Mon, Dec 15, 2014, 10:04 AM Greg KH wrote: On Mon, Dec 15, 2014 at 04:23:18AM +, karthik nayak wrote: > > On Mon, Dec 15, 2014, 7:31 AM Greg KH wrote: > > On Sun, Dec 14, 2014 at 07:36:23PM -0600, Jonathan Jin wrote: > > This patch cleans up the following coding style issues that are detected > by > > checkpatch: > > ERROR: trailing whitespace > > ERROR: open brace '{' following struct go on the same line > > Don't do multiple things in the same patch, make this at least 2 > patches. > > greg k-h > > (Sorry, replied on my phone, default was not set to reply all.) > > Wouldn't this count as one checkpatch fix patch? I mean, being the same file. Nope, you are doing two different _types_ of checkpatch fixes. So it needs to be more than one patch. Remember, you need to make it as easy as possible for a maintainer to read your patch, doing more than one thing in a patch makes it much harder, and it gives them an easy reason to reject to it. greg k-h Thank you for that ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: [PATCH] ATM: HE: Cleanup coding style
On Mon, Dec 15, 2014, 7:31 AM Greg KH wrote: On Sun, Dec 14, 2014 at 07:36:23PM -0600, Jonathan Jin wrote: > This patch cleans up the following coding style issues that are detected by > checkpatch: > ERROR: trailing whitespace > ERROR: open brace '{' following struct go on the same line Don't do multiple things in the same patch, make this at least 2 patches. greg k-h (Sorry, replied on my phone, default was not set to reply all.) Wouldn't this count as one checkpatch fix patch? I mean, being the same file. ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: [eudyptula] has anyone received a gift after completing the challenge ?
Hello, It is. Wait for a while, else send another mail. On Tue Dec 02 2014 at 1:44:04 AM Jessica Ross wrote: > Off topic, but is the Eudyptula challenge still on? I asked to join but > haven't heard anything. > > Jessica R. Ross > jessica.r.r...@gmail.com > > On Fri, Nov 28, 2014 at 3:22 AM, Denis Pithon > wrote: > >> Hi all, >> >> I have finished the challenge some month ago and wonder if somebody has >> received something from the Linux Foundation ? :-) >> Thanks >> >> Denis >> >> ___ >> Kernelnewbies mailing list >> Kernelnewbies@kernelnewbies.org >> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies >> >> > ___ > Kernelnewbies mailing list > Kernelnewbies@kernelnewbies.org > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies > ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Not getting printk output
Hello, Use the new macros such as pr_info(), pr_debug() and so on. On Sun Nov 23 2014 at 2:04:27 PM Philipp Muhoray wrote: > > Am 2014-11-23 um 06:58 schrieb Mayank: > > Hi, > > I am trying to print something to the kernel debug log level using > > printk, but while using dmesg i am not getting the output on the > > console. My /proc/sys/kernel/printk setting is 4 4 1 7. > > Please help > > > > Thanks, > > Mayank > > > > > > ___ > > Kernelnewbies mailing list > > Kernelnewbies@kernelnewbies.org > > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies > > Hello, > > Does your string end with the newline character '\n'? Otherwise your > output will not be flushed immediately (it remains in the buffer). So try > > printk(KERN_DEBUG "Hello World!\n"); > > Maybe that helps. > > br, > phil > > ___ > Kernelnewbies mailing list > Kernelnewbies@kernelnewbies.org > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies > ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Not getting printk output
Hello, What debug level are you using with printk. Regards, Karthik On Sun Nov 23 2014 at 11:38:39 AM Mayank wrote: > Hi, > I am trying to print something to the kernel debug log level using > printk, but while using dmesg i am not getting the output on the > console. My /proc/sys/kernel/printk setting is 4 4 1 7. > Please help > > Thanks, > Mayank > > > ___ > Kernelnewbies mailing list > Kernelnewbies@kernelnewbies.org > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies > ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Your editor/IDE settings for autocompletion and other easiness
Hello, I use GNU Emacs as my editor, integrated it with GNU Global for easier kernel navigation. Cheers, Karthik Nayak On Sat Nov 22 2014 at 3:39:38 PM Oussama Jabbari wrote: > On Sat, Nov 22, 2014 at 4:58 AM, Andrey Utkin > wrote: > > (I was asked to research this topic to help students. So please ignore > > this topic if all you want to say is that it is OK to code in editor > > without autocompletion and any other integration, and that there's LXR > > website. We all know that.) > > > > Dear kernel developers, > > if you have a minute, please share > > - what's your configuration for editor integration with sources tree? > > (the opposite is "just using any editor") > > - which IDE/editor handiness options except autocompletion are > > possible to obtain while developing kernel code, and which options do > > you use? > > Hi, > > I already tried kernel drivers dev with Eclipse (it was quite helpful): > https://wiki.eclipse.org/HowTo_use_the_CDT_to_navigate_Linux_kernel_source > > I also often use juste vim + cscope for searching the kernel: > make cscope > cscope -d > > > > > > If you don't use any special configuration, feel free not to reply. > > > > Thanks! > > > > -- > > Andrey Utkin > > > > ___ > > Kernelnewbies mailing list > > Kernelnewbies@kernelnewbies.org > > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies > > ___ > Kernelnewbies mailing list > Kernelnewbies@kernelnewbies.org > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies > ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Your editor/IDE settings for autocompletion and other easiness
Hello, I use GNU Emacs as my editor, integrated it with GNU Global for easier kernel navigation. Cheers, Karthik Nayak On Sat Nov 22 2014 at 3:39:38 PM Oussama Jabbari wrote: > On Sat, Nov 22, 2014 at 4:58 AM, Andrey Utkin > wrote: > > (I was asked to research this topic to help students. So please ignore > > this topic if all you want to say is that it is OK to code in editor > > without autocompletion and any other integration, and that there's LXR > > website. We all know that.) > > > > Dear kernel developers, > > if you have a minute, please share > > - what's your configuration for editor integration with sources tree? > > (the opposite is "just using any editor") > > - which IDE/editor handiness options except autocompletion are > > possible to obtain while developing kernel code, and which options do > > you use? > > Hi, > > I already tried kernel drivers dev with Eclipse (it was quite helpful): > https://wiki.eclipse.org/HowTo_use_the_CDT_to_navigate_Linux_kernel_source > > I also often use juste vim + cscope for searching the kernel: > make cscope > cscope -d > > > > > > If you don't use any special configuration, feel free not to reply. > > > > Thanks! > > > > -- > > Andrey Utkin > > > > ___ > > Kernelnewbies mailing list > > Kernelnewbies@kernelnewbies.org > > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies > > ___ > Kernelnewbies mailing list > Kernelnewbies@kernelnewbies.org > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies > ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: [Eudyptula] How long have you been waiting?
On Fri, Nov 21, 2014, 6:24 PM Sudip Mukherjee wrote: On Fri, Nov 21, 2014 at 6:16 PM, Vinícius Tinti wrote: > On Fri, Nov 21, 2014 at 4:47 AM, Sudip Mukherjee > wrote: >> i sent my task result yesterday , but lets see if i also get the reply >> from little by replying to your mail. :) >> i guess the time depends on the queue, and there has to be some human >> intervention in the reply, it can not be all script. >> >> >> On Fri, Nov 21, 2014 at 11:52 AM, karthik nayak wrote: >>> Hello, >>> As soon as Denis replied to my mail. I got my next task, cheers to >>> Eudyptula. >>> >>> >>> On Fri, Nov 21, 2014, 11:41 AM Denis Usanov wrote: >>>> >>>> Since 10.10. 6th task. >>>> Anyway I asked the status some weeks ago and eudyptula answered the >>>> queue was really long. >>>> >>>> On 21.11.2014 08:43, karthik nayak wrote: >>>> > Hello, >>>> > As patient as I am, just wondering how long have you all been waiting >>>> > for your response. >>>> > I'm waiting for quite a while now on the 8th task. >>>> > Regards, >>>> > Karthik Nayak >>> >>> >>> ___ >>> Kernelnewbies mailing list >>> Kernelnewbies@kernelnewbies.org >>> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies >>> >> >> ___ >> Kernelnewbies mailing list >> Kernelnewbies@kernelnewbies.org >> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies > > Took 5 weeks for me on Task 05 and I got it wrong. > Well it works but not the way Eudyptula wants. I liked task five, that was fun. Got it wrong a few times. task 5 is a tough one. till now in the order of toughness that is the 2nd most tough i faced . First being? > > -- > Simplicity is the ultimate sophistication ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: [Eudyptula] How long have you been waiting?
Hello, As soon as Denis replied to my mail. I got my next task, cheers to Eudyptula. On Fri, Nov 21, 2014, 11:41 AM Denis Usanov wrote: > Since 10.10. 6th task. > Anyway I asked the status some weeks ago and eudyptula answered the > queue was really long. > > On 21.11.2014 08:43, karthik nayak wrote: > > Hello, > > As patient as I am, just wondering how long have you all been waiting > > for your response. > > I'm waiting for quite a while now on the 8th task. > > Regards, > > Karthik Nayak > ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
[Eudyptula] How long have you been waiting?
Hello, As patient as I am, just wondering how long have you all been waiting for your response. I'm waiting for quite a while now on the 8th task. Regards, Karthik Nayak ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: [PATCH] staging: Fix spacing between function name and parentheses
Hey Nick, Nice try to fix a checkpatch warning. But do read what you're changing. Yes your format is right. If you haven't already, take a look at "git send-email" . Have fun hacking :D Regards, Karthik Nayak On Sat, Oct 11, 2014 at 7:47 PM, nick wrote: > Thanks Hugo, > Sorry about that. On the other hand was the patch good in terms of format? > Cheers Nick > > On 14-10-11 09:52 AM, Hugo Mills wrote: >> On Sat, Oct 11, 2014 at 09:44:05AM -0400, nick wrote: >>> Thank you for your help, I'll study the code and see what I can do >>> about it. Do you have any suggestions of how to fix this checkpatch >>> warning? >> >>Ignore it. The checker has clearly triggered on a false positive -- >> this is not a function call, and should not be held to that standard. >> (Take a look at where the macro is actually used, to see what's going >> on here). Move on to find something more interesting to fix. >> >>Hugo. >> >>> Nick >>> >>> On 14-10-11 05:53 AM, Kristofer Hallin wrote: >>>> Even if you use checkpath you _should_ understand what you are changing. >>>> The output of checkpatch merely there to help. >>>> >>>> In this case you can see that this is a macro just a few lines up in the >>>> code. >>>> On 11 Oct 2014 11:46, "Sudip Mukherjee" wrote: >>>> >>>>> I agree. But in my opinion checkpatch is here to help us fix style >>>>> problems , but we should not blindly act on checkpatch warnings. >>>>> >>>>> thanks >>>>> sudip >>>>> >>>>> On Sat, Oct 11, 2014 at 1:57 PM, Peter Senna Tschudin >>>>> wrote: >>>>>> I think that, in this case, checkpatch.pl contributed: >>>>>> >>>>>> $ ./scripts/checkpatch.pl -f drivers/staging/octeon-usb/octeon-hcd.c >>>>>> WARNING: space prohibited between function name and open parenthesis '(' >>>>>> #415: FILE: drivers/staging/octeon-usb/octeon-hcd.c:415: >>>>>> + if (c.s.field op (value)) { >>>>>\ >>>>>> >>>>>> >>>>>> On Sat, Oct 11, 2014 at 8:11 AM, Dave Tian >>>>> wrote: >>>>>>> Agreed - that is why I mentioned the patch is neither right nor useful:) >>>>>>> >>>>>>> -daveti >>>>>>> >>>>>>> >>>>>>> On Oct 11, 2014, at 2:08 PM, Sudip Mukherjee < >>>>> sudipm.mukher...@gmail.com> wrote: >>>>>>> >>>>>>>> Hi Dave, >>>>>>>> It will work. But my point of saying that was c.s.field ==(value) is >>>>>>>> again not according to the style. >>>>>>>> >>>>>>>> thanks >>>>>>>> sudip >>>>>>>> >>>>>>>> On Sat, Oct 11, 2014 at 10:53 AM, Dave Tian >>>>> wrote: >>>>>>>>> It also works as value is surrounded by (), though I do not think the >>>>> patch itself is right or useful. >>>>>>>>> >>>>>>>>> Dave Tian >>>>>>>>> dave.jing.t...@gmail.com >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> On Oct 11, 2014, at 12:58 PM, Sudip Mukherjee < >>>>> sudipm.mukher...@gmail.com> wrote: >>>>>>>>> >>>>>>>>>> On Fri, Oct 10, 2014 at 09:55:48PM -0400, Nicholas Krause wrote: >>>>>>>>>>> Fixes checkpatch coding style warning about unneeded space >>>>>>>>>>> between function name an parentheses. >>>>>>>>>>> >>>>>>>>>>> Signed-off-by: Nicholas Krause >>>>>>>>>>> --- >>>>>>>>>>> Untested >>>>>>>>>>> drivers/staging/octeon-usb/octeon-hcd.c | 2 +- >>>>>>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>>>>>>> >>>>>>>>>>> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c >>>>> b/drivers/staging/octeon-usb/octeon-hcd.c >>>>>>>>>>> index 5f9db4c..bbeb0cc 100644 >>>>>>>>>>> --- a/drivers/staging/octeon-usb/octeon-hcd.c >>>>>>>>>>> +++ b/drivers/staging/octeon-usb/octeon-hcd.c >>>>>>>>>>> @@ -412,7 +412,7 @@ struct octeon_hcd { >>>>>>>>>>> type c; >>>>> \ >>>>>>>>>>> while (1) { >>>>> \ >>>>>>>>>>> c.u32 = __cvmx_usb_read_csr32(usb, address); >>>>> \ >>>>>>>>>>> -if (c.s.field op (value)) { >>>>> \ >>>>>>>>>>> +if (c.s.field op(value)) { >>>>> \ >>>>>>>>>> >>>>>>>>>> have you read the code before modifying it? >>>>>>>>>> this is not a function. >>>>>>>>>> have you seen how CVMX_WAIT_FOR_FIELD32 is being called? >>>>>>>>>> on every call of CVMX_WAIT_FOR_FIELD32 op is the operator "==" >>>>>>>>>> so when called the macro will be c.s.field == (value). >>>>>>>>>> if your patch is applied then it will become c.s.field ==(value) .. >>>>> will that be correct ? >>>>>>>>>> >>>>>>>>>> thanks >>>>>>>>>> sudip >>>>>>>>>> >>>>>>>>>>> result = 0; >>>>> \ >>>>>>>>>>> break; >>>>> \ >>>>>>>>>>> } else if (cvmx_get_cycle() > done) { >>>>> \ >> > > ___ > Kernelnewbies mailing list > Kernelnewbies@kernelnewbies.org > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: eudyptula-challenge
Hello, Been waiting for a while, But think about the no of mails little has to go through. Its brilliant that we even have such a challenge. Cant wait for my reply :D Regards, Karthik Nayak On Fri, Oct 3, 2014 at 10:55 AM, Giedrius Statkevicius wrote: > On 2014.10.03 02:48, L. Alberto Giménez wrote: >> On Tue, Sep 23, 2014 at 02:35:04PM +0300, Giedrius Statkevicius wrote: >>> On 2014.09.23 07:26, Sudip Mukherjee wrote: >>>> hi, >>>> has anyone heard from little about their task in last 2 weeks ? i am >>>> waiting since last 2 weeks and just wondering if things have again >>>> slowed down. >>> You can always send little a message and ask about the queue times :) >> >> In my case it's been three weeks since my last submission. Two days ago I >> sent a ping >> mail and still got no reply :/ >> >> Is anyone experiencing such delays? > I have been waiting for 3 weeks+. By the way, which task are you doing? On > September 25th he replied to my "ping" e-mail: > "No idea when that will be, sorry, very long queue, just sit back and relax, > there is no rush." > I know that this service free and all but this is seriously tiring :) >> >> Regards! >> > > ___ > Kernelnewbies mailing list > Kernelnewbies@kernelnewbies.org > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Eudyptula Challenge
Got mine a few days back. Patience On Sat 12 Jul 2014 12:23:12 AM IST, Jake Mitchell wrote: > On Fri, 11 Jul 2014, Narendra Joshi wrote: > >> I am waiting for the results of my task03 submission for almost a week now. >> Has anyone been getting replies meanwhile? >> -- >> Narendra Joshi >> > > Not lately. I've been waiting for a response to my task03 submission for > 11 days. Hang in there. > > -Jake > > ___ > Kernelnewbies mailing list > Kernelnewbies@kernelnewbies.org > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: More than 9 days on task 06 Eudyptula Challenge
i just got miine yesterday :) On Fri, Jul 11, 2014 at 8:39 AM, Greg Peter wrote: > Sorry to bring up this old thread! > > Just wondering if 'little' is back from the winter vacation ? Has > anyone got responses for any task in the last 3-4 weeks ? > > On Fri, Jun 27, 2014 at 10:29 AM, Sudip Mukherjee > wrote: > > On Fri, Jun 27, 2014 at 2:59 AM, Lucas Tanure wrote: > >> Sorry to bug this again. > >> I'm waiting for task 06 more than 9 days. There are more guys with the > same > >> delay time in this task ? > >> > >> Thanks > >> > >> -- > >> Lucas Tanure > >> +55 (19) 988176559 > >> > > > > I am waiting for almost 13 days for my task 08 results ... have > > patience . little already said things are slow now ... > > > > ___ > > Kernelnewbies mailing list > > Kernelnewbies@kernelnewbies.org > > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies > > ___ > Kernelnewbies mailing list > Kernelnewbies@kernelnewbies.org > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies > ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Eudyptula Challenge How To Prepare
Read The LInux Device Drivers Book :) On Sat, Jun 28, 2014 at 10:57 AM, me storage wrote: > Hi > I have been waiting for my Task 04 Result from last 3 days .I know so many > people are waiting more than this.So can one please tell me How to prepare > for the next Task i.e what are the concepts necessary topics for Task 05? > Thanks > > ___ > Kernelnewbies mailing list > Kernelnewbies@kernelnewbies.org > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies > > ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: TASK05
Hello, Even i found it difficult at first, read online , search a bit. it's better when you do it yourself :D Regards, Karthik On Fri, Jun 20, 2014 at 5:32 PM, Akam wrote: > Hello, > > I am stuck on Task05. Can you help me with more pointers for this task ? > So I can read and understand and write my own code. > > I am sorry, I am lazy. I tried following LDD chapter mentioned but I am > not able to get it into the code, so as to get it working. Either I am not > trying hard enough or I am not understanding it as I am lacking some basics > to get right clarity from reading chapter 14 of LDD. > > Can somebody give a push to my stuck threads so I get it right? > > Thanks in advance. Sorry if I sound vague. > > -- > cheers > Akam > > ___ > Kernelnewbies mailing list > Kernelnewbies@kernelnewbies.org > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies > > ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Kernel Kconfig doubt..
One the lines of what Arun suggested, try using `make menuconfig` Regards, Karthik Nayak On Tue, Jun 17, 2014 at 7:59 PM, AYAN KUMAR HALDER wrote: > On Tue, Jun 17, 2014 at 4:32 PM, Sudip Mukherjee > wrote: > > On Tue, Jun 17, 2014 at 3:21 PM, siva sangeetha > > wrote: > >> Hi, > >> > >> I am facing one config issue in kernel building. I have added new > define in > >> my board def config, i added the config in Kconfig also but it is not > taking > >> and my expected part of define based code not building. Can anyone tel > me > >> what i am missing. > > > Do you see your newly added configuration in the automatically > generated file "include/config/auto.conf" > > Regards, > Ayan Kumar Halder > > ___ > Kernelnewbies mailing list > Kernelnewbies@kernelnewbies.org > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies > ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: What happen when a hardware is connected to Linux kernel
it is indeed , i was just reading the same :P On Mon, May 19, 2014 at 1:22 PM, Sudip Mukherjee wrote: > > On Mon, May 19, 2014 at 9:44 AM, Saurabh Jain > wrote: >> >> Hello everyone ! >> >> Can anybody tell me the sequence of common events when a hardware (Lets >> say USB stick/ keyboard) is connected to a machine running Linux kernel ? > > > Why am I having the feeling that this question is similar to Task 05 of the > Eudyptula Challenge ??? > > >> >> Actually i am new to this Device Driver field and i want to know what >> happen in common when a device is connected to a machine running Linux >> Kernel. Any link or source will be helpful . >> >> ___ >> Kernelnewbies mailing list >> Kernelnewbies@kernelnewbies.org >> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies >> > > > ___ > Kernelnewbies mailing list > Kernelnewbies@kernelnewbies.org > http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies > ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies