Re: dumping large buffers to file

[Nick Krause]

On Tue, Nov 24, 2015 at 1:30 AM, Ramon Fried  wrote:
> Hi.
>
> I'm currently debugging a ISP DMA issue in a kernel module.
>
> For debugging, I would like to dump buffers to a file on run time.
>
> The buffers are quite big, 1MB at least.
>
> As saving a file directly from kernel is discouraged, is there any available
> framework for doing such a thing ?
>
> I can think of numerous ways of transferring the buffer to user space and
> saving it by a dedicated user process (Netlink, sysfs, char device, etc.)
>

>
> I just don't want to invent the wheel. How do you do it ?
>
>
>
> Thanks.
>
> Ramon
>
>
> ___
> Kernelnewbies mailing list
> Kernelnewbies@kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
>
If you can use printk just switch the log level to a log level that
prints to the syslog buffer
for kernel messages. If you have enough space on your partition for
root this shouldn't
be a problem, however if it is them I would recommend sysfs or procfs
exporting as
there better suited for debugging as the others are for user space
applications needing
access to kernel resources indirectly  or device driver user space interaction.
Hope this Helps,
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: xtime variable in kernel 4.0

[Nick Krause]

On Tue, Apr 14, 2015 at 9:20 AM, Greg KH g...@kroah.com wrote:
 On Tue, Apr 14, 2015 at 08:47:08AM -0400, Mohammad A Khasawneh wrote:
 Hi everyone,

 I'm trying to develop a syscall in kernel v4.0 which copies the xtime 
 variable
 to user space. I can find the variable in 3.X but it seems to have been 
 changed
 in 4.0. Can anyone point me to its location?

 git is your friend, it shouldn't be hard to find where it went to, just
 look at all commits that changed between the version you find it, and
 the new one, and run 'git log path/filename.c'

 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
I am wondering why you need to return the wall clock time to user
space. This seems unnecessary to me unless you can find some
applications
that need the wall clock time in order to function correctly.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Get local CPU id

[Nick Krause]

On Mon, Mar 9, 2015 at 12:26 PM, Jeff Haran jeff.ha...@citrix.com wrote:
 -Original Message-
 From: kernelnewbies-boun...@kernelnewbies.org 
 [mailto:kernelnewbies-boun...@kernelnewbies.org] On Behalf Of Matwey V. 
 Kornilov
 Sent: Monday, March 09, 2015 8:35 AM
 To: kernelnewbies@kernelnewbies.org
 Subject: Re: Get local CPU id


 Many thanks for all answers. smp_processor_id() works just fine in interrupt 
 context.

 Unfortunately /proc/interrupts is not what I was looking for. My idea was to 
 print a line to dmesg at every interrupt to have a timestamp like the 
 following:

 [  926.440799] Enter intr at 0
 [  926.441059] Exit intr at 0

 Every interrupt? You might want to spend some time thinking about which 
 interrupts you don't want to do the above printing for.

 Jeff Haran


 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Jeff,
He can just limit the dmesg output by using console_limit I believe.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Remove Ban?

[Nick Krause]

On Mon, Dec 8, 2014 at 10:32 AM,  valdis.kletni...@vt.edu wrote:
 On Sun, 07 Dec 2014 22:15:13 -0500, nick said:
 Greetings Fellow Developers,
 I have finally learned my lesson as you can tell from my newest patches being
 accepted or considered in good form.

 Right now,all I'm seeing in linux-next from you is 2 patches that
 remove FIXME comments.  Given your previous history of submitting
 patches that failed to accurately analyze C program flow, And the
 commit message on one of them:

 Remove FIXME comments about needing fault addresses to be returned.  These
 are propaagated from walk_addr_generic to gva_to_gpa and from there to
 ops-read_std and ops-write_std.

 doesn't actually address the question of how to deal with fault addresses.
 Yes, they're propagated back - but it doesn't directly address the question
 of how a fault address is handled (in other words, you failed to show that
 write_std actually does the right thing once it gets whatever we send back)

 I wouldn't hold my breath
I submitted the patch. The maintainer changed the commit message not me.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Advantages in Scalability of Softriqs versus Tasklets

[Nick Krause]

I am curious about reading through LKD, when to start using softriqs
other tasklets in terms of
when the limit of scalability of tasklets are hit. I am assuming after
reading LKD it seems to
happen when multiple cores  would be of great advantage in scaling the
bottom half of my or
our people's code. In addition in seems to also happen when timing of
interrupts needs to
be in the range of under milliseconds to process the bottom half and
this seems very important
for the networking subsystem.
Cheers and Thanks for Any Answers,
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re Start Fresh

[Nick Krause]

I am willing to start out completely fresh and willing to learn how to
do this correctly now and hopefully improve my rep ... slowly.
This is not another  email for me trying to state again I am willing
to change, I really would like to help me out and am not sure where
to start in order to improve my rep.
Cheers Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: [PATCH] staging: rtl8723au: Fix brace coding style issues reported by checkpatch

[Nick Krause]

On Tue, Oct 28, 2014 at 1:39 PM, Greg Donald gdon...@gmail.com wrote:
 On Tue, Oct 28, 2014 at 11:50 AM, Greg Freemyer greg.freem...@gmail.com 
 wrote:
 Lots of violations
 checkpatch finds are intentionally left in place because correcting
 them makes the code less readable, not more readable.

 Yeah, but there are still hundreds of thousands of checkpatch
 violations throughout the kernel that if fixed would actually improve
 readability.

 PathErrors  Warnings
 drivers 200979  361350
 arch98791   142300
 sound   25938   31028
 include 13651   25598
 fs  96353   22483
 net 318519216
 lib 80556578
 tools   11263972
 kernel  656 3203
 security47  1247
 mm  203 1186
 scripts 824 1168
 crypto  11441095
 block   196 656
 Documentation   97  259
 init29  173
 virt18  152
 samples 27  118
 ipc 2   77
 usr 17  20
 firmware11  19

 The WARNING line over 80 characters currently accounts for 216K of
 the total violations.  IMHO checkpatch should just stop complaining
 about the 80 char limit since that's the main offender causing new
 kernel developers to inadvertently lessen readability with their first
 patch.  If the 80 char warning should be mostly ignored why have it..
 it's pointless.  Increase it to a 21st century value or kill it.


 --
 Greg Donald
I actually fixed this to improve code readability not for the kernel
rules for your information.
Cheers Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Banned Again

[Nick Krause]

I am getting very annoyed , that I am banned again from my other email
at yoc...@gmail.com are people trying to just prevent me from
being on the list. Is that your goal now?
Cheers Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: A quick guide to why stand-alone checkpatch patches suck...

[Nick Krause]

 Because in general we don't use asserts in the kernel. I'm sure I've used 
 10,000s of asserts in user space over the decades.  Zero in the kernel.

 Specifically, in user space when writing code we can put asserts throughout 
 the code that will cause an immediate code explosion if unexpected things 
 happen.  In the kernel, the better choice is printing an error message then 
 have the code do it's best to handle it.

 That still begs the question of why it happened in the first place.  As long 
 as the event itself us unexpected (ie. not routine) then the error message 
 should remain.  Re-read the sample commit message I wrote.  The first thing I 
 said is the condition is well understood.  Never remove an error message 
 unless you can explain with clarity why the error is happening.   Obviously 
 in that case you should be replacing the error message with a comment that 
 explains the condition.

 Greg
 --
 Sent from my Android phone with K-9 Mail. Please excuse my brevity.
Thanks Greg,
I will look into in more carefully later. In addition thanks to all
the others for the patience and help. I understand that
this is not normal in the kernel community and would like to really
thank everyone for the patience and support. I
want to help out and as I am finding out the coding is not the issue
it's my issues with the community which I hope
we can fix in order for me to help the kernel community. In addition I
do find the kernel interesting and really like
working with it, just having issues with understanding how to write patches.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: A quick guide to why stand-alone checkpatch patches suck...

[Nick Krause]

On Wed, Sep 17, 2014 at 10:39 AM,  valdis.kletni...@vt.edu wrote:
 On Wed, 17 Sep 2014 08:02:01 -0400, nick said:
 it off , if not I would like to known exactly where I am wrong so I can 
 learn.

 Somebody wake me up when he actually *means* that.

Valdis,
I understand that was what he stated I was looking into how to write a
correct patch not remove needed error messages.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Issues with Community

[Nick Krause]

On Wed, Sep 17, 2014 at 9:13 AM, Rik van Riel r...@surriel.com wrote:
 -BEGIN PGP SIGNED MESSAGE-
 Hash: SHA1

 On 09/16/2014 07:22 PM, nick wrote:
 After numerous tries at good patches and still failing , I am
 listening to what you guys stated about my patches check it
 applies, grammar and build checks. I am still unable to get a good
 patch and would really appreciate it if someone walks me through
 one good patch as I will learn this will a tutor and the tutor can
 help be my router to the community

 There are a lot of useful things to do in the Linux kernel community
 besides writing patches.

 One of the useful things you could do is simply run linux-next on your
 system, and update whenever new linux-next code comes out. If it breaks
 (which it sometimes does), you can write a bug report, and learn from
 the resulting email thread what caused the problem.

 Debugging is a much better way to learn development than developing
 new patches from scratch just because...

 - --
 All rights reversed.
 -BEGIN PGP SIGNATURE-
 Version: GnuPG v1

 iQEcBAEBAgAGBQJUGYkCAAoJEM553pKExN6D6ikH/A2iC8wOm1Xa0rpna+i9cCyu
 d3tZof+EbMLezsQjNDXHwJgm7bjsKHT55WT68snliugFueWfkX7c8S48wV2bNso6
 iwObDGCt3iXnuNqWrZ4cjJg4Lk3vOWvs3D1FkCEBlhM8lafJZdaaQfXNVLkOAZyt
 sg9rypTTeV8e1udp/O2UTNP9jwEasLqU3aGXj5AuTUGI77NiquUDn1fwlTwcregr
 nkwv5iCoJuBifm8+GcHHReBzhWX/Ab4d8H+wNGsTHqhlDR3iNyaodMvlHLZcayry
 gkZf3+VcZjR9XClBY5yLeNHmRcYeKFm80XeybF3Ih+zxluB5H2jEOKIp9/MbY88=
 =S6vR
 -END PGP SIGNATURE-

 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Sure I will look into linux-next issues later today.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: A quick guide to why stand-alone checkpatch patches suck...

[Nick Krause]

On Wed, Sep 17, 2014 at 1:13 PM, Bruno Guedes Souto
brunogue...@gmail.com wrote:
 This was a great discussion, until you guys started feeding the troll again.

 Can we just stop feeding the troll? He will prob go way...

 If every *single* time that Nick posts something you reply to him it will only
 lead to more replies from him saying he will get better, understand what he is
 doing and that he wants to improve his rep with the community. That's his
 standard speech.

 BGS


 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Can I stop being called a troll. I am trying to learn here and improve
my rep and understanding of
the kernel. I would like to help but with this negative light around
me it is much more difficult and
hard to do. I understand the problems I have caused now and would like
to improve my rep with
a tutor or someone who is willing to be my router to the community
until I improve enough to a
member of the community on my own.
Thanks Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: A quick guide to why stand-alone checkpatch patches suck...

[Nick Krause]

e stranger on the internet is going to be your
tutor? Unless you belong to some minority, you shouldn't be waiting for
a tutor to take your hand and guide you... that's probably not going to
happen. Apply the advice that's been already given to you, e.g. read the
old mails and write each advice down. Until that, *please* lurk moar.

On Wed, Sep 17, 2014 at 2:01 PM, Philipp Muhoray
philipp.muho...@gmail.com wrote:

 Am 2014-09-17 19:47, schrieb Nick Krause:
 On Wed, Sep 17, 2014 at 1:13 PM, Bruno Guedes Souto
 brunogue...@gmail.com wrote:
 This was a great discussion, until you guys started feeding the troll again.

 Can we just stop feeding the troll? He will prob go way...

 If every *single* time that Nick posts something you reply to him it will 
 only
 lead to more replies from him saying he will get better, understand what he 
 is
 doing and that he wants to improve his rep with the community. That's his
 standard speech.

 BGS


 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbe stranger on the 
 internet is going to be your
tutor? Unless you belong to some minority, you shouldn't be waiting for
a tutor to take your hand and guide you... that's probably not going to
happen. Apply the advice that's been already given to you, e.g. read the
old mails and write each advice down. Until that, *please* lurk moar.
ies
 Can I stop being called a troll. I am trying to learn here and improve
 my rep and understanding of
 the kernel. I would like to help but with this negative light around
 me it is much more difficult and
 hard to do. I understand the problems I have caused now and would like
 to improve my rep with
 a tutor or someone who is willing to be my router to the community
 until I improve enough to a
 member of the community on my own.
 Thanks Nick

 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
 Why do you think that some stranger on the internet is going to be your
 tutor? Unless you belong to some minority, you shouldn't be waiting for
 a tutor to take your hand and guide you... that's probably not going to
 happen. Apply the advice that's been already given to you, e.g. read the
 old mails and write each advice down. Until that, *please* lurk moar.

 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
That's what I plan to do now and ask many questions.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: A quick guide to why stand-alone checkpatch patches suck...

[Nick Krause]

On Wed, Sep 17, 2014 at 2:15 PM, Robert P. J. Day rpj...@crashcourse.ca wrote:
 On Wed, 17 Sep 2014, Nick Krause wrote:

 ... like to improve my rep with a tutor or someone who is willing to
 be my router to the community  ...

   there is no sane human being that would offer to be a tutor or
 mentor (a request you've made before) or router to someone who
 absolutely refuses to listen to the advice people give him.

   you have absolutely no idea what mentoring involves, do you, nick?
 people offer to become mentors because they find up and coming folks
 who appear to be bright, ambitious and teachable, not irredeemably
 thick.

   this *entire* *mailing* *list* has been trying to tutor or mentor
 you for the last two months, and it has been a colossal waste of time.
 where do you get the nerve to now ask for *personal* assistance, given
 that everyone knows you simply ignore whatever anyone tells you?

   can we please, fer chrissake, just vote on a ban to get rid of nick
 and cut the nonsense on this mailing list by 90%? please?

 rday

 --

 
 Robert P. J. Day Ottawa, Ontario, CANADA
 http://crashcourse.ca

 Twitter:   http://twitter.com/rpjday
 LinkedIn:   http://ca.linkedin.com/in/rpjday
 

I am leaving for now and going to learn more about the kernel and come
back with some questions later.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Checkpatch Patches

[Nick Krause]

On Tue, Sep 16, 2014 at 10:19 AM,  valdis.kletni...@vt.edu wrote:
 On Tue, 16 Sep 2014 08:44:27 -0400, nick said:

 I am attaching two check patch patches I wrote in the last few days as I am 
 unable to get a reply
 from the maintainers. Would someone please send them off for me.

 I am attaching.  Fail 3 words in.

 That's why you aren't getting a reply from the maintainers. They don't bother
 reading patches they know will probably *never* be correct.

 And yes, at least one of the two patches is incorrect.

 Thanks for the Help, I really do appreciate it and I do understand how much 
 I have screwed up. My concern now is
 now to make it right.

 You don't make it right by posting more wrong patches. Now do us
 all a favor and *stop* being either an idiot, or a troll, or whatever
 your problem is.  We have *zero* desire to see *any* more patches from
 somebody who is either unable or unwilling to post a *single* correct
 patch after *two months* of trying.

 So please do us a favor and go piss off some other open source project.

 THE KERNEL DOES NOT WANT YOUR BULLSHIT.



I am going to attach it again and I understand Valdis. I am going to
talk to Sudip about reading and checking
my patches first.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Checkpatch Patches

[Nick Krause]

On Tue, Sep 16, 2014 at 12:57 PM, Sudip Mukherjee
sudipm.mukher...@gmail.com wrote:
 On 9/16/14, Nick Krause xerofo...@gmail.com wrote:
 On Tue, Sep 16, 2014 at 10:19 AM,  valdis.kletni...@vt.edu wrote:
 On Tue, 16 Sep 2014 08:44:27 -0400, nick said:

 I am attaching two check patch patches I wrote in the last few days as I
 am unable to get a reply
 from the maintainers. Would someone please send them off for me.

 I am attaching.  Fail 3 words in.

 That's why you aren't getting a reply from the maintainers. They don't
 bother
 reading patches they know will probably *never* be correct.

 And yes, at least one of the two patches is incorrect.

 Thanks for the Help, I really do appreciate it and I do understand how
 much I have screwed up. My concern now is
 now to make it right.

 You don't make it right by posting more wrong patches. Now do us
 all a favor and *stop* being either an idiot, or a troll, or whatever
 your problem is.  We have *zero* desire to see *any* more patches from
 somebody who is either unable or unwilling to post a *single* correct
 patch after *two months* of trying.

 So please do us a favor and go piss off some other open source project.

 THE KERNEL DOES NOT WANT YOUR BULLSHIT.



 I am going to attach it again and I understand Valdis. I am going to
 talk to Sudip about reading and checking
 my patches first.
 Nick


 plzzz .. NO ...
 today i checked your patches just to take a break from what i was doing..
 and besides , i am also a newbie , i also make mistakes when
 submitting patches, but i try to learn from my mistakes and see to it
 that they are never repeated.
 apart from the numerous advises you got from the LKML , i think just
 yesterday Robert P. J. Day has pointed out something, day before
 yesterday Valdis , before that ( sorry i lost track)  ... and you have
 not cared to listen to any of that ..



 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

I am going to resend my patch and see if it's good and if not I am
going to leave for a while.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Checkpatch Patches

[Nick Krause]

On Tue, Sep 16, 2014 at 1:39 PM,  valdis.kletni...@vt.edu wrote:
 On Tue, 16 Sep 2014 13:28:06 -0400, Rik van Riel said:
 -BEGIN PGP SIGNED MESSAGE-

 On 09/16/2014 01:12 PM, Nick Krause wrote:

  I am going to resend my patch and see if it's good and if not I am
  going to leave for a while.

 You may want to consider fixing them, by applying the advice
 provided by many people, before resending them.

 That's just crazy talk.

 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

I am fixing them first and them sending them out. I am going to listen now and
only do them correctly.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Improve my Rep

[Nick Krause]

After issues with the community I am wondering how to improve my rep
and help out more.
I will start out with check patch but if there is other work please
let me known :).

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Improve my Rep

[Nick Krause]

On Mon, Sep 15, 2014 at 11:16 AM, Anuz Pratap Singh Tomar
chambilketha...@gmail.com wrote:


 On Mon, Sep 15, 2014 at 3:38 PM, Nick Krause xerofo...@gmail.com wrote:

 After issues with the community I am wondering how to improve my rep
 and help out more.
 I will start out with check patch but if there is other work please
 let me known :).

 Seriously, you are beyond help.
 A lot of people have tried to answer your mails, correct your patches and
 give you correct advice, but you choose to ignore all of that.
 This behaviour qualifies as either a) Trolling or b) you need medical
 help(as a lot of people pointed out on LKML).
 So please seriously stop, I am not sure what are you trying to achieve by
 posting here, but it is just noise and annoyance to everyone.


 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies




 --
 Thank you
 Warm Regards
 Anuz
 I am sure I can help. Seems I need to be more careful with my patches.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Trial Patch

[Nick Krause]

On Tue, Sep 9, 2014 at 9:54 AM, Peter Senna Tschudin
peter.se...@gmail.com wrote:
 On Tue, Sep 9, 2014 at 3:45 PM, Greg Freemyer greg.freem...@gmail.com wrote:


 On September 8, 2014 11:08:46 PM EDT, nick xerofo...@gmail.com wrote:
I am attaching a trial patch again , please let me known if there are
any issues for me to fix.
Nick

 Nick, I guess you know this list is a training ground for the main lists.  
 As such the same rules are enforced when it comes to formatting.

 Patches as an attachment are simply not acceptable.  You have to do them 
 inline. I'm surprised people are even opening your attachments to look at 
 them.

 My understanding is that the problem is not with attachments, but with
 using strange things like base64 for attachments. Nick has used plain
 text attachment which seem perfectly fine for me. Check this:

 http://www.tux.org/lkml/

 If I get a patch in an attachment (other than a Text/PLAIN type
 attachment with no mangling and that pretty much all mail readers and
 all tools will see as a normal body), I simply WILL NOT apply it unless
 I have strong reason to. I usually wont even bother looking at it,
 unless I expected something special from the sender.

 Really. Don't send patches as attachments.

 Linus

 So plain text attachment seem to be acceptable...



 Greg
 --
 Sent from my Android phone with K-9 Mail. Please excuse my brevity.

 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies



 --
 Peter
I understand that , sorry Guys. I am going to fix this later including
my spell checks.

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Help with btrfs project

[Nick Krause]

On Wed, Aug 20, 2014 at 1:15 PM, Lidza Louina lidza.lou...@gmail.com wrote:
 I agree with Jason.

 I do want Nick to learn the kernel (anyone who wants to learn should
 be able to and we're always looking for new developers) but most of us
 don't have the time or training to be able to help him. Learning via
 email seems to be a very bad medium for him to get a kernel education.
 Emails already take away the human element from communicating (tone of
 voice, facial expressions, etc), and on top of that he has this
 disorder. I really believe that if he finds someone to act as a middle
 man between him and the kernel making sure that he understands our
 emails (to the best of his ability), will help tremendously. I'm sure
 he's smart enough and earnest, but his Asperger's is making this very
 difficult for everyone.

 Hopefully once a system that works for him is set in place, he can
 tell us what is working for him and the kernel could learn how to
 better interact with people with communication disorders and others
 with Autism.

 Lidza

 On Wed, Aug 20, 2014 at 12:33 PM, Mandeep Sandhu
 mandeepsandhu@gmail.com wrote:
 Agree with Jason here.

 If you don't find his questions palatable, just _ignore_ them instead
 of sending rants and sarcastic emails which just wastes more of your
 own time. That way the SNR of this list will improve! :)

 On Wed, Aug 20, 2014 at 8:46 AM, Jason Conklin jason.conk...@gmail.com 
 wrote:
 Guys, stop it. Nick has told us he has Asperger syndrome; as such, he
 is not likely to understand facetious or flippant remarks for what
 they are. The time you've spent responding to Nick's emails would be
 much better used reading a little about autism spectrum disorders
 [1,2] and the kinds of difficulty and confusion they cause in more
 normal (neurotypical) contexts, for both AS people and the people
 they interact with. Otherwise, just move on.

 I am not a psychologist or an expert on autism spectrum disorders, but
 I know enough to recognize that his behavior on this and other lists
 is consistent with several aspects of those disorders. The sad thing
 is that he's getting treated as a malicious troll or a fool, when it's
 pretty clear (to me, anyway) that he's fascinated by the kernel and
 just trying to learn as well as he knows how.

 Without going into autism spectrum intricacies or speculating on
 Nick's particular traits, I'll note that Aspergers is characterized
 by significant difficulties in social interaction and nonverbal
 communication (from Wikipedia) -- which we have seen repeatedly in
 Nick's frequently inappropriate and unresearched questions and
 misunderstanding/misuse of the good advice he has received.

 The resulting frustration is understandable. I acknowledge that the
 format of this and especially the working kernel lists is simply not
 equipped to handle Nick's sort of engagement. The best practice, if
 you're frustrated by Nick's emails, is probably to follow the protocol
 for feeding trolls -- ie, don't -- even though his motivations are
 different from what I'd consider a real troll's. You simply cannot
 expect him to respond (neuro)typically to your input.

 I don't intend to discuss this here anymore, but I really hope the
 above can provide a little context to help the community make more
 fruitful decisions in response to Nick's questions, or at least temper
 your frustrations.

 Jason Conklin


 [1] http://bit.ly/1odpfrd (Wikipedia: Autism spectrum)

 [2] http://bit.ly/1rmgrHg (Wikipedia: Asperger syndrome)

 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
The issue isn't the emails, it's that I am not custom to working in
a high level programming environment. If someone just explains
what I should not do in a written list of rules, I should be fine :).
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Help with btrfs project

[Nick Krause]

On Wed, Aug 20, 2014 at 1:20 PM, Nick Krause xerofo...@gmail.com wrote:
 On Wed, Aug 20, 2014 at 1:15 PM, Lidza Louina lidza.lou...@gmail.com wrote:
 I agree with Jason.

 I do want Nick to learn the kernel (anyone who wants to learn should
 be able to and we're always looking for new developers) but most of us
 don't have the time or training to be able to help him. Learning via
 email seems to be a very bad medium for him to get a kernel education.
 Emails already take away the human element from communicating (tone of
 voice, facial expressions, etc), and on top of that he has this
 disorder. I really believe that if he finds someone to act as a middle
 man between him and the kernel making sure that he understands our
 emails (to the best of his ability), will help tremendously. I'm sure
 he's smart enough and earnest, but his Asperger's is making this very
 difficult for everyone.

 Hopefully once a system that works for him is set in place, he can
 tell us what is working for him and the kernel could learn how to
 better interact with people with communication disorders and others
 with Autism.

 Lidza

 On Wed, Aug 20, 2014 at 12:33 PM, Mandeep Sandhu
 mandeepsandhu@gmail.com wrote:
 Agree with Jason here.

 If you don't find his questions palatable, just _ignore_ them instead
 of sending rants and sarcastic emails which just wastes more of your
 own time. That way the SNR of this list will improve! :)

 On Wed, Aug 20, 2014 at 8:46 AM, Jason Conklin jason.conk...@gmail.com 
 wrote:
 Guys, stop it. Nick has told us he has Asperger syndrome; as such, he
 is not likely to understand facetious or flippant remarks for what
 they are. The time you've spent responding to Nick's emails would be
 much better used reading a little about autism spectrum disorders
 [1,2] and the kinds of difficulty and confusion they cause in more
 normal (neurotypical) contexts, for both AS people and the people
 they interact with. Otherwise, just move on.

 I am not a psychologist or an expert on autism spectrum disorders, but
 I know enough to recognize that his behavior on this and other lists
 is consistent with several aspects of those disorders. The sad thing
 is that he's getting treated as a malicious troll or a fool, when it's
 pretty clear (to me, anyway) that he's fascinated by the kernel and
 just trying to learn as well as he knows how.

 Without going into autism spectrum intricacies or speculating on
 Nick's particular traits, I'll note that Aspergers is characterized
 by significant difficulties in social interaction and nonverbal
 communication (from Wikipedia) -- which we have seen repeatedly in
 Nick's frequently inappropriate and unresearched questions and
 misunderstanding/misuse of the good advice he has received.

 The resulting frustration is understandable. I acknowledge that the
 format of this and especially the working kernel lists is simply not
 equipped to handle Nick's sort of engagement. The best practice, if
 you're frustrated by Nick's emails, is probably to follow the protocol
 for feeding trolls -- ie, don't -- even though his motivations are
 different from what I'd consider a real troll's. You simply cannot
 expect him to respond (neuro)typically to your input.

 I don't intend to discuss this here anymore, but I really hope the
 above can provide a little context to help the community make more
 fruitful decisions in response to Nick's questions, or at least temper
 your frustrations.

 Jason Conklin


 [1] http://bit.ly/1odpfrd (Wikipedia: Autism spectrum)

 [2] http://bit.ly/1rmgrHg (Wikipedia: Asperger syndrome)

 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
 The issue isn't the emails, it's that I am not custom to working in
 a high level programming environment. If someone just explains
 what I should not do in a written list of rules, I should be fine :).
 Nick
In addition it's now not considered a disability most medical professionals
consider it a huge advantage.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Help with btrfs project

[Nick Krause]

On Wed, Aug 20, 2014 at 1:25 PM, Philipp Muhoray
philipp.muho...@gmail.com wrote:

 Am 2014-08-20 19:20, schrieb Nick Krause:
 On Wed, Aug 20, 2014 at 1:15 PM, Lidza Louina lidza.lou...@gmail.com wrote:
 I agree with Jason.

 I do want Nick to learn the kernel (anyone who wants to learn should
 be able to and we're always looking for new developers) but most of us
 don't have the time or training to be able to help him. Learning via
 email seems to be a very bad medium for him to get a kernel education.
 Emails already take away the human element from communicating (tone of
 voice, facial expressions, etc), and on top of that he has this
 disorder. I really believe that if he finds someone to act as a middle
 man between him and the kernel making sure that he understands our
 emails (to the best of his ability), will help tremendously. I'm sure
 he's smart enough and earnest, but his Asperger's is making this very
 difficult for everyone.

 Hopefully once a system that works for him is set in place, he can
 tell us what is working for him and the kernel could learn how to
 better interact with people with communication disorders and others
 with Autism.

 Lidza

 On Wed, Aug 20, 2014 at 12:33 PM, Mandeep Sandhu
 mandeepsandhu@gmail.com wrote:
 Agree with Jason here.

 If you don't find his questions palatable, just _ignore_ them instead
 of sending rants and sarcastic emails which just wastes more of your
 own time. That way the SNR of this list will improve! :)

 On Wed, Aug 20, 2014 at 8:46 AM, Jason Conklin jason.conk...@gmail.com 
 wrote:
 Guys, stop it. Nick has told us he has Asperger syndrome; as such, he
 is not likely to understand facetious or flippant remarks for what
 they are. The time you've spent responding to Nick's emails would be
 much better used reading a little about autism spectrum disorders
 [1,2] and the kinds of difficulty and confusion they cause in more
 normal (neurotypical) contexts, for both AS people and the people
 they interact with. Otherwise, just move on.

 I am not a psychologist or an expert on autism spectrum disorders, but
 I know enough to recognize that his behavior on this and other lists
 is consistent with several aspects of those disorders. The sad thing
 is that he's getting treated as a malicious troll or a fool, when it's
 pretty clear (to me, anyway) that he's fascinated by the kernel and
 just trying to learn as well as he knows how.

 Without going into autism spectrum intricacies or speculating on
 Nick's particular traits, I'll note that Aspergers is characterized
 by significant difficulties in social interaction and nonverbal
 communication (from Wikipedia) -- which we have seen repeatedly in
 Nick's frequently inappropriate and unresearched questions and
 misunderstanding/misuse of the good advice he has received.

 The resulting frustration is understandable. I acknowledge that the
 format of this and especially the working kernel lists is simply not
 equipped to handle Nick's sort of engagement. The best practice, if
 you're frustrated by Nick's emails, is probably to follow the protocol
 for feeding trolls -- ie, don't -- even though his motivations are
 different from what I'd consider a real troll's. You simply cannot
 expect him to respond (neuro)typically to your input.

 I don't intend to discuss this here anymore, but I really hope the
 above can provide a little context to help the community make more
 fruitful decisions in response to Nick's questions, or at least temper
 your frustrations.

 Jason Conklin


 [1] http://bit.ly/1odpfrd (Wikipedia: Autism spectrum)

 [2] http://bit.ly/1rmgrHg (Wikipedia: Asperger syndrome)

 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
 The issue isn't the emails, it's that I am not custom to working in
 a high level programming environment. If someone just explains
 what I should not do in a written list of rules, I should be fine :).
 Nick

 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
 Here's a task for you, then:
 Reread all of our mails from the last few days regarding your behavior,
 and extract anything that we said you should or shouldn't do. Write it
 down in the form of a list, pin it on your wall and commit to it.

 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Sure that's fine.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Help with btrfs project

[Nick Krause]

On Wed, Aug 20, 2014 at 1:30 PM, Nick Krause xerofo...@gmail.com wrote:
 On Wed, Aug 20, 2014 at 1:25 PM, Philipp Muhoray
 philipp.muho...@gmail.com wrote:

 Am 2014-08-20 19:20, schrieb Nick Krause:
 On Wed, Aug 20, 2014 at 1:15 PM, Lidza Louina lidza.lou...@gmail.com 
 wrote:
 I agree with Jason.

 I do want Nick to learn the kernel (anyone who wants to learn should
 be able to and we're always looking for new developers) but most of us
 don't have the time or training to be able to help him. Learning via
 email seems to be a very bad medium for him to get a kernel education.
 Emails already take away the human element from communicating (tone of
 voice, facial expressions, etc), and on top of that he has this
 disorder. I really believe that if he finds someone to act as a middle
 man between him and the kernel making sure that he understands our
 emails (to the best of his ability), will help tremendously. I'm sure
 he's smart enough and earnest, but his Asperger's is making this very
 difficult for everyone.

 Hopefully once a system that works for him is set in place, he can
 tell us what is working for him and the kernel could learn how to
 better interact with people with communication disorders and others
 with Autism.

 Lidza

 On Wed, Aug 20, 2014 at 12:33 PM, Mandeep Sandhu
 mandeepsandhu@gmail.com wrote:
 Agree with Jason here.

 If you don't find his questions palatable, just _ignore_ them instead
 of sending rants and sarcastic emails which just wastes more of your
 own time. That way the SNR of this list will improve! :)

 On Wed, Aug 20, 2014 at 8:46 AM, Jason Conklin jason.conk...@gmail.com 
 wrote:
 Guys, stop it. Nick has told us he has Asperger syndrome; as such, he
 is not likely to understand facetious or flippant remarks for what
 they are. The time you've spent responding to Nick's emails would be
 much better used reading a little about autism spectrum disorders
 [1,2] and the kinds of difficulty and confusion they cause in more
 normal (neurotypical) contexts, for both AS people and the people
 they interact with. Otherwise, just move on.

 I am not a psychologist or an expert on autism spectrum disorders, but
 I know enough to recognize that his behavior on this and other lists
 is consistent with several aspects of those disorders. The sad thing
 is that he's getting treated as a malicious troll or a fool, when it's
 pretty clear (to me, anyway) that he's fascinated by the kernel and
 just trying to learn as well as he knows how.

 Without going into autism spectrum intricacies or speculating on
 Nick's particular traits, I'll note that Aspergers is characterized
 by significant difficulties in social interaction and nonverbal
 communication (from Wikipedia) -- which we have seen repeatedly in
 Nick's frequently inappropriate and unresearched questions and
 misunderstanding/misuse of the good advice he has received.

 The resulting frustration is understandable. I acknowledge that the
 format of this and especially the working kernel lists is simply not
 equipped to handle Nick's sort of engagement. The best practice, if
 you're frustrated by Nick's emails, is probably to follow the protocol
 for feeding trolls -- ie, don't -- even though his motivations are
 different from what I'd consider a real troll's. You simply cannot
 expect him to respond (neuro)typically to your input.

 I don't intend to discuss this here anymore, but I really hope the
 above can provide a little context to help the community make more
 fruitful decisions in response to Nick's questions, or at least temper
 your frustrations.

 Jason Conklin


 [1] http://bit.ly/1odpfrd (Wikipedia: Autism spectrum)

 [2] http://bit.ly/1rmgrHg (Wikipedia: Asperger syndrome)

 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
 The issue isn't the emails, it's that I am not custom to working in
 a high level programming environment. If someone just explains
 what I should not do in a written list of rules, I should be fine :).
 Nick

 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
 Here's a task for you, then:
 Reread all of our mails from the last few days regarding your behavior,
 and extract anything that we said you should or shouldn't do. Write it
 down in the form of a list, pin it on your wall and commit to it.

 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
 Sure that's fine.
 Nick

 ___
 Kernelnewbies mailing list

Re: Help with btrfs project

[Nick Krause]

On Wed, Aug 20, 2014 at 1:58 PM, Sudip Mukherjee
sudipm.mukher...@gmail.com wrote:

 I would like to get back on the list for some work with the btrfs
 developers and I was banned.
 If someone would allow the ban to be removed, I would find it much
 easier as I can email
 the right developers with my patches and questions rather then just
 trying to get in through
 kernel newbies.
 Cheers Nick


 nick,
 i asked a few questions . why dont you answer them and show every one that
 you can.
I may have deleted your email but , please send me your questions and
I can answer.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Help with btrfs project

[Nick Krause]

On Wed, Aug 20, 2014 at 8:21 PM, Bernd Petrovitsch
be...@petrovitsch.priv.at wrote:
 On Mit, 2014-08-20 at 17:25 -0400, Nick Krause wrote:
 On Wed, Aug 20, 2014 at 1:58 PM, Sudip Mukherjee
 sudipm.mukher...@gmail.com wrote:
 [...]
  i asked a few questions . why dont you answer them and show every one that
  you can.
 I may have deleted your email but , please send me your questions and

 It is *your* fault if *you* delete *your* mails, so fix it *youself*
 and don't (try to) push effort to others - as you do from mail #2.

 How should *you* fix *your* immediate failure: Google the mails *you*
 deleted or just search and find it one of the various archives of the
 LKML.

 Sorry, you wasted too much time and bandwidth of everyone 

 Bernd
 --
 I dislike type abstraction if it has no real reason. And saving
 on typing is not a good reason - if your typing speed is the main
 issue when you're coding, you're doing something seriously wrong.
 - Linus Torvalds

The areas for Sudip's questions are below.
1. Btrfs is suppose to replace ext4 as the default Linux file system
due to ext4 having no
features like sub volumes and build in compression. Over all due it's
great features ZFS
still is the default choice in the enterprise and data center space,
but btrfs hows to challenge
the reigning king and make btrfs the default, Oracle developers
started this file system as
their was no good file system on Linux with features like ZFS.
2. Btrfs  allows for unlimited files due to dynamic inode creation and
not a fixed inode count.
In addition in supports sub volumes and build in compression using
certain compression
algorithms. In addition most of it's design is build for large COW file systems.
3. Journaling is the ability of  a file system to keep a log of data
and if the file system is not
in a known good state , the file system will roll back the file system
to the last known good
state, mostly thought of as the file system log.
4. Btrfs does support this in a basic form but not as a tested and
tried fsck online check for
enterprise or critical workloads.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Help with btrfs project

[Nick Krause]

On Wed, Aug 20, 2014 at 10:47 PM, Nick Krause xerofo...@gmail.com wrote:
 On Wed, Aug 20, 2014 at 8:21 PM, Bernd Petrovitsch
 be...@petrovitsch.priv.at wrote:
 On Mit, 2014-08-20 at 17:25 -0400, Nick Krause wrote:
 On Wed, Aug 20, 2014 at 1:58 PM, Sudip Mukherjee
 sudipm.mukher...@gmail.com wrote:
 [...]
  i asked a few questions . why dont you answer them and show every one that
  you can.
 I may have deleted your email but , please send me your questions and

 It is *your* fault if *you* delete *your* mails, so fix it *youself*
 and don't (try to) push effort to others - as you do from mail #2.

 How should *you* fix *your* immediate failure: Google the mails *you*
 deleted or just search and find it one of the various archives of the
 LKML.

 Sorry, you wasted too much time and bandwidth of everyone 

 Bernd
 --
 I dislike type abstraction if it has no real reason. And saving
 on typing is not a good reason - if your typing speed is the main
 issue when you're coding, you're doing something seriously wrong.
 - Linus Torvalds

 The areas for Sudip's questions are below.
 1. Btrfs is suppose to replace ext4 as the default Linux file system
 due to ext4 having no
 features like sub volumes and build in compression. Over all due it's
 great features ZFS
 still is the default choice in the enterprise and data center space,
 but btrfs hows to challenge
 the reigning king and make btrfs the default, Oracle developers
 started this file system as
 their was no good file system on Linux with features like ZFS.
 2. Btrfs  allows for unlimited files due to dynamic inode creation and
 not a fixed inode count.
 In addition in supports sub volumes and build in compression using
 certain compression
 algorithms. In addition most of it's design is build for large COW file 
 systems.
 3. Journaling is the ability of  a file system to keep a log of data
 and if the file system is not
 in a known good state , the file system will roll back the file system
 to the last known good
 state, mostly thought of as the file system log.
 4. Btrfs does support this in a basic form but not as a tested and
 tried fsck online check for
 enterprise or critical workloads.
 Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: one thing at a time

[Nick Krause]

On Tue, Aug 19, 2014 at 8:13 AM, Greg Freemyer greg.freem...@gmail.com wrote:


 On August 18, 2014 10:59:05 PM EDT, Nick Krause xerofo...@gmail.com wrote:
On Mon, Aug 18, 2014 at 10:55 PM, Nick Krause xerofo...@gmail.com
wrote:
 On Mon, Aug 18, 2014 at 10:06 PM, Rik van Riel r...@surriel.com
wrote:
 On 08/18/2014 01:13 PM, Nick Krause wrote:
 Valdis,
 I was interested in both at the same time, just asked about
Beagle-boards first.
 I aren't having any difficulty with it , I just wanted to known
more about this
 area as the docs out there are terrible and not worth reading on
this part of
 the networking stack.
 Nick,

 the Linux kernel requires a lot of focus.

 I have no doubt that you are smart enough to learn
 things about the Linux kernel, but nobody is smart
 enough to learn everything at once. Nobody.

 If you are serious about learning Linux kernel internals,
 it would be good to focus on one thing at a time.

 One thing. Learn everything about it, before moving on
 to the next topic.

 Kernel hacking is much more about attitude than about
 aptitude. Focus is the key.

 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
 Absolutely, I am trying to learn btrfs and networking for now.
 Cheers Nick
My issue now is that due to my issues I can't mail the right list for
being
banned for my questions. If someone wants to talk to the other
developers
about removing the ban that would be great and very helpful as I can my
questions to the right maintainers/developers.
Cheers Nick

 I checked my watch, then my sundial, and finally my calendar.  All said check 
 back after beard has grown 6 additional inches.

 I have no idea if you will ever be un-banned, but it certainly not going to 
 happen in 2014.  I doubt seriously it will happen in 2015.

 You do realize that most of the kernel devs do it both for a living and out 
 of sheer love of the work.  Your participation the last few months impacted 
 both in a negative way.  I've never heard of anyone being banned before, so 
 you are novel.  None of us how long the blackball will stay in place, maybe 
 forever.

 Greg
 --
 Sent from my Android phone with K-9 Mail. Please excuse my brevity.
That's understandable and I hope to get back on, I did screw up and
yes I understand your points.
Cheers Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Questions for Storage Engineers

[Nick Krause]

Hey Guys,
This is a favor for the btrfs developers, one of my aunt's work's at
IBM and is able to ask questions
to a few storage engineers about features they would like to see in a
file system and it's tools. In
addition if you would like to ask them about how to improve btrfs too,
I can send another email
to her with your questions.
Regards Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Questions for Storage Engineers

[Nick Krause]

On Tue, Aug 19, 2014 at 1:58 PM,  valdis.kletni...@vt.edu wrote:
 On Tue, 19 Aug 2014 13:33:22 -0400, Nick Krause said:
 This is a favor for the btrfs developers, one of my aunt's work's at
 IBM and is able to ask questions
 to a few storage engineers about features they would like to see in a
 file system and it's tools. In
 addition if you would like to ask them about how to improve btrfs too,
 I can send another email
 to her with your questions.

 The two most obvious questions are:

 1) Why do you think that IBM storage engineers have any interesting comments
 about btrfs?  Hint:  if IBM is including a storage engineer in the discussion
 of a project, it's probably not a good usage case for btrfs.  Storage 
 engineers
 get involved when the right answer is Lustre, or IBM's GPFS, or SGI's CXFS,
 or large-scale offerings from EMC or NetApp, or similar over-the-top 
 solutions.

 (Full disclosure: I work with those sorts of storage systems for a living, and
 everything mentioned in the previous paragraph is on the floor across the 
 hall)

 2) Why aren't the btrfs developers doing the talking themselves?
That's fair Valdis, the interesting thing through is that btrfs is
their chosen file system internally at least and
they seem to be moving their clients off ext4 to btrfs. The client's
who are using btrfs will be more useful if
I can get the information :). I been banned from the list so I can't
get them involved directly and it's better
I try to get the information from her them you guys as I have known
her for longer.
Cheers Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Questions for Storage Engineers

[Nick Krause]

On Tue, Aug 19, 2014 at 3:32 PM,  valdis.kletni...@vt.edu wrote:
 On Tue, 19 Aug 2014 14:05:25 -0400, Nick Krause said:
 I can get the information :). I been banned from the list so I can't
 get them involved directly and it's better

 You *do* realize that the btrfs maintainers haven't been banned from
 anyplace, and have enough name recognition that if they want info, they
 can go talk to people themselves, right?

 In other words, what's the value-added that you're providing here?

 Oh, and if IBM wants a feature in Linux, they in general don't make a mention
 of what feature they want - they *submit a patch*, properly tested, with
 benchmarks, documentation, and matching userspace tool patches.





Very well then I guess this is closed then.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Help with btrfs project

[Nick Krause]

Hey Guys,
This commit seems to be needed to fixed up based on what the btrfs
developers, are stating on their wiki.
Other then the TODO list, which we can discuss here,  is there any
other parts of this patch that need to
be rewritten, it's merged as of now but I can recreate  new patches if
needed from Linus's tree. The project
idea is Clear unallocated space on the btrfs wiki. I AM NOT asking you
to write the code just want  to known
is how you want this cleaned up.
Cheers Nick

From 55ec5c00022be8f2bbed06b99b5f4be5832a5451 Mon Sep 17 00:00:00 2001
From: David Sterba dste...@suse.cz
Date: Thu, 19 Apr 2012 15:09:09 +0200
Subject: [PATCH 1/1] btrfs: ioctl to clear unused space

abuse discard infrastructure and pass down whether we want to trim or
just zero out. works, does not corrupt data.

TODO:
- more options how to clean (ie. a known signature of freed block, 2
  types of them, or random garbage, or all zeros)
- what to do for SSD mixed with HDD ?

Signed-off-by: David Sterba dste...@suse.cz
---
 fs/btrfs/ctree.h|5 ++-
 fs/btrfs/disk-io.c  |2 +-
 fs/btrfs/extent-tree.c  |   86 +--
 fs/btrfs/free-space-cache.c |   24 +++
 fs/btrfs/free-space-cache.h |3 +-
 fs/btrfs/ioctl.c|   29 ++
 fs/btrfs/ioctl.h|9 
 7 files changed, 134 insertions(+), 24 deletions(-)

diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h
index fa5c45b..e7a87cb 100644
--- a/fs/btrfs/ctree.h
+++ b/fs/btrfs/ctree.h
@@ -2655,7 +2655,10 @@ u64
btrfs_account_ro_block_groups_free_space(struct btrfs_space_info
*sinfo);
 int btrfs_error_unpin_extent_range(struct btrfs_root *root,
u64 start, u64 end);
 int btrfs_error_discard_extent(struct btrfs_root *root, u64 bytenr,
-   u64 num_bytes, u64 *actual_bytes);
+   u64 num_bytes, u64 *actual_bytes,
+   int do_trim);
+int btrfs_clear_free_space(struct btrfs_root *root,
+ struct btrfs_ioctl_clear_free_args *range);
 int btrfs_force_chunk_alloc(struct btrfs_trans_handle *trans,
 struct btrfs_root *root, u64 type);
 int btrfs_trim_fs(struct btrfs_root *root, struct fstrim_range *range);
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index 2936ca4..77a704d 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -3580,7 +3580,7 @@ again:
  if (btrfs_test_opt(root, DISCARD))
  ret = btrfs_error_discard_extent(root, start,
  end + 1 - start,
- NULL);
+ NULL, 1);

  clear_extent_dirty(unpin, start, end, GFP_NOFS);
  btrfs_error_unpin_extent_range(root, start, end);
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index 6e1d367..26514b9 100644
--- a/fs/btrfs/extent-tree.c
+++ b/fs/btrfs/extent-tree.c
@@ -1818,35 +1818,50 @@ static int remove_extent_backref(struct
btrfs_trans_handle *trans,
 }

 static int btrfs_issue_discard(struct block_device *bdev,
- u64 start, u64 len)
+ u64 start, u64 len, int do_trim)
 {
- return blkdev_issue_discard(bdev, start  9, len  9, GFP_NOFS, 0);
+ printk(KERN_DEBUG ISSUE ZERO start %llu len %llu\n,
+ (unsigned long long)start, (unsigned long long)len);
+ if (do_trim) {
+ return blkdev_issue_discard(bdev, start  9, len  9,
+ GFP_NOFS, 0);
+ } else {
+ return blkdev_issue_zeroout(bdev, start  9, len  9,
+ GFP_NOFS);
+ }
 }

 static int btrfs_discard_extent(struct btrfs_root *root, u64 bytenr,
- u64 num_bytes, u64 *actual_bytes)
+ u64 num_bytes, u64 *actual_bytes, int do_trim)
 {
  int ret;
  u64 discarded_bytes = 0;
  struct btrfs_bio *bbio = NULL;
+ int rw;
+
+ printk(KERN_DEBUG discard extent %d: bytenr %llu len %llu\n, do_trim,
+ (unsigned long long)bytenr,
+ (unsigned long long)num_bytes);

+ rw = do_trim ? REQ_DISCARD : REQ_WRITE;
+ rw = REQ_DISCARD;

  /* Tell the block device(s) that the sectors can be discarded */
- ret = btrfs_map_block(root-fs_info-mapping_tree, REQ_DISCARD,
+ ret = btrfs_map_block(root-fs_info-mapping_tree, rw,
   bytenr, num_bytes, bbio, 0);
  /* Error condition is -ENOMEM */
  if (!ret) {
  struct btrfs_bio_stripe *stripe = bbio-stripes;
  int i;

-
  for (i = 0; i  bbio-num_stripes; i++, stripe++) {
- if (!stripe-dev-can_discard)
+ if (do_trim  !stripe-dev-can_discard)
  continue;

  ret = btrfs_issue_discard(stripe-dev-bdev,
   stripe-physical,
-  stripe-length);
+  stripe-length,
+  do_trim);
  if (!ret)
  discarded_bytes += stripe-length;
  else if (ret != -EOPNOTSUPP)
@@ -4924,7 +4939,7 @@ int btrfs_finish_extent_commit(struct
btrfs_trans_handle *trans,

  if (btrfs_test_opt(root, DISCARD))
  ret = btrfs_discard_extent(root, start,
-   end + 1 - start, NULL);
+   end + 1 - start, NULL, 1);

  clear_extent_dirty(unpin, start, end, GFP_NOFS);
  unpin_extent_range(root, start, end);
@@ -5905,7 +5920,7 @@ static int __btrfs_free_reserved_extent(struct
btrfs_root *root,
  }

  if (btrfs_test_opt(root, DISCARD))
- ret = btrfs_discard_extent(root, start, len, NULL);
+ ret = btrfs_discard_extent(root, start, len, NULL, 1);

  if (pin)
  pin_down_extent(root, cache, start, len, 1);
@@ 

TCP/UDP

[Nick Krause]

Hey Guys,
After Searching the kernel Docs there is very little information on
this for new developers. I want to know more about how
the kernel code is written to handle TCP/UDP as even with Google and
kernel programming books it's not good enough to
learn how to write code for this particular subsystem at a high level.
Cheers Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: one thing at a time

[Nick Krause]

On Mon, Aug 18, 2014 at 10:06 PM, Rik van Riel r...@surriel.com wrote:
 On 08/18/2014 01:13 PM, Nick Krause wrote:
 Valdis,
 I was interested in both at the same time, just asked about Beagle-boards 
 first.
 I aren't having any difficulty with it , I just wanted to known more about 
 this
 area as the docs out there are terrible and not worth reading on this part of
 the networking stack.
 Nick,

 the Linux kernel requires a lot of focus.

 I have no doubt that you are smart enough to learn
 things about the Linux kernel, but nobody is smart
 enough to learn everything at once. Nobody.

 If you are serious about learning Linux kernel internals,
 it would be good to focus on one thing at a time.

 One thing. Learn everything about it, before moving on
 to the next topic.

 Kernel hacking is much more about attitude than about
 aptitude. Focus is the key.

 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Absolutely, I am trying to learn btrfs and networking for now.
Cheers Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: one thing at a time

[Nick Krause]

On Mon, Aug 18, 2014 at 10:55 PM, Nick Krause xerofo...@gmail.com wrote:
 On Mon, Aug 18, 2014 at 10:06 PM, Rik van Riel r...@surriel.com wrote:
 On 08/18/2014 01:13 PM, Nick Krause wrote:
 Valdis,
 I was interested in both at the same time, just asked about Beagle-boards 
 first.
 I aren't having any difficulty with it , I just wanted to known more about 
 this
 area as the docs out there are terrible and not worth reading on this part 
 of
 the networking stack.
 Nick,

 the Linux kernel requires a lot of focus.

 I have no doubt that you are smart enough to learn
 things about the Linux kernel, but nobody is smart
 enough to learn everything at once. Nobody.

 If you are serious about learning Linux kernel internals,
 it would be good to focus on one thing at a time.

 One thing. Learn everything about it, before moving on
 to the next topic.

 Kernel hacking is much more about attitude than about
 aptitude. Focus is the key.

 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
 Absolutely, I am trying to learn btrfs and networking for now.
 Cheers Nick
My issue now is that due to my issues I can't mail the right list for being
banned for my questions. If someone wants to talk to the other developers
about removing the ban that would be great and very helpful as I can my
questions to the right maintainers/developers.
Cheers Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Beagleboard and Panda Board Drivers

[Nick Krause]

On Sun, Aug 17, 2014 at 7:16 AM, Prabhakar Lad
prabhakar.cse...@gmail.com wrote:
 Hi,

 On Sun, Aug 17, 2014 at 3:45 AM, Nick Krause xerofo...@gmail.com wrote:
 I would like to read the code for these drivers and am not sure where
 the code for them is.
 If someone can send me the directory that would be great as I am not
 sure where the
 code is.
 Rather than just dropping a mail if you would have  googled it
 you would have found the required answers  which you wanted.

 [1] http://beagleboard.org/linux
 [2] http://pandaboard.org/content/resources/home

 Regards,
 --Prabhakar
Thanks Prabhakar,
I wasn't curious about their own custom kernels but the main line kernel.
Cheers Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Beagleboard and Panda Board Drivers

[Nick Krause]

On Sun, Aug 17, 2014 at 4:02 PM, Dave Hylands dhyla...@gmail.com wrote:
 Hi Nick,


 On Sat, Aug 16, 2014 at 7:45 PM, Nick Krause xerofo...@gmail.com wrote:

 I would like to read the code for these drivers and am not sure where
 the code for them is.
 If someone can send me the directory that would be great as I am not
 sure where the
 code is.

 You're going to find that the drivers are spread out around the tree (well
 mosstly in the drivers tree)

 The way I would go about this is to build a kernel for the board in
 question. Make sure it has all of the drivers installed.

 Then go and look in your build tree. There will be a .o file for each source
 file that was compiled into the kernel (or made into a module).

 Then you'll know exactly which source files were actually compiled into the
 kernel that you built.

 Once you understand how .config files work, you can also figure out which
 source files would be compiled, but you can leave that for later.

 --
 Dave Hylands
 Shuswap, BC, Canada
 http://www.davehylands.com
The issue isn't that I could do that if I HAD the board that's why I am asking,
otherwise I  would do this on my own.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Beagleboard and Panda Board Drivers

[Nick Krause]

On Sun, Aug 17, 2014 at 5:39 PM, Dave Hylands dhyla...@gmail.com wrote:
 Hey Nick,



 The issue isn't that I could do that if I HAD the board that's why I am
 asking,
 otherwise I  would do this on my own.

 You don't need the board to build the kernel.


 --
 Dave Hylands
 Shuswap, BC, Canada
 http://www.davehylands.com

I forget about that thanks Dave. In addition , Brad Rex due to my
memory and my Asperger's  I am
able to do lots of complicated things in my head. Further more I learn
really fast  in my areas of interest,
after my first year of programming I was already have build my own
distro of Linux from Scratch, and
after my second year was learning how to program embedded bootloaders
and the like.  I am not lying
this is no joke and rather common with how high functioning my As is.
Cheers and Thanks Again,
Nick
P.S. Please take my AS into consideration for my abilities as if you
don't most of the things I can do in
my head and with some little time will make no sense:)

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Beagleboard and Panda Board Drivers

[Nick Krause]

On Mon, Aug 18, 2014 at 12:16 AM, Saket Sinha saket.sinh...@gmail.com wrote:
 Hi All,

 Its really sad that many experts on Linux who have guided me and many others
 like me  are leaving this list just because of some people who do not
 deserve to be on this list.

 I request them not to take such abrupt steps deriving many of us of their
 precious guidance and mentor-ship. This list has personally helped me a lot
 in ways when even days of googling  and searching did not work.

 I know, with people like  Nick this becomes very irritating but lets take
 his mails as spams. I get a feeling that he has been deliberately trying to
 get on the nerves of many just to damage their intention and gesture of
 helping others.

 But provided that this list has helped me so much, I try to put up with his
 mails I request and  pray,  none of the experts and even novices and
 advocates of FOSS whose discussions and questions are so valuable, not to
 leave this list and consider Nick and his mails as non-existent.

 Regards,
 Saket Sinha










 On Mon, Aug 18, 2014 at 9:23 AM, Brad Rex brad...@gmail.com wrote:

 On Sun, Aug 17, 2014 at 8:02 PM, Nick Krause xerofo...@gmail.com wrote:

 I forget about that thanks Dave. In addition , Brad Rex due to my
 memory and my Asperger's  I am
 able to do lots of complicated things in my head. Further more I learn
 really fast  in my areas of interest,
 after my first year of programming I was already have build my own
 distro of Linux from Scratch, and
 after my second year was learning how to program embedded bootloaders
 and the like.  I am not lying
 this is no joke and rather common with how high functioning my As is.
 Cheers and Thanks Again,


 My sincerest apologies in not taking into account your abilities.  Given
 your past dialog with both this list and LKML, you can forgive me in not
 being able to fully grasp what you can and cannot do.  Clearly, I'm in the
 wrong, and myself, and I'm sure many others, have underestimated what you
 bring to the table.

 I wish you the best of luck working on Linux ARM-based processors without
 hardware in hand.  My office cube is full of Cortex A-8/9/15 hardware from
 different manufacturers.  I guess I've been doing it wrong all these years.

 And with that, I'll be leaving this list, just like others have.  While I
 never contributed in direct ways to the list, I did benefit from it, and
 those learnings came out in the code I created for my customers.  I shall
 miss Valdis' emails: curt, funny, and to the point.  Apparently I'm not
 worthy enough to be working with or on the kernel or it's drivers, as there
 are others with way more skill than I have that should be leading the
 charge.  My years of working on Android, creating tablets, making IP phones,
 developing VR glasses, creating car infotainment systems, and just plain
 using Linux as my development environment were just silly endeavors on my
 part.

 PS.  Don't bother responding.  Your response will be send to /dev/null.

 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies



 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Look Saket,
I asked a valid question and after he turned it into  I was trying to
get to back
but with bad questions and should have the hard ware for testing.
Regards Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Beagleboard and Panda Board Drivers

[Nick Krause]

I would like to read the code for these drivers and am not sure where
the code for them is.
If someone can send me the directory that would be great as I am not
sure where the
code is.
Thanks Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Kernel Dev - Nick Krause

[Nick Krause]

On Fri, Aug 15, 2014 at 7:36 AM, Andrew Bourhill
andrew.bourh...@eagleeye.com wrote:
 Nick,


 I've been reading the lists for a long long time. My day job is senior
 embedded linux developer for a mobile comms company, I have many many years
 experience under my belt.


 from what I see is a young fella, possibly fresh out of university trying to
 cut his teeth on the kernel.


 take my advice, leave it alone , you are far too in-experienced to be trying
 this.

 your post to the list are becoming tiresome.


 leave it alone, go away and develop your coding skills by writing programs
 of your own. (i would suggest something simple to start - helloworld)..


 this stuff is far too complicated for you - especially device drivers.
 (these need knowledge of the hardware , also knowledge about how hardware
 works)


 just a bit of friendly advice.


 Abo


 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Abo,
I agreed and that is why I am going through the Eudptuyla Challenge
first before I
continue.
Cheers Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Kernel Dev - Nick Krause

[Nick Krause]

On Fri, Aug 15, 2014 at 11:29 AM, Nick Krause xerofo...@gmail.com wrote:
 On Fri, Aug 15, 2014 at 7:36 AM, Andrew Bourhill
 andrew.bourh...@eagleeye.com wrote:
 Nick,


 I've been reading the lists for a long long time. My day job is senior
 embedded linux developer for a mobile comms company, I have many many years
 experience under my belt.


 from what I see is a young fella, possibly fresh out of university trying to
 cut his teeth on the kernel.


 take my advice, leave it alone , you are far too in-experienced to be trying
 this.

 your post to the list are becoming tiresome.


 leave it alone, go away and develop your coding skills by writing programs
 of your own. (i would suggest something simple to start - helloworld)..


 this stuff is far too complicated for you - especially device drivers.
 (these need knowledge of the hardware , also knowledge about how hardware
 works)


 just a bit of friendly advice.


 Abo


 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

 Abo,
 I agreed and that is why I am going through the Eudptuyla Challenge
 first before I
 continue.
 Cheers Nick
Abo,
The issue isn't it's too complicated I am rushing from doing build
fixes to race conditions and I shouldn't rush my
learning curve.
Cheers Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Trace Help

[Nick Krause]

I am just going to be blunt and assume that my trace is wrong.
I am tracing the bug , https://bugzilla.kernel.org/show_bug.cgi?id=72291.
Here are my trace steps
1.Start in _break_lease and find locks_insert_block and trace into that function
2. In that function we hit the internal function, _locks_insert_block and I
trace into that function
3. When I trace into that function , I get see we are using the same spinlocks
as the other functions and come to the conclusion we are not holding the
right spinlock and are looping indefinitely
4. This comment , /* Must be called with i_lock held. */ seems to a
value thing to check if we
are holding the i_lock spinlock
5.I trace back to where we are calling in the function, _break_lease
and we are calling like this,
locks_insert_block(flock, new_fl);
I known that flock is the lock that we are calling with and logically
needs the i_lock
6. flock = inode-i_flock; is clearly not the right lock and we are
already holding it in another
spinlock as part of this function , spin_lock(inode-i_lock);
This means that we are looping forever trying to get the i_lock that
is already held by another spinlock,
causing us to loop forever when we call _break_lease.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Trace Help

[Nick Krause]

On Fri, Aug 15, 2014 at 1:53 PM, Nick Krause xerofo...@gmail.com wrote:
 I am just going to be blunt and assume that my trace is wrong.
 I am tracing the bug , https://bugzilla.kernel.org/show_bug.cgi?id=72291.
 Here are my trace steps
 1.Start in _break_lease and find locks_insert_block and trace into that 
 function
 2. In that function we hit the internal function, _locks_insert_block and I
 trace into that function
 3. When I trace into that function , I get see we are using the same spinlocks
 as the other functions and come to the conclusion we are not holding the
 right spinlock and are looping indefinitely
 4. This comment , /* Must be called with i_lock held. */ seems to a
 value thing to check if we
 are holding the i_lock spinlock
 5.I trace back to where we are calling in the function, _break_lease
 and we are calling like this,
 locks_insert_block(flock, new_fl);
 I known that flock is the lock that we are calling with and logically
 needs the i_lock
 6. flock = inode-i_flock; is clearly not the right lock and we are
 already holding it in another
 spinlock as part of this function , spin_lock(inode-i_lock);
 This means that we are looping forever trying to get the i_lock that
 is already held by another spinlock,
 causing us to loop forever when we call _break_lease.
 Nick
Typo we internally call locks_insert_block

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Help with btrfs_zero_range function

[Nick Krause]

Hey Guys,
I am wondering how to convert btrfs_find_first_hole and
btrfs_fill_holes in order to support zero range for btrfs in order to
support fallocate zero range. I am pasting my code so far and please
let me known if there is something else I am missing.
The function is called btrfs_zero_range in the file I am attaching.
Regards Nick
/*
 * Copyright (C) 2007 Oracle.  All rights reserved.
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public
 * License v2 as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * General Public License for more details.
 *
 * You should have received a copy of the GNU General Public
 * License along with this program; if not, write to the
 * Free Software Foundation, Inc., 59 Temple Place - Suite 330,
 * Boston, MA 021110-1307, USA.
 */

#include linux/fs.h
#include linux/pagemap.h
#include linux/highmem.h
#include linux/time.h
#include linux/init.h
#include linux/string.h
#include linux/backing-dev.h
#include linux/mpage.h
#include linux/aio.h
#include linux/falloc.h
#include linux/swap.h
#include linux/writeback.h
#include linux/statfs.h
#include linux/compat.h
#include linux/slab.h
#include linux/btrfs.h
#include ctree.h
#include disk-io.h
#include transaction.h
#include btrfs_inode.h
#include print-tree.h
#include tree-log.h
#include locking.h
#include volumes.h
#include qgroup.h

static struct kmem_cache *btrfs_inode_defrag_cachep;
/*
 * when auto defrag is enabled we
 * queue up these defrag structs to remember which
 * inodes need defragging passes
 */
struct inode_defrag {
	struct rb_node rb_node;
	/* objectid */
	u64 ino;
	/*
	 * transid where the defrag was added, we search for
	 * extents newer than this
	 */
	u64 transid;

	/* root objectid */
	u64 root;

	/* last offset we were able to defrag */
	u64 last_offset;

	/* if we've wrapped around back to zero once already */
	int cycled;
};

static int __compare_inode_defrag(struct inode_defrag *defrag1,
  struct inode_defrag *defrag2)
{
	if (defrag1-root  defrag2-root)
		return 1;
	else if (defrag1-root  defrag2-root)
		return -1;
	else if (defrag1-ino  defrag2-ino)
		return 1;
	else if (defrag1-ino  defrag2-ino)
		return -1;
	else
		return 0;
}

/* pop a record for an inode into the defrag tree.  The lock
 * must be held already
 *
 * If you're inserting a record for an older transid than an
 * existing record, the transid already in the tree is lowered
 *
 * If an existing record is found the defrag item you
 * pass in is freed
 */
static int __btrfs_add_inode_defrag(struct inode *inode,
struct inode_defrag *defrag)
{
	struct btrfs_root *root = BTRFS_I(inode)-root;
	struct inode_defrag *entry;
	struct rb_node **p;
	struct rb_node *parent = NULL;
	int ret;

	p = root-fs_info-defrag_inodes.rb_node;
	while (*p) {
		parent = *p;
		entry = rb_entry(parent, struct inode_defrag, rb_node);

		ret = __compare_inode_defrag(defrag, entry);
		if (ret  0)
			p = parent-rb_left;
		else if (ret  0)
			p = parent-rb_right;
		else {
			/* if we're reinserting an entry for
			 * an old defrag run, make sure to
			 * lower the transid of our existing record
			 */
			if (defrag-transid  entry-transid)
entry-transid = defrag-transid;
			if (defrag-last_offset  entry-last_offset)
entry-last_offset = defrag-last_offset;
			return -EEXIST;
		}
	}
	set_bit(BTRFS_INODE_IN_DEFRAG, BTRFS_I(inode)-runtime_flags);
	rb_link_node(defrag-rb_node, parent, p);
	rb_insert_color(defrag-rb_node, root-fs_info-defrag_inodes);
	return 0;
}

static inline int __need_auto_defrag(struct btrfs_root *root)
{
	if (!btrfs_test_opt(root, AUTO_DEFRAG))
		return 0;

	if (btrfs_fs_closing(root-fs_info))
		return 0;

	return 1;
}

/*
 * insert a defrag record for this inode if auto defrag is
 * enabled
 */
int btrfs_add_inode_defrag(struct btrfs_trans_handle *trans,
			   struct inode *inode)
{
	struct btrfs_root *root = BTRFS_I(inode)-root;
	struct inode_defrag *defrag;
	u64 transid;
	int ret;

	if (!__need_auto_defrag(root))
		return 0;

	if (test_bit(BTRFS_INODE_IN_DEFRAG, BTRFS_I(inode)-runtime_flags))
		return 0;

	if (trans)
		transid = trans-transid;
	else
		transid = BTRFS_I(inode)-root-last_trans;

	defrag = kmem_cache_zalloc(btrfs_inode_defrag_cachep, GFP_NOFS);
	if (!defrag)
		return -ENOMEM;

	defrag-ino = btrfs_ino(inode);
	defrag-transid = transid;
	defrag-root = root-root_key.objectid;

	spin_lock(root-fs_info-defrag_inodes_lock);
	if (!test_bit(BTRFS_INODE_IN_DEFRAG, BTRFS_I(inode)-runtime_flags)) {
		/*
		 * If we set IN_DEFRAG flag and evict the inode from memory,
		 * and then re-read this inode, this new inode doesn't have
		 * IN_DEFRAG flag. At the case, we may find the existed defrag.
		 */
		ret = __btrfs_add_inode_defrag(inode, defrag);
		if (ret)
			

Re: Nick Krause page fault

[Nick Krause]

On Fri, Aug 15, 2014 at 2:42 PM, nayobix nayo...@nayobix.org wrote:
 Guys,

 I just dont understand, why Nick Krause isn't still banned from this mailing
 list. This mailing list seems like some schizophrenia forum

 Regards,
 B.
 --
 nayobix
 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

I am not sending any more emails to this list , I am going to read
through the kernel source starting the scheduler and
only ask questions if I don't understand something for the next few months.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Skb Documentation?

[Nick Krause]

After searching around in the documentation directory, I need no
information on skb data structure and other information relating to
skb
data type. If someone knowns where there is Documentation in the
kernel directory please tell me, otherwise I would be glad to write
up.
Regards Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Skb Documentation?

[Nick Krause]

On Thu, Aug 14, 2014 at 1:42 PM, Jerry Snitselaar d...@snitselaar.org wrote:
 On Thu Aug 14 14, leo kirotawa wrote:
git grep is your friend. :)
[1]http://www.linuxjournal.com/article/1312

 That and learn to use cscope and/or ctags

 Jerry

 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Jerry,
I fixed up my patch and sent it to the kernel newbies list.
If you can't find it I will resend.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: [PATCH] usb: Fix switch statement in ohci-tmio.c

[Nick Krause]

On Thu, Aug 14, 2014 at 2:05 PM, Nicholas Krause xerofo...@gmail.com wrote:
 I am fixing the bug on at the link, 
 https://bugzilla.kernel.org/show_bug.cgi?id=79931.
 This bug report states that in the function, tmio_hc_stop the switch has no 
 needed breaks.
 Further more this patch fixes this bug by adding the needed breaks.

 Signed-off-by: Nicholas Krause xerofo...@gmail.com
 ---
  drivers/usb/host/ohci-tmio.c | 4 
  1 file changed, 4 insertions(+)

 diff --git a/drivers/usb/host/ohci-tmio.c b/drivers/usb/host/ohci-tmio.c
 index bb40958..d2b5382 100644
 --- a/drivers/usb/host/ohci-tmio.c
 +++ b/drivers/usb/host/ohci-tmio.c
 @@ -100,12 +100,16 @@ static void tmio_stop_hc(struct platform_device *dev)
 switch (ohci-num_ports) {
 default:
 dev_err(dev-dev, Unsupported amount of ports: 
 %d\n, ohci-num_ports);
 +   break;
 case 3:
 pm |= CCR_PM_USBPW3;
 +   break;
 case 2:
 pm |= CCR_PM_USBPW2;
 +   break;
 case 1:
 pm |= CCR_PM_USBPW1;
 +   break;
 }
 tmio_iowrite8(0, tmio-ccr + CCR_INTC);
 tmio_iowrite8(0, tmio-ccr + CCR_ILME);
 --
 1.9.1


If someone wants to send out this patch for me,that would be great :).
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Skb Documentation?

[Nick Krause]

On Thu, Aug 14, 2014 at 2:07 PM, Jeff Haran jeff.ha...@citrix.com wrote:
 -Original Message-
 From: kernelnewbies-boun...@kernelnewbies.org 
 [mailto:kernelnewbies-boun...@kernelnewbies.org] On Behalf Of Jerry
 Snitselaar
 Sent: Thursday, August 14, 2014 10:42 AM
 To: leo kirotawa
 Cc: kernelnewbies
 Subject: Re: Skb Documentation?

 On Thu Aug 14 14, leo kirotawa wrote:
 git grep is your friend. :)
 [1]http://www.linuxjournal.com/article/1312

 That and learn to use cscope and/or ctags

 Jerry

 I've found that the best browser for trying to understand kernel code comes 
 from a commercial source, but you should be able to use it for free. You just 
 need to sign up to create an account and when I did it, it was free. Check 
 out https://scan.coverity.com/. The Coverity browser is C language 
 knowledgeable and the Coverity people regularly do analyses of several open 
 source projects, including Linux.

 Where it really shines over tools like cscope or ctags is when you are trying 
 to understand how a given field of a structure is used, or any other case 
 where the same function or variable name is used in several different 
 contexts. For example, let's say you are interested in how the kernel uses 
 the struct sk_buff cb field. If you do a search for cb in the kernel 
 sources using cscope, you get hits for a myriad of instances of variables and 
 structure fields named cb that have nothing to do with the sk_buff cb 
 field. Weeding out all the false positives is quite tedious and time 
 consuming. But the Coverity browser knows the difference between (struct 
 sk_buff *)-cb and all the cbs that represent callback functions in unrelated 
 code. Big time saver.

 Jeff Haran


 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
I was using lxr for a while but this looks good. Thanks for the
information Jeff.
If you want to send out some patches for me I have two, one is from today that
I just sent and the other one is hard to find due to be not learning
skbs. I will
resend it to you directly if you like.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: [PATCH] usb: Fix switch statement in ohci-tmio.c

[Nick Krause]

On Thu, Aug 14, 2014 at 2:13 PM, Kristofer Hallin
kristofer.hal...@gmail.com wrote:
 Please Nick, stop spamming the list with your patches. I _really_
 doubt that anyone ever will try to get your patches merged since
 you've managed to get banned from vger and got a somewhat flawed
 reputation.

 On Thu, Aug 14, 2014 at 8:06 PM, Nick Krause xerofo...@gmail.com wrote:
 On Thu, Aug 14, 2014 at 2:05 PM, Nicholas Krause xerofo...@gmail.com wrote:
 I am fixing the bug on at the link, 
 https://bugzilla.kernel.org/show_bug.cgi?id=79931.
 This bug report states that in the function, tmio_hc_stop the switch has no 
 needed breaks.
 Further more this patch fixes this bug by adding the needed breaks.

 Signed-off-by: Nicholas Krause xerofo...@gmail.com
 ---
  drivers/usb/host/ohci-tmio.c | 4 
  1 file changed, 4 insertions(+)

 diff --git a/drivers/usb/host/ohci-tmio.c b/drivers/usb/host/ohci-tmio.c
 index bb40958..d2b5382 100644
 --- a/drivers/usb/host/ohci-tmio.c
 +++ b/drivers/usb/host/ohci-tmio.c
 @@ -100,12 +100,16 @@ static void tmio_stop_hc(struct platform_device *dev)
 switch (ohci-num_ports) {
 default:
 dev_err(dev-dev, Unsupported amount of ports: 
 %d\n, ohci-num_ports);
 +   break;
 case 3:
 pm |= CCR_PM_USBPW3;
 +   break;
 case 2:
 pm |= CCR_PM_USBPW2;
 +   break;
 case 1:
 pm |= CCR_PM_USBPW1;
 +   break;
 }
 tmio_iowrite8(0, tmio-ccr + CCR_INTC);
 tmio_iowrite8(0, tmio-ccr + CCR_ILME);
 --
 1.9.1


 If someone wants to send out this patch for me,that would be great :).
 Nick

 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Kristofer,
I understand that too but this patch works and builds I have tested it
completely.
Look I got off on the wrong start and I am starting to improve my repo but seems
impossible if people are just going to forget about my good patches.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: [PATCH] usb: Fix switch statement in ohci-tmio.c

[Nick Krause]

On Thu, Aug 14, 2014 at 4:51 PM,  valdis.kletni...@vt.edu wrote:
 On Thu, 14 Aug 2014 14:18:40 -0400, Nick Krause said:

  case 3:
  pm |= CCR_PM_USBPW3;
  +   break;
  case 2:
  pm |= CCR_PM_USBPW2;
  +   break;
  case 1:
  pm |= CCR_PM_USBPW1;
  +   break;

 I understand that too but this patch works and builds I have tested it
 completely.

 No, you haven't.  Far from it.

 If you were testing it completely, you would have found an actual Toshiba
 Mobile or other hardware that uses this driver, and had logs to show how it
 used to misbehave due to this bug, and that it worked correctly now.

 And you would have noticed, and explained, why the #defines for
 CCR_PM_USBPW2 and CCR_PM_USBPW3 are the same value.  In fact, that's
 why the compiler whined, *not* because of the missing break; code.  So
 sticking in breaks and not even mentioning the #defines shows that you
 did ABSOLUTELY ZERO to actually understand what the compiler was telling you.

 Note that there's perfectly valid reasons for fall-through in a C switch -
 see Tom Duff for a classic example (yes, Dennis Ritchie said it was valid C):

 http://www.lysator.liu.se/c/duffs-device.html

 The #defines could possibly be intentionally that way if the chip is weird and
 uses 2 pins to control 3 ports in a non-intuitive way - and if they're
 active-low bits even the lack of break; after the default: warning case could
 be proper, disabling all ports if an invalid one is specified.

 And there's no indication you even *bothered* to check that possibility - 
 which
 would mean applying your patch would break a properly written driver.

 And even worse, there's no indication you actually understood what the
 compile warning was telling you.

 Look I got off on the wrong start and I am starting to improve my repo but 
 seems

 If you think you're improving your rep with these poor patches, you're 
 delusional.

 impossible if people are just going to forget about my good patches.

 We'll discuss that when you actually submit one that isn't a steaming
 pile of dingo's kidneys.

 Do yourself a favor - try to resist the temptation to post a patch for at
 least 30 to 60 days, *no matter how correct you think it is*.


Very well then I will not do any more patches for the next month and
only read the list.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: [PATCH] usb: Fix switch statement in ohci-tmio.c

[Nick Krause]

On Thu, Aug 14, 2014 at 5:38 PM,  valdis.kletni...@vt.edu wrote:
 On Thu, 14 Aug 2014 17:13:28 -0400, Nick Krause said:
 I am learned C. Perhaps I am a little rusty and need to review.

 We've seen very little evidence that you *ever* really understood C
 at all, and you're *far* from a little rusty.  It's been some 23
 years since I've hacked any code in IBM's Pascal/VS, and 29 since I
 had to do maintenance work on PL/I code, and I *still* remember more
 of those than you remember of C.  (I'll admit that my mad Snobol4 skilz
 have pretty much evaporated, though ;)

 http://en.wikipedia.org/wiki/Dunning%E2%80%93Kruger_effect
 I learned C like two years ago and never really practiced it that
much to be honest.
 In addition I will come back in the future about I have read The C Programming
 Language.
Cheers Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: [PATCH] usb: Fix switch statement in ohci-tmio.c

[Nick Krause]

On Thu, Aug 14, 2014 at 6:12 PM, Nick Krause xerofo...@gmail.com wrote:
 On Thu, Aug 14, 2014 at 5:38 PM,  valdis.kletni...@vt.edu wrote:
 On Thu, 14 Aug 2014 17:13:28 -0400, Nick Krause said:
 I am learned C. Perhaps I am a little rusty and need to review.

 We've seen very little evidence that you *ever* really understood C
 at all, and you're *far* from a little rusty.  It's been some 23
 years since I've hacked any code in IBM's Pascal/VS, and 29 since I
 had to do maintenance work on PL/I code, and I *still* remember more
 of those than you remember of C.  (I'll admit that my mad Snobol4 skilz
 have pretty much evaporated, though ;)

 http://en.wikipedia.org/wiki/Dunning%E2%80%93Kruger_effect
  I learned C like two years ago and never really practiced it that
 much to be honest.
  In addition I will come back in the future about I have read The C 
 Programming
  Language.
 Cheers Nick
Thanks for pointing me in the right direction , I really do need to
brush up on my C.
Sorry for wasting your time.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: [PATCH] usb: Fix switch statement in ohci-tmio.c

[Nick Krause]

On Thu, Aug 14, 2014 at 10:16 PM, Greg Freemyer greg.freem...@gmail.com wrote:
 On Thu, Aug 14, 2014 at 7:46 PM, Nick Krause xerofo...@gmail.com wrote:
 On Thu, Aug 14, 2014 at 6:12 PM, Nick Krause xerofo...@gmail.com wrote:
 On Thu, Aug 14, 2014 at 5:38 PM,  valdis.kletni...@vt.edu wrote:
 On Thu, 14 Aug 2014 17:13:28 -0400, Nick Krause said:
 I am learned C. Perhaps I am a little rusty and need to review.

 We've seen very little evidence that you *ever* really understood C
 at all, and you're *far* from a little rusty.  It's been some 23
 years since I've hacked any code in IBM's Pascal/VS, and 29 since I
 had to do maintenance work on PL/I code, and I *still* remember more
 of those than you remember of C.  (I'll admit that my mad Snobol4 skilz
 have pretty much evaporated, though ;)

 http://en.wikipedia.org/wiki/Dunning%E2%80%93Kruger_effect
  I learned C like two years ago and never really practiced it that
 much to be honest.
  In addition I will come back in the future about I have read The C 
 Programming
  Language.
 Cheers Nick
 Thanks for pointing me in the right direction , I really do need to
 brush up on my C.
 Sorry for wasting your time.
 Nick

 Nick,

 The linux kernel has some of the most complex c code on the planet.
 It is seriously not a place to brush-up, practice, or learn.

 A few _years_ of current c experience is pretty much a must to truly
 grok the kernel.  Once you have that as a base, then it takes a lot of
 real study to comprehend the complex use cases used in the linux
 kernel.

 I suggest you find a userspace project and work with it for a year or
 two before you jump back into the kernel.  Personally, I find the
 libyal family of userspace c libraries interesting.  The code base is
 much smaller, but works with filesystems and is has multi-threaded
 needs.  The main author is crazy smart (works for Google), so I'm not
 saying he needs your help.  I'm saying the code base is small enough
 you might be able to get your arms around it and really understand it.
 That can help you understand the data structures used in filesystems,
 complex volume systems, and encryption.

 https://code.google.com/p/libyal/wiki/Overview

 You said you have an interest in filesystems (as do I).

 Looking at the filesystem section of that overview a couple of his
 targeted libraries haven't even been started yet.  You code will
 likely be throwaway code for your first effort or two, but
 File systems

 Several libraries for different types of filesystems don't even have code yet.

 libfsclfs; Common Log File System (CLFS) format
 libfshfs; Hierarchical File System (HFS) format - at the moment
 documentation only
 libfsntfs; New Technology File System (NTFS) format - at the moment
 documentation only
 libfsrefs; Resilient File System (ReFS) format - at the moment
 documentation only

 For me, if I was trying to learn about filesystems, that would be a
 fun way to hack away at new code.  Also, libyal has lots of low level
 libraries you can build upon so your not starting from scratch.
 Further there are lots of tools written that provide high-level
 end-user applications.

 If you'd rather look at volumes (similar to device mapper code), there
 are these projects:

 libbde; BitLocker drive encryption (BDE)
 libfvde; FileVault drive encryption (FVDE)
 libluksde; LUKS Disk Encryption - at the moment documentation only
 libvslvm; Linux Logical Volume Manager (LVM) volume system format - at
 the moment documentation only
 libvshadow; Volume Shadow Snapshot (VSS) format
 libvslibs; several libraries for different types of volume systems. -
 at the moment documentation only

 Or maybe you'd like to learn about virtual disks such as VMs use:

 Image formats

 Several libraries for accessing different types of storage media:

 libodraw; optical disc (split) RAW image format (bin/cue, iso/cue)
 libsmdev; storage media devices
 libsmraw; (split) RAW image format
 libewf; Expert Witness Compression Format (EWF) image format
 libqcow; QEMU Copy-On-Write (QCOW) image format
 libvhdi; Virtual Hard Disk (VHD) image format
 libvmdk; VMware Virtual Disk (VMDK) format

 FYI: I maintain many of the above for openSUSE and have the packages
 in the main distro.  My to do list for this weekend is to package up
 libqcow, libvhdi, and libvmdk.  That being my weekend plan is why I
 have libyal in my head at the moment.

 Greg
Greg,
Thats very understandable I will  look into something else for now.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: [PATCH] usb: Fix switch statement in ohci-tmio.c

[Nick Krause]

On Thu, Aug 14, 2014 at 10:29 PM, Nick Krause xerofo...@gmail.com wrote:
 On Thu, Aug 14, 2014 at 10:16 PM, Greg Freemyer greg.freem...@gmail.com 
 wrote:
 On Thu, Aug 14, 2014 at 7:46 PM, Nick Krause xerofo...@gmail.com wrote:
 On Thu, Aug 14, 2014 at 6:12 PM, Nick Krause xerofo...@gmail.com wrote:
 On Thu, Aug 14, 2014 at 5:38 PM,  valdis.kletni...@vt.edu wrote:
 On Thu, 14 Aug 2014 17:13:28 -0400, Nick Krause said:
 I am learned C. Perhaps I am a little rusty and need to review.

 We've seen very little evidence that you *ever* really understood C
 at all, and you're *far* from a little rusty.  It's been some 23
 years since I've hacked any code in IBM's Pascal/VS, and 29 since I
 had to do maintenance work on PL/I code, and I *still* remember more
 of those than you remember of C.  (I'll admit that my mad Snobol4 skilz
 have pretty much evaporated, though ;)

 http://en.wikipedia.org/wiki/Dunning%E2%80%93Kruger_effect
  I learned C like two years ago and never really practiced it that
 much to be honest.
  In addition I will come back in the future about I have read The C 
 Programming
  Language.
 Cheers Nick
 Thanks for pointing me in the right direction , I really do need to
 brush up on my C.
 Sorry for wasting your time.
 Nick

 Nick,

 The linux kernel has some of the most complex c code on the planet.
 It is seriously not a place to brush-up, practice, or learn.

 A few _years_ of current c experience is pretty much a must to truly
 grok the kernel.  Once you have that as a base, then it takes a lot of
 real study to comprehend the complex use cases used in the linux
 kernel.

 I suggest you find a userspace project and work with it for a year or
 two before you jump back into the kernel.  Personally, I find the
 libyal family of userspace c libraries interesting.  The code base is
 much smaller, but works with filesystems and is has multi-threaded
 needs.  The main author is crazy smart (works for Google), so I'm not
 saying he needs your help.  I'm saying the code base is small enough
 you might be able to get your arms around it and really understand it.
 That can help you understand the data structures used in filesystems,
 complex volume systems, and encryption.

 https://code.google.com/p/libyal/wiki/Overview

 You said you have an interest in filesystems (as do I).

 Looking at the filesystem section of that overview a couple of his
 targeted libraries haven't even been started yet.  You code will
 likely be throwaway code for your first effort or two, but
 File systems

 Several libraries for different types of filesystems don't even have code 
 yet.

 libfsclfs; Common Log File System (CLFS) format
 libfshfs; Hierarchical File System (HFS) format - at the moment
 documentation only
 libfsntfs; New Technology File System (NTFS) format - at the moment
 documentation only
 libfsrefs; Resilient File System (ReFS) format - at the moment
 documentation only

 For me, if I was trying to learn about filesystems, that would be a
 fun way to hack away at new code.  Also, libyal has lots of low level
 libraries you can build upon so your not starting from scratch.
 Further there are lots of tools written that provide high-level
 end-user applications.

 If you'd rather look at volumes (similar to device mapper code), there
 are these projects:

 libbde; BitLocker drive encryption (BDE)
 libfvde; FileVault drive encryption (FVDE)
 libluksde; LUKS Disk Encryption - at the moment documentation only
 libvslvm; Linux Logical Volume Manager (LVM) volume system format - at
 the moment documentation only
 libvshadow; Volume Shadow Snapshot (VSS) format
 libvslibs; several libraries for different types of volume systems. -
 at the moment documentation only

 Or maybe you'd like to learn about virtual disks such as VMs use:

 Image formats

 Several libraries for accessing different types of storage media:

 libodraw; optical disc (split) RAW image format (bin/cue, iso/cue)
 libsmdev; storage media devices
 libsmraw; (split) RAW image format
 libewf; Expert Witness Compression Format (EWF) image format
 libqcow; QEMU Copy-On-Write (QCOW) image format
 libvhdi; Virtual Hard Disk (VHD) image format
 libvmdk; VMware Virtual Disk (VMDK) format

 FYI: I maintain many of the above for openSUSE and have the packages
 in the main distro.  My to do list for this weekend is to package up
 libqcow, libvhdi, and libvmdk.  That being my weekend plan is why I
 have libyal in my head at the moment.

 Greg
 Greg,
 Thats very understandable I will  look into something else for now.
 Nick
I am going to work with postrqesql for now and learn from there.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: [PATCH] usb: Fix switch statement in ohci-tmio.c

[Nick Krause]

On Thu, Aug 14, 2014 at 10:42 PM, Nick Krause xerofo...@gmail.com wrote:
 On Thu, Aug 14, 2014 at 10:29 PM, Nick Krause xerofo...@gmail.com wrote:
 On Thu, Aug 14, 2014 at 10:16 PM, Greg Freemyer greg.freem...@gmail.com 
 wrote:
 On Thu, Aug 14, 2014 at 7:46 PM, Nick Krause xerofo...@gmail.com wrote:
 On Thu, Aug 14, 2014 at 6:12 PM, Nick Krause xerofo...@gmail.com wrote:
 On Thu, Aug 14, 2014 at 5:38 PM,  valdis.kletni...@vt.edu wrote:
 On Thu, 14 Aug 2014 17:13:28 -0400, Nick Krause said:
 I am learned C. Perhaps I am a little rusty and need to review.

 We've seen very little evidence that you *ever* really understood C
 at all, and you're *far* from a little rusty.  It's been some 23
 years since I've hacked any code in IBM's Pascal/VS, and 29 since I
 had to do maintenance work on PL/I code, and I *still* remember more
 of those than you remember of C.  (I'll admit that my mad Snobol4 skilz
 have pretty much evaporated, though ;)

 http://en.wikipedia.org/wiki/Dunning%E2%80%93Kruger_effect
  I learned C like two years ago and never really practiced it that
 much to be honest.
  In addition I will come back in the future about I have read The C 
 Programming
  Language.
 Cheers Nick
 Thanks for pointing me in the right direction , I really do need to
 brush up on my C.
 Sorry for wasting your time.
 Nick

 Nick,

 The linux kernel has some of the most complex c code on the planet.
 It is seriously not a place to brush-up, practice, or learn.

 A few _years_ of current c experience is pretty much a must to truly
 grok the kernel.  Once you have that as a base, then it takes a lot of
 real study to comprehend the complex use cases used in the linux
 kernel.

 I suggest you find a userspace project and work with it for a year or
 two before you jump back into the kernel.  Personally, I find the
 libyal family of userspace c libraries interesting.  The code base is
 much smaller, but works with filesystems and is has multi-threaded
 needs.  The main author is crazy smart (works for Google), so I'm not
 saying he needs your help.  I'm saying the code base is small enough
 you might be able to get your arms around it and really understand it.
 That can help you understand the data structures used in filesystems,
 complex volume systems, and encryption.

 https://code.google.com/p/libyal/wiki/Overview

 You said you have an interest in filesystems (as do I).

 Looking at the filesystem section of that overview a couple of his
 targeted libraries haven't even been started yet.  You code will
 likely be throwaway code for your first effort or two, but
 File systems

 Several libraries for different types of filesystems don't even have code 
 yet.

 libfsclfs; Common Log File System (CLFS) format
 libfshfs; Hierarchical File System (HFS) format - at the moment
 documentation only
 libfsntfs; New Technology File System (NTFS) format - at the moment
 documentation only
 libfsrefs; Resilient File System (ReFS) format - at the moment
 documentation only

 For me, if I was trying to learn about filesystems, that would be a
 fun way to hack away at new code.  Also, libyal has lots of low level
 libraries you can build upon so your not starting from scratch.
 Further there are lots of tools written that provide high-level
 end-user applications.

 If you'd rather look at volumes (similar to device mapper code), there
 are these projects:

 libbde; BitLocker drive encryption (BDE)
 libfvde; FileVault drive encryption (FVDE)
 libluksde; LUKS Disk Encryption - at the moment documentation only
 libvslvm; Linux Logical Volume Manager (LVM) volume system format - at
 the moment documentation only
 libvshadow; Volume Shadow Snapshot (VSS) format
 libvslibs; several libraries for different types of volume systems. -
 at the moment documentation only

 Or maybe you'd like to learn about virtual disks such as VMs use:

 Image formats

 Several libraries for accessing different types of storage media:

 libodraw; optical disc (split) RAW image format (bin/cue, iso/cue)
 libsmdev; storage media devices
 libsmraw; (split) RAW image format
 libewf; Expert Witness Compression Format (EWF) image format
 libqcow; QEMU Copy-On-Write (QCOW) image format
 libvhdi; Virtual Hard Disk (VHD) image format
 libvmdk; VMware Virtual Disk (VMDK) format

 FYI: I maintain many of the above for openSUSE and have the packages
 in the main distro.  My to do list for this weekend is to package up
 libqcow, libvhdi, and libvmdk.  That being my weekend plan is why I
 have libyal in my head at the moment.

 Greg
 Greg,
 Thats very understandable I will  look into something else for now.
 Nick
 I am going to work with postrqesql for now and learn from there.
 Nick
I forget about the Eudyptula challenge, I am going to start with that
and I will make an agreement that you guys.
Until I complete all of the challenges correctly , I am not allowed to
sent out any more patches. If I do I don't
want any response what so ever , no matter how hard I plead

Re: [PATCH] usb: Fix switch statement in ohci-tmio.c

[Nick Krause]

On Thu, Aug 14, 2014 at 11:42 PM, Jaret Flores jarflo...@gmail.com wrote:
 I forget about the Eudyptula challenge, I am going to start with that
 and I will make an agreement that you guys.
 Until I complete all of the challenges correctly , I am not allowed to
 sent out any more patches. If I do I don't
 want any response what so ever , no matter how hard I plead. If this
 is a deal , Greg and others please reply.

 Warning!  Do not send any emails to the kernelnewbies mailing list
 about the eudyptula challengeotherwise you will be removed from
 the challenge.  I am not a person in control of the challenge, but I
 was just removed today for doing this.  So be sure to read through the
 rules carefully!
 -Jaret
I failed too, asked about the first task(fail) and got removed.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: [PATCH] usb: Fix switch statement in ohci-tmio.c

[Nick Krause]

On Thu, Aug 14, 2014 at 11:43 PM, Nick Krause xerofo...@gmail.com wrote:
 On Thu, Aug 14, 2014 at 11:42 PM, Jaret Flores jarflo...@gmail.com wrote:
 I forget about the Eudyptula challenge, I am going to start with that
 and I will make an agreement that you guys.
 Until I complete all of the challenges correctly , I am not allowed to
 sent out any more patches. If I do I don't
 want any response what so ever , no matter how hard I plead. If this
 is a deal , Greg and others please reply.

 Warning!  Do not send any emails to the kernelnewbies mailing list
 about the eudyptula challengeotherwise you will be removed from
 the challenge.  I am not a person in control of the challenge, but I
 was just removed today for doing this.  So be sure to read through the
 rules carefully!
 -Jaret
 I failed too, asked about the first task(fail) and got removed.
 Nick

In addition thanks to Greg and Vadis for putting up my crap :(.
I hope after I get back from the challenge I able to help more.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: [PATCH] staging: Check for Null return of allocated skb in fw_download_code

[Nick Krause]

On Wed, Aug 13, 2014 at 12:02 PM,  valdis.kletni...@vt.edu wrote:
 On Wed, 13 Aug 2014 18:50:43 +0400, Max Filippov said:

 No need to trigger it, faking it would be enough, e.g.:

 +if (++i  3)
 +skb  = dev_alloc_skb(frag_length + 4);
 +else
 +skb = NULL;

 Don't bet on this triggering on a real system without some additional
 scaffolding - take a look at what the function is doing, and ask yourself
 how many times it will be called on the average system :)
Seems to be called a lot. In addition I can only build test this as I
don't have the hardware.
Cheers Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: [PATCH] staging: Check for Null return of allocated skb in fw_download_code

[Nick Krause]

On Wed, Aug 13, 2014 at 12:55 PM, Nick Krause xerofo...@gmail.com wrote:
 On Wed, Aug 13, 2014 at 12:02 PM,  valdis.kletni...@vt.edu wrote:
 On Wed, 13 Aug 2014 18:50:43 +0400, Max Filippov said:

 No need to trigger it, faking it would be enough, e.g.:

 +if (++i  3)
 +skb  = dev_alloc_skb(frag_length + 4);
 +else
 +skb = NULL;

 Don't bet on this triggering on a real system without some additional
 scaffolding - take a look at what the function is doing, and ask yourself
 how many times it will be called on the average system :)
 Seems to be called a lot. In addition I can only build test this as I
 don't have the hardware.
 Cheers Nick


I did test my patch by doing a kernel build and I get this error,
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c:66:4: error:
implicit declaration of function ‘skb_quene_purge’
[-Werror=implicit-function-declaration]
skb_quene_purge(priv-rtllib-skb_waitQ[tcb_desc-queue_index]);
I am wondering how do I fix this, I will attach my patch so I can fix
this out and send a proper patch :).
By the way thanks for the help guys :).
Nick
From 4aab020dbd8b849e22cda7b0672a03c9133dbcd0 Mon Sep 17 00:00:00 2001
From: Nicholas Krause xerofo...@gmail.com
Date: Wed, 13 Aug 2014 13:24:55 -0400
Subject: [PATCH] staging: Check for Null return of fw_download_code

This patch fixes the bug , https://bugzilla.kernel.org/show_bug.cgi?id=60461
on the kernel bugzilla. Further more I am checking if we are allocating a
NULL skb and if so make rt_status to false and free the quene we are using
for allocated skbs in the while/do loop with skb_quene_purge.

Signed-off-by: Nicholas Krause xerofo...@gmail.com
---
 drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
index 1a95d1f..0f18c6d 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
@@ -61,6 +61,11 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,
 		}
 
 		skb  = dev_alloc_skb(frag_length + 4);
+		if (skb == NULL ) {
+			rt_status = false;
+			skb_quene_purge(priv-rtllib-skb_waitQ[tcb_desc-queue_index]);
+			break;
+		}
 		memcpy((unsigned char *)(skb-cb), dev, sizeof(dev));
 		tcb_desc = (struct cb_desc *)(skb-cb + MAX_DEV_ADDR_SIZE);
 		tcb_desc-queue_index = TXCMD_QUEUE;
-- 
1.9.1

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: [PATCH] staging: Check for Null return of allocated skb in fw_download_code

[Nick Krause]

On Wed, Aug 13, 2014 at 2:25 PM, Jerry Snitselaar d...@snitselaar.org wrote:
 On Wed Aug 13 14, Max Filippov wrote:
 On Wed, Aug 13, 2014 at 10:03 PM, Nick Krause xerofo...@gmail.com wrote:
  I did test my patch by doing a kernel build and I get this error,
  drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c:66:4: error:
  implicit declaration of function ‘skb_quene_purge’
  [-Werror=implicit-function-declaration]
  skb_quene_purge(priv-rtllib-skb_waitQ[tcb_desc-queue_index]);
  I am wondering how do I fix this, I will attach my patch so I can fix
  this out and send a proper patch :).

 Typo, skb_queue_purge.


 I imagine that array index isn't going to go over very well.

 Jerry

 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

I known the patch is premature but a NULL pointer and in a device
driver needs to be patched no matter what.
If some one reading this has the hardware , it would be great if they
can test this :).
Cheers Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: [PATCH] staging: Check for Null return of allocated skb in fw_download_code

[Nick Krause]

On Wed, Aug 13, 2014 at 2:27 PM, Nick Krause xerofo...@gmail.com wrote:
 On Wed, Aug 13, 2014 at 2:25 PM, Jerry Snitselaar d...@snitselaar.org wrote:
 On Wed Aug 13 14, Max Filippov wrote:
 On Wed, Aug 13, 2014 at 10:03 PM, Nick Krause xerofo...@gmail.com wrote:
  I did test my patch by doing a kernel build and I get this error,
  drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c:66:4: error:
  implicit declaration of function ‘skb_quene_purge’
  [-Werror=implicit-function-declaration]
  skb_quene_purge(priv-rtllib-skb_waitQ[tcb_desc-queue_index]);
  I am wondering how do I fix this, I will attach my patch so I can fix
  this out and send a proper patch :).

 Typo, skb_queue_purge.


 I imagine that array index isn't going to go over very well.

 Jerry

 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

 I known the patch is premature but a NULL pointer and in a device
 driver needs to be patched no matter what.
 If some one reading this has the hardware , it would be great if they
 can test this :).
 Cheers Nick


Also just checked and the patch is fixed and builds at least from my testing.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: [PATCH] staging: Check for Null return of fw_download_code

[Nick Krause]

On Wed, Aug 13, 2014 at 3:00 PM, Nicholas Krause xerofo...@gmail.com wrote:
 This patch fixes the bug , https://bugzilla.kernel.org/show_bug.cgi?id=60461
 on the kernel bugzilla. Further more I am checking if we are allocating a
 NULL skb and if so make rt_status to false and free the quene we are using
 for allocated skbs in the while/do loop with skb_quene_purge.

 Signed-off-by: Nicholas Krause xerofo...@gmail.com
 ---
  drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 5 +
  1 file changed, 5 insertions(+)

 diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c 
 b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
 index 1a95d1f..0f18c6d 100644
 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
 +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
 @@ -61,6 +61,11 @@ static bool fw_download_code(struct net_device *dev, u8 
 *code_virtual_address,
 }

 skb  = dev_alloc_skb(frag_length + 4);
 +   if (skb == NULL ) {
 +   rt_status = false;
 +   
 skb_queue_purge(priv-rtllib-skb_waitQ[tcb_desc-queue_index]);
 +   break;
 +   }
 memcpy((unsigned char *)(skb-cb), dev, sizeof(dev));
 tcb_desc = (struct cb_desc *)(skb-cb + MAX_DEV_ADDR_SIZE);
 tcb_desc-queue_index = TXCMD_QUEUE;
 --
 1.9.1

This is the fixed patch, I do get an error about uninitialized
variables but assume that it's common based on other errors I am
getting.
If someone wants to send this out, please do so as this is has been
built and applied tested.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: [PATCH] staging: Check for Null return of allocated skb in fw_download_code

[Nick Krause]

On Wed, Aug 13, 2014 at 3:17 PM,  valdis.kletni...@vt.edu wrote:
 On Wed, 13 Aug 2014 14:03:08 -0400, Nick Krause said:

 I did test my patch by doing a kernel build and I get this error,
 drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c:66:4: error:
 implicit declaration of function ‘skb_quene_purge’
 [-Werror=implicit-function-declaration]
 skb_quene_purge(priv-rtllib-skb_waitQ[tcb_desc-queue_index]);

 Well, this is a C 101 problem.

 I am wondering how do I fix this,

 You fix this by not doing any further kernel hacking until you've gotten
 a handle on *VERY BASIC* C development concepts.

 Also, you're going to have to justify why you're being a total
 dumbass and coding skb_waitQ[tcb_desc-queue_index] when the *obvious*
 code is skb_waitQ[TXCMD_QUEUE] - yes, an optimizing compiler will do
 that substitution, but code clarity is important.

 Argh.  I may have to break out my +5 Trout of Smacking

 On Wed, 13 Aug 2014 15:01:45 -0400, Nick Krause said:
 This is the fixed patch, I do get an error about uninitialized
 variables

 Are you *trying* to get put in *everybody's* killfile?

 If someone wants to send this out, please do so as this is has been
 built and applied tested.

 And you think that *anybody* wants to upstream a patch from you that even
 *you* admit still has trouble??!?

I checked the patched and it worked , uninitialized variables are
common and I hit 12 of them.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: [PATCH] staging: Check for Null return of allocated skb in fw_download_code

[Nick Krause]

On Wed, Aug 13, 2014 at 3:24 PM, Nick Krause xerofo...@gmail.com wrote:
 On Wed, Aug 13, 2014 at 3:17 PM,  valdis.kletni...@vt.edu wrote:
 On Wed, 13 Aug 2014 14:03:08 -0400, Nick Krause said:

 I did test my patch by doing a kernel build and I get this error,
 drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c:66:4: error:
 implicit declaration of function ‘skb_quene_purge’
 [-Werror=implicit-function-declaration]
 skb_quene_purge(priv-rtllib-skb_waitQ[tcb_desc-queue_index]);

 Well, this is a C 101 problem.

 I am wondering how do I fix this,

 You fix this by not doing any further kernel hacking until you've gotten
 a handle on *VERY BASIC* C development concepts.

 Also, you're going to have to justify why you're being a total
 dumbass and coding skb_waitQ[tcb_desc-queue_index] when the *obvious*
 code is skb_waitQ[TXCMD_QUEUE] - yes, an optimizing compiler will do
 that substitution, but code clarity is important.

 Argh.  I may have to break out my +5 Trout of Smacking

 On Wed, 13 Aug 2014 15:01:45 -0400, Nick Krause said:
 This is the fixed patch, I do get an error about uninitialized
 variables

 Are you *trying* to get put in *everybody's* killfile?

 If someone wants to send this out, please do so as this is has been
 built and applied tested.

 And you think that *anybody* wants to upstream a patch from you that even
 *you* admit still has trouble??!?

 I checked the patched and it worked , uninitialized variables are
 common and I hit 12 of them.
 Nick

Valdis,
Sorry about the stupid question , I assumed it was something else I was fixing.
In addition I fixed up the patch and there are not more errors based on using
gcc's optimization features.

Sorry Nick :(

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: [PATCH] staging: Check for Null return of fw_download_code

[Nick Krause]

On Wed, Aug 13, 2014 at 3:54 PM, Nicholas Krause xerofo...@gmail.com wrote:
 This patch fixes the bug , https://bugzilla.kernel.org/show_bug.cgi?id=60461
 on the kernel bugzilla. Further more I am checking if we are allocating a
 NULL skb and if so make rt_status to false and free the quene we are using
 for allocated skbs in the while/do loop with skb_quene_purge.

 Signed-off-by: Nicholas Krause xerofo...@gmail.com
 ---
  drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 5 +
  1 file changed, 5 insertions(+)

 diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c 
 b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
 index 1a95d1f..0f18c6d 100644
 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
 +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
 @@ -61,6 +61,11 @@ static bool fw_download_code(struct net_device *dev, u8 
 *code_virtual_address,
 }

 skb  = dev_alloc_skb(frag_length + 4);
 +   if (skb == NULL ) {
 +   rt_status = false;
 +   
 skb_queue_purge(priv-rtllib-skb_waitQ[TXCMD_QUEUE]);
 +   break;
 +   }
 memcpy((unsigned char *)(skb-cb), dev, sizeof(dev));
 tcb_desc = (struct cb_desc *)(skb-cb + MAX_DEV_ADDR_SIZE);
 tcb_desc-queue_index = TXCMD_QUEUE;
 --
 1.9.1

If there are any other errors with this patch, please let me known. I
checked again and there are no warnings or build errors.
Sorry to Valdis about the stupid questions.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Forget this patch ( Error with checkpatch)

[Nick Krause]

On Wed, Aug 13, 2014 at 3:55 PM, Nick Krause xerofo...@gmail.com wrote:
 On Wed, Aug 13, 2014 at 3:54 PM, Nicholas Krause xerofo...@gmail.com wrote:
 This patch fixes the bug , https://bugzilla.kernel.org/show_bug.cgi?id=60461
 on the kernel bugzilla. Further more I am checking if we are allocating a
 NULL skb and if so make rt_status to false and free the quene we are using
 for allocated skbs in the while/do loop with skb_quene_purge.

 Signed-off-by: Nicholas Krause xerofo...@gmail.com
 ---
  drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 5 +
  1 file changed, 5 insertions(+)

 diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c 
 b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
 index 1a95d1f..0f18c6d 100644
 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
 +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
 @@ -61,6 +61,11 @@ static bool fw_download_code(struct net_device *dev, u8 
 *code_virtual_address,
 }

 skb  = dev_alloc_skb(frag_length + 4);
 +   if (skb == NULL ) {
 +   rt_status = false;
 +   
 skb_queue_purge(priv-rtllib-skb_waitQ[TXCMD_QUEUE]);
 +   break;
 +   }
 memcpy((unsigned char *)(skb-cb), dev, sizeof(dev));
 tcb_desc = (struct cb_desc *)(skb-cb + MAX_DEV_ADDR_SIZE);
 tcb_desc-queue_index = TXCMD_QUEUE;
 --
 1.9.1

 If there are any other errors with this patch, please let me known. I
 checked again and there are no warnings or build errors.
 Sorry to Valdis about the stupid questions.
 Nick

Checkpatch error please forget.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: [PATCH] staging: Check for Null return of fw_download_code

[Nick Krause]

On Wed, Aug 13, 2014 at 3:59 PM, Nicholas Krause xerofo...@gmail.com wrote:
 This patch fixes the bug , https://bugzilla.kernel.org/show_bug.cgi?id=60461
 on the kernel bugzilla. Further more I am checking if we are allocating a
 NULL skb and if so make rt_status to false and free the quene we are using
 for allocated skbs in the while/do loop with skb_quene_purge.

 Signed-off-by: Nicholas Krause xerofo...@gmail.com
 ---
  drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 5 +
  1 file changed, 5 insertions(+)

 diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c 
 b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
 index 1a95d1f..0f18c6d 100644
 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
 +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
 @@ -61,6 +61,11 @@ static bool fw_download_code(struct net_device *dev, u8 
 *code_virtual_address,
 }

 skb  = dev_alloc_skb(frag_length + 4);
 +   if (skb == NULL) {
 +   rt_status = false;
 +   
 skb_queue_purge(priv-rtllib-skb_waitQ[TXCMD_QUEUE]);
 +   break;
 +   }
 memcpy((unsigned char *)(skb-cb), dev, sizeof(dev));
 tcb_desc = (struct cb_desc *)(skb-cb + MAX_DEV_ADDR_SIZE);
 tcb_desc-queue_index = TXCMD_QUEUE;
 --
 1.9.1


Forget to run checkpatch , only care about second patch. The first one
I didn't run through checkpatch and got a error.
Sorry Again Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Build Warnings

[Nick Krause]

Hey Guys,
With a build of allmodconfig on x86 I hit a few warnings.I am checking
them myself too to see if there to be concerned
about. In addition I will attach the file , errors which states where
the build warnings our. Please let me known if there
is any other work out there for me to do, I am willing to learn :).
Cheers Nick
P.S. I send out my patch for the other bug if you don't known which is
the correct one, I will resend.


errors
Description: Binary data
___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Build Warnings

[Nick Krause]

On Wed, Aug 13, 2014 at 6:59 PM, Nick Krause xerofo...@gmail.com wrote:
 Hey Guys,
 With a build of allmodconfig on x86 I hit a few warnings.I am checking
 them myself too to see if there to be concerned
 about. In addition I will attach the file , errors which states where
 the build warnings our. Please let me known if there
 is any other work out there for me to do, I am willing to learn :).
 Cheers Nick
 P.S. I send out my patch for the other bug if you don't known which is
 the correct one, I will resend.
Also thanks to Valdis for the help and I do agreed with you that was a stupid
question and should have checked my code first(sorry again).
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: [PATCHv3] staging: Check for Null allocated skb in fw_download_code

[Nick Krause]

On Tue, Aug 12, 2014 at 4:18 PM, Nicholas Krause xerofo...@gmail.com wrote:
 I am fixing the bug entry , https://bugzilla.kernel.org/show_bug.cgi?id=60461.
 This entry states that we are not checking the skb allocated in 
 fw_download_code
 for NULL and after checking it ,I fixed it to check for the NULL value before
 returning false and exiting fw_download_code cleanly. In additon I removed the
 variable, rt_status as it's easier to read this function's return value with
 just true or false and rt status is a unneeded variable for the bool return
 of this function.

 Signed-off-by: Nicholas Krause xerofo...@gmail.com
 ---
  drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)

 diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c 
 b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
 index 1a95d1f..66d83f8 100644
 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
 +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
 @@ -36,7 +36,6 @@ static bool fw_download_code(struct net_device *dev, u8 
 *code_virtual_address,
  u32 buffer_len)
  {
 struct r8192_priv *priv = rtllib_priv(dev);
 -   boolrt_status = true;
 u16 frag_threshold;
 u16 frag_length, frag_offset = 0;
 int i;
 @@ -61,6 +60,8 @@ static bool fw_download_code(struct net_device *dev, u8 
 *code_virtual_address,
 }

 skb  = dev_alloc_skb(frag_length + 4);
 +   if (skb == NULL)
 +   return false;
 memcpy((unsigned char *)(skb-cb), dev, sizeof(dev));
 tcb_desc = (struct cb_desc *)(skb-cb + MAX_DEV_ADDR_SIZE);
 tcb_desc-queue_index = TXCMD_QUEUE;
 @@ -99,7 +100,7 @@ static bool fw_download_code(struct net_device *dev, u8 
 *code_virtual_address,

 write_nic_byte(dev, TPPoll, TPPoll_CQ);

 -   return rt_status;
 +   return true;
  }

  static bool CPUcheck_maincodeok_turnonCPU(struct net_device *dev)
 --
 1.9.1


I am trying to get this patch merged and after my issues with the
kernel community, I can't get this into the mainline.
If someone wants to send it out for me and state it's from me that
would be great.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: [PATCHv3] staging: Check for Null allocated skb in fw_download_code

[Nick Krause]

On Tue, Aug 12, 2014 at 8:50 PM, Jerry Snitselaar d...@snitselaar.org wrote:
 On Tue Aug 12 14, valdis.kletni...@vt.edu wrote:
 On Tue, 12 Aug 2014 16:19:40 -0400, Nick Krause said:
  On Tue, Aug 12, 2014 at 4:18 PM, Nicholas Krause xerofo...@gmail.com 
  wrote:
   I am fixing the bug entry , 
   https://bugzilla.kernel.org/show_bug.cgi?id=60461.
   This entry states that we are not checking the skb allocated in 
   fw_download_code
   for NULL and after checking it ,I fixed it to check for the NULL value 
   before
   returning false and exiting fw_download_code cleanly.

  I am trying to get this patch merged and after my issues with the
  kernel community, I can't get this into the mainline.

 No, you're having trouble getting this into mainline because you are *STILL*
 persisting in submitting patches that are buggy.

 In this case, the problem is you *DON'T* exit the function cleanly.

 Note your patch causes an immediate return from inside a do/while loop, which
 *also* contains:

skb_put(skb, i);

 So if there's (say) 3 fragments needed, and we fail on the allocation of the
 third one, you just leaked references to the first two fragments, and never
 actually clean up the allocations, so we have references to leaked memory.  
 And
 leaking memory in a case where we're almost certainly very close to OOM isn't
 exactly a good idea.  Yes, failing to check the return code is a bug - but 
 so is
 failing to unwind the allocations already made.

 It took me all of a minute to spot this issue - the only clue needed was 
 that there
 was a '*_put()' call in the function, which should be a warning flag that 
 reference
 counting needs to be checked.

 Greg:  Consider this a NACK of this patch.

 Nick: If you're going to fix this bug, *UNDERSTAND THE CODE* and fix it 
 *CORRECTLY*.

 Seriously Nick.  *PLEASE* stop posting patches until you've gotten a better 
 handle
 on what code maintenance really entails.


 A minor point, but I don't believe skb_put() has anything to do with 
 reference counting,
 though the name would make you think so. sk_buff reference counting happens 
 in skb_get()
 and the *free_skb() routines from the looks of it.

 Jerry

 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Sorry Guys,
I will reread the function and send out a patch that is bug free and
actually works.
Thanks Greg for at least reading it for now :).
Cheers Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: [PATCHv3] staging: Check for Null allocated skb in fw_download_code

[Nick Krause]

On Tue, Aug 12, 2014 at 10:41 PM, Nick Krause xerofo...@gmail.com wrote:
 On Tue, Aug 12, 2014 at 10:01 PM, Nick Krause xerofo...@gmail.com wrote:
 On Tue, Aug 12, 2014 at 8:50 PM, Jerry Snitselaar d...@snitselaar.org 
 wrote:
 On Tue Aug 12 14, valdis.kletni...@vt.edu wrote:
 On Tue, 12 Aug 2014 16:19:40 -0400, Nick Krause said:
  On Tue, Aug 12, 2014 at 4:18 PM, Nicholas Krause xerofo...@gmail.com 
  wrote:
   I am fixing the bug entry , 
   https://bugzilla.kernel.org/show_bug.cgi?id=60461.
   This entry states that we are not checking the skb allocated in 
   fw_download_code
   for NULL and after checking it ,I fixed it to check for the NULL value 
   before
   returning false and exiting fw_download_code cleanly.

  I am trying to get this patch merged and after my issues with the
  kernel community, I can't get this into the mainline.

 No, you're having trouble getting this into mainline because you are 
 *STILL*
 persisting in submitting patches that are buggy.

 In this case, the problem is you *DON'T* exit the function cleanly.

 Note your patch causes an immediate return from inside a do/while loop, 
 which
 *also* contains:

skb_put(skb, i);

 So if there's (say) 3 fragments needed, and we fail on the allocation of 
 the
 third one, you just leaked references to the first two fragments, and never
 actually clean up the allocations, so we have references to leaked memory. 
  And
 leaking memory in a case where we're almost certainly very close to OOM 
 isn't
 exactly a good idea.  Yes, failing to check the return code is a bug - but 
 so is
 failing to unwind the allocations already made.

 It took me all of a minute to spot this issue - the only clue needed was 
 that there
 was a '*_put()' call in the function, which should be a warning flag that 
 reference
 counting needs to be checked.

 Greg:  Consider this a NACK of this patch.

 Nick: If you're going to fix this bug, *UNDERSTAND THE CODE* and fix it 
 *CORRECTLY*.

 Seriously Nick.  *PLEASE* stop posting patches until you've gotten a 
 better handle
 on what code maintenance really entails.


 A minor point, but I don't believe skb_put() has anything to do with 
 reference counting,
 though the name would make you think so. sk_buff reference counting happens 
 in skb_get()
 and the *free_skb() routines from the looks of it.

 Jerry

 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
 Sorry Guys,
 I will reread the function and send out a patch that is bug free and
 actually works.
 Thanks Greg for at least reading it for now :).
 Cheers Nick

 I looked into what Jerry states and he seems to be right. I will paste
 the code of skb_put for your convenience to check if
 Jerry and me are right. In addition about the call to
 write_nic_byte(dev, TPPoll, TPPoll_CQ); is there any good place to put
 it besides the end of the function seems there isn't.  I was wondering
 if I rewrote this to break out of the loop and keep
 everything else the same is Ok.

 Nick
Sorry about the multiple emails. Here is skb_put for you all to read.
Nick

1271 unsigned char *skb_put(struct sk_buff *skb, unsigned int len)
1272 {
1273 unsigned char *tmp = skb_tail_pointer(skb);
1274 SKB_LINEAR_ASSERT(skb);
1275 skb-tail += len;
1276 skb-len  += len;
1277 if (unlikely(skb-tail  skb-end))
1278 skb_over_panic(skb, len, __builtin_return_address(0));
1279 return tmp;
1280 }
1281 EXPORT_SYMBOL(skb_put);

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: [PATCH] staging: Check for Null return of allocated skb in fw_download_code

[Nick Krause]

On Tue, Aug 12, 2014 at 11:12 PM, Nicholas Krause xerofo...@gmail.com wrote:
 This patch checks if we are getting a Null allocated skb in the while/do
 loop of this function. Further more no reference checking is needing
 as skb_put is only working with the packet defined by skb and not allocating
 a new one. Further more I am breaking out of the loop in order to make sure
 we call nic_write_byte and cause no errors with writing the nic byte(s) of
 private date and then call rt_status which I changed to false in the loop
 with my additon of checking the allocated skb.

 Signed-off-by: Nicholas Krause xerofo...@gmail.com
 ---
  drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 4 
  1 file changed, 4 insertions(+)

 diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c 
 b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
 index 1a95d1f..829af66 100644
 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
 +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
 @@ -61,6 +61,10 @@ static bool fw_download_code(struct net_device *dev, u8 
 *code_virtual_address,
 }

 skb  = dev_alloc_skb(frag_length + 4);
 +   if( skb == NULL) {
 +   rt_status =  false ;
 +   break;
 +   }
 memcpy((unsigned char *)(skb-cb), dev, sizeof(dev));
 tcb_desc = (struct cb_desc *)(skb-cb + MAX_DEV_ADDR_SIZE);
 tcb_desc-queue_index = TXCMD_QUEUE;
 --
 1.9.1

If you didn't read my other emails, skb_put is not allocating another
skb and therefore no memory leaks
as you guys stated. By the way thanks for the input, I should have
read the code more carefully first.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Forget this Patch( not checkpatched)

[Nick Krause]

On Tue, Aug 12, 2014 at 11:14 PM, Nick Krause xerofo...@gmail.com wrote:
 On Tue, Aug 12, 2014 at 11:12 PM, Nicholas Krause xerofo...@gmail.com wrote:
 This patch checks if we are getting a Null allocated skb in the while/do
 loop of this function. Further more no reference checking is needing
 as skb_put is only working with the packet defined by skb and not allocating
 a new one. Further more I am breaking out of the loop in order to make sure
 we call nic_write_byte and cause no errors with writing the nic byte(s) of
 private date and then call rt_status which I changed to false in the loop
 with my additon of checking the allocated skb.

 Signed-off-by: Nicholas Krause xerofo...@gmail.com
 ---
  drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 4 
  1 file changed, 4 insertions(+)

 diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c 
 b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
 index 1a95d1f..829af66 100644
 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
 +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
 @@ -61,6 +61,10 @@ static bool fw_download_code(struct net_device *dev, u8 
 *code_virtual_address,
 }

 skb  = dev_alloc_skb(frag_length + 4);
 +   if( skb == NULL) {
 +   rt_status =  false ;
 +   break;
 +   }
 memcpy((unsigned char *)(skb-cb), dev, sizeof(dev));
 tcb_desc = (struct cb_desc *)(skb-cb + MAX_DEV_ADDR_SIZE);
 tcb_desc-queue_index = TXCMD_QUEUE;
 --
 1.9.1

 If you didn't read my other emails, skb_put is not allocating another
 skb and therefore no memory leaks
 as you guys stated. By the way thanks for the input, I should have
 read the code more carefully first.
 Nick

I forget to run through check patch , please forget it.

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: [PATCH] staging: Check for Null return of allocated skb in fw_download_code

[Nick Krause]

On Tue, Aug 12, 2014 at 11:24 PM, Nicholas Krause xerofo...@gmail.com wrote:
 This patch checks if we are getting a Null allocated skb in the while/do
 loop of this function. Further more no reference checking is needing
 as skb_put is only working with the packet defined by skb and not allocating
 a new one. Further more I am breaking out of the loop in order to make sure
 we call nic_write_byte and cause no errors with writing the nic byte(s) of
 private date and then call rt_status which I changed to false in the loop
 with my additon of checking the allocated skb.

 Signed-off-by: Nicholas Krause xerofo...@gmail.com
 ---
  drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 4 
  1 file changed, 4 insertions(+)

 diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c 
 b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
 index 1a95d1f..829af66 100644
 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
 +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
 @@ -61,6 +61,10 @@ static bool fw_download_code(struct net_device *dev, u8 
 *code_virtual_address,
 }

 skb  = dev_alloc_skb(frag_length + 4);
 +   if (skb == NULL) {
 +   rt_status =  false;
 +   break;
 +   }
 memcpy((unsigned char *)(skb-cb), dev, sizeof(dev));
 tcb_desc = (struct cb_desc *)(skb-cb + MAX_DEV_ADDR_SIZE);
 tcb_desc-queue_index = TXCMD_QUEUE;
 --
 1.9.1


 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Sorry about the two patches please read only the second one, I send twice.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Questions about Tasklets and other Bottom Halves

[Nick Krause]

Hey Guys,
I am a few basic and perhaps stupid questions. After doing some
research, why are we using a worker thread for usb
drivers and the like versus softrqs for networking. I am assuming this
is due to the networking stack in need of more
scalability versus USB and timing demands and various things . I am
also curious, not from a theoretical as I am reading
Linux Kernel Development( if Robert is reading this, great job on this
book :) ) and learning a lot, need to brush up some of my
kernel skills as stated. Further more I am wondering when are tasklets
too slow or not scalable enough and we need
to move to softriqs, I am asking from experience and not theoretical
as i can just Google or read  my copy of LKD.
Regards Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Help with git

[Nick Krause]

On Thu, Aug 7, 2014 at 11:13 PM, Nick Krause xerofo...@gmail.com wrote:
 On Thu, Aug 7, 2014 at 11:05 PM,  valdis.kletni...@vt.edu wrote:
 On Thu, 07 Aug 2014 22:25:06 -0400, Nick Krause said:

 1. git clone linux-next

 Before you do the git add, you *really* want to create a branch for
 yourself to work on.

 2. git add file changed

 Because otherwise this will get dumped on one of 200+ linux-next branches
 and cause acute indigestion the next time you do a 'git remote update'.


 That was stupid :(. Guess I known how to do it now.
 Thanks Nick


I am tried your idea and not working. Really weird, seems I am not
using the correct commands.
The commands I am using are
1.git branch next
2.git remote add -t master -f next
git://git.kernel.org/pub/scm/linux/kernel/git/sfr/linux-next.git

And that's it. I hit the git message of this,

usage: git remote add [options] name url

-f, --fetch   fetch the remote branches
--tagsimport all tags and associated objects when fetching
  or do not fetch any tag at all (--no-tags)
-t, --track branch  branch(es) to track
-m, --master branch
  master branch
--mirror[=push|fetch]
  set up remote as a mirror to push to or fetch from
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Help with git

[Nick Krause]

On Fri, Aug 8, 2014 at 1:39 PM,  valdis.kletni...@vt.edu wrote:
 On Fri, 08 Aug 2014 13:04:15 -0400, Nick Krause said:

 1.git branch next

 No, this should be (3) or so.  You really want to 'git clone' linus's tree and
 then 'git remote add' the linux-next tree before you do this.

 If you're new to git, do yourself a favor, follow the directions, and just
 build and then boot an updated linux-next kernel every day for a week or so,
 just so you know you haven't dorked up your base, *before* you go adding
 more branches of your own.

 And you'll do yourself a favor by calling the branch 'nickswork' or something
 so you don't confuse it with a -next branch down the road.  If you're planning
 to go on another scattershot ramble across the kernel like before, you
 *really* want to put each set of patches on a separate topic branch so you
 can switch to that branch and 'git diff' will then only produce a diff that
 contains the 2-3 patches in that topic.

I don't plan to do what I did, that was wrong and I was a complete
jackass there.
I plan to work in staging with checkpatch just to prove I can do the work first.
Then I am going to work on a few areas( still deciding where to specialize)
1. Btrfs
2. Scheduler
3. F2FS
4. Networking
5. Drivers(mostly USB and Intel Graphics)
I think my issue with getting baned was mostly not listening and
needing to learn git.
Cheers and Thanks :),
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Help with git

[Nick Krause]

On Fri, Aug 8, 2014 at 2:07 PM, Greg Freemyer greg.freem...@gmail.com wrote:
 On Fri, Aug 8, 2014 at 1:37 PM, Nick Krause xerofo...@gmail.com wrote:
 Thanks Numo,
 Would you mind asking Greg if he wants some help with staging clean up
 as he is very upset with me after me
 not listening and I own it to him to help help him out.
 Cheers Nick

 Greg KH monitors kernelnewbies.

 Keep participating here and prove yourself.

 Also, staging clean-ups that are just beautification are not really
 needed in staging.

 Greg KH has automated scripts he could run to clean it all up in one
 whack.  I assume he chooses not to let newbies have the practice.

 That means every time he accepts a beautification patch he is doing
 extra work for the benefit of the submitter, not for the benefit of
 staging.

 So at this point, don't think about beautification work.  If you want
 someone to submit a patch for you, it needs to be a patch that
 actually fixes a bug.

 Greg



 --
 Greg Freemyer

Thanks for the notice , if there are any bugs that are simple for a
newbie on Linus's tree I would be glad to help out there.
Cheers Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Reading Code

[Nick Krause]

For the last few days , I have been reading the code for do_fork and
other parts of the scheduler code.
As most of the developers feel this is in my best interest. I do
however have a few questions about the
code for the function, schedule.
1. In task struct we have this one defined if needed
1481 #ifdef CONFIG_BLOCK
1482 /* stack plugging */
1483 struct blk_plug *plug;
1484 #endif
I am curious is this used for block IO or something else as we are
checking for it in schedule() with this line,
sched_submit_work(tsk); which in turn points to sched_submit_work and
in turn checks for blk_plug
2814 static inline void sched_submit_work(struct task_struct *tsk)
2815 {
2816 if (!tsk-state || tsk_is_pi_blocked(tsk))
2817 return;
2818 /*
2819 * If we are going to sleep and we have plugged IO queued,
2820 * make sure to submit it to avoid deadlocks.
2821 */
2822 if (blk_needs_flush_plug(tsk))
2823 blk_schedule_flush_plug(tsk);
2824 }
Since schedule returns this and after searching using lxr, can't find
much on this, what is this type actually defined as when compiled?
368 #define __sched __attribute__((__section__(.sched.text)))
3. context_switch(rq, prev, next); /* unlocks the rq */
I am getting confused by this function after tracing it, if  someone
wants to explain it to me that would be great.

In addition I am not not trying to turn this into a self help just for
me, but my questions about git I goggled for 2 hours and didn't

find any answers, sorry about that guys. In addition I hope theses
questions are valid.
Cheers Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Reading Code

[Nick Krause]

On Fri, Aug 8, 2014 at 3:40 PM, Pol poleysc...@hotmail.com wrote:
 Well, seems like you have to also learn to google, since I found the answer
 to all your questions within seconds.

 Pol



 On 08.8.14 21:16, Nick Krause wrote:

 For the last few days , I have been reading the code for do_fork and
 other parts of the scheduler code.
 As most of the developers feel this is in my best interest. I do
 however have a few questions about the
 code for the function, schedule.
 1. In task struct we have this one defined if needed
 1481 #ifdef CONFIG_BLOCK
 1482 /* stack plugging */
 1483 struct blk_plug *plug;
 1484 #endif
 I am curious is this used for block IO or something else as we are
 checking for it in schedule() with this line,
 sched_submit_work(tsk); which in turn points to sched_submit_work and
 in turn checks for blk_plug
 2814 static inline void sched_submit_work(struct task_struct *tsk)
 2815 {
 2816 if (!tsk-state || tsk_is_pi_blocked(tsk))
 2817 return;
 2818 /*
 2819 * If we are going to sleep and we have plugged IO queued,
 2820 * make sure to submit it to avoid deadlocks.
 2821 */
 2822 if (blk_needs_flush_plug(tsk))
 2823 blk_schedule_flush_plug(tsk);
 2824 }
 Since schedule returns this and after searching using lxr, can't find
 much on this, what is this type actually defined as when compiled?
 368 #define __sched __attribute__((__section__(.sched.text)))
 3. context_switch(rq, prev, next); /* unlocks the rq */
 I am getting confused by this function after tracing it, if  someone
 wants to explain it to me that would be great.

 In addition I am not not trying to turn this into a self help just for
 me, but my questions about git I goggled for 2 hours and didn't

 find any answers, sorry about that guys. In addition I hope theses
 questions are valid.
 Cheers Nick


Pol,
I think perhaps I was goggling the wrong things. If someone wants to
help me answer my questions that would be great.
Sorry Pol

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Formula One Scheduler (was Re: Help with git)

[Nick Krause]

On Fri, Aug 8, 2014 at 4:28 PM, Arlie Stephens ar...@worldash.org wrote:
 On Aug 08 2014, valdis.kletni...@vt.edu wrote:
 There's a big difference between knowing how to change the spark plugs on
 a VW Beetle, and being able to walk into a Formula One pit and make tuning
 suggestions that actually help the performance.

 And yes, there's *that* big a gap between the usual beginner programmer
 and some parts of the kernel.  In fact, I'll go out on a limb and say that
 there are more people in this world that really understand Formula One
 engines than people who really understand the Linux scheduler. :)

 Now that's depressing.

 --
 Arlie

 (Arlie Stephens ar...@worldash.org)

 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies


That is kind of depressing. Is there any maintainers who want to
mentor me with the scheduler and other areas of interest.
I am willing to listen , I will just like a mentor to help me out :).
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Delivery Status Notification (Failure)

[Nick Krause]

On Thu, Aug 7, 2014 at 8:29 AM, Pramod Gurav pramod.gurav@gmail.com wrote:
 On Thu, Aug 7, 2014 at 12:15 PM, priyaranjan priyaranjan45...@gmail.com 
 wrote:



On Thu, Aug 7, 2014 at 12:59 AM, valdis.kletni...@vt.edu wrote:

 On Wed, 06 Aug 2014 15:07:21 -0400, Nick Krause said:
  Does anybody have some work in the scheduler subsystem I can work on
   that is a good top dipping for a kernel newbie.


 I think you should start with learning the schedular and it codemay be
 you can find something...



 There is zero code in the scheduler that somebody of your demonstrated
 competence will be able to successfully modify.

 For that matter, there is zero code in most of the rest of the kernel
 that you're in any position to patch.


 One shouldn't judge a book by its coverThis is a newbie list, If  all
 people here are already competent enough to post high-end patches(though
 patching a kernel might not be a very huge thing in this world, given that
 there are more complex things in this world) ..then there would be not need
 of a newbie list.

 Priyaranjan,

 With that analogy, Nick's book is a big hit in lkml! :) Nobody wants
 to read it! lol
 Nick, No offence meant!


 Do yourself and the world a favor - make a resolution to *NOT* attempt
 a patch of anything in the calendar year 2014, and spend the time
  learning.




 Its always a good idea to keep learning and keep others motivated to
 learn... :)


 __
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies



 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies




 --
 Thanks and Regards
 Pramod
No I don't take any offense, I am very rusty with kernel code haven't
touched it in like 2 years.
If you want to me to learn through just answer my questions and I will learn.
Regards Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Questions about struct task_struct

[Nick Krause]

On Thu, Aug 7, 2014 at 4:05 PM,  valdis.kletni...@vt.edu wrote:
 On Wed, 06 Aug 2014 18:11:30 -0400, Nick Krause said:

 1.volatile long state; Is this line like jiffies for timers with
 regards to the keyword volatile?

 Why should it be any different?

 2.void *stack; Is this a pointer to the kernel stack for the process
 related to the process
 that the structure is keeping data for and is void to make it an
 opaque data type? Is this
 normally an int or some other data type when called with most processes?

 Under what conditions would it be an int?  Think a bit.

 3.unsigned int flags; /* per process flags, defined below */, My only
 question about this is
 what flags are there and are these the ifdef statements in the struct?

 You explain what ifdef statements in the struct means, and maybe
 we'll be able to explain that to you..

 4.Why are we making the usage count atomic?(pretty obvious but real
 world reasons would be great)

 If you don't understand why usage and reference counts need to be atomic,
 you've got a *lot* to learn about race conditions.

 8.What are the options like CONFIG_PREEMPT_RCU used for in terms of
 workloads or locking as I heard a lot about
 them on the threads on the lkml?

 Start looking at Kconfig files.  Most of them are documented.
Thanks Valdis,
I was just curious if I was correct in my understanding of task struct,
seems I am so far and yes I do known why we have reference counting,
I was more curious about how to trace issues with this for debugging.
Regards Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Delivery Status Notification (Failure)

[Nick Krause]

On Thu, Aug 7, 2014 at 4:11 PM,  valdis.kletni...@vt.edu wrote:
 On Thu, 07 Aug 2014 13:14:42 -0400, Nick Krause said:

 No I don't take any offense, I am very rusty with kernel code haven't
 touched it in like 2 years.

 Excuse me if I'm dubious. Yesterday you said:

 On Wed, 06 Aug 2014 18:11:30 -0400, Nick Krause said:
 I am new to kernel programming and have a lot  questions about this
What I meant to state was I never tried to do it more then on my own and
didn't do much mostly tracing and reading code.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Help with git

[Nick Krause]

On Thu, Aug 7, 2014 at 9:52 PM, Kristofer Hallin
kristofer.hal...@gmail.com wrote:
 Seems like something is messed up. Try 'git rebase --abort' and see if
 that helps you.

 And don't try to get that patch merged upstream.

 On Fri, Aug 8, 2014 at 3:48 AM, Nick Krause xerofo...@gmail.com wrote:
 I can't seem to apply one of my created patches after trying for the last 
 hour.
 This is what is popping up, if anybody can tell me is wrong that would be 
 great.
 sed: can't read /home/nick/linux-next/.git/rebase-apply/info: No such
 file or directory
 sed: can't read /home/nick/linux-next/.git/rebase-apply/info: No such
 file or directory
 sed: can't read /home/nick/linux-next/.git/rebase-apply/info: No such
 file or directory
 Patch does not have a valid e-mail address.
 Nick

 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

That was fast, thanks I will try that see if works. I am banned from
the LKML for now,
just telling you up front so you will have to send it in for me, let's
just state I was not
listening. :)
Nick
P.S. Listening to The Wall seems to great for listening to well programming.

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Help with git

[Nick Krause]

On Thu, Aug 7, 2014 at 9:58 PM, Nick Krause xerofo...@gmail.com wrote:
 On Thu, Aug 7, 2014 at 9:52 PM, Kristofer Hallin
 kristofer.hal...@gmail.com wrote:
 Seems like something is messed up. Try 'git rebase --abort' and see if
 that helps you.

 And don't try to get that patch merged upstream.

 On Fri, Aug 8, 2014 at 3:48 AM, Nick Krause xerofo...@gmail.com wrote:
 I can't seem to apply one of my created patches after trying for the last 
 hour.
 This is what is popping up, if anybody can tell me is wrong that would be 
 great.
 sed: can't read /home/nick/linux-next/.git/rebase-apply/info: No such
 file or directory
 sed: can't read /home/nick/linux-next/.git/rebase-apply/info: No such
 file or directory
 sed: can't read /home/nick/linux-next/.git/rebase-apply/info: No such
 file or directory
 Patch does not have a valid e-mail address.
 Nick

 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

 That was fast, thanks I will try that see if works. I am banned from
 the LKML for now,
 just telling you up front so you will have to send it in for me, let's
 just state I was not
 listening. :)
 Nick
 P.S. Listening to The Wall seems to great for listening to well programming.
Tried that and states there is no rebase in process.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Help with git

[Nick Krause]

On Thu, Aug 7, 2014 at 10:00 PM,  valdis.kletni...@vt.edu wrote:
 On Thu, 07 Aug 2014 21:48:54 -0400, Nick Krause said:

 sed: can't read /home/nick/linux-next/.git/rebase-apply/info: No such
 file or directory

 It usually helps if you give the actual command that you were trying to do.

 You didn't do this on top of a linux-next tree that you did a 'git pull' to
 update, did you?

No I just pulled it down and didn't do anything else, is that bad practice and I
should have used git fetch instead?
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Questions about fork and scheduler

[Nick Krause]

Would someone who works the scheduler and process subsystems a lot
send me a few messages tomorrow to help
me check my understanding of these subsystems in order to certify my
knowledge first.
Regards Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Help with git

[Nick Krause]

On Thu, Aug 7, 2014 at 10:18 PM, Sudip Mukherjee
sudipm.mukher...@gmail.com wrote:

 On Aug 8, 2014 7:32 AM, Nick Krause xerofo...@gmail.com wrote:

 On Thu, Aug 7, 2014 at 10:00 PM,  valdis.kletni...@vt.edu wrote:
  On Thu, 07 Aug 2014 21:48:54 -0400, Nick Krause said:
 
  sed: can't read /home/nick/linux-next/.git/rebase-apply/info: No such
  file or directory
 
  It usually helps if you give the actual command that you were trying to
  do.
 
  You didn't do this on top of a linux-next tree that you did a 'git pull'
  to
  update, did you?
 
 No I just pulled it down and didn't do anything else, is that bad practice
 and I
 should have used git fetch instead?
 Nick


 can you please post the git commands that you have used to initialize the
 git and how did you pulled it down and how are you syncing with linux-next
 tree??
 and ofcourse what command you are using to apply the patch , the folder
 where the patch is and the the folder where linux-next tree and also mention
 your cwd when you are trying to apply the patch.

 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Sure here they are
1. git clone linux-next
2. git add file changed
3. git commit
4. git format-patch -1 -s
5. git add patch
6. git am
Then it fails with the above message.
Cheers Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Help with git

[Nick Krause]

On Thu, Aug 7, 2014 at 11:05 PM,  valdis.kletni...@vt.edu wrote:
 On Thu, 07 Aug 2014 22:25:06 -0400, Nick Krause said:

 1. git clone linux-next

 Before you do the git add, you *really* want to create a branch for
 yourself to work on.

 2. git add file changed

 Because otherwise this will get dumped on one of 200+ linux-next branches
 and cause acute indigestion the next time you do a 'git remote update'.


That was stupid :(. Guess I known how to do it now.
Thanks Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Bad Patches and Issues with other devolopers

[Nick Krause]

On Wed, Aug 6, 2014 at 6:30 AM, Anuz Pratap Singh Tomar
chambilketha...@gmail.com wrote:



 On Wed, Aug 6, 2014 at 11:02 AM, Pramod Gurav pramod.gurav@gmail.com
 wrote:

 Now Nick can go and Troll these guys in there, Thanks to Anuz! :)

 Happy to help :D


 On Wed, Aug 6, 2014 at 3:18 PM, Anuz Pratap Singh Tomar
 chambilketha...@gmail.com wrote:
  oh man you have gained prominence in vger?
  They have banned you from vger.
  Sarah Sharp, Greg-KH, Ted Tso etc are talking about you, quite some fame
  lol.
  https://plus.google.com/116960357493251979546/posts/N1roxd2k1f7
  https://lkml.org/lkml/2014/8/4/206
 
 
  On Wed, Aug 6, 2014 at 12:43 AM, Nick Krause xerofo...@gmail.com
  wrote:
 
  On Tue, Aug 5, 2014 at 6:49 PM, Greg Freemyer greg.freem...@gmail.com
  wrote:
   On Tue, Aug 5, 2014 at 5:35 PM, Nick Krause xerofo...@gmail.com
   wrote:
   Is there any way to fix this or am I just unemployable.
   Cheers Nick
  
   Get married and take your wife's name!
  
   Being more realistic, get good at a specific subsystem and earn a
   good
   reputation in that subsystem.  If you're lucky someone will get to
   know your reputation and get you a shot regardless that you got off
   on
   the wrong foot.
  
   More importantly, except for kernel trainers like Robert, most
   companies hire linux kernel subsystem developers, not linux kernel
   developers.  Thus you need to find a part of the kernel you want to
   delve into and get really good at just it.
  
   You can also research who the companies are that employ kernel
   developers and see which subsystems they are working in.  As an
   example Redhat employs a couple of the XFS developers.  SUSE employs
   one of the mdraid developers, etc.
  
   Greg
  
  
   --
   Greg Freemyer
  I was really worried , that I would have to give up on this goal,
  but thanks for the advice. I am interested in working in schedulers,
  file systems and  networking. If you guys want to help me , just
  tell me how to get started and again to all the maintainers, I feel
  terrible about wasting your time.
  Sorry and thanks A lot,
  Nick
 
  ___
  Kernelnewbies mailing list
  Kernelnewbies@kernelnewbies.org
  http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
 
 
 
 
  --
  Thank you
  Warm Regards
  Anuz
 
  ___
  Kernelnewbies mailing list
  Kernelnewbies@kernelnewbies.org
  http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
 



 --
 Thanks and Regards
 Pramod




 --
 Thank you
 Warm Regards
 Anuz

I am banned from vger or not?
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Bad Patches and Issues with other devolopers

[Nick Krause]

On Wed, Aug 6, 2014 at 8:47 AM, Nick Krause xerofo...@gmail.com wrote:
 On Wed, Aug 6, 2014 at 6:30 AM, Anuz Pratap Singh Tomar
 chambilketha...@gmail.com wrote:



 On Wed, Aug 6, 2014 at 11:02 AM, Pramod Gurav pramod.gurav@gmail.com
 wrote:

 Now Nick can go and Troll these guys in there, Thanks to Anuz! :)

 Happy to help :D


 On Wed, Aug 6, 2014 at 3:18 PM, Anuz Pratap Singh Tomar
 chambilketha...@gmail.com wrote:
  oh man you have gained prominence in vger?
  They have banned you from vger.
  Sarah Sharp, Greg-KH, Ted Tso etc are talking about you, quite some fame
  lol.
  https://plus.google.com/116960357493251979546/posts/N1roxd2k1f7
  https://lkml.org/lkml/2014/8/4/206
 
 
  On Wed, Aug 6, 2014 at 12:43 AM, Nick Krause xerofo...@gmail.com
  wrote:
 
  On Tue, Aug 5, 2014 at 6:49 PM, Greg Freemyer greg.freem...@gmail.com
  wrote:
   On Tue, Aug 5, 2014 at 5:35 PM, Nick Krause xerofo...@gmail.com
   wrote:
   Is there any way to fix this or am I just unemployable.
   Cheers Nick
  
   Get married and take your wife's name!
  
   Being more realistic, get good at a specific subsystem and earn a
   good
   reputation in that subsystem.  If you're lucky someone will get to
   know your reputation and get you a shot regardless that you got off
   on
   the wrong foot.
  
   More importantly, except for kernel trainers like Robert, most
   companies hire linux kernel subsystem developers, not linux kernel
   developers.  Thus you need to find a part of the kernel you want to
   delve into and get really good at just it.
  
   You can also research who the companies are that employ kernel
   developers and see which subsystems they are working in.  As an
   example Redhat employs a couple of the XFS developers.  SUSE employs
   one of the mdraid developers, etc.
  
   Greg
  
  
   --
   Greg Freemyer
  I was really worried , that I would have to give up on this goal,
  but thanks for the advice. I am interested in working in schedulers,
  file systems and  networking. If you guys want to help me , just
  tell me how to get started and again to all the maintainers, I feel
  terrible about wasting your time.
  Sorry and thanks A lot,
  Nick
 
  ___
  Kernelnewbies mailing list
  Kernelnewbies@kernelnewbies.org
  http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
 
 
 
 
  --
  Thank you
  Warm Regards
  Anuz
 
  ___
  Kernelnewbies mailing list
  Kernelnewbies@kernelnewbies.org
  http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
 



 --
 Thanks and Regards
 Pramod




 --
 Thank you
 Warm Regards
 Anuz

 I am banned from vger or not?
 Nick
Seems I am banned from the list is there any way around this or not?
Regards Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Bad Patches and Issues with other devolopers

[Nick Krause]

On Wed, Aug 6, 2014 at 9:28 AM, Kristofer Hallin
kristofer.hal...@gmail.com wrote:
 Being banned from the list means that you're not welcome anymore, so don't
 try to get around it.

 On Aug 6, 2014 3:25 PM, Nick Krause xerofo...@gmail.com wrote:

 On Wed, Aug 6, 2014 at 8:47 AM, Nick Krause xerofo...@gmail.com wrote:
  On Wed, Aug 6, 2014 at 6:30 AM, Anuz Pratap Singh Tomar
  chambilketha...@gmail.com wrote:
 
 
 
  On Wed, Aug 6, 2014 at 11:02 AM, Pramod Gurav
  pramod.gurav@gmail.com
  wrote:
 
  Now Nick can go and Troll these guys in there, Thanks to Anuz! :)
 
  Happy to help :D
 
 
  On Wed, Aug 6, 2014 at 3:18 PM, Anuz Pratap Singh Tomar
  chambilketha...@gmail.com wrote:
   oh man you have gained prominence in vger?
   They have banned you from vger.
   Sarah Sharp, Greg-KH, Ted Tso etc are talking about you, quite some
   fame
   lol.
   https://plus.google.com/116960357493251979546/posts/N1roxd2k1f7
   https://lkml.org/lkml/2014/8/4/206
  
  
   On Wed, Aug 6, 2014 at 12:43 AM, Nick Krause xerofo...@gmail.com
   wrote:
  
   On Tue, Aug 5, 2014 at 6:49 PM, Greg Freemyer
   greg.freem...@gmail.com
   wrote:
On Tue, Aug 5, 2014 at 5:35 PM, Nick Krause xerofo...@gmail.com
wrote:
Is there any way to fix this or am I just unemployable.
Cheers Nick
   
Get married and take your wife's name!
   
Being more realistic, get good at a specific subsystem and earn a
good
reputation in that subsystem.  If you're lucky someone will get
to
know your reputation and get you a shot regardless that you got
off
on
the wrong foot.
   
More importantly, except for kernel trainers like Robert, most
companies hire linux kernel subsystem developers, not linux
kernel
developers.  Thus you need to find a part of the kernel you want
to
delve into and get really good at just it.
   
You can also research who the companies are that employ kernel
developers and see which subsystems they are working in.  As an
example Redhat employs a couple of the XFS developers.  SUSE
employs
one of the mdraid developers, etc.
   
Greg
   
   
--
Greg Freemyer
   I was really worried , that I would have to give up on this goal,
   but thanks for the advice. I am interested in working in
   schedulers,
   file systems and  networking. If you guys want to help me , just
   tell me how to get started and again to all the maintainers, I feel
   terrible about wasting your time.
   Sorry and thanks A lot,
   Nick
  
   ___
   Kernelnewbies mailing list
   Kernelnewbies@kernelnewbies.org
   http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
  
  
  
  
   --
   Thank you
   Warm Regards
   Anuz
  
   ___
   Kernelnewbies mailing list
   Kernelnewbies@kernelnewbies.org
   http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
  
 
 
 
  --
  Thanks and Regards
  Pramod
 
 
 
 
  --
  Thank you
  Warm Regards
  Anuz
 
  I am banned from vger or not?
  Nick
 Seems I am banned from the list is there any way around this or not?
 Regards Nick

 ___
 Kernelnewbies mailing list
 Kernelnewbies@kernelnewbies.org
 http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

I am not trying to get around it, I would like to be welcomed back is all.
Cheers Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Bad Patches and Issues with other devolopers

[Nick Krause]

On Wed, Aug 6, 2014 at 9:46 AM, Anuz Pratap Singh Tomar
chambilketha...@gmail.com wrote:



 On Wed, Aug 6, 2014 at 2:32 PM, Nick Krause xerofo...@gmail.com wrote:

 On Wed, Aug 6, 2014 at 9:28 AM, Kristofer Hallin
 kristofer.hal...@gmail.com wrote:
  Being banned from the list means that you're not welcome anymore, so
  don't
  try to get around it.
 
  On Aug 6, 2014 3:25 PM, Nick Krause xerofo...@gmail.com wrote:
 
  On Wed, Aug 6, 2014 at 8:47 AM, Nick Krause xerofo...@gmail.com
  wrote:
   On Wed, Aug 6, 2014 at 6:30 AM, Anuz Pratap Singh Tomar
   chambilketha...@gmail.com wrote:
  
  
  
   On Wed, Aug 6, 2014 at 11:02 AM, Pramod Gurav
   pramod.gurav@gmail.com
   wrote:
  
   Now Nick can go and Troll these guys in there, Thanks to Anuz! :)
  
   Happy to help :D
  
  
   On Wed, Aug 6, 2014 at 3:18 PM, Anuz Pratap Singh Tomar
   chambilketha...@gmail.com wrote:
oh man you have gained prominence in vger?
They have banned you from vger.
Sarah Sharp, Greg-KH, Ted Tso etc are talking about you, quite
some
fame
lol.
https://plus.google.com/116960357493251979546/posts/N1roxd2k1f7
https://lkml.org/lkml/2014/8/4/206
   
   
On Wed, Aug 6, 2014 at 12:43 AM, Nick Krause
xerofo...@gmail.com
wrote:
   
On Tue, Aug 5, 2014 at 6:49 PM, Greg Freemyer
greg.freem...@gmail.com
wrote:
 On Tue, Aug 5, 2014 at 5:35 PM, Nick Krause
 xerofo...@gmail.com
 wrote:
 Is there any way to fix this or am I just unemployable.
 Cheers Nick

 Get married and take your wife's name!

 Being more realistic, get good at a specific subsystem and
 earn a
 good
 reputation in that subsystem.  If you're lucky someone will
 get
 to
 know your reputation and get you a shot regardless that you
 got
 off
 on
 the wrong foot.

 More importantly, except for kernel trainers like Robert, most
 companies hire linux kernel subsystem developers, not linux
 kernel
 developers.  Thus you need to find a part of the kernel you
 want
 to
 delve into and get really good at just it.

 You can also research who the companies are that employ kernel
 developers and see which subsystems they are working in.  As
 an
 example Redhat employs a couple of the XFS developers.  SUSE
 employs
 one of the mdraid developers, etc.

 Greg


 --
 Greg Freemyer
I was really worried , that I would have to give up on this
goal,
but thanks for the advice. I am interested in working in
schedulers,
file systems and  networking. If you guys want to help me , just
tell me how to get started and again to all the maintainers, I
feel
terrible about wasting your time.
Sorry and thanks A lot,
Nick
   
___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
   
   
   
   
--
Thank you
Warm Regards
Anuz
   
___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
   
  
  
  
   --
   Thanks and Regards
   Pramod
  
  
  
  
   --
   Thank you
   Warm Regards
   Anuz
  
   I am banned from vger or not?
   Nick
  Seems I am banned from the list is there any way around this or not?
  Regards Nick
 
  ___
  Kernelnewbies mailing list
  Kernelnewbies@kernelnewbies.org
  http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

 I am not trying to get around it, I would like to be welcomed back is all.
 Cheers Nick


 If I were you I would stop being a keyboard warrior at this very point and
 start reading LDD, ULK, LKD etc and looking at code.


 --
 Thank you
 Warm Regards
 Anuz
I have read the books you suggested, seems I was not doing the work in
the correct way.
I seem to be helping out with some traces for now.
Regards Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Bad Patches and Issues with other devolopers

[Nick Krause]

On Wed, Aug 6, 2014 at 9:59 AM, Andev debian...@gmail.com wrote:
 On Wed, Aug 6, 2014 at 9:56 AM, Nick Krause xerofo...@gmail.com wrote:

 I have read the books you suggested, seems I was not doing the work in
 the correct way.
 I seem to be helping out with some traces for now.
 Regards Nick


 Nick, Are you suffering from autism? This is a genuine question as
 your behavior is really making lots of people think so. Please let us
 know so that we can act accordingly.

 --
 Andev
I do have aspergers.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Bad Patches and Issues with other devolopers

[Nick Krause]

On Wed, Aug 6, 2014 at 10:07 AM, Nick Krause xerofo...@gmail.com wrote:
 On Wed, Aug 6, 2014 at 9:59 AM, Andev debian...@gmail.com wrote:
 On Wed, Aug 6, 2014 at 9:56 AM, Nick Krause xerofo...@gmail.com wrote:

 I have read the books you suggested, seems I was not doing the work in
 the correct way.
 I seem to be helping out with some traces for now.
 Regards Nick


 Nick, Are you suffering from autism? This is a genuine question as
 your behavior is really making lots of people think so. Please let us
 know so that we can act accordingly.

 --
 Andev
 I do have aspergers.
 Nick
In addition, sometimes I don't listen to advice even through it's
good advice(testing patches) due to ego and that's not a good
thing on the list.
Cheers Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Bad Patches and Issues with other devolopers

[Nick Krause]

On Wed, Aug 6, 2014 at 12:31 PM, Josh Carlson joshcarls...@gmail.com wrote:
 +1 lmfao!

 -Josh


 On 08/06/2014 09:35 AM, Robert P. J. Day wrote:

 On Wed, 6 Aug 2014, Nick Krause wrote:

 Seems I am banned from the [LKML] list is there any way around this
 or not?

good lord, man ... when you're *banned* from a particular venue, the
 proper and productive response is to examine your behaviour, then do
 what it takes to correct it, *not* immediately ask if there's a way
 to circumvent the ban.

at this point, i suggest it's time to ban you from *this* list for
 the simple reason that your participation has nothing to do with
 furthering anyone's knowledge of the linux kernel; rather, it has
 devolved into a discussion about your unacceptable behaviour, and this
 is most emphatically *not* the proper mailing list for that.

if there's a voting process, i would vote that nick krause be
 removed from this mailing list.

 rday


Thanks Guys,
If someone is willing to get me back on the list , and help me with
that it would  be great.
Cheers Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies