Re: My kernel patch was rejected with comments
On Wed, Mar 22, 2017 at 4:02 PM, Tobin C. Harding <m...@tobin.cc> wrote: > On Wed, Mar 22, 2017 at 12:24:47PM +0530, Prasant J wrote: >> Hi, >> >> I submitted a kernel patch and it was rejected with comments from >> maintainer. Is it important to reply with a new patch against >> maintainers response mail? Or it it ok if I send a new email with the >> updated patch? > > You don't send the new patch as a reply. You may, if you wish, reply > to the maintainer (or reviewer) with some comments that you understand > and intend on implementing their suggestions (and thanks) or > disagreeing as it may be. > @Tobin: Thanks a lot for your response. It is very helpful. How do I reply to the maintainer or how do people reply to maintainers? gmail web gui may not be a good idea.. right? or Should I set up evolution or thunderbird for this? (as mentioned here: https://01.org/linuxgraphics/gfx-docs/drm/process/email-clients.html) > You then re-work your patch and submit it as normal using git > send-email. But you put v2 in the subject. You can use > > git format-patch -X --subject-prefix='PATCH v2' --numbered --cover-letter > > (where X is the number of commits to add to the series, assuming it is > a series). > > In the cover letter add a section stating the changes since v1, for > example > > v1 -> v2 > - use foo() instead of bar() > > If it is a single patch, you may wish to just edit the subject > manually. Make sure you put the version change information below the > --- line so it is not included if/when the patch gets merged. > Could you please explain the last para? I did not understand "below the --- line" Thanks & regards, Pj ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
My kernel patch was rejected with comments
Hi, I submitted a kernel patch and it was rejected with comments from maintainer. Is it important to reply with a new patch against maintainers response mail? Or it it ok if I send a new email with the updated patch? I have mutt and git send-mail setup but I can only send mail with those. How do I reply to a maintainers comment? I manually copied Message-ID from gmail web GUI and tried using it in "--in-reply-to" with git send email but when I saw the linux mailing list, it did weird things. It sent a blank reply to maintainers email and sent a new mail with my updated patch. Is there any tutorial on how can a I setup my workflow? Any inputs will be of great help here! Regards, Pj ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
How do I know if my patch was accepted?
Hi, I was able to send a tiny coding style error correction patch to the kernel mailing list. How do I find out whether my patch was accepted or not? How do I find out subsystem maintainers git tree for my patch (patch related to drivers/staging/vt6656/ )? Regards, Pj ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Struggling with git (format-patch & send-email)
On Thu, Mar 9, 2017 at 4:33 AM, Jim Davis <jim.ep...@gmail.com> wrote: > On Wed, Mar 8, 2017 at 10:35 AM, Prasant J <pj0...@gmail.com> wrote: >> Hi, >> >> I want to send my 2 commits as patches in chain reply to my first >> email. My first email will have multiple files as attachment. How can >> I achieve it? >> >> first email subject: [mystring] Feature 01 >> patch 01: |_ [mystring] [PATCH 01/02] My commit msg 1 >> patch 02:|_ [mystring] [PATCH 02/02] My commit msg 2 >> >> >> My git send-email is working, but I want to achieve the above desired >> outcome which I'm unable to. >> >> I have tried so many combinations of git format-patch and send-email >> over the past days but I'm unable to get the above outcome. >> >> One combination that was close to working: >> => git format-patch -2 --numbered --start-number 01 -o patch-dir --thread >> => git send-email --in-reply-to="Message-Id" --to u...@gmail.com >> --chain-reply-to --suppress-cc=self patch-dir/* >> >> I'm trying to see the desired effect in my web gmail, but I do not see. > > If you don't have access to something like mutt or thunderbird that > can show you threads, then you may have to mail it to yourself and try > the 'show original' option and look at the References: header to check > that you have the results you'd like to see. > > Yes, that's painful. I use mutt only to send emails. >> >> >> * What am I doing wrong? Any inputs will be of help! >> * How to add subject prefix? (subject-prefix of git format-patch is >> not working as above) >> * How to get 2 digit patch number? I'm getting PATCH 1/2 instead of PATCH >> 01/02 > > Well, one way is to use --subject-prefix="PATCH 01/02" --no-numbered > arguments to format-patch. But then you'd have to write a shell loop > of some sort to process each patch, instead of having format-patch do > that for you. > So, If I understand correct * there is no way to prefix subject with "[mystring]" directly from git it has to be done manually. * there is no way to make the numbers 2 digit stuffed with '0' directly from git. Thanks for inputs Jim! Regards, Pj ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: Struggling with git (format-patch & send-email)
On Thu, Mar 9, 2017 at 1:47 AM, Greg KH <g...@kroah.com> wrote: > On Wed, Mar 08, 2017 at 11:05:35PM +0530, Prasant J wrote: >> Hi, >> >> I want to send my 2 commits as patches in chain reply to my first >> email. My first email will have multiple files as attachment. How can >> I achieve it? >> >> first email subject: [mystring] Feature 01 >> patch 01: |_ [mystring] [PATCH 01/02] My commit msg 1 >> patch 02:|_ [mystring] [PATCH 02/02] My commit msg 2 >> >> >> My git send-email is working, but I want to achieve the above desired >> outcome which I'm unable to. >> >> I have tried so many combinations of git format-patch and send-email >> over the past days but I'm unable to get the above outcome. >> >> One combination that was close to working: >> => git format-patch -2 --numbered --start-number 01 -o patch-dir --thread >> => git send-email --in-reply-to="Message-Id" --to u...@gmail.com >> --chain-reply-to --suppress-cc=self patch-dir/* >> >> I'm trying to see the desired effect in my web gmail, but I do not see. > > gmail does not show threading like this, you are going to have to use > another mail client that will show the threading properly, to be able to > see if you did it correctly or not. > > good luck! @Greg: Thanks for response, that helped partially. Thunderbird shows threaded mails. But chain-reply-to does not seem to work, or may be thunderbird is not showing as expected or my understanding is wrong. In Thunderbird I see as follows: >> first email subject: [mystring] Feature 01 >> patch 01: |_ [mystring] [PATCH 01/02] My commit msg 1 >> patch 02: |_ [mystring] [PATCH 02/02] My commit msg 2 Both patches are seen as response to first email. Below is the Mail header when I do chain-reply: Lets say, First Mail: Message-Id => after git send-email, the header for the patches is as follows: Patch 1: Message-Id => In-Reply-to => References => Patch 2: Message-Id => In-Reply-to => References => * Do the above headers look as expected & correct? If yes, then my thunderbird is not showing properly or my understanding is wrong. * Why in Patch 2 "References" prepended? (That should not be the case in chaining.. am I right?) Thanks & regards, Pj ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Struggling with git (format-patch & send-email)
Hi, I want to send my 2 commits as patches in chain reply to my first email. My first email will have multiple files as attachment. How can I achieve it? first email subject: [mystring] Feature 01 patch 01: |_ [mystring] [PATCH 01/02] My commit msg 1 patch 02:|_ [mystring] [PATCH 02/02] My commit msg 2 My git send-email is working, but I want to achieve the above desired outcome which I'm unable to. I have tried so many combinations of git format-patch and send-email over the past days but I'm unable to get the above outcome. One combination that was close to working: => git format-patch -2 --numbered --start-number 01 -o patch-dir --thread => git send-email --in-reply-to="Message-Id" --to u...@gmail.com --chain-reply-to --suppress-cc=self patch-dir/* I'm trying to see the desired effect in my web gmail, but I do not see. * What am I doing wrong? Any inputs will be of help! * How to add subject prefix? (subject-prefix of git format-patch is not working as above) * How to get 2 digit patch number? I'm getting PATCH 1/2 instead of PATCH 01/02 Awaiting help! Thanks & regards, Pj ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
