Re: [PATCH] staging wlan-ng: Add missing blank lines after declarations

2014-09-17 Thread Robert P. J. Day 
On Tue, 16 Sep 2014, Nicholas Krause wrote:

 Fixing trivial checkpatch warnings about missing blank lines after 
 declarations.

 Signed-off-by: Nicholas Krause xerofo...@gmail.com

   ... snip ...

From Documentation/SubmittingPatches:

  The summary phrase may be prefixed by tags enclosed in square
brackets: Subject: [PATCH tag] summary phrase.  The tags are not
considered part of the summary phrase, but describe how the patch
should be treated.  Common tags might include a version descriptor if
the multiple versions of the patch have been sent out in response to
comments (i.e., v1, v2, v3) ...

  this is now ... what? version 6? 7? 8? of a patch that adds three
blank lines to a file. so ... still wrong.

  didn't you say you were going to leave if you couldn't submit the
next patch properly? whatever happened to that promise?

rday

-- 


Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca

Twitter:   http://twitter.com/rpjday
LinkedIn:   http://ca.linkedin.com/in/rpjday



___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

[PATCH] staging wlan-ng: Add missing blank lines after declarations

2014-09-16 Thread Nicholas Krause 
Fixing trivial checkpatch warnings about missing line after declarations

Signed-off-by: Nicholas Krause xerofo...@gmail.com
---
 drivers/staging/wlan-ng/hfa384x.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/staging/wlan-ng/hfa384x.h 
b/drivers/staging/wlan-ng/hfa384x.h
index 1f2c78c..20d146b 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -1376,6 +1376,7 @@ int hfa384x_drvr_setconfig(hfa384x_t *hw, u16 rid, void 
*buf, u16 len);
 static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
 {
int result = 0;
+
result = hfa384x_drvr_getconfig(hw, rid, val, sizeof(u16));
if (result == 0)
*((u16 *) val) = le16_to_cpu(*((u16 *) val));
@@ -1385,6 +1386,7 @@ static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, 
u16 rid, void *val)
 static inline int hfa384x_drvr_setconfig16(hfa384x_t *hw, u16 rid, u16 val)
 {
u16 value = cpu_to_le16(val);
+
return hfa384x_drvr_setconfig(hw, rid, value, sizeof(value));
 }
 
@@ -1402,6 +1404,7 @@ static inline int
 hfa384x_drvr_setconfig16_async(hfa384x_t *hw, u16 rid, u16 val)
 {
u16 value = cpu_to_le16(val);
+
return hfa384x_drvr_setconfig_async(hw, rid, value, sizeof(value),
NULL, NULL);
 }
-- 
1.9.1


___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

[PATCH] staging wlan-ng: Add missing blank lines after declarations

2014-09-16 Thread Nicholas Krause 
Fixing trivial checkpatch warnings about missing blanks lines after 
declarations.

Signed-off-by: Nicholas Krause xerofo...@gmail.com
---
 drivers/staging/wlan-ng/hfa384x.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/staging/wlan-ng/hfa384x.h 
b/drivers/staging/wlan-ng/hfa384x.h
index 1f2c78c..20d146b 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -1376,6 +1376,7 @@ int hfa384x_drvr_setconfig(hfa384x_t *hw, u16 rid, void 
*buf, u16 len);
 static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
 {
int result = 0;
+
result = hfa384x_drvr_getconfig(hw, rid, val, sizeof(u16));
if (result == 0)
*((u16 *) val) = le16_to_cpu(*((u16 *) val));
@@ -1385,6 +1386,7 @@ static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, 
u16 rid, void *val)
 static inline int hfa384x_drvr_setconfig16(hfa384x_t *hw, u16 rid, u16 val)
 {
u16 value = cpu_to_le16(val);
+
return hfa384x_drvr_setconfig(hw, rid, value, sizeof(value));
 }
 
@@ -1402,6 +1404,7 @@ static inline int
 hfa384x_drvr_setconfig16_async(hfa384x_t *hw, u16 rid, u16 val)
 {
u16 value = cpu_to_le16(val);
+
return hfa384x_drvr_setconfig_async(hw, rid, value, sizeof(value),
NULL, NULL);
 }
-- 
1.9.1


___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: [PATCH] staging wlan-ng: Add missing blank lines after declarations

2014-09-16 Thread nick 


On 14-09-16 05:58 PM, Nicholas Krause wrote:
 Fixing trivial checkpatch warnings about missing blanks lines after 
 declarations.
 
 Signed-off-by: Nicholas Krause xerofo...@gmail.com
 ---
  drivers/staging/wlan-ng/hfa384x.h | 3 +++
  1 file changed, 3 insertions(+)
 
 diff --git a/drivers/staging/wlan-ng/hfa384x.h 
 b/drivers/staging/wlan-ng/hfa384x.h
 index 1f2c78c..20d146b 100644
 --- a/drivers/staging/wlan-ng/hfa384x.h
 +++ b/drivers/staging/wlan-ng/hfa384x.h
 @@ -1376,6 +1376,7 @@ int hfa384x_drvr_setconfig(hfa384x_t *hw, u16 rid, void 
 *buf, u16 len);
  static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
  {
   int result = 0;
 +
   result = hfa384x_drvr_getconfig(hw, rid, val, sizeof(u16));
   if (result == 0)
   *((u16 *) val) = le16_to_cpu(*((u16 *) val));
 @@ -1385,6 +1386,7 @@ static inline int hfa384x_drvr_getconfig16(hfa384x_t 
 *hw, u16 rid, void *val)
  static inline int hfa384x_drvr_setconfig16(hfa384x_t *hw, u16 rid, u16 val)
  {
   u16 value = cpu_to_le16(val);
 +
   return hfa384x_drvr_setconfig(hw, rid, value, sizeof(value));
  }
  
 @@ -1402,6 +1404,7 @@ static inline int
  hfa384x_drvr_setconfig16_async(hfa384x_t *hw, u16 rid, u16 val)
  {
   u16 value = cpu_to_le16(val);
 +
   return hfa384x_drvr_setconfig_async(hw, rid, value, sizeof(value),
   NULL, NULL);
  }
 
I checked my grammar. I am assuming I am still wrong through.
Nick 

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: [PATCH] staging wlan-ng: Add missing blank lines after declarations

2014-09-16 Thread Amit Agarwal 
On Tue, 2014-09-16 at 17:59 -0400, nick wrote:
 
 On 14-09-16 05:58 PM, Nicholas Krause wrote:
  Fixing trivial checkpatch warnings about missing blanks lines after 
  declarations.
  

 blanks lines after declarations.

 I checked my grammar. I am assuming I am still wrong through.


___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

[PATCH] staging wlan-ng: Add missing blank lines after declarations

2014-09-16 Thread Nicholas Krause 
Fixing trivial checkpatch warnings about missing blank lines after declarations.

Signed-off-by: Nicholas Krause xerofo...@gmail.com
---
 drivers/staging/wlan-ng/hfa384x.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/staging/wlan-ng/hfa384x.h 
b/drivers/staging/wlan-ng/hfa384x.h
index 1f2c78c..20d146b 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -1376,6 +1376,7 @@ int hfa384x_drvr_setconfig(hfa384x_t *hw, u16 rid, void 
*buf, u16 len);
 static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
 {
int result = 0;
+
result = hfa384x_drvr_getconfig(hw, rid, val, sizeof(u16));
if (result == 0)
*((u16 *) val) = le16_to_cpu(*((u16 *) val));
@@ -1385,6 +1386,7 @@ static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, 
u16 rid, void *val)
 static inline int hfa384x_drvr_setconfig16(hfa384x_t *hw, u16 rid, u16 val)
 {
u16 value = cpu_to_le16(val);
+
return hfa384x_drvr_setconfig(hw, rid, value, sizeof(value));
 }
 
@@ -1402,6 +1404,7 @@ static inline int
 hfa384x_drvr_setconfig16_async(hfa384x_t *hw, u16 rid, u16 val)
 {
u16 value = cpu_to_le16(val);
+
return hfa384x_drvr_setconfig_async(hw, rid, value, sizeof(value),
NULL, NULL);
 }
-- 
1.9.1


___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: [PATCH] staging wlan-ng: Add missing blank lines after declarations

2014-09-16 Thread nick 


On 14-09-16 10:41 PM, Nicholas Krause wrote:
 Fixing trivial checkpatch warnings about missing blank lines after 
 declarations.
 
 Signed-off-by: Nicholas Krause xerofo...@gmail.com
 ---
  drivers/staging/wlan-ng/hfa384x.h | 3 +++
  1 file changed, 3 insertions(+)
 
 diff --git a/drivers/staging/wlan-ng/hfa384x.h 
 b/drivers/staging/wlan-ng/hfa384x.h
 index 1f2c78c..20d146b 100644
 --- a/drivers/staging/wlan-ng/hfa384x.h
 +++ b/drivers/staging/wlan-ng/hfa384x.h
 @@ -1376,6 +1376,7 @@ int hfa384x_drvr_setconfig(hfa384x_t *hw, u16 rid, void 
 *buf, u16 len);
  static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
  {
   int result = 0;
 +
   result = hfa384x_drvr_getconfig(hw, rid, val, sizeof(u16));
   if (result == 0)
   *((u16 *) val) = le16_to_cpu(*((u16 *) val));
 @@ -1385,6 +1386,7 @@ static inline int hfa384x_drvr_getconfig16(hfa384x_t 
 *hw, u16 rid, void *val)
  static inline int hfa384x_drvr_setconfig16(hfa384x_t *hw, u16 rid, u16 val)
  {
   u16 value = cpu_to_le16(val);
 +
   return hfa384x_drvr_setconfig(hw, rid, value, sizeof(value));
  }
  
 @@ -1402,6 +1404,7 @@ static inline int
  hfa384x_drvr_setconfig16_async(hfa384x_t *hw, u16 rid, u16 val)
  {
   u16 value = cpu_to_le16(val);
 +
   return hfa384x_drvr_setconfig_async(hw, rid, value, sizeof(value),
   NULL, NULL);
  }
 
Greg and others,
Thanks to Amit for checking my grammar firstly. I would like to known before I 
start cleaning drivers/staging/ and it's subdirectories if this patch is good 
and valid so I can use it as a template for me to look at when I send out
my other patches.
Thanks and Am So Thankful for all the Chances Here,
Nick 

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies