Re: Skb Documentation?

2014-08-15 Thread Bjørn Mork
Nick Krause  writes:

> After searching around in the documentation directory, I need no
> information on skb data structure and other information relating to
> skb
> data type. If someone knowns where there is Documentation in the
> kernel directory please tell me, otherwise I would be glad to write
> up.

Instead of repeating myself: https://lkml.org/lkml/2014/7/23/610


Bjørn

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies


RE: Skb Documentation?

2014-08-14 Thread Jeff Haran
> -Original Message-
> From: kernelnewbies-boun...@kernelnewbies.org 
> [mailto:kernelnewbies-boun...@kernelnewbies.org] On Behalf Of Jerry
> Snitselaar
> Sent: Thursday, August 14, 2014 10:42 AM
> To: leo kirotawa
> Cc: kernelnewbies
> Subject: Re: Skb Documentation?
> 
> On Thu Aug 14 14, leo kirotawa wrote:
> >git grep is your friend. :)
> >[1]http://www.linuxjournal.com/article/1312
> 
> That and learn to use cscope and/or ctags
> 
> Jerry

I've found that the best browser for trying to understand kernel code comes 
from a commercial source, but you should be able to use it for free. You just 
need to sign up to create an account and when I did it, it was free. Check out 
https://scan.coverity.com/. The Coverity browser is C language knowledgeable 
and the Coverity people regularly do analyses of several open source projects, 
including Linux.

Where it really shines over tools like cscope or ctags is when you are trying 
to understand how a given field of a structure is used, or any other case where 
the same function or variable name is used in several different contexts. For 
example, let's say you are interested in how the kernel uses the struct sk_buff 
cb field. If you do a search for "cb" in the kernel sources using cscope, you 
get hits for a myriad of instances of variables and structure fields named "cb" 
that have nothing to do with the sk_buff cb field. Weeding out all the false 
positives is quite tedious and time consuming. But the Coverity browser knows 
the difference between (struct sk_buff *)->cb and all the cbs that represent 
callback functions in unrelated code. Big time saver.

Jeff Haran


___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies


Re: Skb Documentation?

2014-08-14 Thread Nick Krause
On Thu, Aug 14, 2014 at 2:07 PM, Jeff Haran  wrote:
>> -Original Message-
>> From: kernelnewbies-boun...@kernelnewbies.org 
>> [mailto:kernelnewbies-boun...@kernelnewbies.org] On Behalf Of Jerry
>> Snitselaar
>> Sent: Thursday, August 14, 2014 10:42 AM
>> To: leo kirotawa
>> Cc: kernelnewbies
>> Subject: Re: Skb Documentation?
>>
>> On Thu Aug 14 14, leo kirotawa wrote:
>> >git grep is your friend. :)
>> >[1]http://www.linuxjournal.com/article/1312
>>
>> That and learn to use cscope and/or ctags
>>
>> Jerry
>
> I've found that the best browser for trying to understand kernel code comes 
> from a commercial source, but you should be able to use it for free. You just 
> need to sign up to create an account and when I did it, it was free. Check 
> out https://scan.coverity.com/. The Coverity browser is C language 
> knowledgeable and the Coverity people regularly do analyses of several open 
> source projects, including Linux.
>
> Where it really shines over tools like cscope or ctags is when you are trying 
> to understand how a given field of a structure is used, or any other case 
> where the same function or variable name is used in several different 
> contexts. For example, let's say you are interested in how the kernel uses 
> the struct sk_buff cb field. If you do a search for "cb" in the kernel 
> sources using cscope, you get hits for a myriad of instances of variables and 
> structure fields named "cb" that have nothing to do with the sk_buff cb 
> field. Weeding out all the false positives is quite tedious and time 
> consuming. But the Coverity browser knows the difference between (struct 
> sk_buff *)->cb and all the cbs that represent callback functions in unrelated 
> code. Big time saver.
>
> Jeff Haran
>
>
> ___
> Kernelnewbies mailing list
> Kernelnewbies@kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
I was using lxr for a while but this looks good. Thanks for the
information Jeff.
If you want to send out some patches for me I have two, one is from today that
I just sent and the other one is hard to find due to be not learning
skbs. I will
resend it to you directly if you like.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies


Re: Skb Documentation?

2014-08-14 Thread Nick Krause
On Thu, Aug 14, 2014 at 1:42 PM, Jerry Snitselaar  wrote:
> On Thu Aug 14 14, leo kirotawa wrote:
>>git grep is your friend. :)
>>[1]http://www.linuxjournal.com/article/1312
>
> That and learn to use cscope and/or ctags
>
> Jerry
>
> ___
> Kernelnewbies mailing list
> Kernelnewbies@kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Jerry,
I fixed up my patch and sent it to the kernel newbies list.
If you can't find it I will resend.
Nick

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies


Re: Skb Documentation?

2014-08-14 Thread Jerry Snitselaar
On Thu Aug 14 14, leo kirotawa wrote:
>git grep is your friend. :)
>[1]http://www.linuxjournal.com/article/1312

That and learn to use cscope and/or ctags

Jerry

___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies


Re: Skb Documentation?

2014-08-14 Thread Valdis . Kletnieks
On Thu, 14 Aug 2014 12:40:53 -0400, Nick Krause said:
> After searching around in the documentation directory, I need no
> information on skb data structure and other information relating to

Shouldn't you have done that reading *BEFORE* you started submitting
57 different versions of a patch that messed with skb's?

> otherwise I would be glad to write up.

No.  Please, for FSM's sake, *DON'T* write it up.

We prefer our documentation written by somebody who actually understands
the topic under discussion.


pgp6O1ptw1tuf.pgp
Description: PGP signature
___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies


Re: Skb Documentation?

2014-08-14 Thread leo kirotawa
git grep is your friend. :)
http://www.linuxjournal.com/article/1312


On Thu, Aug 14, 2014 at 1:40 PM, Nick Krause  wrote:

> After searching around in the documentation directory, I need no
> information on skb data structure and other information relating to
> skb
> data type. If someone knowns where there is Documentation in the
> kernel directory please tell me, otherwise I would be glad to write
> up.
> Regards Nick
>
> ___
> Kernelnewbies mailing list
> Kernelnewbies@kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
>



-- 

--
Leônidas S. Barbosa (Kirotawa)
blog: corecode.wordpress.com
___
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies