Re: objdiff usage
On Wed, Dec 2, 2015 at 11:39 AM, Bogicevic Sasawrote: > Well, when I pull staging tree and go to drivers/pci/hotplug I get c and > h files. Am I supposed to first compile the kernel make changes and > compile again to be anle to compare ? Something like that. Take a look to the script itself, the usage example should be quite clear +# usage example: +# +# $ git checkout COMMIT_A +# $ +# $ ./scripts/objdiff record path/to/*.o +# +# $ git checkout COMMIT_B +# $ +# $ ./scripts/objdiff record path/to/*.o +# +# $ ./scripts/objdiff diff COMMIT_A COMMIT_B +# $ Regards, Bojan ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: objdiff usage
Hi Sasa, On Wed, Dec 2, 2015 at 9:56 AM, Bogicevic Sasawrote: > Hi all, > I am looking for a guidance on ./scripts/objdiff usage, cant seem to > find a goot example of the scenario where you for example make a bunch of > changes (code style issues) in one folder and need to check if that│changes > don't change the object file. That can speed up code cleaning quite a bi but > all I found online are patches related to objdiff. > │ > Thanks,Sasa > Example usage link can be fund in the objdiff commit thread: https://lkml.org/lkml/2014/4/7/312 Regards, Bojan ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: objdiff usage
On 12/02/2015, bojan prtvar wrote: >Hi Sasa, > >On Wed, Dec 2, 2015 at 9:56 AM, Bogicevic Sasawrote: >> Hi all, >> I am looking for a guidance on ./scripts/objdiff usage, cant seem to >> find a goot example of the scenario where you for example make a bunch of >> changes (code style issues) in one folder and need to check if that│changes >> don't change the object file. That can speed up code cleaning quite a bi but >> all I found online are patches related to objdiff. >> │ >> Thanks,Sasa >> > > >Example usage link can be fund in the objdiff commit thread: >https://lkml.org/lkml/2014/4/7/312 > >Regards, >Bojan Hvala Bojane :) Thanks Bojan, What about the case where you dont have object files to compare ? For example driver/pci/hotplug in my case ? How do you prove that your changes didn't brake something ? Thanks, Sasa { name: Sasa Bogicevic phone: +381:606006200 } ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: objdiff usage
On 12/02/2015, bojan prtvar wrote: >> What about the case where you dont have object files to compare ? >> For example driver/pci/hotplug in my case ? How do you prove that your >> changes didn't brake something ? > >What do you mean by no object files in driver/pci/hotplug ? >Is your HOTPLUG_PCI defined? > > >Bojan Well, when I pull staging tree and go to drivers/pci/hotplug I get c and h files. Am I supposed to first compile the kernel make changes and compile again to be anle to compare ? -- { name: Sasa Bogicevic phone: +381606006200 } ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: objdiff usage
On 12/02/2015, bojan prtvar wrote: >On Wed, Dec 2, 2015 at 11:39 AM, Bogicevic Sasawrote: >> Well, when I pull staging tree and go to drivers/pci/hotplug I get c and >> h files. Am I supposed to first compile the kernel make changes and >> compile again to be anle to compare ? > > > >Something like that. Take a look to the script itself, the usage >example should be quite clear > >+# usage example: >+# >+# $ git checkout COMMIT_A >+# $ >+# $ ./scripts/objdiff record path/to/*.o >+# >+# $ git checkout COMMIT_B >+# $ >+# $ ./scripts/objdiff record path/to/*.o >+# >+# $ ./scripts/objdiff diff COMMIT_A COMMIT_B >+# $ > >Regards, >Bojan Ahhh all clear now, thanks a lot! Sasa { name: Sasa Bogicevic phone: +381606006200 } ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies