Re: what is the + sigh in the modules folder name?
On 23.01.2012 15:53, Robert P. J. Day wrote: On Tue, 24 Jan 2012, Graeme Russ wrote: It would be worth testing if a checkout of a tag (say 3.2.0) plus a local commit causes '+' and 'dirty' i think dirty only shows up if you have local, uncommitted changes. but i should probably verify that. I had a local commits when I compiled the kernel. I should have mentioned that in my original email. ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: what is the + sigh in the modules folder name?
Hi Christopher, From my knowledge it because of in linux-2.6.37/Makefile In my case content of Lantiq_UGW_5.x/linux/Makefile #head Lantiq_UGW_5.x/linux/Makefile VERSION = 2 PATCHLEVEL = 6 SUBLEVEL = 32 EXTRAVERSION = .32 NAME = Man-Eating Seals of Antiquity # *DOCUMENTATION* This EXTRAVERSION get added to Kernel build path # Read KERNELRELEASE from include/config/kernel.release (if it exists) KERNELRELEASE = $(shell cat include/config/kernel.release 2 /dev/null) KERNELVERSION = $(VERSION).$(PATCHLEVEL).$(SUBLEVEL)$(EXTRAVERSION) On My system on provide the following command. #uname -r #2.6.32.32 # If you check the EXTRAVERSION you will find the reason of '+' Or Some were in the linux-2.6.37/Makefile you might be appending some extra FLAGS or environment variable to KERNELVERSION. Read the linux-2.6.37/Makefile for details under the following line. # Build the kernel release string Please try to echo this KERNELVERSION during compilation of kernel. -Anand Moon From: Christopher Harvey ch...@basementcode.com To: kernelnewbies@kernelnewbies.org Sent: Tuesday, January 24, 2012 8:46 PM Subject: Re: what is the + sigh in the modules folder name? On 23.01.2012 15:53, Robert P. J. Day wrote: On Tue, 24 Jan 2012, Graeme Russ wrote: It would be worth testing if a checkout of a tag (say 3.2.0) plus a local commit causes '+' and 'dirty' i think dirty only shows up if you have local, uncommitted changes. but i should probably verify that. I had a local commits when I compiled the kernel. I should have mentioned that in my original email. ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: what is the + sigh in the modules folder name?
Hi... On Mon, Jan 23, 2012 at 23:15, Christopher Harvey ch...@basementcode.com wrote: I have a path on system called: '/lib/modules/2.6.37+/' It used to be called: '/lib/modules/2.6.37/' Hm strange. You said you have the kernel source, right? Can you show us about ten top lines of the Makefile in the main kernel source directory? I am suspecting there is + character in the extraversion..but that needs to be checked -- regards, Mulyadi Santosa Freelance Linux trainer and consultant blog: the-hydra.blogspot.com training: mulyaditraining.blogspot.com ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: what is the + sigh in the modules folder name?
On Tue, Jan 24, 2012 at 12:25:20AM +0700, Mulyadi Santosa wrote: Hi... On Mon, Jan 23, 2012 at 23:15, Christopher Harvey ch...@basementcode.com wrote: I have a path on system called: '/lib/modules/2.6.37+/' It used to be called: '/lib/modules/2.6.37/' Hm strange. You said you have the kernel source, right? Can you show us about ten top lines of the Makefile in the main kernel source directory? I am suspecting there is + character in the extraversion..but that needs to be checked No, it just means you have a modified kernel tree, that is not reall 2.6.37, you have changed it somehow. The build system asks git about this when building the kernel. It's normal, just only build a clean 2.6.37 and it will go away. greg k-h ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: what is the + sigh in the modules folder name?
On Tue, 24 Jan 2012, Mulyadi Santosa wrote: Hi... On Mon, Jan 23, 2012 at 23:15, Christopher Harvey ch...@basementcode.com wrote: I have a path on system called: '/lib/modules/2.6.37+/' It used to be called: '/lib/modules/2.6.37/' Hm strange. You said you have the kernel source, right? Can you show us about ten top lines of the Makefile in the main kernel source directory? I am suspecting there is + character in the extraversion..but that needs to be checked i'd check scripts/setlocalversion, particularly this snippet around line 50: if [ -z `git describe --exact-match 2/dev/null` ]; then # If only the short version is requested, don't bother # running further git commands if $short; then echo + return fi rday -- Robert P. J. Day Ottawa, Ontario, CANADA http://crashcourse.ca Twitter: http://twitter.com/rpjday LinkedIn: http://ca.linkedin.com/in/rpjday ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: what is the + sigh in the modules folder name?
On Mon, 23 Jan 2012, Greg KH wrote: On Tue, Jan 24, 2012 at 12:25:20AM +0700, Mulyadi Santosa wrote: Hi... On Mon, Jan 23, 2012 at 23:15, Christopher Harvey ch...@basementcode.com wrote: I have a path on system called: '/lib/modules/2.6.37+/' It used to be called: '/lib/modules/2.6.37/' Hm strange. You said you have the kernel source, right? Can you show us about ten top lines of the Makefile in the main kernel source directory? I am suspecting there is + character in the extraversion..but that needs to be checked No, it just means you have a modified kernel tree, that is not reall 2.6.37, you have changed it somehow. The build system asks git about this when building the kernel. you sure? i thought that if it was a modified working tree, you'd get the -dirty qualifier added, not just a +. i should know this since i remember documenting it once upon a time. rday -- Robert P. J. Day Ottawa, Ontario, CANADA http://crashcourse.ca Twitter: http://twitter.com/rpjday LinkedIn: http://ca.linkedin.com/in/rpjday ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: what is the + sigh in the modules folder name?
On Mon, Jan 23, 2012 at 8:52 PM, Graeme Russ graeme.r...@gmail.com wrote: On 01/24/2012 05:15 AM, Greg KH wrote: On Mon, Jan 23, 2012 at 12:40:41PM -0500, Robert P. J. Day wrote: On Mon, 23 Jan 2012, Greg KH wrote: On Tue, Jan 24, 2012 at 12:25:20AM +0700, Mulyadi Santosa wrote: Hi... On Mon, Jan 23, 2012 at 23:15, Christopher Harvey ch...@basementcode.com wrote: I have a path on system called: '/lib/modules/2.6.37+/' It used to be called: '/lib/modules/2.6.37/' Hm strange. You said you have the kernel source, right? Can you show us about ten top lines of the Makefile in the main kernel source directory? I am suspecting there is + character in the extraversion..but that needs to be checked No, it just means you have a modified kernel tree, that is not reall 2.6.37, you have changed it somehow. The build system asks git about this when building the kernel. you sure? i thought that if it was a modified working tree, you'd get the -dirty qualifier added, not just a +. Try it and see :) From what I can tell, the '+' means you are building source which includes upstream commits after the last tag in the tree Well that commits not necessarily are upstream ;-) It only means that are commits after the last tag. Regards, -- Javier Martínez Canillas (+34) 682 39 81 69 Barcelona, Spain ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: what is the + sigh in the modules folder name?
Hi Javier, On Tue, Jan 24, 2012 at 8:30 AM, Javier Martinez Canillas martinez.jav...@gmail.com wrote: On Mon, Jan 23, 2012 at 8:52 PM, Graeme Russ graeme.r...@gmail.com wrote: On 01/24/2012 05:15 AM, Greg KH wrote: On Mon, Jan 23, 2012 at 12:40:41PM -0500, Robert P. J. Day wrote: On Mon, 23 Jan 2012, Greg KH wrote: On Tue, Jan 24, 2012 at 12:25:20AM +0700, Mulyadi Santosa wrote: Hi... On Mon, Jan 23, 2012 at 23:15, Christopher Harvey ch...@basementcode.com wrote: I have a path on system called: '/lib/modules/2.6.37+/' It used to be called: '/lib/modules/2.6.37/' Hm strange. You said you have the kernel source, right? Can you show us about ten top lines of the Makefile in the main kernel source directory? I am suspecting there is + character in the extraversion..but that needs to be checked No, it just means you have a modified kernel tree, that is not reall 2.6.37, you have changed it somehow. The build system asks git about this when building the kernel. you sure? i thought that if it was a modified working tree, you'd get the -dirty qualifier added, not just a +. Try it and see :) From what I can tell, the '+' means you are building source which includes upstream commits after the last tag in the tree Well that commits not necessarily are upstream ;-) It only means that are commits after the last tag. It would be worth testing if a checkout of a tag (say 3.2.0) plus a local commit causes '+' and 'dirty' Regards, Graeme ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: what is the + sigh in the modules folder name?
Hi Robert, On Tue, Jan 24, 2012 at 8:53 AM, Robert P. J. Day rpj...@crashcourse.ca wrote: On Tue, 24 Jan 2012, Graeme Russ wrote: It would be worth testing if a checkout of a tag (say 3.2.0) plus a local commit causes '+' and 'dirty' i think dirty only shows up if you have local, uncommitted changes. but i should probably verify that. Hmm, if that is the case, I wonder if there is a way in git to tell if there are local commits that are not upstream Regards, Graeme ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Re: what is the + sigh in the modules folder name?
On Tue, 24 Jan 2012, Graeme Russ wrote: It would be worth testing if a checkout of a tag (say 3.2.0) plus a local commit causes '+' and 'dirty' i think dirty only shows up if you have local, uncommitted changes. but i should probably verify that. rday -- Robert P. J. Day Ottawa, Ontario, CANADA http://crashcourse.ca Twitter: http://twitter.com/rpjday LinkedIn: http://ca.linkedin.com/in/rpjday ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies