Re: [PATCH 0/2] Simple fix to the ARM kexec tools implementation

[Simon Horman]

On Tue, Jun 21, 2016 at 09:20:33AM +0100, Russell King - ARM Linux wrote:
> On Tue, Jun 21, 2016 at 11:41:28AM +0530, Pratyush Anand wrote:
> > Yes, so until we have proper header for zImage, these patches looks
> > fine to me.
> 
> If you read my last email in the "kexec failures with DEBUG_RODATA"
> thread, you'll see that I'm unhappy with this idea, because adding a
> "proper header" still results in some kind of assumption about how
> the zImage decompressor works being needed by the boot environment.
> 
> > For both of the patches:
> > 
> > Reviewed-by: Pratyush Anand 
> 
> Thanks.
> 
> Simon, do you need me to resend with the r-b tag, or will you pick
> these two up and the documentation fix patch you asked for?

Thanks for reminding me about this, I have applied this patch
and the other one you mention.

___
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH 0/2] Simple fix to the ARM kexec tools implementation

[Russell King - ARM Linux]

On Tue, Jun 21, 2016 at 11:41:28AM +0530, Pratyush Anand wrote:
> Yes, so until we have proper header for zImage, these patches looks
> fine to me.

If you read my last email in the "kexec failures with DEBUG_RODATA"
thread, you'll see that I'm unhappy with this idea, because adding a
"proper header" still results in some kind of assumption about how
the zImage decompressor works being needed by the boot environment.

> For both of the patches:
> 
> Reviewed-by: Pratyush Anand 

Thanks.

Simon, do you need me to resend with the r-b tag, or will you pick
these two up and the documentation fix patch you asked for?

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

___
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH 0/2] Simple fix to the ARM kexec tools implementation

[Pratyush Anand]

On 17/06/2016:08:44:05 PM, Russell King - ARM Linux wrote:
> This is the "simple" fix for the ARM kexec tools code, which makes
> the code actually do what the comments describe.
> 
> There are two problems:
> 
> 1. When placing the initrd, we do not take account of the 32k offset
>that is required for the kernel image.
> 
> 2. The code claims to allow the zImage decompressor to expand by a
>factor of 4, but only allows space for a factor of 3, since the
>decompressor itself has to fit in this memory space as well.
> 
> Changing the code to follow the comments allows Keystone II to kexec
> with DEBUG_RODATA enabled, at least with the kernel I've been testing
> with.
> 
> This is a stop-gap solution until a better solution can be implemented.

Yes, so until we have proper header for zImage, these patches looks fine to me.
For both of the patches:

Reviewed-by: Pratyush Anand 

> 
>  kexec/arch/arm/kexec-zImage-arm.c | 16 ++--
>  1 file changed, 10 insertions(+), 6 deletions(-)
> 
> -- 
> RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
> FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
> according to speedtest.net.

___
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

[PATCH 0/2] Simple fix to the ARM kexec tools implementation

[Russell King - ARM Linux]

This is the "simple" fix for the ARM kexec tools code, which makes
the code actually do what the comments describe.

There are two problems:

1. When placing the initrd, we do not take account of the 32k offset
   that is required for the kernel image.

2. The code claims to allow the zImage decompressor to expand by a
   factor of 4, but only allows space for a factor of 3, since the
   decompressor itself has to fit in this memory space as well.

Changing the code to follow the comments allows Keystone II to kexec
with DEBUG_RODATA enabled, at least with the kernel I've been testing
with.

This is a stop-gap solution until a better solution can be implemented.

 kexec/arch/arm/kexec-zImage-arm.c | 16 ++--
 1 file changed, 10 insertions(+), 6 deletions(-)

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

___
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec